[PULL] drm-misc-fixes

2024-05-23 Thread Thomas Zimmermann
| 7 ++ 7 files changed, 57 insertions(+), 50 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH v2 2/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-17 Thread Thomas Zimmermann
WC mapping of the G200. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmermann Thanks a lot for the fix. Best regards Thomas --- drivers/gpu/drm/mgag200/Kconfig | 10 ++ drivers/gpu/drm/mgag200/mgag200_drv.c | 6 ++ 2 files changed, 16 insertions(+) diff --git

Re: [PATCH 2/2] drm/mgag200: Add an option to disable Write-Combine

2024-05-17 Thread Thomas Zimmermann
mdev->vram = devm_ioremap_wc(dev->dev, res->start, resource_size(res)); if (!mdev->vram) return -ENOMEM; /* Don't fail on errors, but performance might be reduced. */ devm_arch_phys_wc_add(dev->dev, res->start, resource_size(res)); +#e

Re: [PATCH 1/2] Revert "drm/mgag200: Add a workaround for low-latency"

2024-05-17 Thread Thomas Zimmermann
hardware. Signed-off-by: Jocelyn Falempe Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/Kconfig| 12 drivers/gpu/drm/mgag200/mgag200_drv.c | 17 - drivers/gpu/drm/mgag200/mgag200_mode.c | 8 3 files changed, 37 deletions(-) diff

[PATCH] arch: Fix name collision with ACPI's video.o

2024-05-17 Thread Thomas Zimmermann
-f697f767f...@suse.de/T/#t Signed-off-by: Thomas Zimmermann Fixes: 2fd001cd3600 ("arch: Rename fbdev header and source files") Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- arch/sparc/video/Makefile

Re: [PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Thomas Zimmermann
Hi Am 16.05.24 um 17:03 schrieb Hans de Goede: Hi, On 5/16/24 3:04 PM, Rafael J. Wysocki wrote: CC Hans who has been doing the majority of the ACPI video work. On Thu, May 16, 2024 at 2:43 PM Thomas Zimmermann wrote: Commit 2fd001cd3600 ("arch: Rename fbdev header and source

[PATCH] ACPI: video: Fix name collision with architecture's video.o

2024-05-16 Thread Thomas Zimmermann
es: https://lore.kernel.org/intel-gfx/9dcac6e9-a3bf-4ace-bbdc-f697f767f...@suse.de/T/#t Tested-by: Chaitanya Kumar Borah Signed-off-by: Thomas Zimmermann Fixes: 2fd001cd3600 ("arch: Rename fbdev header and source files") Cc: Arnd Bergmann Cc: linux-a...@vger.kernel.org Cc: linux-fb...@vge

Re: [PATCH 00/10] drm/mgag200: Refactor DDC code

2024-05-16 Thread Thomas Zimmermann
Hi Am 16.05.24 um 11:14 schrieb Jocelyn Falempe: Thanks for this refactor of mgag200. for the whole series: Reviewed-by: Jocelyn Falempe Thank you so much! Best regards Thomas -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146

[PULL] drm-misc-fixes

2024-05-16 Thread Thomas Zimmermann
++ 3 files changed, 29 insertions(+), 25 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH] drm/fbdev-dma: Clean up deferred I/O

2024-05-15 Thread Thomas Zimmermann
Am 15.05.24 um 13:59 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Call fb_deferred_io_cleanup() upon destroying the framebuffer device. Releases the internal memory. Signed-off-by: Thomas Zimmermann Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage han

Re: [PATCH 05/11] drm/hisilicon/hibmc: convert to struct drm_edid

2024-05-15 Thread Thomas Zimmermann
Hi Am 15.05.24 um 14:34 schrieb Jani Nikula: On Tue, 14 May 2024, Thomas Zimmermann wrote: Hi Am 14.05.24 um 14:55 schrieb Jani Nikula: Prefer the struct drm_edid based functions for reading the EDID and updating the connector. Signed-off-by: Jani Nikula --- Cc: Xinliang Liu Cc: Tian

Re: [PATCH 05/11] drm/hisilicon/hibmc: convert to struct drm_edid

2024-05-14 Thread Thomas Zimmermann
Cc: Maxime Ripard Cc: Thomas Zimmermann --- .../gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c| 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c index

Re: drm: Remove driver dependencies on FB_DEVICE

2024-05-14 Thread Thomas Zimmermann
working on that topic. Best regards Thomas Thanks, Manas -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH] drm/edid: remove drm_do_get_edid()

2024-05-14 Thread Thomas Zimmermann
Am 13.05.24 um 22:27 schrieb Jani Nikula: All users of drm_do_get_edid() have been converted to drm_edid_read_custom(). Remove the unused function to prevent new users from creeping in. Signed-off-by: Jani Nikula Reviewed-by: Thomas Zimmermann --- Cc: Robert Foss Cc: Maarten

[PATCH 04/10] drm/mgag200: Allocate instance of struct mga_i2c_chan dynamically

2024-05-13 Thread Thomas Zimmermann
Allocate instances of struct mga_i2c_chan in mgag200_ddc_create() and return a pointer to the contained i2c adapter. The callers of the function are now independent from struct mga_i2c_chan. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_ddc.h | 11 +++ drivers

[PATCH 06/10] drm/mgag200: Replace struct mga_i2c_chan with struct mgag200_ddc

2024-05-13 Thread Thomas Zimmermann
refer to any functionality on an i2c bus. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 10 - drivers/gpu/drm/mgag200/mgag200_i2c.c | 56 --- 2 files changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/gpu

[PATCH 08/10] drm/mgag200: Rename struct i2c_algo_bit_data callbacks

2024-05-13 Thread Thomas Zimmermann
Align the names of the algo-bit helpers with mgag200's convention of using an mgag200 prefix plus the struct's name plus the callback's name for such function symbols. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_ddc.c | 16 1 file changed, 8 insertions

[PATCH 09/10] drm/mgag200: Acquire I/O-register lock in DDC code

2024-05-13 Thread Thomas Zimmermann
in the internal I2C function bit_xfer(). Both calls are executed unconditionally if present. Invoking DDC transfers from any where within the driver now takes the lock. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_ddc.c | 24 drivers/gpu/drm/mgag200

[PATCH 00/10] drm/mgag200: Refactor DDC code

2024-05-13 Thread Thomas Zimmermann
data structures internal, acquires locks automatically and is much more readable overall. Patch 10 replaces driver code with an equivalent helper. Tested on various Matrox hardware. [1] https://patchwork.freedesktop.org/series/131977/ Thomas Zimmermann (10): drm/mgag200: Set DDC timeout

[PATCH 02/10] drm/mgag200: Bind I2C lifetime to DRM device

2024-05-13 Thread Thomas Zimmermann
lifetime by using DRM's managed release. When the DRM device goes away (after the Linux device) DRM will first clean up the connector and then clean up the I2C adapter. Signed-off-by: Thomas Zimmermann Fixes: b279df242972 ("drm/mgag200: Switch I2C code to managed cleanup") Cc: Thomas Zimm

[PATCH 05/10] drm/mgag200: Inline mgag200_i2c_init()

2024-05-13 Thread Thomas Zimmermann
The function mgag200_i2c_init() is an internal helper that sets up the i2c data structure. Inline its code into the only caller. Rearrange the individual steps to separate among i2c algorithm, adapter and fields in struct mga_i2c_chan. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm

[PATCH 07/10] drm/mgag200: Rename mgag200_i2c.c to mgag200_ddc.c

2024-05-13 Thread Thomas Zimmermann
Rename the source file according to its content. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/Makefile | 2 +- drivers/gpu/drm/mgag200/{mgag200_i2c.c => mgag200_ddc.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) ren

[PATCH 01/10] drm/mgag200: Set DDC timeout in milliseconds

2024-05-13 Thread Thomas Zimmermann
Compute the i2c timeout in jiffies from a value in milliseconds. The original values of 2 jiffies equals 2 milliseconds if HZ has been configured to a value of 1000. This corresponds to 2.2 milliseconds used by most other DRM drivers. Update mgag200 accordingly. Signed-off-by: Thomas Zimmermann

[PATCH 10/10] drm/mgag200: Use drm_connector_helper_get_modes()

2024-05-13 Thread Thomas Zimmermann
Mgag200's .get_modes() function is identical to the common helper. Use the latter. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 4 +--- drivers/gpu/drm/mgag200/mgag200_mode.c | 17 - 2 files changed, 1 insertion(+), 20 deletions(-) diff --git

[PATCH 03/10] drm/mgag200: Store pointer to struct mga_device in struct mga_i2c_chan

2024-05-13 Thread Thomas Zimmermann
Avoid upcasting to struct mga_device in i2c code by storing the pointer directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.h | 2 +- drivers/gpu/drm/mgag200/mgag200_i2c.c | 18 +- 2 files changed, 10 insertions(+), 10

[PATCH v3 0/5] drm/udl: Convert to struct drm_edid

2024-05-10 Thread Thomas Zimmermann
removes the obsolete struct udl_connector. v3: - implement udl_probe_edid() with memchr_inv() (Jani) v2: - drop the generic EDID probing (Jani) - fixes Thomas Zimmermann (5): drm/udl: Remove DRM_CONNECTOR_POLL_HPD drm/udl: Move drm_dev_{enter,exit}() into udl_get_edid_block() drm/udl: Clean

[PATCH v3 3/5] drm/udl: Clean up Makefile

2024-05-10 Thread Thomas Zimmermann
Clean up Makefile before listing new object files. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- drivers/gpu/drm/udl/Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/Makefile b/drivers/gpu/drm/udl

[PATCH v3 5/5] drm/udl: Remove struct udl_connector

2024-05-10 Thread Thomas Zimmermann
Udl's struct udl_connector is an empty wrapper around struct drm_connector. Remove it. Allocate the connector as part of struct udl_device and inline the init function into its only caller. v2: - fix return value in udl_modeset_init() (Dan) Signed-off-by: Thomas Zimmermann Reviewed-by: Jani

[PATCH v3 4/5] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-05-10 Thread Thomas Zimmermann
to .detect() and .get_modes(), but is now unused. v3: - implement udl_probe_edid() with memchr_inv() (Jani) v2: - implement udl_probe_edid() within udl - reword commit description Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- drivers/gpu/drm/udl/Makefile | 1 + drivers/gpu

[PATCH v3 1/5] drm/udl: Remove DRM_CONNECTOR_POLL_HPD

2024-05-10 Thread Thomas Zimmermann
DisplayLink devices do not generate hotplug events. Remove the poll flag DRM_CONNECTOR_POLL_HPD, as it may not be specified together with DRM_CONNECTOR_POLL_CONNECT or DRM_CONNECTOR_POLL_DISCONNECT. Signed-off-by: Thomas Zimmermann Fixes: afdfc4c6f55f ("drm/udl: Fixed problem with UDL ad

[PATCH v3 2/5] drm/udl: Move drm_dev_{enter, exit}() into udl_get_edid_block()

2024-05-10 Thread Thomas Zimmermann
and therefore does not require protection. This change will allow to use udl_get_edid_block() in various contexts easily. Signed-off-by: Thomas Zimmermann Reviewed-by: Jani Nikula --- drivers/gpu/drm/udl/udl_modeset.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions

Re: [PATCH v2 4/5] drm/udl: Untangle .get_modes() and .detect_ctx()

2024-05-10 Thread Thomas Zimmermann
ee(udl_connector); } static const struct drm_connector_funcs udl_connector_funcs = { .reset = drm_atomic_helper_connector_reset, - .detect = udl_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, .destroy = udl_connector_destroy, .atomic_duplicate_st

Re: simpledrm, running display servers, and drivers replacing simpledrm while the display server is running

2024-05-10 Thread Thomas Zimmermann
nal DRM device open until a new one shows up. All DRM graphics drivers with hotplugging support are required to accept commands after their hardware has been unplugged. They simply won't display anything. Best regards Thomas Thanks -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software

Re: simpledrm, running display servers, and drivers replacing simpledrm while the display server is running

2024-05-10 Thread Thomas Zimmermann
shows up. All DRM graphics drivers with hotplugging support are required to accept commands after their hardware has been unplugged. They simply won't display anything. Best regards Thomas Thanks -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH

[PULL] drm-misc-fixes

2024-05-10 Thread Thomas Zimmermann
: add bandgap setting for g12 drivers/gpu/drm/drm_connector.c | 2 +- drivers/gpu/drm/meson/meson_dw_hdmi.c | 70 --- 2 files changed, 32 insertions(+), 40 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH

Re: [PATCH 11/11] drm/tegra: Use fbdev client helpers

2024-05-08 Thread Thomas Zimmermann
Hi Am 07.05.24 um 23:03 schrieb Felix Kuehling: On 2024-05-07 07:58, Thomas Zimmermann wrote: Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann

Re: [PATCH 00/15] drm: struct drm_edid conversions

2024-05-07 Thread Thomas Zimmermann
++--- 19 files changed, 167 insertions(+), 153 deletions(-) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

[PATCH] drm/fbdev-shmem: Clean up deferred I/O

2024-05-07 Thread Thomas Zimmermann
Call fb_deferred_io_cleanup() upon destroying the framebuffer device. Releases the internal memory. Signed-off-by: Thomas Zimmermann Fixes: 150f431a0831 ("drm/fbdev: Add fbdev-shmem") Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Da

[PATCH] drm/fbdev-dma: Clean up deferred I/O

2024-05-07 Thread Thomas Zimmermann
Call fb_deferred_io_cleanup() upon destroying the framebuffer device. Releases the internal memory. Signed-off-by: Thomas Zimmermann Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred I/O") Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Maarten Lan

Re: [PATCH 08/11] drm/i915: Use drm_fbdev_helper_client_unregister()

2024-05-07 Thread Thomas Zimmermann
Hi Am 07.05.24 um 14:25 schrieb Rodrigo Vivi: On Tue, May 07, 2024 at 01:58:29PM +0200, Thomas Zimmermann wrote: Implement struct drm_client_funcs.unregister with the helpers drm_fbdev_helper_client_unregister() and remove the custom code from the driver. The generic helper is equivalent

[PATCH 11/11] drm/tegra: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/radeon_fbdev.c | 66 ++- drivers/gpu/drm/tegra

[PATCH 10/11] drm/omapdrm: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 55 ++-- 1 file changed, 3

[PATCH 09/11] drm/msm: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 58 ++--- 1 file changed, 3

[PATCH 08/11] drm/i915: Use drm_fbdev_helper_client_unregister()

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs.unregister with the helpers drm_fbdev_helper_client_unregister() and remove the custom code from the driver. The generic helper is equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display/intel_fbdev.c | 21

[PATCH 05/11] drm/armada: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 58 ++- 1 file changed, 3

[PATCH 07/11] drm/gma500: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/fbdev.c | 58 ++ 1 file changed, 3

[PATCH 06/11] drm/exynos: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 58 ++- 1 file changed, 3

[PATCH 00/11] drm: Provide common fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
. i915 is slightly different, but can still use some of the helper code. Fbdev support for VGA switcheroo and non-atomic mode setting is now entirely implemented in the fbdev helpers. Thomas Zimmermann (11): drm/fb-helper: Add helpers for struct drm_client_funcs drm/fbdev-dma: Use fbdev client

[PATCH 01/11] drm/fb-helper: Add helpers for struct drm_client_funcs

2024-05-07 Thread Thomas Zimmermann
hotpluging if struct drm_device.fb_helper has been set, while the custom helper tests for struct drm_fb_helper.info. Both fields signal the presence of an active fbdev emulation, but the former field is deprecated. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 103

[PATCH 04/11] drm/fbdev-ttm: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_ttm.c | 58 +++-- 1 file changed, 5

[PATCH 03/11] drm/fbdev-shmem: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_shmem.c | 56 ++- 1 file changed, 2

[PATCH 02/11] drm/fbdev-dma: Use fbdev client helpers

2024-05-07 Thread Thomas Zimmermann
Implement struct drm_client_funcs with the respective helpers and remove the custom code from the emulation. The generic helpers are equivalent in functionality. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_dma.c | 56 ++--- 1 file changed, 2

Re: [PATCH v2 12/12] fbdev/viafb: Make I2C terminology more inclusive

2024-05-06 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/video

Re: [PATCH v2 11/12] fbdev/smscufx: Make I2C terminology more inclusive

2024-05-06 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/v

Re: [PATCH v3 0/3] arch: Remove fbdev dependency from video helpers

2024-05-03 Thread Thomas Zimmermann
Am 03.05.24 um 17:29 schrieb Arnd Bergmann: On Fri, Apr 5, 2024, at 11:04, Thomas Zimmermann wrote: Hi, if there are no further comments, can this series be merged through asm-generic? Sorry for the delay, I've merged these for asm-generic now. Thank you so much! Arnd

Re: [PATCH v1 12/12] fbdev/viafb: Make I2C terminology more inclusive

2024-05-03 Thread Thomas Zimmermann
Hi Am 03.05.24 um 00:26 schrieb Easwar Hariharan: On 5/2/2024 3:46 AM, Thomas Zimmermann wrote: Am 30.04.24 um 19:38 schrieb Easwar Hariharan: I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to

[PULL] drm-misc-fixes

2024-05-02 Thread Thomas Zimmermann
/gpu/drm/ttm/ttm_tt.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c| 1 + drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- 9 files changed, 80 insertions(+), 45 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany

Re: [PATCH v3 0/2] drm: Fix dma_resv deadlock at drm object pin time

2024-05-02 Thread Thomas Zimmermann
Hi Am 02.05.24 um 14:00 schrieb Boris Brezillon: On Thu, 2 May 2024 13:59:41 +0200 Boris Brezillon wrote: Hi Thomas, On Thu, 2 May 2024 13:51:16 +0200 Thomas Zimmermann wrote: Hi, ignoring my r-b on patch 1, I'd like to rethink the current patches in general. I think drm_gem_shmem_pin

Re: [PATCH v3 0/2] drm: Fix dma_resv deadlock at drm object pin time

2024-05-02 Thread Thomas Zimmermann
| 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) base-commit: 75b68f22e39aafb22f3d8e3071e1aba73560788c -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien

Re: [PATCH v3 1/2] drm/panfrost: Fix dma_resv deadlock at drm object pin time

2024-05-02 Thread Thomas Zimmermann
, you can add Reviewed-by: Thomas Zimmermann Best regards Thomas Cc: Thomas Zimmermann Cc: Dmitry Osipenko Cc: Boris Brezillon Cc: Steven Price Fixes: a78027847226 ("drm/gem: Acquire reservation lock in drm_gem_{pin/unpin}()") Signed-off-by: Adrián Larumbe --- drivers/gp

Re: [PATCH v1 12/12] fbdev/viafb: Make I2C terminology more inclusive

2024-05-02 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/video

Re: [PATCH v1 11/12] fbdev/smscufx: Make I2C terminology more inclusive

2024-05-02 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/v

Re: [PATCH v1 02/12] drm/gma500: Make I2C terminology more inclusive

2024-05-02 Thread Thomas Zimmermann
interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+rene...@sang-engineering.com/ Signed-off-by: Easwar Hariharan Acked-by: Thomas Zimmermann --- drivers/gpu/

Re: [PATCH] drm/fb_dma: Add checks in drm_fb_dma_get_scanout_buffer()

2024-04-29 Thread Thomas Zimmermann
, free free to add Reviewed-by: Thomas Zimmermann Best regards Thomas fb = plane->state->fb; /* Only support linear modifier */ if (fb->modifier != DRM_FORMAT_MOD_LINEAR) base-commit: 2e3f08a1ac99cb9a19a5cb151593d4f9df5cc6a7 -- -- Thomas Zimmermann Graphics Dri

Re: After suspend/resume cycle ASPEED VGA monitor suffers with "No Signal" state.

2024-04-29 Thread Thomas Zimmermann
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- SERR- -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

[PULL] drm-misc-fixes

2024-04-25 Thread Thomas Zimmermann
| 80 - drivers/video/fbdev/core/fb_defio.c | 2 +- 6 files changed, 4 insertions(+), 97 deletions(-) delete mode 100644 drivers/gpu/drm/gma500/psb_lid.c -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse

Re: [PATCH v8 6/6] drm/{i915,xe}: Implement fbdev emulation as in-kernel client

2024-04-23 Thread Thomas Zimmermann
Hi Am 23.04.24 um 13:36 schrieb Hogander, Jouni: On Tue, 2024-04-23 at 13:13 +0200, Thomas Zimmermann wrote: Hi Am 22.04.24 um 16:11 schrieb Hogander, Jouni: On Tue, 2024-04-09 at 10:04 +0200, Thomas Zimmermann wrote: Replace all code that initializes or releases fbdev emulation throughout

Re: [PATCH v2] fbdev: fix incorrect address computation in deferred IO

2024-04-23 Thread Thomas Zimmermann
bdev/271372d6-e665-4e7f-b088-dee5f4ab3...@oracle.com Fixes: 56c134f7f1b5 ("fbdev: Track deferred-I/O pages in pageref struct") Cc: Signed-off-by: Nam Cao Reviewed-by: Thomas Zimmermann Thank you so much. I'll take care of merging the patch later this week. Best regards Thomas

Re: [PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-23 Thread Thomas Zimmermann
ry.c#L5222 [2] https://elixir.bootlin.com/linux/v6.8/source/include/linux/pagemap.h#L957 Best regards Thomas Best regards, Nam -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH v8 6/6] drm/{i915,xe}: Implement fbdev emulation as in-kernel client

2024-04-23 Thread Thomas Zimmermann
Hi Am 22.04.24 um 16:11 schrieb Hogander, Jouni: On Tue, 2024-04-09 at 10:04 +0200, Thomas Zimmermann wrote: Replace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to intel_fbdev_setup() after i915 has

Re: [PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-23 Thread Thomas Zimmermann
. Can we do the same here and avoid that computation? Best regards Thomas [1] https://elixir.bootlin.com/linux/v6.8/source/drivers/video/fbdev/core/fb_defio.c#L100 struct page *page = vmf->page; file_update_time(vmf->vma->vm_file); -- -- Thomas Zimmermann Graphics Dri

Re: [PATCH] drm/atomic-helper: fix parameter order in drm_format_conv_state_copy() call

2024-04-19 Thread Thomas Zimmermann
-by: Lucas Stach Tested-by: Leonard Göhrs Reviewed-by: Thomas Zimmermann Please also add Cc: # v6.8+ Best regards Thomas --- drivers/gpu/drm/drm_gem_atomic_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_atomic_helper.c b/drive

[PATCH v3 25/43] drm/ingenic: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ingenic. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Paul Cercueil Acked-by: Paul Cercueil --- drivers/gpu

[PATCH v3 00/43] drm: Provide fbdev emulation per memory manager

2024-04-19 Thread Thomas Zimmermann
with simpledrm, vc4 and amdgpu. v3: - fbdev-dma: init fb_ops with DMAMEM initializer (Javier) - fbdev-shmem: clarify get_page usage (Javier) v2: - fbdev-shmem: use drm_driver_legacy_fb_format() (Geert) - fix a few typos Thomas Zimmermann (43): drm/fbdev-generic: Do not set physical framebuffer address

[PATCH v3 34/43] drm/tiny/ili9225: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9225. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu

[PATCH v3 24/43] drm/imx/lcdc: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by lcdc. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team

[PATCH v3 17/43] drm/tiny/simpledrm: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny

[PATCH v3 37/43] drm/tiny/mi0283qt: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by mi0283qt. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Nora

[PATCH v3 20/43] drm/vkms: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Rodrigo Siqueira Cc: Melissa Wen Cc: "Maíra Canal" Cc: Haneen Mohammed Cc: Daniel Vetter Reviewed-by: Javie

[PATCH v3 15/43] drm/tiny/gm12u320: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede Reviewed-by: Hans de Goede --- drivers/gpu/drm/tiny/gm12u320.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 19/43] drm/virtio: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Airlie Cc: Gerd Hoffmann Cc: Gurchetan Singh Cc: Chia-I Wu Tested-by: Dmitry Osipenko Reviewed-by: Javier

[PATCH v3 21/43] drm/fbdev-dma: Implement damage handling and deferred I/O

2024-04-19 Thread Thomas Zimmermann
that support coherent mappings. v3: - init fb_ops with FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS() (Javier) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_dma.c | 65 ++--- 1 file changed, 51 insertions(+), 14 deletions(-) diff

[PATCH v3 33/43] drm/tiny/ili9163: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9163. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm

[PATCH v3 41/43] drm/tiny/st7735r: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by st7735r. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu

[PATCH v3 43/43] drm/fbdev: Clean up fbdev documentation

2024-04-19 Thread Thomas Zimmermann
Rewrite some docs that are not up-to-date any longer. Remove the TODO item for fbdev-generic conversion, as the helper has been replaced. Make documentation for DMA, SHMEM and TTM emulation available. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet Reviewed-by: Javier Martinez Canillas

[PATCH v3 29/43] drm/renesas/rz-du: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rz-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Biju Das Tested-by: Biju Das Reviewed-by: Javier

[PATCH v3 07/43] fbdev/deferred-io: Provide get_page hook in struct fb_deferred_io

2024-04-19 Thread Thomas Zimmermann
typo in commit message (Javier) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/core/fb_defio.c | 4 include/linux/fb.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video

[PATCH v3 16/43] drm/tiny/ofdrm: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ofdrm.c

[PATCH v3 36/43] drm/tiny/ili9486: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9486. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm

[PATCH v3 08/43] drm/fbdev: Add fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
mechanism in commit description (Javier) v2: - use drm_driver_legacy_fb_format() (Geert) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_fbdev_shmem.c | 316 ++ include/drm

[PATCH v3 42/43] drm/fbdev-generic: Convert to fbdev-ttm

2024-04-19 Thread Thomas Zimmermann
Only TTM-based drivers use fbdev-generic. Rename it to fbdev-ttm and change the symbol infix from _generic_ to _ttm_. Link the source file into TTM helpers, so that it is only build if TTM-based drivers have been selected. Select DRM_TTM_HELPER for loongson. Signed-off-by: Thomas Zimmermann

[PATCH v3 01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-04-19 Thread Thomas Zimmermann
: - refer to vzalloc() in commit message (Javier) Signed-off-by: Thomas Zimmermann Fixes: a5b44c4adb16 ("drm/fbdev-generic: Always use shadow buffering") Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Zack Rusin Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: # v6.4+ Reviewed-

[PATCH v3 32/43] drm/tiny/hx8357d: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by hx8357d. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm

[PATCH v3 26/43] drm/mediatek: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ingenic. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Chun-Kuang Hu Cc: Philipp Zabel Reviewed-by: Javier

[PATCH v3 27/43] drm/panel/panel-ilitek-9341: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by panel-ilitek-9341. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam

[PATCH v3 39/43] drm/tiny/repaper: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by repaper. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --

[PATCH v3 40/43] drm/tiny/st7586: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by st7586. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu

[PATCH v3 30/43] drm/renesas/shmobile: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by shmobile. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Geert Uytterhoeven Reviewed

[PATCH v3 28/43] drm/renesas/rcar-du: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rcar-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Kieran Bingham Reviewed

[PATCH v3 22/43] drm/arm/komeda: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by komeda. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Liviu Dudau Acked-by: Liviu Dudau --- drivers/gpu/drm

  1   2   3   4   5   6   7   8   9   10   >