[PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses

2024-04-19 Thread A
>From 51e98164e314a2d1d834d2a9baea21a9823650bb Mon Sep 17 00:00:00 2001 From: Ashok Kumar Date: Fri, 19 Apr 2024 10:32:48 -0700 Subject: [PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses Adhere to Linux kernel coding style. Reported by checkpatch CHECK: Unnecessary parentheses

Re: [PATCH 04/12] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 2:21 PM, Dmitry Baryshkov wrote: On Sat, 20 Apr 2024 at 00:06, Abhinav Kumar wrote: On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: MDP4 and MDP5 drivers enumerate supported formats each time the plane is created. In preparation to merger of MDP DPU format databases, define

Re: [PATCH][next] drivers: video: Simplify device_node cleanup using __free

2024-04-19 Thread Shresth Prasad
> Please fix the subject line to be "backlight: : ...". I came > very close to deleting this patch without reading it ;-) . Really sorry about that, I'll fix it. > Do we need to get dev->of_node at all? The device, which we are > borrowing, already owns a reference to the node so I don't see >

Re: [PATCH 04/12] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: MDP4 and MDP5 drivers enumerate supported formats each time the plane is created. In preparation to merger of MDP DPU format databases, define precise formats list, so that changes to the database do not cause the driver to add unsupported format

Re: [PATCH 04/12] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Dmitry Baryshkov
On Sat, 20 Apr 2024 at 00:06, Abhinav Kumar wrote: > > > > On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: > > MDP4 and MDP5 drivers enumerate supported formats each time the plane is > > created. In preparation to merger of MDP DPU format databases, define > > precise formats list, so that changes

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

2024-04-19 Thread Rob Herring
On Thu, Apr 18, 2024 at 10:55:39PM +0200, Heiner Kallweit wrote: > 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based device > instantiation") removed the last call to i2c_mux_add_adapter() with a > non-null class argument. Therefore the class argument can be removed. > > Note:

[PATCH] drm: fix drm lastclose ignoring closed active fbs

2024-04-19 Thread Bob Beckett
From: Robert Beckett when fb's have been marked as closed, if there is still something active then don't restore fbdev during lastclose Signed-off-by: Robert Beckett --- drivers/gpu/drm/drm_fb_helper.c | 3 +++ drivers/gpu/drm/drm_plane.c | 21 +

Re: [PATCH v4 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-19 Thread Marijn Suijten
On 2024-04-17 18:29:34, David Wronek wrote: > Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a > Raydium RM69380 controller, as found on the Lenovo Xiaoxin Pad Pro 2021. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: David Wronek Reviewed-by: Marijn Suijten > --- >

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

2024-04-19 Thread Jonathan Cameron
On Thu, 18 Apr 2024 22:55:39 +0200 Heiner Kallweit wrote: > 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based device > instantiation") removed the last call to i2c_mux_add_adapter() with a > non-null class argument. Therefore the class argument can be removed. > > Note: Class-based

[linux-next:master] BUILD REGRESSION a35e92ef04c07bd473404b9b73d489aea19a60a8

2024-04-19 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a35e92ef04c07bd473404b9b73d489aea19a60a8 Add linux-next specific files for 20240419 Error/Warning: (recently discovered and may have been fixed) WARNING: modpost: vmlinux: section mismatch

Re: [git pull] drm fixes for 6.9-rc5

2024-04-19 Thread pr-tracker-bot
The pull request you sent on Fri, 19 Apr 2024 10:53:05 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-04-19 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ce944f3f97cf1bc813003ea2f3bf2abefa87dbd7 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v3 2/2] misc: sram: Add DMA-BUF Heap exporting of SRAM areas

2024-04-19 Thread Christian Gmeiner
Am Di., 9. Apr. 2024 um 14:14 Uhr schrieb Greg Kroah-Hartman : > > On Tue, Apr 09, 2024 at 02:06:05PM +0200, Pascal FONTAIN wrote: > > From: Andrew Davis > > > > This new export type exposes to userspace the SRAM area as a DMA-BUF > > Heap, > > this allows for allocations of DMA-BUFs that can be

[PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-19 Thread Nam Cao
With deferred IO enabled, a page fault happens when data is written to the framebuffer device. Then driver determines which page is being updated by calculating the offset of the written virtual address within the virtual memory area, and uses this offset to get the updated page within the

Re: [PATCH][next] drivers: video: Simplify device_node cleanup using __free

2024-04-19 Thread Dmitry Baryshkov
On Sat, Apr 20, 2024 at 12:22:41AM +0530, Shresth Prasad wrote: > > > Please fix the subject line to be "backlight: : ...". I came > > very close to deleting this patch without reading it ;-) . > > Really sorry about that, I'll fix it. > > > Do we need to get dev->of_node at all? The device,

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

2024-04-19 Thread Markus Elfring
… > Add a mutex unlock call. How do you think about a wording variant like the following? Extend the exception handling so that the missed mutex_unlock() call will be performed finally. Regards, Markus

Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing

2024-04-19 Thread Doug Anderson
Hi, On Thu, Apr 18, 2024 at 5:48 AM lvzhaoxiong wrote: > > ILI2900 requires reset to pull down time greater than 10ms, > so the configuration post_power_delay_ms is 10, and the chipset > initial time is required to be greater than 100ms, > so the post_gpio_reset_on_delay_ms is set to 100. > >

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-19 Thread Abhinav Kumar
On 4/10/2024 7:38 PM, Dmitry Baryshkov wrote: On Thu, 11 Apr 2024 at 02:54, Abhinav Kumar wrote: On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote: On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote: On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote: On Wed, 10 Apr 2024 at 23:00,

Re: [PATCH 2/7] drm/msm/dsi: Pass bonded-DSI hdisplay/2 to DSC timing configuration

2024-04-19 Thread Marijn Suijten
On 2024-04-17 14:58:25, Dmitry Baryshkov wrote: > On Wed, 17 Apr 2024 at 02:57, Marijn Suijten > wrote: > > > > When configuring the timing of DSI hosts (interfaces) in > > dsi_timing_setup() all values written to registers are taking bonded > > DSI into account by dividing the original mode

Re: [PATCH 2/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layour in the plane state and drop this call from dpu_plane_sspp_update(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[PATCH v2 1/9] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-19 Thread Dmitry Baryshkov
Instead of having DPU-specific defines, switch to the definitions from the mdp_common.xml.h file. This is the preparation for merged of DPU and MDP format tables. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 8 +-

[PATCH v2 5/9] drm/msm: merge dpu_format and mdp_format in struct msm_format

2024-04-19 Thread Dmitry Baryshkov
Structures dpu_format and mdp_format are largely the same structures. In order to remove duplication between format databases, merge these two stucture definitions into the global struct msm_format. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov ---

[PATCH v2 3/9] drm/msm/dpu: in dpu_format replace bitmap with unsigned long field

2024-04-19 Thread Dmitry Baryshkov
Using bitmap for the flags results in a clumsy syntax on test_bit, replace it with unsigned long type and simple binary ops. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +-

[PATCH v2 7/9] drm/msm: convert msm_format::unpack_align_msb to the flag

2024-04-19 Thread Dmitry Baryshkov
Instead of having a u8 or bool field unpack_align_msb, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 12 ++--

[PATCH v2 8/9] drm/msm: merge dpu format database to MDP formats

2024-04-19 Thread Dmitry Baryshkov
Finally remove duplication between DPU and generic MDP code by merging DPU format lists to the MDP format database. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 4 +- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 7 +-

[PATCH v2 9/9] drm/msm: drop msm_kms_funcs::get_format() callback

2024-04-19 Thread Dmitry Baryshkov
Now as all subdrivers were converted to use common database of formats, drop the get_format() callback and use mdp_get_format() directly. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 4 ++--

[PATCH v2 4/9] drm/msm/dpu: pull format flag definitions to mdp_format.h

2024-04-19 Thread Dmitry Baryshkov
In preparation to merger of formats databases, pull format flag definitions to mdp_format.h header, so that they are visibile to both dpu and mdp drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 98 ++---

[PATCH v2 2/9] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Dmitry Baryshkov
MDP4 and MDP5 drivers enumerate supported formats each time the plane is created. In preparation to merger of MDP DPU format databases, define precise formats list, so that changes to the database do not cause the driver to add unsupported format to the list. Reviewed-by: Abhinav Kumar

[PATCH v2 6/9] drm/msm: convert msm_format::unpack_tight to the flag

2024-04-19 Thread Dmitry Baryshkov
Instead of having a u8 or bool field unpack_tight, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 22

[PATCH v2 0/9] drm/msm: fold dpu_format into mdp_formats database

2024-04-19 Thread Dmitry Baryshkov
During the review of [1] Abhinav pointed out that mdp_rgb_formats and mdp_rgb_yuv_formats arrays from patch 1 are directly based on the struct mdp_format formats array. This was true, because MDP4 / MDP5 drivers used their own (small) list of supported formats. The DPU driver, supporting more

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 45 -

Re: [PATCH 3/9] drm/msm/dpu: split dpu_format_populate_layout

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 44

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Move a call to dpu_format_populate_plane_sizes() to the atomic_check > > step, so that any issues with the FB layout can be reported as early as > > possible. > > > >

Re: [PATCH v3 12/17] clk: mediatek: mt8365-mm: fix DPI0 parent

2024-04-19 Thread Stephen Boyd
Quoting Alexandre Mergnat (2024-04-18 07:17:00) > To have a working display through DPI, a workaround has been > implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to > the DPI node. Shortly, that add an extra clock. > > It seems consistent to have the "dpi0_sel" as parent. >

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 6:26 PM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote: On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov

[PATCH 2/3] drm/msm/mdp4: don't destroy mdp4_kms in mdp4_kms_init error path

2024-04-19 Thread Dmitry Baryshkov
Since commit 3c74682637e6 ("drm/msm/mdp4: move resource allocation to the _probe function") the mdp4_kms data is allocated during probe. It is an error to destroy it during mdp4_kms_init(), as the data is still referenced by the drivers's data and can be used later in case of probe deferral.

[PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-19 Thread Dmitry Baryshkov
MSM display drivers provide kms structure allocated during probe(). Don't clean up priv->kms field in case of an error. Otherwise probe functions might fail after KMS probe deferral. Fixes: a2ab5d5bb6b1 ("drm/msm: allow passing struct msm_kms to msm_drv_probe()") Signed-off-by: Dmitry Baryshkov

[PATCH 0/3] drm/msm/mdp4: fix probe deferral issues

2024-04-19 Thread Dmitry Baryshkov
While testing MDP4 LVDS support I noticed several issues (two are related to probe deferral case and last one is a c error in LCDC part). Fix those issues. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (3): drm/msm: don't clean up priv->kms prematurely drm/msm/mdp4: don't

[PATCH 3/3] drm/msm/mdp4: correct LCDC regulator name

2024-04-19 Thread Dmitry Baryshkov
Correct c error from the conversion of LCDC regulators to the bulk API. Fixes: 54f1fbcb47d4 ("drm/msm/mdp4: use bulk regulators API for LCDC encoder") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

Re: [PATCH 5/9] drm/msm/dpu: check for the plane pitch overflow

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 05:16:30PM -0700, Abhinav Kumar wrote: > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Check that the plane pitch doesn't overflow the maximum pitch size > > allowed by the hardware. > > > > Signed-off-by: Dmitry Baryshkov > > --- > >

[PATCH 2/2] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-04-19 Thread Dmitry Baryshkov
Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +- 1 file

[PATCH 1/2] drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER

2024-04-19 Thread Dmitry Baryshkov
This panel driver uses DSC PPS functions and as such depends on the DRM_DISPLAY_DP_HELPER. Add missing dependency Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kysryyli-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/Kconfig

[PATCH 0/2] drm/panel: two fixes for lg-sw43408

2024-04-19 Thread Dmitry Baryshkov
Fix two issues with the panel-lg-sw43408 driver reported by the kernel test robot. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (2): drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

Re: [PATCH 2/7] drm/msm/dsi: Pass bonded-DSI hdisplay/2 to DSC timing configuration

2024-04-19 Thread Dmitry Baryshkov
On Sat, Apr 20, 2024 at 12:18:39AM +0200, Marijn Suijten wrote: > On 2024-04-17 14:58:25, Dmitry Baryshkov wrote: > > On Wed, 17 Apr 2024 at 02:57, Marijn Suijten > > wrote: > > > > > > When configuring the timing of DSI hosts (interfaces) in > > > dsi_timing_setup() all values written to

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote: > > > On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: > > The msm_kms_funcs::check_modified_format() callback is not used by the > > driver. Drop it completely. > > > > Signed-off-by: Dmitry Baryshkov > > --- > >

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 6:34 PM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as

Re: [PATCH 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-04-19 Thread Dmitry Baryshkov
On Sat, 20 Apr 2024 at 06:05, Abhinav Kumar wrote: > > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Lift mode_config limits set by the DPU driver to the actual FB limits as > > handled by the dpu_plane.c. > > > > Signed-off-by: Dmitry Baryshkov > > --- > >

Re: [PATCH 5/9] drm/msm/dpu: check for the plane pitch overflow

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 +- 2

Re: [PATCH 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

Re: [PATCH 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 8:06 PM, Dmitry Baryshkov wrote: On Sat, 20 Apr 2024 at 06:05, Abhinav Kumar wrote: On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Signed-off-by: Dmitry Baryshkov ---

[pull] amdgpu, amdkfd, radeon drm-next-6.10

2024-04-19 Thread Alex Deucher
Hi Dave, Sima, More new stuff for 6.10. The following changes since commit ab956ed95b8bc4a65c913d7057075866d5fc3724: drm/amd/display: Add a function for checking tmds mode (2024-04-12 00:36:47 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12

Re: [PATCH] component: Support masters with no subcomponents

2024-04-19 Thread Linus Walleij
On Thu, Apr 18, 2024 at 1:36 AM Dmitry Baryshkov wrote: > I have LVDS working on apq8064, but it requires fixes in the MMCC > driver, in the MDP4 driver and in DTS. I need to clean up them first > before even attempting to send them out. Also a PWM/LPG driver would > help as otherwise the power

[PATCH v3 03/43] fbdev/deferred-io: Clean up pageref on lastclose

2024-04-19 Thread Thomas Zimmermann
Clean up the pageref state as part of the lastclose helper. This only requires to clear the page's mapping field. The pageref and page can stay in place for the next opened instance of the frame- buffer file. With the change in the clean-up logic, there's no further need to look up pages during

[PATCH v3 04/43] fbdev/deferred-io: Test screen_buffer for vmalloc'ed memory

2024-04-19 Thread Thomas Zimmermann
Framebuffers in virtual memory are available via screen_buffer. Use it instead of screen_base and avoid the type casting. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/core/fb_defio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v3 06/43] fbdev/deferred-io: Always call get_page() for framebuffer pages

2024-04-19 Thread Thomas Zimmermann
Unconditionally call get_page() after looking up a page from the framebuffer memory. Guarantees that we always hold a reference. This change also refactors the code such that it can support a driver-supplied get_page helper. This will be useful for DRM's fbdev emulation. Signed-off-by: Thomas

[PATCH v3 02/43] fbdev/deferred-io: Move pageref setup into separate helper

2024-04-19 Thread Thomas Zimmermann
Set up struct fb_deferred_io_pageref in the new helper function fb_deferred_io_pageref_lookup(), which runs when the pageref is first taken. Remove the setup code from the rest of the code. At first, the code allocates the memory of all pageref structs. The setup of the various fields happens

[PATCH v3 05/43] fbdev/deferred-io: Test smem_start for I/O memory

2024-04-19 Thread Thomas Zimmermann
Test smem_start before looking up pages from its value. Return NULL if it is unset. This will result in a SIGBUS signal. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/core/fb_defio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v3 09/43] drm/ast: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Jocelyn Falempe Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c |

[PATCH v3 10/43] drm/gud: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers/gpu/drm/gud/gud_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 11/43] drm/hyperv: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Deepak Rawat Reviewed-by: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 4 ++-- 1 file changed, 2

[PATCH v3 14/43] drm/tiny/cirrus: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 12/43] drm/mgag200: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Jocelyn Falempe Reviewed-by: Jocelyn Falempe ---

Re: [PATCH 1/3] drm/i915: Refactor confusing __intel_gt_reset()

2024-04-19 Thread Nirmoy Das
Hi John. On 4/19/2024 1:27 AM, John Harrison wrote: On 4/18/2024 10:10, Nirmoy Das wrote: __intel_gt_reset() is really for resetting engines though the name might suggest something else. So add two helper functions to remove confusions with no functional changes. Technically you only added one

Re: [PATCH 2/3] drm/i915 Rename intel_engine_reset to intel_gt_engine_recover

2024-04-19 Thread Nirmoy Das
Hi John, On 4/19/2024 1:27 AM, John Harrison wrote: On 4/18/2024 10:10, Nirmoy Das wrote: intel_engine_reset() not only reset a engine but also tries to recover it so give it a proper name without any functional changes. Not seeing what the difference is. If this was a super low level

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

2024-04-19 Thread Peter Rosin
Hi! 2024-04-18 at 22:55, Heiner Kallweit wrote: > 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based device > instantiation") removed the last call to i2c_mux_add_adapter() with a > non-null class argument. Therefore the class argument can be removed. > > Note: Class-based device

Re: [PATCH v3 14/17] drm/mediatek: add MT8365 SoC support

2024-04-19 Thread Alexandre Mergnat
On 19/04/2024 10:01, AngeloGioacchino Del Regno wrote: Il 18/04/24 16:17, amerg...@baylibre.com ha scritto: From: Fabien Parent Add DRM support for MT8365 SoC. Signed-off-by: Fabien Parent Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Alexandre Mergnat There are two things

Re: [PATCH v3 28/43] drm/renesas/rcar-du: Use fbdev-dma

2024-04-19 Thread Kieran Bingham
Quoting Thomas Zimmermann (2024-04-19 09:29:21) > Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports > damage handling, which is required by rcar-du. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann >

[PATCH v5 1/1] UPSTREAM: drm/bridge: it6505: fix hibernate to resume no display issue

2024-04-19 Thread kuro
From: Kuro ITE added a FIFO reset bit for input video. When system power resume, the TTL input of it6505 may get some noise before video signal stable and the hardware function reset is required. But the input FIFO reset will also trigger error interrupts of output module rising. Thus, it6505

[PATCH v5 0/1] drm/bridge: it6505: fix hibernate to resume no display issue

2024-04-19 Thread kuro
From: Kuro New patch description for v5 patch after customer feedback and test finished, update again, kernel build pass. New patch description for v4 patch update by reviewer Pin-yen Lin comment, remove function

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Patrik Jakobsson
On Fri, Apr 19, 2024 at 9:45 AM Takashi Iwai wrote: > > On Fri, 19 Apr 2024 09:39:09 +0200, > Harshit Mogalapalli wrote: > > > > Hi Takashi, > > > > On 19/04/24 12:14, Takashi Iwai wrote: > > > On Thu, 18 Apr 2024 21:29:57 +0200, > > > Helge Deller wrote: > > >> > > >> On 4/18/24 16:26, Takashi

Re: [PATCH v3 14/17] drm/mediatek: add MT8365 SoC support

2024-04-19 Thread AngeloGioacchino Del Regno
Il 18/04/24 16:17, amerg...@baylibre.com ha scritto: From: Fabien Parent Add DRM support for MT8365 SoC. Signed-off-by: Fabien Parent Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Alexandre Mergnat There are two things that I want to point out. Please check below. The series

[PATCH v3 30/43] drm/renesas/shmobile: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by shmobile. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Geert Uytterhoeven Reviewed-by:

[PATCH v3 28/43] drm/renesas/rcar-du: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rcar-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Kieran Bingham Reviewed-by:

[PATCH v3 39/43] drm/tiny/repaper: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by repaper. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes ---

[PATCH v3 40/43] drm/tiny/st7586: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by st7586. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner ---

[PATCH v3 27/43] drm/panel/panel-ilitek-9341: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by panel-ilitek-9341. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam

[PATCH v3 01/43] drm/fbdev-generic: Do not set physical framebuffer address

2024-04-19 Thread Thomas Zimmermann
Framebuffer memory is allocated via vzalloc() from non-contiguous physical pages. The physical framebuffer start address is therefore meaningless. Do not set it. The value is not used within the kernel and only exported to userspace on dedicated ARM configs. No functional change is expected. v2:

[PATCH v3 32/43] drm/tiny/hx8357d: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by hx8357d. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 26/43] drm/mediatek: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ingenic. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Chun-Kuang Hu Cc: Philipp Zabel Reviewed-by: Javier

[PATCH v3 42/43] drm/fbdev-generic: Convert to fbdev-ttm

2024-04-19 Thread Thomas Zimmermann
Only TTM-based drivers use fbdev-generic. Rename it to fbdev-ttm and change the symbol infix from _generic_ to _ttm_. Link the source file into TTM helpers, so that it is only build if TTM-based drivers have been selected. Select DRM_TTM_HELPER for loongson. Signed-off-by: Thomas Zimmermann

[PATCH v3 08/43] drm/fbdev: Add fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Add an fbdev emulation for SHMEM-based memory managers. The code is similar to fbdev-generic, but does not require an additional shadow buffer for mmap(). Fbdev-shmem operates directly on the buffer object's SHMEM pages. Fbdev's deferred-I/O mechanism updates the hardware state on write

[PATCH v3 36/43] drm/tiny/ili9486: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9486. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 16/43] drm/tiny/ofdrm: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ofdrm.c |

[PATCH v3 07/43] fbdev/deferred-io: Provide get_page hook in struct fb_deferred_io

2024-04-19 Thread Thomas Zimmermann
Add a callback for drivers to provide framebuffer pages to fbdev's deferred-I/O helpers. Implementations need to acquire a reference on the page before returning it. Returning NULL generates a SIGBUS signal. This will be useful for DRM's fbdev emulation with GEM-shmem buffer objects. v2: - fix

[PATCH v3 29/43] drm/renesas/rz-du: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rz-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Biju Das Tested-by: Biju Das Reviewed-by: Javier

[PATCH v3 43/43] drm/fbdev: Clean up fbdev documentation

2024-04-19 Thread Thomas Zimmermann
Rewrite some docs that are not up-to-date any longer. Remove the TODO item for fbdev-generic conversion, as the helper has been replaced. Make documentation for DMA, SHMEM and TTM emulation available. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet Reviewed-by: Javier Martinez Canillas

[PATCH v3 18/43] drm/udl: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Sean Paul Cc: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/udl/udl_drv.c

[PATCH v3 13/43] drm/solomon: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 4 ++-- 1 file

[PATCH v3 35/43] drm/tiny/ili9341: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9341. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Kamlesh Gurudasani Reviewed-by: Javier Martinez

[PATCH v3 38/43] drm/tiny/panel-mipi-dbi: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by panel-mipi-dbi. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes ---

[PATCH v3 23/43] drm/hisilicon/kirin: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by kirin. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Xinliang Liu Cc: Tian Tao Cc: Xinwei Kong Cc: Sumit

[PATCH v3 22/43] drm/arm/komeda: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by komeda. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Liviu Dudau Acked-by: Liviu Dudau ---

[PATCH v3 31/43] drm/rockchip: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rockchip. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan

[PATCH v3 33/43] drm/tiny/ili9163: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9163. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas ---

[PATCH v3 41/43] drm/tiny/st7735r: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by st7735r. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner ---

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

2024-04-19 Thread Laurent Pinchart
Hi Heiner, Thank you for the patch. On Thu, Apr 18, 2024 at 10:55:39PM +0200, Heiner Kallweit wrote: > 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based device > instantiation") removed the last call to i2c_mux_add_adapter() with a > non-null class argument. Therefore the class

Re: [PATCH v1 2/4] drm/panel: boe-tv101wum-nl6: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-04-19 Thread Linus Walleij
On Fri, Apr 19, 2024 at 2:48 AM cong yang wrote: > > Use one driver, use different compatible strings for the different > > panels and use the corresponding sequence for each panel > > selected by compatible string. > > I mean add starry_himax83102_j02, boe_nv110wum and ivo_t109nw41 > together

[PATCH v3 37/43] drm/tiny/mi0283qt: Use fbdev-dma

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by mi0283qt. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes ---

[PATCH v3 17/43] drm/tiny/simpledrm: Use fbdev-shmem

2024-04-19 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas ---

  1   2   >