Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Fabio Estevam
On Mon, Oct 28, 2013 at 7:19 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com This is based on the initial work done by Sascha Hauer and Tony Prisk. It looks like you've

Re: [PATCH 1/2] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c

2013-10-29 Thread Greg KH
On Tue, Oct 29, 2013 at 12:14:14AM +0100, Andi Shyti wrote: Hi Greg, If you write it like this: return !ret ? ret : -ETIMEDOUT; checkpatch shouldn't complain. No, but I will. That's horrid code, please be specific and readable, no one should ever use ?: syntax

Re: [PATCH] drivers: staging: bcm: Removed a developer debug statement.

2013-10-29 Thread Greg KH
On Thu, Oct 24, 2013 at 01:02:45AM +0300, Dan Carpenter wrote: On Wed, Oct 23, 2013 at 03:11:20PM -0400, Chuong Ngo wrote: Removed a developer debug statement per the TODO list. Additionally, removed braces for the if-statement to match coding style. Line wrap the changelog at 72

Re: [PATCH 02/11 V2] Staging: bcm: Remove typedef for _U_IP_ADDRESS and call directly.

2013-10-29 Thread Greg KH
On Mon, Oct 28, 2013 at 11:51:39PM -0400, Kevin McKinney wrote: This patch removes typedef for _U_IP_ADDRESS, and changes the name of the struct to bcm_ip_address. In addition, any calls to struct U_IP_ADDRESS are changed to call directly. Signed-off-by: Kevin McKinney klmckinn...@gmail.com

Re: [PATCH 02/11 V2] Staging: bcm: Remove typedef for _U_IP_ADDRESS and call directly.

2013-10-29 Thread Greg KH
On Tue, Oct 29, 2013 at 09:01:48AM -0700, Greg KH wrote: On Mon, Oct 28, 2013 at 11:51:39PM -0400, Kevin McKinney wrote: This patch removes typedef for _U_IP_ADDRESS, and changes the name of the struct to bcm_ip_address. In addition, any calls to struct U_IP_ADDRESS are changed to call

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 01:45:50PM -0200, Fabio Estevam wrote: On Tue, Oct 29, 2013 at 1:00 PM, Fabio Estevam feste...@gmail.com wrote: Today I was able to get access to a wandboard solo and the HDMI image does look different compared to a wandboard quad board: - The Linux logo penguins

[patch] staging: ozwpan: prevent overflow in oz_cdev_write()

2013-10-29 Thread Dan Carpenter
We need to check count so we don't overflow the ei-data buffer. Reported-by: Nico Golde n...@ngolde.de Reported-by: Fabian Yamaguchi f...@goesec.de Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index

Re: [PATCH] staging: octeon: drop redundant mac address check

2013-10-29 Thread David Daney
On 10/28/2013 06:24 PM, Luka Perkov wrote: Checking if MAC address is valid using is_valid_ether_addr() is already done in of_get_mac_address(). Signed-off-by: Luka Perkov l...@openwrt.org Acked-by: David Daney david.da...@cavium.com --- drivers/staging/octeon/ethernet.c | 2 +- 1 file

[patch] Staging: sb105x: info leak in mp_get_count()

2013-10-29 Thread Dan Carpenter
The icount.reserved[] array isn't initialized so it leaks stack information to userspace. Reported-by: Nico Golde n...@ngolde.de Reported-by: Fabian Yamaguchi f...@goesec.de Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/staging/sb105x/sb_pci_mp.c

[PATCH] staging: bcm: Remove unnecessary pointer casting

2013-10-29 Thread Lisa Nguyen
Some void pointers can be assigned to other pointer variables in functions without casting. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/CmHost.c | 10 +- drivers/staging/bcm/IPv6Protocol.c | 2 +- drivers/staging/bcm/InterfaceDld.c | 4 ++--

Re: [PATCH] imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 07:42:22PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com sig_cfg.clk_pol controls the 'di0_polarity_disp_clk' bit of register IPUx_DI0_GENERAL through the following code in imx-drm/ipu-v3/ipu-di.c: if (!sig-clk_pol)

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 08:01:46PM -0200, Fabio Estevam wrote: Hi Greg, On Mon, Oct 28, 2013 at 7:03 PM, Greg KH gre...@linuxfoundation.org wrote: And why is new support being added to this driver instead of working to get it out of staging? Philipp Zabel mentioned that he will submit

Re: [PATCH] imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity

2013-10-29 Thread Fabio Estevam
Hi Russell, On Tue, Oct 29, 2013 at 9:25 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: There's slightly more to this than that mail, and I have to raise the issue about whether this is the correct fix or not. See: http://www.spinics.net/lists/arm-kernel/msg279902.html Today I

[PATCH 08/12 V3] Staging: bcm: Replace B_UINT8 with u8 in Adapter.h

2013-10-29 Thread Kevin McKinney
This patch replaces B_UINT8 with u8 in Adapter.h Signed-off-by: Kevin McKinney klmckinn...@gmail.com --- drivers/staging/bcm/Adapter.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h index

[PATCH 03/12 V3] Staging: bcm: Replace USHORT with unsigned short in Adapter.h

2013-10-29 Thread Kevin McKinney
This patch replaces USHORT with unsigned short in Adapter.h Signed-off-by: Kevin McKinney klmckinn...@gmail.com --- drivers/staging/bcm/Adapter.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/bcm/Adapter.h

[PATCH 01/12 V3] Staging: bcm: Fix WARNING: space prohibited before semicolon.

2013-10-29 Thread Kevin McKinney
This patch removes a space before semicolon as specified by checkpatch.pl. Signed-off-by: Kevin McKinney klmckinn...@gmail.com --- drivers/staging/bcm/Adapter.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h

[PATCH 09/12 V3] Staging: bcm: Replace UINT32 with u32 in Adapter.h

2013-10-29 Thread Kevin McKinney
This patch replaces UINT32 with u32 in Adapter.h Signed-off-by: Kevin McKinney klmckinn...@gmail.com --- drivers/staging/bcm/Adapter.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h index

[PATCH -next] staging: drm/imx: fix return value check in ipu_add_subdevice_pdata()

2013-10-29 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function platform_device_register_data() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

[PATCH 4/8] staging: bcm: Replace INT with int

2013-10-29 Thread Lisa Nguyen
Replace user-defined data type INT with C defined int data type. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Bcmchar.c | 14 +++ drivers/staging/bcm/Bcmnet.c | 4 +- drivers/staging/bcm/HandleControlPacket.c | 2 +-

[PATCH 8/8] staging: bcm: Remove user defined data type DWORD

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type DWORD in Typedef.h since it is not used anywhere in the bcm driver. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Typedefs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h

[PATCH 1/8] staging: bcm: Replace PVOID with void *

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type PVOID and replace it with void *. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Adapter.h | 22 +++--- drivers/staging/bcm/Bcmchar.c | 6 +++--- drivers/staging/bcm/CmHost.c | 16

[PATCH 7/8] staging: bcm: Replace LONG with long

2013-10-29 Thread Lisa Nguyen
Replace user-defined data type LONG with C defined data type long. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/CmHost.c | 22 ++--- drivers/staging/bcm/HandleControlPacket.c | 2 +- drivers/staging/bcm/IPv6Protocol.c| 6 +++---

[PATCH 5/8] staging: bcm: Remove user defined data type PSHORT

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type PSHORT since it is not used anywhere in the bcm driver. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Typedefs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h index

[PATCH v2 1/8] staging: bcm: Replace PVOID with void *

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type PVOID and replace it with void *. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Adapter.h | 22 +++--- drivers/staging/bcm/Bcmchar.c | 6 +++--- drivers/staging/bcm/CmHost.c | 16

[PATCH v2 5/8] staging: bcm: Remove user defined data type PSHORT

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type PSHORT since it is not used anywhere in the bcm driver. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Typedefs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h index

[PATCH v2 4/8] staging: bcm: Replace INT with int

2013-10-29 Thread Lisa Nguyen
Replace user-defined data type INT with C defined int data type. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Bcmchar.c | 14 +++ drivers/staging/bcm/Bcmnet.c | 4 +- drivers/staging/bcm/HandleControlPacket.c | 2 +-

[PATCH v2 7/8] staging: bcm: Replace VOID with void

2013-10-29 Thread Lisa Nguyen
Replace user-defined data type VOID with C defined data type void. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- Changes since v2: - Corrected subject line and commit message drivers/staging/bcm/CmHost.c | 22 ++--- drivers/staging/bcm/HandleControlPacket.c |

[PATCH 0/8] staging: bcm: Clean up user defined data types

2013-10-29 Thread Lisa Nguyen
This patch series reflects the first round of data type cleanups. There was no need to redefine existing data types, and some user defined data types were removed if they were not used anywhere in the bcm driver. Lisa Nguyen (8): staging: bcm: Replace PVOID with void * staging: bcm:

[PATCH v2 8/8] staging: bcm: Remove user defined data type DWORD

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type DWORD in Typedef.h since it is not used anywhere in the bcm driver. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Typedefs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h

[PATCH 3/8] staging: bcm: Remove user defined type SHORT

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type SHORT since it is not used anywhere in the bcm driver. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Typedefs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h index

[PATCH v2 3/8] staging: bcm: Remove user defined type SHORT

2013-10-29 Thread Lisa Nguyen
Remove user-defined data type SHORT since it is not used anywhere in the bcm driver. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Typedefs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/bcm/Typedefs.h b/drivers/staging/bcm/Typedefs.h index

[PATCH v2 2/8] staging: bcm: Replace CHAR with char

2013-10-29 Thread Lisa Nguyen
Replace user-defined data type CHAR with C defined char data type. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- drivers/staging/bcm/Adapter.h | 2 +- drivers/staging/bcm/HandleControlPacket.c | 2 +- drivers/staging/bcm/Typedefs.h| 1 - 3 files changed, 2