On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick
stephanie.s.wall...@intel.com wrote:
This is where we handle media specific packets and transport. The MS driver
interfaces with a media agnostic (MA) driver via a series of transfer pairs.
Transfer pairs consist of a set of functions to pass
[added linux-...@vger.kernel.org Cc]
Stephanie Wallick stephanie.s.wall...@intel.com writes:
Media Agnostic (MA) USB enables the USB protocol to be used over a wide
range of physical media. MA USB is a relatively new protocol and is
currently unsupported in the Linux kernel. This patch set
On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote:
This patch replaces dev_err by pr_err since the value
of ir is NULL when the message is displayed.
Signed-off-by: Aya Mahfouz mahfouz.saif.elya...@gmail.com
---
drivers/staging/media/lirc/lirc_zilog.c | 2 +-
1 file changed, 1
The v4l2-mediabus.h header is now deprecated and should be replaced with
v4l2-mbus.h.
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
---
drivers/staging/media/omap4iss/iss_csi2.c | 2 +-
drivers/staging/media/omap4iss/iss_video.h | 2 +-
2 files changed, 2 insertions(+), 2
Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
users don't have access to these definitions.
We have to keep this definition for user-space users even though they're
encouraged to move to the new media_bus_format enum.
Signed-off-by: Boris Brezillon
The v4l2-mediabus.h header is now deprecated and should be replaced with
v4l2-mbus.h.
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
---
drivers/gpu/ipu-v3/ipu-csi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/ipu-v3/ipu-csi.c
The v4l2_mbus_pixelcode enum (or its values) should be replaced by the
media_bus_format enum.
Keep this enum in v4l2-mediabus.h and create a new header containing
the v4l2_mbus_framefmt struct definition (which is not deprecated) so
that we can add a #warning statement in v4l2-mediabus.h and
Replace references to the v4l2_mbus_pixelcode enum with the new
media_bus_format enum in all common headers.
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
---
include/media/v4l2-mediabus.h| 2 +-
include/media/v4l2-subdev.h | 2 +-
include/uapi/linux/v4l2-subdev.h |
Hello,
This patch series prepares the use of media bus formats outside of
the V4L2 subsytem (my final goal is to use it in the Atmel HLCDC DRM
driver where I have to configure my DPI/RGB bus according to the
connected display).
The series first defines a new enum with a neutral name
The v4l2-mediabus.h header is now deprecated and should be replaced with
v4l2-mbus.h.
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
---
drivers/media/platform/omap3isp/ispcsi2.c | 2 +-
drivers/media/platform/omap3isp/ispvideo.h | 2 +-
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all usb drivers.
Signed-off-by: Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definition in pci drivers.
Signed-off-by: Boris
Rename mediabus formats and move the enum into a separate header file so
that it can be used by DRM/KMS subsystem without any reference to the V4L2
subsystem.
Old V4L2_MBUS_FMT_ definitions are now referencing MEDIA_BUS_FMT_ value.
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in the ipu-v3 driver.
Signed-off-by: Boris Brezillon
The v4l2-mediabus.h header is now deprecated and should be replaced with
v4l2-mbus.h.
Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com
---
drivers/media/i2c/mt9m032.c | 2 +-
drivers/media/i2c/mt9t001.c | 2 +-
drivers/media/i2c/mt9v032.c
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Update the v4l documentation accordingly.
Signed-off-by: Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all media drivers residing in staging.
Signed-off-by: Boris
In order to have subsytem agnostic media bus format definitions we've
moved media bus definitions to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in i2c drivers.
Signed-off-by: Boris
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all platform drivers.
Signed-off-by: Boris Brezillon
On 11/04/14 11:20, Hans Verkuil wrote:
Hi Boris,
On 11/04/14 10:54, Boris Brezillon wrote:
Rename mediabus formats and move the enum into a separate header file so
that it can be used by DRM/KMS subsystem without any reference to the V4L2
subsystem.
Old V4L2_MBUS_FMT_ definitions are
Hi Hans,
On Tue, 04 Nov 2014 11:20:40 +0100
Hans Verkuil hansv...@cisco.com wrote:
Hi Boris,
On 11/04/14 10:54, Boris Brezillon wrote:
Rename mediabus formats and move the enum into a separate header file so
that it can be used by DRM/KMS subsystem without any reference to the V4L2
Linux already includes a copy of the GPL, checkpatch compains about the address.
Remove it from the license text.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/imx-ldb.c | 5 -
drivers/staging/imx-drm/imx-tve.c | 5 -
Add myself as the maintainer of the i.MX DRM driver.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index df2aecf..ddf191d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3183,6 +3183,13 @@
The imx-drm driver was put into staging mostly for the following reasons,
all of which have been addressed or superseded:
- convert the irq driver to use linear irq domains
- work out the device tree bindings, this lead to the common of_graph
bindings being used
- factor out common helper
Am Dienstag, den 04.11.2014, 11:52 +0100 schrieb Philipp Zabel:
The imx-drm driver was put into staging mostly for the following reasons,
all of which have been addressed or superseded:
- convert the irq driver to use linear irq domains
- work out the device tree bindings, this lead to the
Well, I gave two alternatives :-)
Both are fine as far as I am concerned, but it would be nice to hear
what others think.
Regards,
Hans
On 11/04/14 11:45, Boris Brezillon wrote:
Hi Hans,
On Tue, 04 Nov 2014 11:20:40 +0100
Hans Verkuil hansv...@cisco.com wrote:
Hi Boris,
On
On Tue, Nov 4, 2014 at 6:52 PM, Philipp Zabel p.za...@pengutronix.de wrote:
Add myself as the maintainer of the i.MX DRM driver.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Shawn Guo shawn@linaro.org
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff
From: Andy yan andy@rock-chips.com
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly difference, such as phy pll configuration, register width(imx hdmi
register is one byte, but rk3288
KY Srinivasan k...@microsoft.com writes:
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, October 22, 2014 9:07 AM
To: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org
Cc: linux-ker...@vger.kernel.org
Subject: [PATCH] tools: hv:
Hi,
On 04/11/14 13:39, Andy Yan wrote:
From: Andy yan andy@rock-chips.com
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Change-Id: I5f417372f256aa26cd00a3cd0160741680afd39d
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width(imx hdmi register is one byte, but rk3288 is 4
bytes width), 4K support(imx6 doesn't support 4k, but
Hi Andy,
On 04/11/14 13:33, Andy Yan wrote:
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width(imx hdmi register is one byte, but rk3288 is 4
On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote:
From: Andy yan andy@rock-chips.com
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly difference, such as phy pll
On Tue, Nov 04, 2014 at 09:39:58PM +0800, Andy Yan wrote:
From: Andy yan andy@rock-chips.com
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Change-Id:
Hi Philipp,
Just a flyby question
On 04/11/14 10:52, Philipp Zabel wrote:
The imx-drm driver was put into staging mostly for the following reasons,
all of which have been addressed or superseded:
- convert the irq driver to use linear irq domains
- work out the device tree bindings, this
Get rid of all extraneous blank lines in periodic_work.c.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/periodic_work.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/periodic_work.c
The error output in mapit() in memregion_direct.c has variables past the 80
character limit. Move them to the next line, but the string constant will still
go past the limit, and that's okay.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
Get rid of the extra blank lines in this file.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/memregion_direct.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/memregion_direct.c
Add a comment to the charqueue's spinlock to explain that it is a lock for the
structure.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/charqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Use the variable name rather than the type in the sizeof() call in this
function.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/memregion_direct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Clean up the extraneous blank lines in charqueue.c.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/charqueue.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/charqueue.c
Fix the declaration line so it is just one single line, and add the missing
brackets on the else clause in the if statement.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
The last if statement in this function is missing brackets on the else
clause. Add them.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/periodic_work.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Fix the sizeof() so it uses the variable name rather than the type, fix the
argument alignment to the kzalloc(), and rename the goto label.
Away = cleanup
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/memregion_direct.c | 8
1 file
Fix the function name declaration so it is just one line, and add the missing
brackets to the else clause in the if statement.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Fix warnings, errors, and strict checks in the visorutil directory.
Benjamin Romer (15):
staging: unisys: fix line spacing in charqueue.c
staging: unisys: refactor CHARQUEUE
staging: unisys: split double assignment in visor_charqueue_create()
staging: unisys: add comment to spinlock in
Remove the typedef for this structure and just use struct memregion instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorchannel/visorchannel.h | 2 +-
.../unisys/visorchannel/visorchannel_funcs.c | 6 ++--
Remove the typedef and just use struct charqueue instead. Update all references.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/charqueue.c | 21 +++--
drivers/staging/unisys/visorutil/charqueue.h | 17 +
2 files
Split up the doubled assignment in visor_charqueue_create() into two separate
assignments.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/charqueue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Remove all the extraneous blank lines from visorkmodutils.c.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c
Get rid of all extra spaces between casts and their targets in this file.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/memregion_direct.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Tuesday, November 4, 2014 4:40 AM
To: KY Srinivasan; Haiyang Zhang
Cc: Greg Kroah-Hartman; de...@linuxdriverproject.org; linux-
ker...@vger.kernel.org
Subject: [PATCH] Drivers: hv: vmbus: Fix a race
Remove the private data member 'ao_sample_count' and use the comedi_async
'scans_done' member to detect the analog output end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'stop_count' and use the comedi_async
'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'stop_count' and use the comedi_async
'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'ai_sample_count' and use the comedi_async
'scans_done' member to detect the analog input end-of-acquisition.
Move the EOA check so it happens after adding the samples from the current
urb to the async buffer. This prevents the unnecessary resubmit of the urb
when
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'ntrig' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This member of the private data is set to '0' but never used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 2 --
1 file changed, 2
Remove the private data member 'stopcount' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The comedi drivers that support async commands with a cmd-stop_src of
TRIG_COUNT
currently have a private data member that is used to count the number of scans
completed in order to detect the end of acquisition for the command.
This series addes a new member, 'scans_done', to comedi_async and
Remove the private data member 'ao_sample_count' and use the comedi_async
'scans_done' member to detect the analog output end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'ai_AiActualScan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
The function v_APCI3120_InterruptDmaMoveBlock16bit() is then just a wrapper
for comedi_buf_write_samples(). Remove it.
Signed-off-by: H Hartley Sweeten
Remove the private data member 'ao_stop_count' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Use the helper function comedi_nscans_left() to determine the number of scans
available in the async buffer or left in the command.
Signed-off-by: H Hartley Sweeten
This series converts the remaining comedi drivers to use the comedi_async
'scans_done' member to count the number of scans completed when counting
scans with a cmd-stop_src of TRIG_COUNT.
H Hartley Sweeten (13):
staging: comedi: drivers: introduce comedi_nscans_left()
staging: comedi:
Remove the private data member 'ao_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
read from the async buffer.
Signed-off-by: H Hartley Sweeten
Introduce a helper function to determine the number of scans left in
the async command.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedidev.h | 2 ++
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the analog input end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Remove the private data member 'ai_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten
Introduce a helper function to calculate the number of samples remaining
when the cmd-stop_src is TRIG_COUNT.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedidev.h |
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Remove the private data member 'ai_count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Use the helper function comedi_nscans_left() to check if the number of scans
left in the command.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Remove the private data member 'ai_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the helper function comedi_nscans_left() to get the number of scans in the
async buffer of left in the command.
Signed-off-by: H Hartley Sweeten
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
Remove the private data member 'ai_scan_count' and use the comedi_async
'scans_done'
member to detect the analog input end-of-acquisition.
Use the comedi_nsamples_left() helper to work out the number of 'wake' samples
in
pci230_ai_update_fifo_trigger_level() and the number of 'todo' samples
Remove the private data member 'ao_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
read from the async buffer.
Signed-off-by: H Hartley Sweeten
Remove the private data member 'ai_sample_count' and use the comedi_async
'scans_done' member to detect the analog input end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten
Am Dienstag, den 04.11.2014, 16:19 + schrieb Emil Velikov:
Hi Philipp,
Just a flyby question
On 04/11/14 10:52, Philipp Zabel wrote:
The imx-drm driver was put into staging mostly for the following reasons,
all of which have been addressed or superseded:
- convert the irq driver
2014-11-03 19:15 GMT+04:00 Hans Verkuil hverk...@xs4all.nl:
Hi Andrey,
On 10/29/2014 05:03 PM, Andrey Utkin wrote:
The used approach actually cannot prevent new encoder interrupt to
appear, because interrupt handler can execute in different thread, and
in current implementation there is
Introduce a helper function to select a timer and read a value from it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 45
For aesthetics, rename this register offset.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 9 -
Following is the big cleanup series for the ADDI-DATA APCI-3120 driver.
Quick summary of the cleanup:
* Removes all the CamelCase
* Cleans up the register map defines
* Fixes the Analog Input subdevice
* Fixes the async command support for the Analog Input subdevice
* Cleans up all the
The wrong define is being used to disable the gate to stop timer 2 in this
function.
Use the apci3120_timer_enable() helper to properly disable the timer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Rename this CamelCase member of the private data.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 50 --
Move this helper function from the included source file into the main driver
source file.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c
Merge these two functions and use an 'enable' parameter to determine if the
external trigger needs to be enabled or disabled.
This function always succeeds and the callers don't check the return. Change
the return type to void.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc:
For aesthetics, remove this define and just use ~APCI3120_ENABLE_EOC_INT.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 5 ++---
1
Move the common code used to initialize DMA to apci3120_init_dma().
This follows the programming procedure described in the APCI-3120
documentation.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Rename this CamelCase member of the private data and convert it to
a bit-field.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 4 ++--
For aesthetics, remove this define and just use ~APCI3120_ENABLE_TIMER_COUNTER.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 5 ++---
This member of the private data is no longer used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi_apci_3120.c | 1 -
1 file changed, 1 deletion(-)
This function does not follow the comedi API for (*insn_config) functions.
It's also no long needed. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Rename this CamelCase member of the private data and tidy up the mask/set
of its bits.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 70
Define a macro that returns the mask of the timer_mode bits for a given
timer. Use the macro to remove the magic values used to clear the bits.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This define is not used in the driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 1 -
1 file changed, 1 deletion(-)
1 - 100 of 206 matches
Mail list logo
