Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-07 Thread Michael Wang
On 12/07/2011 05:04 PM, Jeff Kirsher wrote: On Tue, 2011-12-06 at 22:36 -0800, Michael Wang wrote: On 12/07/2011 02:19 PM, Joe Perches wrote: On Wed, 2011-12-07 at 14:08 +0800, Michael Wang wrote: I'm not good at script, if you are interested, we can work together to fix all the remain

Re: [E1000-devel] [PATCH] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 04:10 AM, Jesse Brandeburg wrote: On Mon, 5 Dec 2011 17:04:09 -0800 Michael Wang wang...@linux.vnet.ibm.com wrote: Actually, I make this change because of my last patch: e1000e: Avoid wrong check on TX hang And I get the suggestion from David, the mail like below. He want me

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 12:14 PM, Joe Perches wrote: On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote: On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote: From: Michael Wang wang...@linux.vnet.ibm.com Use true and false instead of 1 and 0 when assign value to a bool type variable. Thanks

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 02:01 PM, Joe Perches wrote: On Wed, 2011-12-07 at 12:49 +0800, Michael Wang wrote: On 12/07/2011 12:14 PM, Joe Perches wrote: On Tue, 2011-12-06 at 19:43 -0800, Jeff Kirsher wrote: On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote: From: Michael Wang wang

Re: [E1000-devel] [PATCH v2] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-06 Thread Michael Wang
On 12/07/2011 02:19 PM, Joe Perches wrote: On Wed, 2011-12-07 at 14:08 +0800, Michael Wang wrote: I'm not good at script, if you are interested, we can work together to fix all the remain cases, and send out some patches. You should try coccinelle and spatch. Hi, Joe I have not used

Re: [E1000-devel] [PATCH] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-05 Thread Michael Wang
On 12/06/2011 01:28 AM, Jesse Brandeburg wrote: On Sun, 4 Dec 2011 20:04:52 -0800 Michael Wang wang...@linux.vnet.ibm.com wrote: From: Michael Wang wang...@linux.vnet.ibm.com Use true and false instead of 1 and 0 when assign value to a bool type variable. Signed-off-by: Michael Wang

[E1000-devel] [PATCH v2] e1000e: Avoid wrong check on TX hang

2011-12-05 Thread Michael Wang
From: Michael Wang wang...@linux.vnet.ibm.com Descriptors may not be write-back while checking TX hang with flag FLAG2_DMA_BURST on. So when we detect hang, we just flush the descriptor and detect again for once. v2: Change 0, 1 to false and true, remove excessive parenthesis. Signed-off

Re: [E1000-devel] [PATCH v2] e1000e: Avoid wrong check on TX hang

2011-12-05 Thread Michael Wang
the edition by my self, I am sorry and must apologize to you for you time. Please check the patch and help the submit. Thanks Best regards Michael Wang On 12/06/2011 10:39 AM, Michael Wang wrote: From: Michael Wang wang...@linux.vnet.ibm.com Descriptors may not be write-back while checking TX

[E1000-devel] [PATCH] e1000e: Assign true and false to bool type variable instead of 1 and 0

2011-12-04 Thread Michael Wang
From: Michael Wang wang...@linux.vnet.ibm.com Use true and false instead of 1 and 0 when assign value to a bool type variable. Signed-off-by: Michael Wang wang...@linux.vnet.ibm.com --- drivers/net/ethernet/intel/e1000e/netdev.c | 34 ++-- 1 files changed, 17

[E1000-devel] [PATCH] e1000e : Avoid wrong check on TX hang

2011-11-17 Thread Michael Wang
From: Michael Wang wang...@linux.vnet.ibm.com Descriptors may not be write-back while checking TX hang with flag FLAG2_DMA_BURST on. So when we detect hang, we just flush the descriptor and detect again for once. Signed-off-by: Michael Wang wang...@linux.vnet.ibm.com --- drivers/net/e1000e

Re: [E1000-devel] [PATCH] e1000e : Avoid wrong check on TX hang

2011-11-17 Thread Michael Wang
not been write-back. So we need flush the descriptor and do recheck, not just stop the tx when detect hang. Flavio: Please sign-off the patch and provide the test information. Thanks Best regards, Michael Wang On 11/18/2011 09:37 AM, Michael Wang wrote: From: Michael Wang wang

[E1000-devel] Fwd: Re: May be a bug in scatterlist.c

2011-11-07 Thread Michael Wang
, Michael Wang Original Message Subject:Re: May be a bug in scatterlist.c Date: Mon, 07 Nov 2011 14:45:45 +0800 From: Michael Wang wang...@linux.vnet.ibm.com To: kernel-ment...@selenic.com On 11/07/2011 12:01 PM, Michael Wang wrote: Hi, Experts I found

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2011-10-26 Thread Michael Wang
Hi, Flavio, Jesse I have send out the patch, which I hope can do some help. Because this is my first time to send a patch, I am sorry if I have done some silly thing. And please tell me if there are some problem about it. Thanks Best regards, Michael Wang

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2011-10-25 Thread Michael Wang
Leitner wrote: On Wed, 19 Oct 2011 12:49:48 +0800 wangyunwang...@linux.vnet.ibm.comwrote: Hi, Flavio I am new to join the community, work on e1000e driver currently, And I found a thing strange in this issue, please check below. Thanks, Michael Wang On 10/18/2011 10:42 PM, Flavio

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2011-10-25 Thread Michael Wang
time yet to get a full repro going. I think besides my confusion, I will still try to do such work, but I really don't know whether this issue is caused by wthresh or not. Thanks Best regards Michael Wang -- The demand

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2011-10-24 Thread Michael Wang
the community, work on e1000e driver currently, And I found a thing strange in this issue, please check below. Thanks, Michael Wang On 10/18/2011 10:42 PM, Flavio Leitner wrote: On Mon, 17 Oct 2011 11:48:22 -0700 Jesse Brandeburgjesse.brandeb...@intel.comwrote: On Fri, 14 Oct 2011 10:04:26

Re: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2011-10-21 Thread Michael Wang
On 10/19/2011 08:16 PM, Flavio Leitner wrote: On Wed, 19 Oct 2011 12:49:48 +0800 wangyunwang...@linux.vnet.ibm.com wrote: Hi, Flavio I am new to join the community, work on e1000e driver currently, And I found a thing strange in this issue, please check below. Thanks, Michael Wang