Re: [Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-24 Thread Hans Unzner
Am 22.04.23 um 01:12 schrieb andy pugh: On Fri, 21 Apr 2023 at 13:56, Hans Unzner wrote: What exactly do you mean with "inited from the device" resp. how should that happen? If the flag is set, it would read the current state of the registers and set the HAL pin states accordingly. This

Re: [Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-21 Thread andy pugh
On Fri, 21 Apr 2023 at 13:56, Hans Unzner wrote: What exactly do you mean with "inited from the device" resp. how should > that happen? > If the flag is set, it would read the current state of the registers and set the HAL pin states accordingly. This does depend on there being a matching read

Re: [Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-21 Thread Hans Unzner
Am 21.04.23 um 12:16 schrieb Andy Pugh: On 21 Apr 2023, at 07:02, Hans Unzner wrote: Because, e.g., setting a bit in a holding register you need to read that register, set that bit and write the value back. I am wondering about including a flag that indicates that the HAL pins should

Re: [Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-21 Thread Andy Pugh
> On 21 Apr 2023, at 07:02, Hans Unzner wrote: > > Because, e.g., setting a bit in a holding register you need to read that > register, set that bit and write the value back. I am wondering about including a flag that indicates that the HAL pins should be inited from the device, but in

Re: [Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-21 Thread Hans Unzner
Yes, those bitmasks are a common "problem", I am not sure if that should be part of the generic Modbus driver. I think it should be on a higher level. So an application that uses your mesa modbus driver. Because, e.g., setting a bit in a holding register you need to read that register, set that

Re: [Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-20 Thread andy pugh
On Thu, 20 Apr 2023 at 20:05, Hans Unzner wrote: - The created HAL pins are inputs for some modbus commands and outputs > for some others. Maybe that could be mentioned. > I also need to add some more flexibility, as the VFD I am playing with expects a command 6 (register write) with 1 for

Re: [Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-20 Thread Hans Unzner
Hi Andy, this is really a great addition - I already often thought that a modbus driver for the mesa cards is somehow missing. Thanks for that! The docs are quite comprehensive, so no real need to add something. However, some annotations: - The created HAL pins are inputs for some modbus

[Emc-developers] New Modbus driver framework for Mesa UARTS

2023-04-18 Thread andy pugh
I have just pushed a feature branch (andypugh/mesa_modbus) to the LinuxCNC github. It uses the Mesa FPGA UARTs (specifically pktUART) to offer real-time modbus connection directly to a Mesa card. Docs are here: