Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-04-07 Thread Thomas Guilbert
In Chromium code, we set s->metadata ahead of time, with a custom entry to avoid id3v1 tag parsing. Some recent changes in mp3dec.c meant that we had to update this code, and in the process, we discovered this reference leak on our end. I am submitting this patch as a general code hardening

Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-04-07 Thread wm4
On Thu, 6 Apr 2017 14:07:53 -0700 Thomas Guilbert wrote: > The patch didn't show up as properly formatted on > https://patchwork.ffmpeg.org/patch/3228/. > > Re-submitting using no line wrap in the base64 attachment, and copying the > contents of the patch for ease of

Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-04-06 Thread Thomas Guilbert
The patch didn't show up as properly formatted on https://patchwork.ffmpeg.org/patch/3228/. Re-submitting using no line wrap in the base64 attachment, and copying the contents of the patch for ease of review: >From fced5ab0e09f529397adddcb560d1a08f2df4840 Mon Sep 17 00:00:00 2001 From: Thomas