Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: Fix parsing of ts_layering_mode parameter

2024-05-17 Thread James Zern via ffmpeg-devel
Hi, On Wed, May 15, 2024 at 11:11 PM Aaron Thompson via ffmpeg-devel wrote: > > The value was being parsed as base 4, so the value "4" was invalid and > would result in ts_layering_mode being set to 0. > > Signed-off-by: Aaron Thompson > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding

2024-04-18 Thread James Zern via ffmpeg-devel
On Thu, Apr 18, 2024 at 11:21 AM Thilo Borgmann via ffmpeg-devel wrote: > > Hi, > > On 17.04.24 00:52, James Zern via ffmpeg-devel wrote: > > On Wed, Apr 17, 2024 at 12:20 PM Thilo Borgmann via ffmpeg-devel > > wrote: > >> > >> From: Thilo Borgma

Re: [FFmpeg-devel] [PATCH v12 0/8] [WIP] webp: add support for animated WebP decoding

2024-04-17 Thread James Zern via ffmpeg-devel
On Wed, Apr 17, 2024 at 12:20 PM Thilo Borgmann via ffmpeg-devel wrote: > > From: Thilo Borgmann > > Marked WIP because we'd want to introduce private bsf's first; review > welcome before that though > VP8 decoder decoupled again > The whole animated sequence goes into one packet > The

Re: [FFmpeg-devel] [PATCH v11 4/8] libavcodec/webp: add support for animated WebP

2024-04-17 Thread James Zern via ffmpeg-devel
On Thu, Mar 28, 2024 at 7:10 AM Thilo Borgmann via ffmpeg-devel wrote: > > From: Josef Zlomek > > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP decoder adds the animation related features according to the specs: >

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled

2024-04-02 Thread James Zern via ffmpeg-devel
On Mon, Apr 1, 2024 at 11:29 AM Andreas Rheinhardt wrote: > > James Zern via ffmpeg-devel: > > On Sat, Mar 30, 2024 at 10:30 PM Andreas Rheinhardt > > wrote: > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/libvpxenc.

Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled

2024-04-01 Thread James Zern via ffmpeg-devel
On Sat, Mar 30, 2024 at 10:30 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxenc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 635cdf7a0e..bcbdc4981e 100644 >

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/libvpxenc: Remove obsolete av_unused

2024-03-27 Thread James Zern via ffmpeg-devel
On Tue, Mar 26, 2024 at 6:38 PM Andreas Rheinhardt wrote: > > Forgotten in 753074721bd414874d18c372c491bdc6323fa3bf. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm.

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/libvpxenc: Only search for side data when intending to use it

2024-03-27 Thread James Zern via ffmpeg-devel
On Tue, Mar 26, 2024 at 6:36 PM Andreas Rheinhardt wrote: > > Also rewrite the code so that a variable that is only used > depending upon CONFIG_LIBVPX_VP9_ENCODER is not declared > outside of the #if block. > (The variable was declared with av_uninit, but it should have been > av_unused, as the

Re: [FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option

2024-02-15 Thread James Zern via ffmpeg-devel
On Tue, Feb 13, 2024 at 7:26 PM James Zern wrote: > > On Mon, Feb 12, 2024 at 10:34 PM Dariusz Marcinkiewicz via > ffmpeg-devel wrote: > > > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > > > Co-authored-by: Erik Språng > &g

Re: [FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option

2024-02-13 Thread James Zern via ffmpeg-devel
On Mon, Feb 12, 2024 at 10:34 PM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > Co-authored-by: Erik Språng > Signed-off-by: Dariusz Marcinkiewicz > --- > doc/encoders.texi | 6 ++ > libavcodec/libvpxenc.c | 13

Re: [FFmpeg-devel] [PATCH v4] lavc/libvpxenc: add screen-content-mode option

2024-02-12 Thread James Zern via ffmpeg-devel
On Sat, Feb 10, 2024 at 12:22 AM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > Co-authored-by: Erik Språng > Signed-off-by: Dariusz Marcinkiewicz > --- > doc/encoders.texi | 3 +++ > libavcodec/libvpxenc.c | 11

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-09 Thread James Zern via ffmpeg-devel
On Thu, Feb 8, 2024 at 1:58 PM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx and makes > us retry encode if screen_content_mode == 2 and no output was produced > by encoder. > > Co-authored-by: Erik Språng > Signed-off-by: Dariusz

Re: [FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-02-07 Thread James Zern via ffmpeg-devel
Hi, On Wed, Feb 7, 2024 at 8:04 AM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > For the subject use '(libavcodec|avcodec|lavc)/libvpxenc: ...' to better document what is being changed. See the history of the file for examples.

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: Remove redundant unreferencing of AVFrame

2023-09-18 Thread James Zern via ffmpeg-devel
On Mon, Sep 18, 2023 at 5:40 AM Andreas Rheinhardt wrote: > > The AVFrame of a decoder with the ordinary decode callback > is generically unreferenced on error. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxdec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >

Re: [FFmpeg-devel] [PATCH v4 0/7] webp: add support for animated WebP decoding

2023-07-27 Thread James Zern
On Thu, Jul 27, 2023 at 4:29 AM Thilo Borgmann wrote: > > Am 25.07.23 um 22:14 schrieb James Zern: > > On Tue, Jul 25, 2023 at 1:58 AM Thilo Borgmann > > wrote: > >> > >> Still images fixed from v2. Now includes a fate test for animated webp. > >

Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-27 Thread James Zern
On Wed, Jul 26, 2023 at 2:36 PM Tomas Härdin wrote: > > tis 2023-07-25 klockan 16:18 +0200 skrev Thilo Borgmann: > > Am 25.07.23 um 14:24 schrieb Tomas Härdin: > > > > +// Extremely simplified key frame detection: > > > > +// - the first frame (containing headers) is marked as a key > > >

Re: [FFmpeg-devel] [PATCH v4 0/7] webp: add support for animated WebP decoding

2023-07-25 Thread James Zern
On Tue, Jul 25, 2023 at 1:58 AM Thilo Borgmann wrote: > > Still images fixed from v2. Now includes a fate test for animated webp. > > Patch 5/7 is still there for making changes in lavc/webp reviewable but > shall be stashed when pushing. > > -Thilo > > > Josef Zlomek (2): > libavcodec/webp:

Re: [FFmpeg-devel] [PATCH v4 3/7] avcodec/webp_parser: parse each frame into one packet

2023-07-25 Thread James Zern
On Tue, Jul 25, 2023 at 7:18 AM Thilo Borgmann wrote: > > Am 25.07.23 um 14:24 schrieb Tomas Härdin: > >> +// Extremely simplified key frame detection: > >> +// - the first frame (containing headers) is marked as a key > >> frame > >> +// - other frames are marked as non-key frames >

Re: [FFmpeg-devel] [PATCH v3 0/6] webp: add support for animated WebP decoding

2023-07-24 Thread James Zern
On Thu, Jul 20, 2023 at 4:08 PM Thilo Borgmann wrote: > > All issues of v2 fixed. Makes tsan happy now as well. > > Patch 5/6 is still there for making changes in lavc/webp reviewable but > shall be stashed when pushing. > This looks to fail fate: https://patchwork.ffmpeg.org/check/83180/ It

Re: [FFmpeg-devel] Build failure un Debian Testing

2023-07-14 Thread James Zern
On Fri, Jul 14, 2023 at 10:47 AM James Almer wrote: > > On 7/14/2023 1:49 PM, James Zern wrote: > > On Fri, Jul 14, 2023 at 5:37 AM James Almer wrote: > >> > >> On 7/14/2023 7:12 AM, Nicolas George wrote: > >>> James Almer (12023-07-13): &

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-14 Thread James Zern
On Thu, Jul 13, 2023 at 12:38 PM James Zern wrote: > > On Fri, Jul 7, 2023 at 2:31 PM David Lemler wrote: > > > > Prevent the fifo used in encoding VPx videos from filling up and > > stopping encode when it reaches 21845 items, which happens when the > > video has m

Re: [FFmpeg-devel] Build failure un Debian Testing

2023-07-14 Thread James Zern
On Fri, Jul 14, 2023 at 5:37 AM James Almer wrote: > > On 7/14/2023 7:12 AM, Nicolas George wrote: > > James Almer (12023-07-13): > >> Curious that they pull git snapshots of this package for Debian testing. > >> For > >> others they seem to stick to tagged releases. > > > > I do not understand

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-13 Thread James Zern
On Fri, Jul 7, 2023 at 2:31 PM David Lemler wrote: > > Prevent the fifo used in encoding VPx videos from filling up and > stopping encode when it reaches 21845 items, which happens when the > video has more than that number of frames. > > Incorporated suggestion from James Zern

Re: [FFmpeg-devel] [PATCH v2 5/5] libavformat/webp: add WebP demuxer

2023-07-11 Thread James Zern
On Thu, Jul 6, 2023 at 4:28 AM Thilo Borgmann wrote: > > From: Josef Zlomek > > Adds the demuxer of animated WebP files. > It supports non-animated, animated, truncated, and concatenated files. > Reading from a pipe (and other non-seekable inputs) is also supported. > > The WebP demuxer splits

Re: [FFmpeg-devel] [PATCH v2 4/5] avcodec/webp: make init_canvas_frame static

2023-07-11 Thread James Zern
On Thu, Jul 6, 2023 at 4:28 AM Thilo Borgmann wrote: > > --- > libavcodec/webp.c | 143 +++--- > 1 file changed, 71 insertions(+), 72 deletions(-) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 3/5] libavcodec/webp: add support for animated WebP decoding

2023-07-11 Thread James Zern
On Thu, Jul 6, 2023 at 4:28 AM Thilo Borgmann wrote: > > From: Josef Zlomek > > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP decoder adds the animation related features according to the specs: > https://developers.google.com/speed/webp/docs/riff_container#animation >

Re: [FFmpeg-devel] [PATCH v2 2/5] avcodec/webp_parser: parse each frame into one packet

2023-07-11 Thread James Zern
On Thu, Jul 6, 2023 at 4:28 AM Thilo Borgmann wrote: > > --- > libavcodec/webp_parser.c | 132 ++- > 1 file changed, 90 insertions(+), 42 deletions(-) > > [...] > +} else { > +/* read the next tag */ > +

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/webp: move definitions into header

2023-07-11 Thread James Zern
On Thu, Jul 6, 2023 at 4:27 AM Thilo Borgmann wrote: > > --- > libavcodec/webp.c | 17 +-- > libavcodec/webp.h | 55 +++ > 2 files changed, 56 insertions(+), 16 deletions(-) > create mode 100644 libavcodec/webp.h > > [...] > +#define

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-07 Thread James Zern
On Wed, Jul 5, 2023 at 7:22 PM David Lemler wrote: > > > On 07/05/2023 2:16 PM CDT James Zern wrote: > > > > > > On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > > > > > Hi, > > > > > > > +ffmpeg-dev. I took the wrong em

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-07 Thread James Zern
On Thu, Jul 6, 2023 at 12:45 AM Anton Khirnov wrote: > > Quoting James Zern (2023-07-05 21:16:37) > > On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > > > > > Hi, > > > > > > > +ffmpeg-dev. I took the wrong email off the reply. > >

Re: [FFmpeg-devel] [PATCH v2 5/5] libavformat/webp: add WebP demuxer

2023-07-06 Thread James Zern
On Thu, Jul 6, 2023 at 4:28 AM Thilo Borgmann wrote: > > From: Josef Zlomek > > Adds the demuxer of animated WebP files. > It supports non-animated, animated, truncated, and concatenated files. > Reading from a pipe (and other non-seekable inputs) is also supported. > > The WebP demuxer splits

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-05 Thread James Zern
On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > Hi, > +ffmpeg-dev. I took the wrong email off the reply. > On Mon, Jul 3, 2023 at 10:08 PM David Lemler wrote: > > > > Prevent the fifo used in encoding VPx videos from filling up and stopping > > encode when

Re: [FFmpeg-devel] [PATCH v1 2/2] lavc/libvpxenc: support creating full range output

2023-06-17 Thread James Zern
On Sat, Jun 17, 2023 at 1:11 AM Thilo Borgmann wrote: > > suggested-by: ffm...@meta.com > --- > libavcodec/libvpxenc.c | 12 > 1 file changed, 12 insertions(+) > Looks like there's some discussion on the parent patch about the correctness of adding this. This wrapper does set the

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/webp: make init_canvas_frame static

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:21 AM Thilo Borgmann wrote: > > --- > libavcodec/webp.c | 143 +++--- > 1 file changed, 71 insertions(+), 72 deletions(-) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v1 3/4] libavcodec/webp: add support for animated WebP decoding

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:21 AM Thilo Borgmann wrote: > > From: Josef Zlomek > > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP decoder adds the animation related features according to the specs: > https://developers.google.com/speed/webp/docs/riff_container#animation >

Re: [FFmpeg-devel] [PATCH v1 0/4] webp: add support for animated WebP decoding

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:20 AM Thilo Borgmann wrote: > > Follow-up to [1], the decoder only. > > In [1] we found a hanging sample. In frame-threading, this led to an > infinite wait, damaged frames otherwise. So warn acordingly and do > best-effort in single-thread mode. > > Also split into more

Re: [FFmpeg-devel] [PATCH v1 1/4] avcodec/webp: move definitions into header

2023-06-13 Thread James Zern
On Thu, Jun 8, 2023 at 7:20 AM Thilo Borgmann wrote: > > --- > libavcodec/webp.c | 17 +-- > libavcodec/webp.h | 55 +++ > 2 files changed, 56 insertions(+), 16 deletions(-) > create mode 100644 libavcodec/webp.h > lgtm.

Re: [FFmpeg-devel] [PATCH v2 5/5] aarch64: Add Windows runtime detection of the dotprod instructions

2023-06-05 Thread James Zern
On Tue, May 30, 2023 at 5:31 AM Martin Storsjö wrote: > > For Windows, there's no publicly defined constant for checking for > the i8mm extension yet. > --- > libavutil/aarch64/cpu.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavutil/aarch64/cpu.c

Re: [FFmpeg-devel] [PATCH v2 11/13] lavc/libvpxenc: send frame durations to the encoder

2023-05-09 Thread James Zern
On Tue, May 9, 2023 at 2:10 AM Anton Khirnov wrote: > > Adapt similar code from libaomenc - stop using ticks_per_frame except as > a last resort. > --- > libavcodec/libvpxenc.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > lgtm. > diff --git

Re: [FFmpeg-devel] Add support for animated WebP

2023-05-08 Thread James Zern
On Fri, May 5, 2023 at 10:47 AM Thilo Borgmann wrote: > > Am 27.04.23 um 20:08 schrieb Thilo Borgmann: > > Hi, > > > > support for animated WebP had been proposed twice in the past [1][2]. > > This did stall when Lynne called for some review on the demuxer in [1]. > > > > So these are the rebased

Re: [FFmpeg-devel] [PATCH 11/13] lavc/libvpxenc: send frame durations to the encoder

2023-05-08 Thread James Zern
On Sun, May 7, 2023 at 6:34 AM Anton Khirnov wrote: > > Adapt similar code from libaomenc - stop using ticks_per_frame except as > a last resort. > --- > libavcodec/libvpxenc.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/libvpxdec: Constify VP9-decoder

2023-03-13 Thread James Zern
On Sun, Mar 12, 2023 at 11:18 AM Andreas Rheinhardt wrote: > > Possible since 8d226fb9786f34760e80e0d6b403bd63e9ac4ddd. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/allcodecs.c | 2 +- > libavcodec/libvpxdec.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > lgtm.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

2023-03-02 Thread James Zern
On Tue, Feb 28, 2023 at 1:20 PM James Zern wrote: > > On Tue, Feb 28, 2023 at 12:49 PM James Almer wrote: > > > > On 2/28/2023 5:40 PM, James Zern wrote: > > > On Tue, Feb 28, 2023 at 4:07 AM James Almer wrote: > > >> > > >> It's u

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 12:49 PM James Almer wrote: > > On 2/28/2023 5:40 PM, James Zern wrote: > > On Tue, Feb 28, 2023 at 4:07 AM James Almer wrote: > >> > >> It's used only by the encoder. > >> > > > > It sets AVCodec.pix_fmts, but may

Re: [FFmpeg-devel] [PATCH 8/8] lavc/libvpxenc: drop FrameListData.duration

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > It is write-only. > --- > libavcodec/libvpxenc.c | 3 --- > 1 file changed, 3 deletions(-) > libaomenc.c transfers this to AVPacket. You added this in: 7cf161abe5 lavc/libaomenc: pass through frame durations to encoded packets Should

Re: [FFmpeg-devel] [PATCH 6/8] lavc/libvpxenc: drop a useless condition

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > A non-NULL packet is always passed to frame_data_apply(). > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index

Re: [FFmpeg-devel] [PATCH 5/8] lavc/libvpxenc: handle frame durations and AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:01 AM Anton Khirnov wrote: > > --- > libavcodec/libvpxenc.c | 139 + > libavcodec/version.h | 2 +- > 2 files changed, 100 insertions(+), 41 deletions(-) > lgtm > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH 4/8] lavc/libvpxenc: rename hdr10_plus_fifo and related objects

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > This AVFifo is used to propagate HDR metadata from input frames to > output packets, since libvpx does not allow passing through arbitrary > user data. > > It will be extended to pass through other kinds of data in future > commits, so give

Re: [FFmpeg-devel] [PATCH 3/8] lavc/libvpxenc: reindent

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:01 AM Anton Khirnov wrote: > > --- > libavcodec/libvpxenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > lgtm. > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index eaa4ad8f25..abaa8c3513 100644 > --- a/libavcodec/libvpxenc.c >

Re: [FFmpeg-devel] [PATCH 2/8] lavc/libvpxenc: drop frame_number

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:02 AM Anton Khirnov wrote: > > It is not used, except to check whether the packet is valid before > writing HDR metadata to the packet in storeframe(). However, that check > serves no purpose, as the encoded packet is already treated as valid > higher up in this

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxdec: remove unnecessary init_static_data function

2023-02-28 Thread James Zern
On Tue, Feb 28, 2023 at 4:07 AM James Almer wrote: > > It's used only by the encoder. > It sets AVCodec.pix_fmts, but maybe the values reported aren't used meaningfully. > Signed-off-by: James Almer > --- > libavcodec/libvpxdec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-17 Thread James Zern
On Tue, Jan 10, 2023 at 5:23 PM James Zern wrote: > > On Tue, Jan 10, 2023 at 2:47 AM myp...@gmail.com wrote: > > > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > > wrote: > > [...] > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxe

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-10 Thread James Zern
On Tue, Jan 10, 2023 at 2:47 AM myp...@gmail.com wrote: > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > wrote: > [...] > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index 9aa5510c28..0627e13973 100644 > > --- a/libavcodec/libvpxenc.c > > +++

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-09 Thread James Zern
On Thu, Jan 5, 2023 at 2:42 AM Dmitrii Ovchinnikov wrote: > > From: Dmitrii Ovchinnikov > > This change improves the performance and multicore > scalability of the vp9 codec for streaming single-pass encoded videos. The > current thread limit for ffmpeg codecs is 16 (MAX_AUTO_THREADS in >

Re: [FFmpeg-devel] [PATCH v2 05/31] avcodec/libvpxenc: use av_dict_iterate

2022-11-30 Thread James Zern
On Sat, Nov 26, 2022 at 6:47 AM Marvin Scholz wrote: > > --- > libavcodec/libvpxenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm. > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 667cffc200..9aa5510c28 100644 > --- a/libavcodec/libvpxenc.c > +++

Re: [FFmpeg-devel] [PATCH V2] lavc/libvpx: increase thread limit to 64

2022-11-21 Thread James Zern
On Tue, Oct 25, 2022 at 8:56 AM Dmitrii Ovchinnikov wrote: > > >> Why do you still impose an upper limit unconditionally even if the > >>user has set his preferred number of threads? > Libvpx-vp9 does not support number of threads greater than 64, so we impose > an upper limit of 64. > E.g. if we

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-31 Thread James Zern
On Tue, Oct 25, 2022 at 10:02 PM James Zern wrote: > > On Tue, Oct 25, 2022 at 11:28 AM James Zern wrote: > > > > Signed-off-by: James Zern > > --- > > libavcodec/libaomdec.c | 8 ++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > &g

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-25 Thread James Zern
On Tue, Oct 25, 2022 at 11:28 AM James Zern wrote: > > Signed-off-by: James Zern > --- > libavcodec/libaomdec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > I was reminded that there was an earlier patch [1], which I had an open comment on. I

[FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-25 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libaomdec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 378d638a89..53982559d9 100644 --- a/libavcodec/libaomdec.c +++ b/libavcodec/libaomdec.c @@ -113,15 +113,19

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-22 Thread James Zern
On Wed, Sep 21, 2022 at 12:14 PM James Zern wrote: > > On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian > wrote: > > > > According to the HEIF specification (ISO/IEC 23008-12) Section > > 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi'

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-21 Thread James Zern
On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian wrote: > > According to the HEIF specification (ISO/IEC 23008-12) Section > 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box > in its SampleEntry to notify the nature of the auxiliary track to the > decoder. > > The

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-20 Thread James Zern
On Mon, Sep 19, 2022 at 4:03 PM Vignesh Venkatasubramanian wrote: > > According to the HEIF specification Section 7.5.3.1, tracks with It might be worth adding ISO/IEC 23008-12 for added precision. > handler_type 'auxv' must contain a 'auxi' box in its > SampleEntry to notify the nature of the

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add -min-gf-interval

2022-09-13 Thread James Zern
this maps to the vpxenc argument with the same name and the VP9E_SET_MIN_GF_INTERVAL codec control Signed-off-by: James Zern --- doc/encoders.texi | 2 ++ libavcodec/libvpxenc.c | 11 +++ libavcodec/version.h | 2 +- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: fix compile after 5bab794

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 12:30 PM James Zern wrote: > > encoder is a struct, not a pointer; use '.' to access iface. > > Signed-off-by: James Zern > --- > libavcodec/libaomenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Already fixed. > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 12:28 PM James Almer wrote: > > On 8/25/2022 4:21 PM, James Zern wrote: > > On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote: > >> > >> On 8/25/2022 2:34 PM, James Zern wrote: > >>> On Thu, Aug 25, 2022 at 10:16 AM James Almer

[FFmpeg-devel] [PATCH] avcodec/libaomenc: fix compile after 5bab794

2022-08-25 Thread James Zern
encoder is a struct, not a pointer; use '.' to access iface. Signed-off-by: James Zern --- libavcodec/libaomenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index a82b933c18..1e89b7e3a8 100644 --- a/libavcodec/libaomenc.c

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote: > > On 8/25/2022 2:34 PM, James Zern wrote: > > On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: > >> > >> Signed-off-by: James Almer > >> --- > >> There doesn't seem to be any proper API t

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag

2022-08-25 Thread James Zern
On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: > > Signed-off-by: James Almer > --- > There doesn't seem to be any proper API to check if an encoder is open. > true. > libavcodec/libaomenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > lgtm. > diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libaomenc: use av_fast_realloc() to resize the stats buffer

2022-08-24 Thread James Zern
On Tue, Aug 23, 2022 at 4:34 PM James Almer wrote: > > Signed-off-by: James Almer > --- > libavcodec/libaomenc.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libvpxenc: use av_fast_realloc() to resize the stats buffer

2022-08-24 Thread James Zern
On Tue, Aug 23, 2022 at 4:34 PM James Almer wrote: > > Signed-off-by: James Almer > --- > libavcodec/libvpxenc.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-08-09 Thread James Zern
On Tue, Aug 2, 2022 at 9:54 AM James Zern wrote: > > Andreas, > > On Thu, Jul 28, 2022 at 11:25 AM Vignesh Venkatasubramanian > wrote: > > > > Stores the item ids of all the items found in the file and > > processes the primary item at the end of the meta box. T

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-08-02 Thread James Zern
Andreas, On Thu, Jul 28, 2022 at 11:25 AM Vignesh Venkatasubramanian wrote: > > Stores the item ids of all the items found in the file and > processes the primary item at the end of the meta box. This patch > does not change any behavior. It sets up the code for parsing > alpha channel (and

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-27 Thread James Zern
On Wed, Jul 27, 2022 at 9:12 AM Vignesh Venkatasubramanian wrote: > > Stores the item ids of all the items found in the file and > processes the primary item at the end of the meta box. This patch > does not change any behavior. It sets up the code for parsing > alpha channel (and possibly images

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-26 Thread James Zern
On Fri, Jul 22, 2022 at 11:21 AM Vignesh Venkatasubramanian wrote: > > On Wed, Jul 13, 2022 at 9:12 AM Vignesh Venkatasubramanian > wrote: > > > > On Mon, Jul 11, 2022 at 3:25 PM James Zern > > wrote: > > > > > > On Thu, Jun 30, 2022 at 2:

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-11 Thread James Zern
On Thu, Jun 30, 2022 at 2:04 PM Vignesh Venkatasubramanian wrote: > > Stores the item ids of all the items found in the file and > processes the primary item at the end of the meta box. This patch > does not change any behavior. It sets up the code for parsing > alpha channel (and possibly images

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-29 Thread James Zern
On Tue, Jun 28, 2022 at 12:02 PM James Zern wrote: > > On Tue, Jun 28, 2022 at 11:56 AM Vignesh Venkatasubramanian > wrote: > > > > Update the still AVIF parser to only read the primary item. With this > > patch, AVIF still images with exif/icc/alpha channel will

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-28 Thread James Zern
On Tue, Jun 28, 2022 at 11:56 AM Vignesh Venkatasubramanian wrote: > > Update the still AVIF parser to only read the primary item. With this > patch, AVIF still images with exif/icc/alpha channel will no longer > fail to parse. > > For example, this patch enables parsing of files in: >

[FFmpeg-devel] [fate] add webp/dual_transform.webp

2022-06-28 Thread James Zern
Reviving this from samples-requ...@ffmpeg.org. The patch has been merged, all that is needed is to add the file and enable the test. The file can be downloaded from gitiles without needing to clone the repo [1]. This is to add coverage for a fix for 9368 [2][3]. [1] curl

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-28 Thread James Zern
0:51 pm, Vignesh Venkatasubramanian wrote: > > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > > > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > > > >> wrote: > > > >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-27 Thread James Zern
On Mon, Jun 27, 2022 at 9:48 AM James Almer wrote: > > On 6/27/2022 1:43 PM, Vignesh Venkatasubramanian wrote: > > On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian > > wrote: > >> > >> On Mon, Jun 13, 2022 at 10:17 AM James Zern > >> wrote

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Get number of operating points

2022-06-23 Thread James Zern
On Thu, Jun 16, 2022 at 10:36 AM James Zern wrote: > > On Thu, Jun 16, 2022 at 9:24 AM Wan-Teh Chang wrote: > > > > Use the new codec control AV1E_GET_NUM_OPERATING_POINTS to get the > > number of operating points. This is the size of the output arrays of &g

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Get number of operating points

2022-06-16 Thread James Zern
On Thu, Jun 16, 2022 at 9:24 AM Wan-Teh Chang wrote: > > Use the new codec control AV1E_GET_NUM_OPERATING_POINTS to get the > number of operating points. This is the size of the output arrays of > AV1E_GET_SEQ_LEVEL_IDX and AV1E_GET_TARGET_SEQ_LEVEL_IDX. > > Signed-off-by: Wan-Teh Chang > --- >

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-13 Thread James Zern
On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian wrote: > > AVIF specification allows for alpha channel as an auxiliary item (in > case of still images) or as an auxiliary track (in case of animated > images). Add support for both of these. The AVIF muxer will take > exactly two

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-02 Thread James Zern
On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian wrote: > > On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > > > > On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > > wrote: > > > > > > Update the still AVIF parser to only re

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-01 Thread James Zern
On Wed, May 18, 2022 at 2:56 PM Vignesh Venkatasubramanian wrote: > > AVIF specification allows for alpha channel as an auxillary item (in auxiliary > case of still images) or as an auxillary track (in case of animated > images). Add support for both of these. The AVIF muxer will take >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-01 Thread James Zern
On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian wrote: > > Update the still AVIF parser to only read the primary item. With this > patch, AVIF still images with exif/icc/alpha channel will no longer > fail to parse. > > For example, this patch enables parsing of files in: >

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-05-27 Thread James Zern
On Tue, May 17, 2022 at 12:45 PM James Zern wrote: > > On Tue, Apr 19, 2022 at 11:20 AM Bohan Li > wrote: > > > > When target levels are set, this patch checks whether they are > > satisfied by libaom. If not, a warning is shown. Otherwise the output

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-05-24 Thread James Zern
On Tue, May 17, 2022 at 12:45 PM James Zern wrote: > > On Tue, Apr 19, 2022 at 11:20 AM Bohan Li > wrote: > > > > When target levels are set, this patch checks whether they are > > satisfied by libaom. If not, a warning is shown. Otherwise the output

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

2022-05-17 Thread James Zern
On Tue, Apr 19, 2022 at 11:20 AM Bohan Li wrote: > > When target levels are set, this patch checks whether they are > satisfied by libaom. If not, a warning is shown. Otherwise the output > levels are also logged. > > This patch applies basically the same approach used for libvpx. > >

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-17 Thread James Zern
On Tue, May 17, 2022 at 11:24 AM Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > images. Expose that in the ffmpeg's wrapper. This is especially > useful for encoding still AVIF images. > > Signed-off-by: Vignesh Venkatasubramanian > --- >

Re: [FFmpeg-devel] [PATCH] avformat/img2: Add support for AVIF mux in image2

2022-05-17 Thread James Zern
On Mon, May 16, 2022 at 10:40 AM Vignesh Venkatasubramanian wrote: > > Add support for AVIF muxing in the image2 muxer. > > Tested with this example: > ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags global_header -c:v > libaom-av1 -f image2 img-%2d.avif > > Signed-off-by: Vignesh

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-03 Thread James Zern
On Mon, May 2, 2022 at 2:35 PM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specification: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-02 Thread James Zern
On Wed, Apr 13, 2022 at 1:40 PM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specification: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread James Zern
On Mon, Mar 28, 2022 at 1:49 PM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > Specification > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-04-05 Thread James Zern
On Thu, Mar 31, 2022 at 10:31 AM James Zern wrote: > > On Wed, Mar 30, 2022 at 11:25 AM Danil Chapovalov > wrote: > > > > --- > > doc/encoders.texi | 3 +++ > > libavcodec/libvpxenc.c | 6 ++ > > 2 files changed, 9 insertions(+) > > > &g

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: return quantizer parameter for an encoded frame

2022-04-05 Thread James Zern
On Tue, Apr 5, 2022 at 7:23 AM Danil Chapovalov wrote: > > I've rechecked documentation for the "vpx_codec_control" - can't find > any guarantee about the last parameter when the function fails, thus > prefer to be on the safe side. > The check is fine, though the function can only fail due to

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-31 Thread James Zern
On Wed, Mar 30, 2022 at 11:25 AM Danil Chapovalov wrote: > > --- > doc/encoders.texi | 3 +++ > libavcodec/libvpxenc.c | 6 ++ > 2 files changed, 9 insertions(+) > lgtm. I'll submit this with a patch version bump soon if there aren't any further comments.

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-29 Thread James Zern
On Mon, Mar 28, 2022 at 7:05 AM Danil Chapovalov wrote: > > On Thu, Mar 24, 2022 at 7:27 PM James Zern wrote: > > > > On Thu, Mar 24, 2022 at 6:12 AM Danil Chapovalov > > wrote: > > > > > > --- > > > libavcodec/libvpxenc.c | 6 ++ >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-24 Thread James Zern
On Thu, Mar 24, 2022 at 6:12 AM Danil Chapovalov wrote: > > --- > libavcodec/libvpxenc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index dff1d06b0e..463a658bb0 100644 > --- a/libavcodec/libvpxenc.c > +++

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration

2022-03-16 Thread James Zern
Lynne, On Wed, Mar 16, 2022 at 5:39 AM Lynne wrote: > > 16 Mar 2022, 13:07 by danilchap-at-google@ffmpeg.org: > > > --- > > libavcodec/libvpxenc.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index

  1   2   3   4   5   >