>Adapting changes to exotic builds are up to their maintainers.
>Isn't all this too obvious?..
This primary issue, Dimitry, is that you are making changes without any
consultation, assuming that your vision of a problem/solution is the right one
for everyone else.
You need to post
21.02.2016 9:01, Dmitry Yemanov wrote:
> There's a difference between cosmetic changes that hurt nobody and
> changes that may affect other developers. You've committed something
> comfortable for you without asking whether it's suitable for the rest of
> the team.
At first, these changes can
20.02.2016 19:39, Dimitry Sibiryakov wrote:
> Will you do it for Adriano's "Misc" as well?
There's a difference between cosmetic changes that hurt nobody and
changes that may affect other developers. You've committed something
comfortable for you without asking whether it's suitable for the
20.02.2016 18:56, Dimitry Sibiryakov wrote:
> 1) Changes made in autoconfig_msvc.h aren't visible to the rest of sources
> without manual
> copying of the file or running boot_build.bat.
How many times per day do you modify autoconfig.h? Why?
Running boot build may look annoying, but it's a
And how do you describe your changes in relation to cmake?
воскресенье, 21 февраля 2016 г. пользователь Dimitry Sibiryakov написал:
> 20.02.2016 22:58, Egor Pugin wrote:
> > In other words you replaced autogenerated file with hand-written one.
>
>No, I didn't.
>
> --
>WBR, SD.
>
>
>
20.02.2016 22:58, Egor Pugin wrote:
> In other words you replaced autogenerated file with hand-written one.
No, I didn't.
--
WBR, SD.
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM
In other words you replaced autogenerated file with hand-written one. What
is not so good.
воскресенье, 21 февраля 2016 г. пользователь Dimitry Sibiryakov написал:
> 20.02.2016 22:42, Egor Pugin wrote:
> > So, cmake+msvc is broken, isn't it?
>
>I guess it still work fine.
>
> --
>WBR,
20.02.2016 22:42, Egor Pugin wrote:
> So, cmake+msvc is broken, isn't it?
I guess it still work fine.
--
WBR, SD.
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM:
So, cmake+msvc is broken, isn't it?
воскресенье, 21 февраля 2016 г. пользователь Dimitry Sibiryakov написал:
> 20.02.2016 21:52, Egor Pugin wrote:
> > The original commit also breaks cmake build as it generates
> autoconfig.h and not
> > autoconfig_msvc.h.
>
>If you didn't notice that,
20.02.2016 21:52, Egor Pugin wrote:
> The original commit also breaks cmake build as it generates autoconfig.h and
> not
> autoconfig_msvc.h.
If you didn't notice that, build still use autoconfig.h with any compiler
except MS VC.
--
WBR, SD.
The original commit also breaks cmake build as it generates autoconfig.h
and not autoconfig_msvc.h.
суббота, 20 февраля 2016 г. пользователь Dimitry Sibiryakov написал:
> 20.02.2016 17:57, Adriano dos Santos Fernandes wrote:
> > Do you want me to say "put a space, remove a space, trim trailing
20.02.2016 17:57, Adriano dos Santos Fernandes wrote:
> Do you want me to say "put a space, remove a space, trim trailing spaces"?
No, I don't. For me that's perfectly ok, but it is Vlad who insisted on
commit comments
explaining what issues they address.
BTW, following commit was not
20.02.2016 18:39, Dimitry Sibiryakov wrote:
> 20.02.2016 17:36, Vlad Khorsun wrote:
>> Next time i will undo such "clear" changes not wasting time on
>> confirmation.
>
> Will you do it for Adriano's "Misc" as well?
It doesn't concern you.
Vlad
Em 20/02/2016 14:39, Dimitry Sibiryakov escreveu:
> 20.02.2016 17:36, Vlad Khorsun wrote:
>> Next time i will undo such "clear" changes not wasting time on
>> confirmation.
>
>Will you do it for Adriano's "Misc" as well?
>
Do you want me to say "put a space, remove a space, trim
20.02.2016 17:36, Vlad Khorsun wrote:
> Next time i will undo such "clear" changes not wasting time on
> confirmation.
Will you do it for Adriano's "Misc" as well?
--
WBR, SD.
--
Site24x7 APM Insight: Get
20.02.2016 18:25, Dimitry Sibiryakov wrote:
> 20.02.2016 17:22, Vlad Khorsun wrote:
>> Is it too hard to write useful comment when committing not waiting for
>> someone to ask you ?
>
> Everything is clear in code.
Next time i will undo such "clear" changes not wasting time on
20.02.2016 17:22, Vlad Khorsun wrote:
>Is it too hard to write useful comment when committing not waiting for
> someone to ask you ?
Everything is clear in code.
--
WBR, SD.
--
Site24x7 APM Insight: Get Deep
20.02.2016 17:56, Dimitry Sibiryakov wrote:
> 20.02.2016 16:49, Vlad Khorsun wrote:
>> What issue this commit going to solve ?
>
> 1) Changes made in autoconfig_msvc.h aren't visible to the rest of sources
> without manual
> copying of the file or running boot_build.bat.
> 2) Windows build
20.02.2016 16:49, Vlad Khorsun wrote:
> What issue this commit going to solve ?
1) Changes made in autoconfig_msvc.h aren't visible to the rest of sources
without manual
copying of the file or running boot_build.bat.
2) Windows build and posix build are fighting with each other overwriting
20.02.2016 17:34, aaf...@users.sourceforge.net wrote:
> Revision: 62991
>http://sourceforge.net/p/firebird/code/62991
> Author: aafemt
> Date: 2016-02-20 15:34:20 + (Sat, 20 Feb 2016)
> Log Message:
> ---
> Use autoconfig_msvc.h from where it is
What issue this
20 matches
Mail list logo
