Re: [Firebird-devel] ExprNode::FLAG_VALUE

2022-01-17 Thread Adriano dos Santos Fernandes
On 17/01/2022 12:19, Dmitry Yemanov wrote: > > Why is it done this way? AFAIU, impureCount is known during the compile > time, so the whole impure area could be preallocated during the prepare > stage. > There are others similar patterns, see irsb_message for example. The size is know at

Re: [Firebird-devel] ExprNode::FLAG_VALUE

2022-01-17 Thread Dmitry Yemanov
06.01.2022 17:13, Adriano dos Santos Fernandes wrote: See also: https://github.com/FirebirdSQL/firebird/issues/1355 https://github.com/FirebirdSQL/firebird/commit/626ab18c426fd32d482e02093e72e57330596174 Worth testing GROUP BY , ? Since v3 we must be safe. Aggregate stream allocates

Re: [Firebird-devel] ExprNode::FLAG_VALUE

2022-01-06 Thread Adriano dos Santos Fernandes
On 06/01/2022 09:53, Dmitry Yemanov wrote: > 06.01.2022 04:28, Adriano dos Santos Fernandes wrote: >> >> There is ExprNode::FLAG_VALUE ("Full value area required in impure >> space"), inherited from old (2.5) code base nod_value. >> >> It's set by sort subsystem and used only for parameters and

Re: [Firebird-devel] ExprNode::FLAG_VALUE

2022-01-06 Thread Dmitry Yemanov
06.01.2022 04:28, Adriano dos Santos Fernandes wrote: There is ExprNode::FLAG_VALUE ("Full value area required in impure space"), inherited from old (2.5) code base nod_value. It's set by sort subsystem and used only for parameters and variables. Initially it as also used for fields. But at

[Firebird-devel] ExprNode::FLAG_VALUE

2022-01-05 Thread Adriano dos Santos Fernandes
Hi! There is ExprNode::FLAG_VALUE ("Full value area required in impure space"), inherited from old (2.5) code base nod_value. It's set by sort subsystem and used only for parameters and variables. It makes then allocate impure space for impure_value_ex instead of traditional dsc. Most nodes