[Firebird-devel] code quality and strange comments

2015-07-15 Thread swobje...@outlook.com
Iam fairly new to the codebase but i found allready some strange stuff in some source files. Is some of this allready reviewed and/or allready fixed? firebird/trunk L1165 file: picstr.cpp Text: // Someone may have done something very stupid, like specify a repeat // count of

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Adriano dos Santos Fernandes
And? Any of these comments are not compiling? Adriano On 15/07/2015 09:17, swobje...@outlook.com wrote: Iam fairly new to the codebase but i found allready some strange stuff in some source files. Is some of this allready reviewed and/or allready fixed? firebird/trunk L1165 file:

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Ivan Arabadzhiev
https://s-media-cache-ak0.pinimg.com/736x/27/69/8a/27698a48b044a7f8d46ccb4e5974d38d.jpg :) 2015-07-15 17:19 GMT+03:00 Jiří Činčura j...@cincura.net: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread marius adrian popa
QLI i guess it will be removed in the future 4.x and for other parts of the code we accept pull requests :) On Wed, Jul 15, 2015 at 5:19 PM, Jiří Činčura j...@cincura.net wrote: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Jiří Činčura
Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) -- Mgr. Jiří Činčura Independent IT Specialist

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Claudio Valderrama C.
-Original Message- From: Adriano dos Santos Fernandes [mailto:adrian...@gmail.com] Sent: Miércoles, 15 de Julio de 2015 9:23 And? Any of these comments are not compiling? Adriano Adriano, I think you shouldn't waste your time with Internet trolls. Just ignore them. Some

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Dave Smith
Am 15.07.2015 um 16:38 schrieb marius adrian popa: QLI i guess it will be removed in the future 4.x and for other parts of the code we accept pull requests :) Ok. Is the entire devel now completely on git based? I grabbed the source from an svn repo at: svn co

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Dave Smith
Am 15.07.2015 um 16:19 schrieb Jiří Činčura: Any of these comments are not compiling? I think he's not worried about the comments themselves. But about what these are talking about. I'm pretty sure you understood it. ;) exactly ;d

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Dave Smith
Just for the sake of you mood, i changed it ;D Am 15.07.2015 um 16:44 schrieb Adriano dos Santos Fernandes: Historic comments should be removed if they are wrong. I don't have a good mood with people hiding their names in mailing lists, like 'swobjects'. You can call me Dave ;d

Re: [Firebird-devel] code quality and strange comments

2015-07-15 Thread Adriano dos Santos Fernandes
Historic comments should be removed if they are wrong. I don't have a good mood with people hiding their names in mailing lists, like 'swobjects'. Adriano On 15/07/2015 11:38, marius adrian popa wrote: QLI i guess it will be removed in the future 4.x and for other parts of the code we