Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread Yon Uriarte
Hi, osg::ref_ptrGeode SGNewCloud::genCloud() { ... +GeodeList* g = (*iter).second; + +if (iter == cloudMap.end() || g-size() num_flavours) ... dereferencing iterator::end is a no-no (it's not standard c++). suggest: GeodeList* g;// = (*iter).second; if (iter == cloudMap.end()

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread Yon Uriarte
Hi Stuart, a little patch for the update callback, this time in a readable and #ifdef'ed format. The update time goes down from 10ms to 1ms on this machine. Fog is still applied. Bonus: trivial patch for annoying unsigned warnings. greetings, yon clouds.patch Description: Binary data

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread James Turner
On 5 Dec 2008, at 14:23, Yon Uriarte wrote: a little patch for the update callback, this time in a readable and #ifdef'ed format. The update time goes down from 10ms to 1ms on this machine. Fog is still applied. I'd just like to say, this kind of work is appreciated, and much needed

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread Stuart Buchanan
Curt wrote: I did think of that after scratching my head a while ... the metar reported several cloud layers and I did try to switch to a new location as well as switching to fair weather and thunderstorm ... I did get snow and rain, but with a perfectly clear sky. I think there's a

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-05 Thread James Turner
On 5 Dec 2008, at 14:48, Stuart Buchanan wrote: BTW - I've found the source of a long-standing bug were changing the weather scenario when real-weather-fetch was enabled didn't work. Wooo! Fantastic! James --

Re: [Flightgear-devel] Yet Another Clouds Patch

2008-12-04 Thread Yon Uriarte
Hi again Stuart, this patch reduces draw time from 4.2ms to 3.0ms on my system. Middle of the ocean, ufo, feet, v=0. Seems the # of attributes is awfully expensive, at least on ATI/win32. The changes are #ifdef'ed for easy testing. greetings, yon clouds3d.packed.attributes.patch

[Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Stuart Buchanan
Hi All, Attached is yet another patch for 3D clouds. Could someone please apply it to CVS? This provides the following enhancements bug fixes - Fix the chequer-board bug. - Add proper cloud coverage function - so scattered clouds are now truly scattered. - Add real-time control for visibility

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Curtis Olson
On Thu, Dec 4, 2008 at 2:12 PM, Stuart Buchanan wrote: Hi All, Attached is yet another patch for 3D clouds. Could someone please apply it to CVS? This provides the following enhancements bug fixes - Fix the chequer-board bug. - Add proper cloud coverage function - so scattered clouds are

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Martin Spott
Curtis Olson wrote: I could easily be doing something wrong, or have inherited some configuration setting from a previous version, but before today's patch I had 3d clouds, and now I do not. This is with OSG 2.7.5. Is there anything I can quickly double check? The current weather !? ;-) I

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Curtis Olson
On Thu, Dec 4, 2008 at 4:49 PM, Martin Spott wrote: Curtis Olson wrote: I could easily be doing something wrong, or have inherited some configuration setting from a previous version, but before today's patch I had 3d clouds, and now I do not. This is with OSG 2.7.5. Is there anything

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread Heiko Schulz
Hi, I did think of that after scratching my head a while ... the metar reported several cloud layers and I did try to switch to a new location as well as switching to fair weather and thunderstorm ... I did get snow and rain, but with a perfectly clear sky. I can try to re-cvs update

Re: [Flightgear-devel] Yet another Clouds Patch (again)

2008-12-04 Thread gerard robin
On vendredi 05 décembre 2008, Heiko Schulz wrote: Hi, I did think of that after scratching my head a while ... the metar reported several cloud layers and I did try to switch to a new location as well as switching to fair weather and thunderstorm ... I did get snow and rain, but

Re: [Flightgear-devel] Yet Another Clouds Patch

2008-12-03 Thread Yon Uriarte
Hi Stuart, I like the 3dclouds, so i took a look at them. This is a patch for you and maybe some brave developer. It's really not usable. First, some notes. Please excuse the telegram-like prose, I can barely read them myself now - UFO #

[Flightgear-devel] Yet Another Clouds Patch

2008-11-30 Thread Stuart Buchanan
Hi All, Attached is another clouds patch. This does the following: 1) Puts the 3D clouds in a cloud rendering bin, to reduce the transparent edge problem. Viewing 3d clouds against a 2D layer _above_ it now blends correctly. There is still a problem when viewing a layer below the 3d clouds, and

Re: [Flightgear-devel] Yet Another Clouds Patch

2008-11-30 Thread Heiko Schulz
Hi, Hi All, Attached is another clouds patch. This does the following: 1) Puts the 3D clouds in a cloud rendering bin, to reduce the transparent edge problem. Viewing 3d clouds against a 2D layer _above_ it now blends correctly. There is still a problem when viewing a layer below the 3d

Re: [Flightgear-devel] Yet Another Clouds Patch

2008-11-30 Thread Frederic Bouvier
- Heiko Schulz a écrit : Sounds great! If someone comit this patch can he also comit (as long noone has something against) my last cloudset? Both are in CVS now. -Fred -- Frédéric Bouvier http://my.fotolia.com/frfoto/ Photo gallery - album photo http://fgsd.sourceforge.net/