Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 7:10 PM, Joe Mistachkin wrote: > > Scott Robison wrote: > > > > Okay, thanks for all the help. I've committed some new test cases that > > demonstrate errors in the trunk invalid_utf8. 16 tests fail on trunk, > > none fail on invalid_utf8_table

Re: [fossil-users] how to report bug in fossil

Scott Robison wrote: > > Okay, thanks for all the help. I've committed some new test cases that > demonstrate errors in the trunk invalid_utf8. 16 tests fail on trunk, > none fail on invalid_utf8_table branch (which of course doesn't mean > there aren't bugs, just that the sample data doesn't

Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 5:24 PM, Joe Mistachkin wrote: > > Scott Robison wrote: > > > > So my expectation that it would automatically update the utf.test file is > > incorrect? I'm supposed to manually integrate that file back to utf.test? > > > > Yes and yes. > > > > > If

Re: [fossil-users] how to report bug in fossil

Scott Robison wrote: > > So my expectation that it would automatically update the utf.test file is > incorrect? I'm supposed to manually integrate that file back to utf.test? > Yes and yes. > > If I want to specify a new test that should fail but does not currently, > am I just supposed to

Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 4:23 PM, Joe Mistachkin wrote: > > Scott Robison wrote: > > > > Also: Simply uncommenting the "createTestResults $tempPath 100" call > doesn't > > seem to be doing anything for me. Here is what I'm doing: > > > > Here are the steps I just used here

Re: [fossil-users] how to report bug in fossil

Scott Robison wrote: > > Also: Simply uncommenting the "createTestResults $tempPath 100" call doesn't > seem to be doing anything for me. Here is what I'm doing: > Here are the steps I just used here locally: 1. Uncomment the "createTestResults" line. 2. Run "tclsh

Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 3:27 PM, Scott Robison wrote: > On Fri, Jun 10, 2016 at 12:26 PM, Scott Robison > wrote: > >> On Jun 10, 2016 6:04 AM, "Jan Nijtmans" wrote: >> > >> > 2016-06-10 10:12 GMT+02:00 Scott Robison: >>

Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 12:26 PM, Scott Robison wrote: > On Jun 10, 2016 6:04 AM, "Jan Nijtmans" wrote: > > > > 2016-06-10 10:12 GMT+02:00 Scott Robison: > > > FYI, my test code here (C++ harness) consisted of passing every > possible > > > four

Re: [fossil-users] how to report bug in fossil

On Jun 10, 2016 6:04 AM, "Jan Nijtmans" wrote: > > 2016-06-10 10:12 GMT+02:00 Scott Robison: > > FYI, my test code here (C++ harness) consisted of passing every possible > > four byte buffer to the old function and my new function. My function > > identifies the expected

Re: [fossil-users] how to report bug in fossil

2016-06-10 10:12 GMT+02:00 Scott Robison: > FYI, my test code here (C++ harness) consisted of passing every possible > four byte buffer to the old function and my new function. My function > identifies the expected number of "strings" as valid UTF-8. I didn't eyeball > each one to make sure the

Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 2:04 AM, Scott Robison wrote: > On Fri, Jun 10, 2016 at 1:37 AM, Joe Mistachkin > wrote: > >> >> Scott Robison >> > >> > Glad to be able to get to something before everyone else for a change. >> :) >> > >> >> Yes, thank you

Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 1:37 AM, Joe Mistachkin wrote: > > Scott Robison > > > > Glad to be able to get to something before everyone else for a change. :) > > > > Yes, thank you very much. > > Also, I know it's not a lot of fun, but... > > It would be nice if some new

Re: [fossil-users] how to report bug in fossil

2016-06-10 9:24 GMT+02:00 Scott Robison: > On Fri, Jun 10, 2016 at 1:15 AM, Jan Nijtmans > wrote: >> >> 2016-06-10 2:01 GMT+02:00 Scott Robison: >> > I just committed >> > a one line fix (with multiple lines of comments to clarify what the code >> > is >> > doing in the

Re: [fossil-users] how to report bug in fossil

Scott Robison > > Glad to be able to get to something before everyone else for a change. :) > Yes, thank you very much. Also, I know it's not a lot of fun, but... It would be nice if some new tests covering these edge cases were added to the "utf.test" file. The "generated section" in the

Re: [fossil-users] how to report bug in fossil

On Fri, Jun 10, 2016 at 1:15 AM, Jan Nijtmans wrote: > 2016-06-10 2:01 GMT+02:00 Scott Robison: > > I just committed > > a one line fix (with multiple lines of comments to clarify what the code > is > > doing in the tricky part). > > Scott, I owe you. Many thanks! You are

Re: [fossil-users] how to report bug in fossil

2016-06-10 2:01 GMT+02:00 Scott Robison: > I just committed > a one line fix (with multiple lines of comments to clarify what the code is > doing in the tricky part). Scott, I owe you. Many thanks! You are completely right, this was an edge-case not covered for. Regards, Jan Nijtmans

Re: [fossil-users] how to report bug in fossil

On Thu, Jun 9, 2016 at 6:19 PM, Warren Young wrote: > On Jun 9, 2016, at 6:01 PM, Scott Robison wrote: > > > > On Thu, Jun 9, 2016 at 2:12 PM, Warren Young wrote: > > On Jun 9, 2016, at 6:25 AM, rosscann...@fastmail.com wrote: > > >

Re: [fossil-users] how to report bug in fossil

On Jun 9, 2016, at 6:01 PM, Scott Robison wrote: > > On Thu, Jun 9, 2016 at 2:12 PM, Warren Young wrote: > On Jun 9, 2016, at 6:25 AM, rosscann...@fastmail.com wrote: > > > > The bug: > > In lookslike.c, invalid_utf8() returns 'invalid' for the input

Re: [fossil-users] how to report bug in fossil

Thanks! That patch works for me. Ross On Fri, Jun 10, 2016, at 10:01 AM, Scott Robison wrote: > On Thu, Jun 9, 2016 at 2:12 PM, Warren Young wrote: >> On Jun 9, 2016, at 6:25 AM, rosscann...@fastmail.com wrote: >> > >> > The bug: >> > In lookslike.c, invalid_utf8()

Re: [fossil-users] how to report bug in fossil

On Thu, Jun 9, 2016 at 2:12 PM, Warren Young wrote: > On Jun 9, 2016, at 6:25 AM, rosscann...@fastmail.com wrote: > > > > The bug: > > In lookslike.c, invalid_utf8() returns 'invalid' for the input 0xE0, > > 0xB8, 0x94, which is the Thai character 'do dek' (U+0E14). > > I took

Re: [fossil-users] how to report bug in fossil

On Jun 9, 2016, at 3:21 PM, rosscann...@fastmail.com wrote: > > - it's massive; It’s also open source under one of the most liberal licenses available. Fossil could just swipe the one header file it needs. It hasn’t changed since 2005, so one may presume that it is stable. > - it has

Re: [fossil-users] how to report bug in fossil

I'm new to this list, so take my opinion lightly, but I would hesitate to introduce Boost into the fossil build if it's not there already. Boost adds a long list of complications to any build it's part of: - it's massive; - it has dependencies between its modules, so even if you just want a tiny

Re: [fossil-users] how to report bug in fossil

On Jun 9, 2016, at 6:25 AM, rosscann...@fastmail.com wrote: > > The bug: > In lookslike.c, invalid_utf8() returns 'invalid' for the input 0xE0, > 0xB8, 0x94, which is the Thai character 'do dek' (U+0E14). I took a look at that code, and there is no possibility for it to be correct. It doesn’t

Re: [fossil-users] how to report bug in fossil

rosscann...@fastmail.com wrote: > > The bug: > In lookslike.c, invalid_utf8() returns 'invalid' for the input 0xE0, > 0xB8, 0x94, which is the Thai character 'do dek' (U+0E14). This can be > easily reproduced by trying to commit a file that contains those three > bytes and nothing else - you will