Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Martin Gagnon wrote: > > Strange, "fossil add a_dir_symlink" doesn't works for the case #2 on my > actual repository, but if I try to reproduce the problem on a brand new > repo, everything works.. Probably I hit a strange corner case. I will > try to investigate a bit more.. > I've added the

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Mon, Feb 13, 2017 at 02:29:58PM -0800, Joe Mistachkin wrote: > > Martin Gagnon wrote: > > > > But if I do: > > $ fossil add a_dir_symlink/* > > > > It add the content. > > > > Actually, may be it was intended ? > > > > The way it should work (on the branch) is: > > 1. With

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Martin Gagnon wrote: > > But if I do: > $ fossil add a_dir_symlink/* > > It add the content. > > Actually, may be it was intended ? > The way it should work (on the branch) is: 1. With allowSymlinks ON, symlinks to both files and directories are always treated as "normal"

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Mon, Feb 13, 2017 at 01:11:39PM -0800, Joe Mistachkin wrote: > > Martin Gagnon wrote: > > > > $ fossil add a_dir_symlink > > > > Nothing happens... > > > > It was a bit more complex than I thought, made a couple more changes. > > Hopefully, it will work better now. Same result with

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Martin Gagnon wrote: > > $ fossil add a_dir_symlink > > Nothing happens... > It was a bit more complex than I thought, made a couple more changes. Hopefully, it will work better now. -- Joe Mistachkin @ https://urn.to/r/mistachkin ___

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Mon, Feb 13, 2017 at 12:37:10PM -0800, Joe Mistachkin wrote: > > Changes on the "symlinks" branch prevent directory symlinks > from being traversed into if the "allow-symlinks" setting is > enabled or the "--no-dir-symlinks" flag is specified. > > Making this change work correctly also

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Joe Mistachkin
Changes on the "symlinks" branch prevent directory symlinks from being traversed into if the "allow-symlinks" setting is enabled or the "--no-dir-symlinks" flag is specified. Making this change work correctly also required removing the forced override of the cached "allow-symlinks" setting from

Re: [fossil-users] Directory symlinks...

2017-02-13 Thread Martin Gagnon
On Fri, Sep 30, 2016 at 09:25:01PM -0700, Joe Mistachkin wrote: > > Warren Young wrote: > > > > Well, that's a tricky one, innit? Fossil manages files, not directories, > > but Fossil's view of symlinks is file-like. So is it an apple or an > > orange? > > > > I've checked in a fix on the

Re: [fossil-users] Git Tag comments

2017-02-13 Thread Roy Marples
On 13/02/2017 11:12, Jan Nijtmans wrote: > 2017-02-13 12:09 GMT+01:00 Roy Marples: >> Is the value displayed in the timeline? > Yes >> I'm also unsure about overloading the meaning of tag value . the ui >> indicates it can be set via the command line so could someone be using >> it for

Re: [fossil-users] Git Tag comments

2017-02-13 Thread Jan Nijtmans
2017-02-13 12:09 GMT+01:00 Roy Marples: > Is the value displayed in the timeline? Yes > I'm also unsure about overloading the meaning of tag value . the ui > indicates it can be set via the command line so could someone be using > it for something else to store in fossil? For some tags, like

Re: [fossil-users] Git Tag comments

2017-02-13 Thread Roy Marples
On 13/02/2017 10:42, Jan Nijtmans wrote: > 2017-02-13 4:50 GMT+01:00 Roy Marples: >> 3 has now been implemented in the roy-export branch. >> Turned out to be quite easy. A database rebuild is required though as an >> extra field has been added to the tagxref table. > > Thanks, Roy! I looked at

Re: [fossil-users] Git Tag comments

2017-02-13 Thread Roy Marples
On 13/02/2017 09:49, Roy Marples wrote: >>> * tag comments are imported and exported [2] >> >> ?? How does one enter a tag comment from the Fossil command line or >> this is an import/export only feature? fossil tag add --comment "A tag test comment" tagtest current now works. Roy

Re: [fossil-users] Git Tag comments

2017-02-13 Thread Jan Nijtmans
2017-02-13 4:50 GMT+01:00 Roy Marples: > 3 has now been implemented in the roy-export branch. > Turned out to be quite easy. A database rebuild is required though as an > extra field has been added to the tagxref table. Thanks, Roy! I looked at your implementation: cards have to be in

Re: [fossil-users] Git Tag comments

2017-02-13 Thread Roy Marples
On 13/02/2017 06:47, Artur Shepilko wrote: >> * no more silent renaming of master vs trunk [1] > > "fossil import --rename-trunk" already allows a choice for a Fossil > branch name to receive Git's "master" branch. > A bug was missed in src/import.c:~567 if( fossil_strcmp(z, > "master")==0 ) z

Re: [fossil-users] Fossil SCGI Server Regression (from 1.36 to 1.37)

2017-02-13 Thread Thomas Bilk
2017-02-13 0:28 GMT+01:00 Richard Hipp : >> I guess there was a regression introduced somewhere between [8b03934e] >> and [fb4b87d9]. > > Would you be willing to bisect for us? Sure. I will report my findings later today. ___