Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-12 Thread Jan Nijtmans
2013/11/5 Jan Nijtmans jan.nijtm...@gmail.com: fossil clone [--once] http://u...@url.org fossil sync [--once] http://u...@url.org fossil pull [--once] http://u...@url.org fossil push [--once] http://u...@url.org 1) When not cloning, if a password is necessary and there is a

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-12 Thread Jan Nijtmans
2013/11/12 Jan Nijtmans jan.nijtm...@gmail.com: Something is wrong on trunk: $ ./fossil sync http://jan.nijtm...@www.fossil-scm.org/fossil missing or incorrect password for user jan.nijtmans with previous fossil, and corresponding to test description: $ fossil sync

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-07 Thread Jan Nijtmans
2013/11/6 Andy Bradford amb-fos...@bradfords.org: So, I do think it's ready, pending any other feedback. I merged the url-password-fixes and the jan-httpsproxytunnel branched together, and did various tests using https over a http tunnel. This confirmed what I already guessed: The merge of those

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-07 Thread Andy Bradford
Thus said Jan Nijtmans on Thu, 07 Nov 2013 12:41:01 +0100: I merged the url-password-fixes and the jan-httpsproxytunnel branched together, and did various tests using https over a http tunnel. This confirmed what I already guessed: The merge of those two branches didn't have any

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-05 Thread Jan Nijtmans
2013/11/5 Andy Bradford: In addition to the clone/sync/push/pull operations that you mentioned for test cases, we should also add update/commit/remote-url operations. I now added the --once option to fossil clone. I can only think of one use-case: when cloning a repository where autosync is

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-05 Thread Andy Bradford
Thus said Jan Nijtmans on Tue, 05 Nov 2013 11:14:07 +0100: I now added the --once option to fossil clone. I can only think of one use-case: when cloning a repository where autosync is going to be off, which is going to be synced automatically using a script containing fossil sync

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-05 Thread Andy Bradford
Thus said Andy Bradford on 05 Nov 2013 22:04:14 -0700: Thanks for the help. Looks like it might be ready? Nope, not ready yet... I just encountered a problem when cloning. Andy -- TAI64 timestamp: 40005279d649 ___ fossil-users mailing list

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-04 Thread Andy Bradford
Thus said Jan Nijtmans on Sat, 02 Nov 2013 12:11:51 +0100: I just made a little modification preventing the prompt if the saved password is already equal to the to-be-saved password. I will do some more testing the coming days, but I think the pending-review branch (another name would be

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-02 Thread Andy Bradford
Thus said Jan Nijtmans on Fri, 01 Nov 2013 16:53:24 +0100: [Be aware that I have only been looking at the Fossil code for a short time, so what I say may be inaccurate] 1) If a password is necessary and there is a saved password, use the saved password. 2) Otherwise, prompt

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-02 Thread Andy Bradford
Thus said Ron Wilson on Fri, 01 Nov 2013 12:10:19 -0400: Also, I would suggest that before prompting, Fossil determine if STDIN and (STDERR or STDOUT) are associate with a console. If not, then Fossil is not running interactively. The normal password prompting already checked for the

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-02 Thread Andy Bradford
Thus said Martin Gagnon on Fri, 01 Nov 2013 06:52:33 -0400: It's ok for me, but I still think that specifying password in URL in interactive shell a bad idea. E.g. It got saved in shell command history. I too stay away from passwords in command line shell commands and prefer to use

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-02 Thread Andy Bradford
Thus said Jan Nijtmans on Fri, 01 Nov 2013 16:53:24 +0100: fossil clone [--once] http://u...@url.org By the way, clone does not currently have a --once: $ fossil clone --once http://tester:testing@localhost:8081/ clone.fossil unknown repository: --once Andy -- TAI64 timestamp:

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-02 Thread Jan Nijtmans
2013/11/2 Andy Bradford amb-sendok-1385966124.fhhccojmfocil...@bradfords.org: I believe steps 1--4 are fine and do work as expected. Due to the way the http sync code is written, I don't know how many times we can actually continue to prompt after a failure. At the

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-02 Thread Andy Bradford
Thus said Jan Nijtmans on Sat, 02 Nov 2013 12:11:51 +0100: Agreed. A single retry is enough for me too. As it turns out, I can get it to prompt more than once easily enough, but 2 is the limit here because we drop out of the http exchange loop if we've seen 2 login failure messages. It

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-02 Thread Andy Bradford
Thus said Andy Bradford on 02 Nov 2013 10:07:30 -0600: I'm now investigating why it didn't prompt me to save the password (it has nothing to do with your change), but you'll notice that it did prompt me twice. Haha, it was not prompting me because I entered the same failed

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-01 Thread Andy Bradford
Thus said =?Big5?B?vEKq2qtG?= on Fri, 01 Nov 2013 13:55:50 +0800: Great thanks, I was just wondering about that. I tried the fix and works well for me, it now prompts for remembering password when cloning with username+password. As it turns out, after I committed the fix, I

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-01 Thread Martin Gagnon
Le 1 nov. 2013 02:05, Andy Bradford amb-fos...@bradfords.org a écrit : Thus said =?Big5?B?vEKq2qtG?= on Fri, 01 Nov 2013 13:55:50 +0800: Great thanks, I was just wondering about that. I tried the fix and works well for me, it now prompts for remembering password when cloning

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-01 Thread Stephan Beal
On Fri, Nov 1, 2013 at 11:19 AM, Martin Gagnon eme...@gmail.com wrote: Personally, I think it shouldn't prompt to save password when specifying it from URL. When using a interactive shell, it's better to let fossil prompt for the password, then it's time to ask to save it. FWIW: +1.

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-01 Thread Stephan Beal
On Fri, Nov 1, 2013 at 11:38 AM, Jan Nijtmans jan.nijtm...@gmail.comwrote: The --once option is meant to disable saving the url/password, hence it also disables prompting in this case. That's what scripts should be using, and that's the only reliable way to prevent prompting. That's

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-01 Thread Martin Gagnon
Le 1 nov. 2013 06:38, Jan Nijtmans jan.nijtm...@gmail.com a écrit : 2013/11/1 Stephan Beal sgb...@googlemail.com: On Fri, Nov 1, 2013 at 11:19 AM, Martin Gagnon eme...@gmail.com wrote: Personally, I think it shouldn't prompt to save password when specifying it from URL. When using a

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-11-01 Thread Jan Nijtmans
2013/11/1 Martin Gagnon eme...@gmail.com: It's ok for me, but I still think that specifying password in URL in interactive shell a bad idea. E.g. It got saved in shell command history. I agree with that! But for people who DO specify the password in the URL it's a problem: should this

[fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread 劉芳亭
Hi, I have recently upgraded our fossil from 1.23 to 1.27, and have encountered this issue: fossil clone http://user:password@. this will not ask me if I want to remember password, but did clone successfully. However if I want to add a file or make a change to files and commit via: fossil

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread Jan Nijtmans
2013/10/31 劉芳亭 ftl...@mapacode.tw: Hi, I have recently upgraded our fossil from 1.23 to 1.27, and have encountered this issue: fossil clone http://user:password@. this will not ask me if I want to remember password, but did clone successfully. However if I want to add a file or make a

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread Stephan Beal
On Thu, Oct 31, 2013 at 10:49 AM, Jan Nijtmans jan.nijtm...@gmail.comwrote: Is there someone who knows how to fix this? (I'm not confident in this part of fossil to do it myself.) i _suspect_ (haven't confirmed) that this is related to the recent user:password handling change. i am

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread Jan Nijtmans
2013/10/31 Stephan Beal sgb...@googlemail.com: i _suspect_ (haven't confirmed) that this is related to the recent user:password handling change. i am swamped at work for the next week to ten days and will likely not get a chance to look into it, though. A simple thing to test would be to

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread Ron Wilson
On Thu, Oct 31, 2013 at 5:21 AM, 劉芳亭 ftl...@mapacode.tw wrote: Hi, I have recently upgraded our fossil from 1.23 to 1.27, and have encountered this issue: fossil clone http://user:password@. this will not ask me if I want to remember password, but did clone successfully. However if I

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread Andy Bradford
Thus said Ron Wilson on Thu, 31 Oct 2013 09:54:29 -0400: Error: login failed, missing or incorrect password for user xxx Did Fossil ask you for the password after this error? If not, it should have. Fossil 1.27 will not do this, but Fossil from trunk will prompt for it. Andy --

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread 劉芳亭
Thanks to all for your response, I have tried the trunk and it does work, here is test result/comparison: Fossil 1.27 ~/fossil$ fossil clone http://ftliou:password@host/atest atest.fossil Round-trips: 2 Artifacts sent: 0 received: 7 Clone finished with 558 bytes sent, 1790

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread Andy Bradford
Thus said =?Big5?B?vEKq2qtG?= on Fri, 01 Nov 2013 10:10:53 +0800: Thanks to all for your response, I have tried the trunk and it does work, here is test result/comparison: I just now committed a fix to pending-review that should also correct the missing prompt to save the password which

Re: [fossil-users] problem with committing when cloned via http://user:password@

2013-10-31 Thread 劉芳亭
Great thanks, I was just wondering about that. I tried the fix and works well for me, it now prompts for remembering password when cloning with username+password. ft ___ fossil-users mailing list fossil-users@lists.fossil-scm.org