Re: [fpc-devel] ANN: Management operators - final patch

2016-11-21 Thread Florian Klämpfl
Am 21.11.2016 um 02:54 schrieb Paul Ishenin: > 21.11.2016 8:16, Maciej Izak wrote: > > Overall you've made a great job and a perfect example of how to supply > patches for FPC. > > I have a small question regards the following commit: >> 13. >>

Re: [fpc-devel] ANN: Management operators - final patch

2016-11-21 Thread Maciej Izak
2016-11-21 2:16 GMT+01:00 Maciej Izak : > I have new dedicated branch located here: > > https://github.com/maciej-izak/freepascal/tree/fpc-management-operators > note: management operators are also available in version for NewPascal :

Re: [fpc-devel] ANN: Management operators - final patch

2016-11-21 Thread Maciej Izak
2016-11-21 2:54 GMT+01:00 Paul Ishenin : > Use fpc_Copy for Clone and fpc_Addref for Copy is misleading. First of all I don't like to have Florian in opposition to this feature ;) it is a teamwork. Anyway I agree that this is misleading... But as was suggested by

Re: [fpc-devel] ANN: Management operators - final patch

2016-11-20 Thread Sven Barth
Am 21.11.2016 02:17 schrieb "Maciej Izak" : > > Hi, > > Patch for management operators is totally reworked. All suggestions from Florian, Jonas and Sven have been implemented. This is the third attempt. My base is trunk r34916. Each commit works well with "make clean all". I

Re: [fpc-devel] ANN: Management operators - final patch

2016-11-20 Thread Paul Ishenin
21.11.2016 8:16, Maciej Izak wrote: Overall you've made a great job and a perfect example of how to supply patches for FPC. I have a small question regards the following commit: 13. https://github.com/maciej-izak/freepascal/commit/9baa32a49a204686427981d33c9054f64b2057c4 Use fpc_Copy for