Re: [fpc-devel] Review of AVR patch for bug 31925

2017-11-19 Thread Florian Klämpfl
Am 22.09.2017 um 17:28 schrieb Christo: > On Fri, 2017-09-22 at 07:10 +0200, Christo wrote: >> On Wed, 2017-09-20 at 12:36 +0200, Karoly Balogh (Charlie/SGR) wrote: >>> > > A complication I've noted is that enabling overflow checking doesn't > call the fpc_mul_byte_overflow function (as the

Re: [fpc-devel] Review of AVR patch for bug 31925

2017-09-23 Thread Georg Hieber
implementing 8*8 bit multiplications as library functions is certainly one way to cope with the absence of mul/mulsu instructions in  the "basic" avr subarchitectures, and the resultint compiler error message when confronted with any source code resulting in such a multiplication. The

Re: [fpc-devel] Review of AVR patch for bug 31925

2017-09-21 Thread Christo
On Wed, 2017-09-20 at 12:36 +0200, Karoly Balogh (Charlie/SGR) wrote: > Few things I see: I wouldn't do IFDEF CPUAVR in inc/generic and > inc/compproc. Use maybe IFDEF CPU8 and/or CPU16 instead. This code is > indeed generic, and will be useful on other limited CPU archs as > well. Or > just

Re: [fpc-devel] Review of AVR patch for bug 31925

2017-09-20 Thread Karoly Balogh (Charlie/SGR)
Hi, On Wed, 20 Sep 2017, Christo wrote: > I have made an attempt at fixing an AVR related bug.  Since this is my > first attempt at messing with the compiler, I would like a review and > critique of my attempt. > (...) > > Can anyone see any problems with this approach, or perhaps suggest a >

[fpc-devel] Review of AVR patch for bug 31925

2017-09-20 Thread Christo
I have made an attempt at fixing an AVR related bug.  Since this is my first attempt at messing with the compiler, I would like a review and critique of my attempt. The bug seems to be caused by the absence of the MUL instruction for the limited AVR subarchitectures (avr1 - avr35). As far as I