Re: [PATCH] (2) Remove Dmalloc and Efence support.

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 02:07:58AM +0100, Dominik Vogt wrote: > 0001: Remove Efence and Dmalloc support. > 0002: Remove trailing whitespace. Applied. Thanks! Kindly, Thomas

[PATCH] (2) Remove Dmalloc and Efence support.

2021-11-14 Thread Dominik Vogt
0001: Remove Efence and Dmalloc support. 0002: Remove trailing whitespace. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 0d9780ca99675083470398857d149e3d1f05f84e Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Mon, 15 Nov 2021 02:03:44 +0100 Subject: [PATCH 1/2] Remove Efence and Dmalloc

Re: Removind dmalloc and efence support?

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:49:58AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:42:33AM +0100, Dominik Vogt wrote: > > Has anybody really used them in the last fifteen years? Since > > valgrind has become pretty stable and good I never saw a need for > > dmalloc or efence any more. > >

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:45:18AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:36:15AM +0100, Dominik Vogt wrote: > > While we're at it, much of the markup could be removed. The > > manpage is partially unreadable because too many words have markup > > (especially for the style

Re: Removind dmalloc and efence support?

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 01:42:33AM +0100, Dominik Vogt wrote: > Has anybody really used them in the last fifteen years? Since > valgrind has become pretty stable and good I never saw a need for > dmalloc or efence any more. I agree. It can go. There's a chance some distros ship efence (and

Re: Plans for the NEWS file?

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 01:40:40AM +0100, Dominik Vogt wrote: > There probably needs to be some time when we annouce that we're > done removing stuff so that people know that future changes will > no longer break their configs. I'd say the feature set is > unstable at the moment, not the code

Re: Paging issue

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 01:36:15AM +0100, Dominik Vogt wrote: > While we're at it, much of the markup could be removed. The > manpage is partially unreadable because too many words have markup > (especially for the style command). Yeah. I suspect this is a holdover from when the original man

Removind dmalloc and efence support?

2021-11-14 Thread Dominik Vogt
Has anybody really used them in the last fifteen years? Since valgrind has become pretty stable and good I never saw a need for dmalloc or efence any more. Ciao Dominik ^_^ ^_^ -- Dominik Vogt

Re: Plans for the NEWS file?

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:30:34AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:18:49AM +0100, Dominik Vogt wrote: > > Is the NEWS file going to be used for 3.x releases too? I always > > found it easier to add new entries when patches are written > > instead of reading the whole

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:24:42AM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 01:16:06AM +0100, Dominik Vogt wrote: > > Of course. What is the maximum line length that was used to > > format the .adoc files? (Can we re-add some formatting > > instructions in comments at the start of the

Re: [PATCH] (3) Miscellaneous updates

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 01:26:31AM +0100, Dominik Vogt wrote: > 0001: Improve Snap... docuemntation. > 0002: Improve EdgeMoveDelay documentation. > 0003: Remove superfluous "#if 1". Applied, thanks! Kindly, Thomas

Re: Plans for the NEWS file?

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 01:18:49AM +0100, Dominik Vogt wrote: > Is the NEWS file going to be used for 3.x releases too? I always > found it easier to add new entries when patches are written > instead of reading the whole changelog when making a release. I now autogenerate this at release time

[PATCH] (3) Miscellaneous updates

2021-11-14 Thread Dominik Vogt
0001: Improve Snap... docuemntation. 0002: Improve EdgeMoveDelay documentation. 0003: Remove superfluous "#if 1". Ciao Dominik ^_^ ^_^ -- Dominik Vogt From bda6a6a423ac05b68e65fc850afba9de57c6e46c Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 23:30:49 +0100 Subject:

Re: Paging issue

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 01:16:06AM +0100, Dominik Vogt wrote: > Of course. What is the maximum line length that was used to > format the .adoc files? (Can we re-add some formatting > instructions in comments at the start of the main manpage source > as we had in the groff sources? I've noticed

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Sun, Nov 14, 2021 at 11:57:27PM +, Thomas Adam wrote: > On Mon, Nov 15, 2021 at 12:31:28AM +0100, Dominik Vogt wrote: > > On Mon, Nov 15, 2021 at 12:19:59AM +0100, Dominik Vogt wrote: > > > What do you think about the attached patch? Pressing "Alt" during > > > an interactive move already

Plans for the NEWS file?

2021-11-14 Thread Dominik Vogt
Is the NEWS file going to be used for 3.x releases too? I always found it easier to add new entries when patches are written instead of reading the whole changelog when making a release. Can you give me an update on the intended release scheme? Fvwm is probably in an "unstable" phase at the

Re: [PATCH] Reject out of range windows for Move and Resize commands.

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 01:11:34AM +0100, Dominik Vogt wrote: > Fixes programs going crazy when you accidentally say something like > > all (mplayer) resize 1920 1200 > > instead of > > all (mplayer) resize 1920p 1200p > > (Generates an error message without doing anything else.) Makes

[PATCH] Reject out of range windows for Move and Resize commands.

2021-11-14 Thread Dominik Vogt
Fixes programs going crazy when you accidentally say something like all (mplayer) resize 1920 1200 instead of all (mplayer) resize 1920p 1200p (Generates an error message without doing anything else.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt From c7e032441e57cb59b4472e6396e64da45b7628c6

Re: Paging issue

2021-11-14 Thread Thomas Adam
On Mon, Nov 15, 2021 at 12:31:28AM +0100, Dominik Vogt wrote: > On Mon, Nov 15, 2021 at 12:19:59AM +0100, Dominik Vogt wrote: > > What do you think about the attached patch? Pressing "Alt" during > > an interactive move already disables snapping. It's easy to make > > it enable paging without

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Mon, Nov 15, 2021 at 12:19:59AM +0100, Dominik Vogt wrote: > What do you think about the attached patch? Pressing "Alt" during > an interactive move already disables snapping. It's easy to make > it enable paging without any delay too. I like it. > > You can say > > style * edgemovedelay >

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Sun, Nov 14, 2021 at 04:51:26PM +, Thomas Adam wrote: > On Sun, Nov 14, 2021 at 04:50:23PM +0100, Dominik Vogt wrote: > > Current situation for me: At least 90% of all paging situations > > are accidents. > > Yeah, and it gets even worse if you happen to use paging with >

Re: Paging issue

2021-11-14 Thread Thomas Adam
On Sun, Nov 14, 2021 at 04:50:23PM +0100, Dominik Vogt wrote: > Current situation for me: At least 90% of all paging situations > are accidents. Yeah, and it gets even worse if you happen to use paging with 'DesktopConfiguration per-monitor' as well. > Maybe that feature ist just crap and we

Re: Paging issue

2021-11-14 Thread Dominik Vogt
On Sun, Nov 14, 2021 at 03:35:12PM +, Thomas Adam wrote: > On Sun, Nov 14, 2021 at 01:55:32PM +0100, Dominik Vogt wrote: > > 1) Because the pointer is at the top of the screen, it's > > immediately in the one pixel high panning window, so fvwm waits > > the configured 500 ms and then switches

Re: Paging issue

2021-11-14 Thread Thomas Adam
On Sun, Nov 14, 2021 at 01:55:32PM +0100, Dominik Vogt wrote: > 1) Because the pointer is at the top of the screen, it's > immediately in the one pixel high panning window, so fvwm waits > the configured 500 ms and then switches pages to 0 0 although > neither the window nor the pointer have ever

Re: Snapping issue

2021-11-14 Thread Dominik Vogt
The snapping code is really an unmaintainable mess. Some thoughts on how it might be rewritten: Situation: 1. There are three different snapping mechanisms: a) Snapping to windows or icons. b) Snapping to screen edges. c) Snapping to the grid. Each one has some distance defined at which

Paging issue

2021-11-14 Thread Dominik Vogt
With Style * SnapGrid 4 4 EdgeResistance 500 Style * EdgeMoveDelay 500, EdgeMoveResistance 128 EdgeScroll 0 0 Problem: * Create on page 0 1 and align it with the top of the screen. * Move the pointer to the top of the screen too. * Use some keyboard shortcut to start an interactive

Snapping issue

2021-11-14 Thread Dominik Vogt
Snapping to the grid, other windows and screen edges hat a nasty interaction that has been bugging me for years, but I don't know how to fix it. Suppose you have this: Style * SnapAttraction 12 Sametype, SnapGrid 4 4 EdgeResistance 500 Style * EdgeMoveDelay 500, EdgeMoveResistance 128

Re: [PATCH] 1/3 Fix and document "bugopts debugrandr".

2021-11-14 Thread Thomas Adam
On Sun, Nov 14, 2021 at 10:58:19AM +0100, Dominik Vogt wrote: > The patch makes the bogus "bugopts debugrandr" option actually do > something. Hi Dominik, Thank you. All four patches have now been merged! Thanks, Thomas

[PATCH] (7) Remove ifdefs

2021-11-14 Thread Dominik Vogt
#1, 2, 3 and 5 remove code that hasn't been used in ages. #4 removes an ifdef that commented out code that shouldn't be. #6 makes a very old code switch permanent. #7 general ifdef and debug output cleanup. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 6d65cc40b6371f4d0a7a2adf5254e2e329ded7ab

[PATCH] 1/3 Fix and document "bugopts debugrandr".

2021-11-14 Thread Dominik Vogt
The patch makes the bogus "bugopts debugrandr" option actually do something. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 415a98341f4f33495d58c4b74718a25a3a83eff8 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 10:54:20 +0100 Subject: [PATCH 1/3] Fix and document "bugopts

Re: [PATCH] 3/3 Correct typo.

2021-11-14 Thread Dominik Vogt
Typo in error message. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 2d6ceb2c0650a7b0e30a3be7a04363e59b83370e Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 10:55:53 +0100 Subject: [PATCH 3/3] Correct typo. --- fvwm/conditional.c | 2 +- 1 file changed, 1 insertion(+), 1

Re [PATCH] 4/3 Enable EWMH debug messages with "bugopts debugrandr"

2021-11-14 Thread Dominik Vogt
Put EWMH_GetWorkAreaIntersection debug messages in the "debugrandr" category. Ciao Dominik ^_^ ^_^ -- Dominik Vogt From 367de6c621cf768e13d3edb596c91176e2f62265 Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 11:02:48 +0100 Subject: [PATCH 4/4] Enable EWMH debug messages

Re: [PATCH] 2/3 Sanitize screen related code indentation.

2021-11-14 Thread Dominik Vogt
(No indentation with spaces.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt From e04bcd721ea1ebbbf64eec7463cc4dadde7fb88c Mon Sep 17 00:00:00 2001 From: Dominik Vogt Date: Sun, 14 Nov 2021 10:55:32 +0100 Subject: [PATCH 2/3] Sanitize screen related code indentation. --- libs/FScreen.c | 85