Re: make rpm-dist and deb-dist both fail with the same error

2006-01-18 Thread Dominik Vogt
On Sun, Jan 15, 2006 at 09:44:49PM +, Mikhael Goikhman wrote: Just tested. Mere make is broken on the released fvwm-2.5.15 tarballs. Hrmpf, why didn't make distcheck catch this? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature

Re: bell on failed grab

2006-01-18 Thread Dominik Vogt
On Sun, Jan 15, 2006 at 10:24:01PM +, Tavis Ormandy wrote: Hello, I would really like to appeal for the removal of the XBell() at line 1029 in fvwm/functions.c, part of execute_complex_function(). It doesnt serve any purpose as it is impossible to determine even if it was fvwm that rang

Re: MenuStyle ActiveColorset and the need of HilightBack/ActiveFore

2006-01-18 Thread Dominik Vogt
On Wed, Jan 18, 2006 at 10:45:08AM +0100, Viktor Griph wrote: On Wed, 18 Jan 2006, Viktor Griph wrote: Hi When using the ActiveColorset menustyle, you also have to specify HiglightBack and/or ActiveFore (without arguments) in order to make the style use the colorset. Just using

Re: make rpm-dist and deb-dist both fail with the same error

2006-01-18 Thread Mikhael Goikhman
On 18 Jan 2006 12:45:21 +0100, Dominik Vogt wrote: On Sun, Jan 15, 2006 at 09:44:49PM +, Mikhael Goikhman wrote: Just tested. Mere make is broken on the released fvwm-2.5.15 tarballs. Hrmpf, why didn't make distcheck catch this? No matter how smart make distcheck is, it is always

Re: bell on failed grab

2006-01-18 Thread Tavis Ormandy
On Wed, Jan 18, 2006 at 12:44:26PM +0100, Dominik Vogt wrote: On Sun, Jan 15, 2006 at 10:24:01PM +, Tavis Ormandy wrote: Hello, I would really like to appeal for the removal of the XBell() at line 1029 in fvwm/functions.c, part of execute_complex_function(). That's fine with me, so

Patch: HasTitle and HasBorders

2006-01-18 Thread Thomas Adam
Hello, I'd been meaning to send these in for a while, but University work always seems to get in the way. :) I've created two patches[1] --- very minor ones that add two new conditionals: HasTitle -- Checks to see whether a window has a titlebar or not. HasBorders -- Checks to see whether a

Re: Patch: HasTitle and HasBorders

2006-01-18 Thread Mikhael Goikhman
On 18 Jan 2006 18:53:58 +, Thomas Adam wrote: I'd been meaning to send these in for a while, but University work always seems to get in the way. :) I've created two patches[1] --- very minor ones that add two new conditionals: HasTitle -- Checks to see whether a window has a

Re: Patch: HasTitle and HasBorders

2006-01-18 Thread Thomas Adam
On Thu, Jan 19, 2006 at 12:57:18AM +, Mikhael Goikhman wrote: I am all for adding these conditions, but implementation is incorect . HasBorders can't work, since you do not use any window info for it . Hint: you may use has_no_borders window flag for this. Ah. But I did

Re: Patch: HasTitle and HasBorders

2006-01-18 Thread Mikhael Goikhman
On 19 Jan 2006 01:16:28 +, Thomas Adam wrote: On Thu, Jan 19, 2006 at 12:57:18AM +, Mikhael Goikhman wrote: I am all for adding these conditions, but implementation is incorect . HasBorders can't work, since you do not use any window info for it . Hint: you may use

Re: Patch: HasTitle and HasBorders

2006-01-18 Thread Mikhael Goikhman
On 19 Jan 2006 01:16:28 +, Thomas Adam wrote: OK. I'll do this in the morning, after I have slept. We are not really in hurry. In fact, I would feel more comfortably before applying any patch if its author tells that he runs fvwm with this patch applied for several days without problems