Re: FvwmIconMan: debug code cleanup
On 8/7/06, Serge (gentoosiast) Koksharov [EMAIL PROTECTED] wrote: Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. Hello! Your patch seems ok to me :) BTW, I've seen some references of manger replaced by manager. I guess having so many of them could mean the intended word was indeed manger. After a search in the dictionary, manger means something like a cattle pen (a fenced place where you put livestock). This would definitely fit the module, as it is indeed a fenced place for icons :) Could there have been a misunderstanding of the Man short word right in the begining? Can the original author clear this up? I'll let you all think about that :) Cheers Renato Bye. -- Serge Koksharov, Free Software user supporter GPG public key ID: 0x3D330896 (pgp.mit.edu) Key fingerprint: 5BC4 0475 CB03 6A31 0076 82C2 C240 72F0 3D33 0896
Re: FvwmIconMan: debug code cleanup
On Tue, 8 Aug 2006 16:39:42 +0100 seventh guardian [EMAIL PROTECTED] wrote: On 8/7/06, Serge (gentoosiast) Koksharov [EMAIL PROTECTED] wrote: Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. Hello! Your patch seems ok to me :) BTW, I've seen some references of manger replaced by manager. I guess having so many of them could mean the intended word was indeed manger. After a search in the dictionary, manger means something like a cattle pen (a fenced place where you put livestock). This would definitely fit the module, as it is indeed a fenced place for icons :) Indeed -- have you never sung the Christmas carol Away in a Manger? Could there have been a misunderstanding of the Man short word right in the begining? Can the original author clear this up? It depends in what context the word 'manger' is being used (I haven't looked). It does seem awfully like a typo to me. :) -- Thomas Adam -- ThisWindow (thomas_adam) Destroy
Re: FvwmIconMan: debug code cleanup
On 8/8/06, Thomas Adam [EMAIL PROTECTED] wrote: On Tue, 8 Aug 2006 16:39:42 +0100 seventh guardian [EMAIL PROTECTED] wrote: On 8/7/06, Serge (gentoosiast) Koksharov [EMAIL PROTECTED] wrote: Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. Hello! Your patch seems ok to me :) BTW, I've seen some references of manger replaced by manager. I guess having so many of them could mean the intended word was indeed manger. After a search in the dictionary, manger means something like a cattle pen (a fenced place where you put livestock). This would definitely fit the module, as it is indeed a fenced place for icons :) Indeed -- have you never sung the Christmas carol Away in a Manger? No.. I'm portuguese.. but the word mangedoura exists here too with the same meaning :) Could there have been a misunderstanding of the Man short word right in the begining? Can the original author clear this up? It depends in what context the word 'manger' is being used (I haven't looked). It does seem awfully like a typo to me. :) Yes, but it does appear several times.. spooky :) Renato -- Thomas Adam -- ThisWindow (thomas_adam) Destroy
Re: FvwmIconMan: debug code cleanup
On Tue, Aug 08, 2006 at 12:16:44AM +0400, Serge (gentoosiast) Koksharov wrote: Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. The patch looks fine. Any volunteers to commit it? Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: FvwmIconMan: debug code cleanup
On 8/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 08, 2006 at 12:16:44AM +0400, Serge (gentoosiast) Koksharov wrote: Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. The patch looks fine. Any volunteers to commit it? Good, I'll do it then. Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFE2NVwmeSprTOr4tgRAgWCAJ9l7GcGSKVpXC9TFus00+aIDgocpwCcC4VG IsHE3z8MgyhJdnwqv8CL+bU= =VAt2 -END PGP SIGNATURE-
Re: FvwmIconMan: debug code cleanup
On 8/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 8/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 08, 2006 at 12:16:44AM +0400, Serge (gentoosiast) Koksharov wrote: Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. The patch looks fine. Any volunteers to commit it? Good, I'll do it then. BTW, do you think typo corrections should be mentioned in the changelog? I'm tempted to remove them, but need a core-dev opinion.. :) Cheers Renato Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFE2NVwmeSprTOr4tgRAgWCAJ9l7GcGSKVpXC9TFus00+aIDgocpwCcC4VG IsHE3z8MgyhJdnwqv8CL+bU= =VAt2 -END PGP SIGNATURE-
Re: FvwmIconMan: debug code cleanup
On Tue, Aug 08, 2006 at 07:28:32PM +0100, seventh guardian wrote: On 8/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 8/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Tue, Aug 08, 2006 at 12:16:44AM +0400, Serge (gentoosiast) Koksharov wrote: Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. The patch looks fine. Any volunteers to commit it? Good, I'll do it then. BTW, do you think typo corrections should be mentioned in the changelog? Only if they are the only change or if they affect functionality (e.g. if a typo in an option name is corrected). I'm tempted to remove them, but need a core-dev We don't have such a concept. Everybody is welcome to help. All I do is try to explain the tiny bits of design that fvwm has and help you with some knowledge about the larger picture (not everything happened by accident). opinion.. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
FvwmIconMan: debug code cleanup
Hello,
Here some documentation fixes and debug code cleanups in FvwmIconMan.
Please see attached patch's ChangeLog section for more information.
Bye.
--
Serge Koksharov, Free Software user supporter
GPG public key ID: 0x3D330896 (pgp.mit.edu)
Key fingerprint: 5BC4 0475 CB03 6A31 0076 82C2 C240 72F0 3D33 0896
diff -Naur fvwmCVS-orig/modules/ChangeLog fvwmCVS-fixed/modules/ChangeLog
--- fvwmCVS-orig/modules/ChangeLog 2006-08-07 11:54:31.0 +0400
+++ fvwmCVS-fixed/modules/ChangeLog 2006-08-07 20:59:43.0 +0400
@@ -1,3 +1,58 @@
+2006-08-07 Serge Koksharov gentoosiast dog yandex dot ru
+
+ * FvwmIconMan/FvwmIconMan.1.in:
+ documented printdebug, refresh, searchback and searchforward builtin
+ commands.
+ fixed typos.
+
+ * FvwmIconMan/FvwmIconMan.c (main):
+ changed ifdef from ELECTRIC_FENCE to HAVE_LIBEFENCE.
+ removed now useless 'ifdef DEBUG_ATTACH' construction with hardcoded
+ paths.
+ removed now useless 'if 0' construction.
+ (PrintMemuse):
+ fixed compiler warning.
+
+ * FvwmIconMan/FvwmIconMan.h:
+ changed ifdef from DMALLOC to HAVE_DMALLOC_H.
+
+ * FvwmIconMan/debug.c (ConsoleDebug):
+ * FvwmIconMan/globals.c (print_managers):
+ * FvwmIconMan/readconfig.c (parse_format_dependencies):
+ (print_args):
+ (print_binding):
+ * FvwmIconMan/winlist.c (iconmanager_show):
+ * FvwmIconMan/xmanager.c (check_managers_consistency):
+ (print_button_info):
+ changed ifdefs from PRINT_DEBUG to FVWM_DEBUG_MSGS.
+
+ * FvwmIconMan/debug.h:
+ removed now useless 'if 0' construction.
+
+ * FvwmIconMan/debuglevels.h:
+ fixed typo.
+
+ * FvwmIconMan/functions.c (builtin_gotomanager):
+ fixed typo in debug message.
+
+ * FvwmIconMan/globals.c:
+ removed useless commented definitions of Module ModuleLen which now
+ aren't hardcoded.
+
+ * FvwmIconMan/readconfig.c:
+ removed ancient 'if FVWM_VERSION == 1' construction.
+ (print_binding):
+ compilation fix.
+ fixed compiler warnings.
+
+ * FvwmIconMan/xmanager.c (print_buttons):
+ removed (this function defined but isn't used anywhere in the
+ code and its functionality superseded by print_button_info
+ function).
+ fixed compiler warnings.
+ (print_button_info):
+ fixed compiler warnings.
+
2006-08-05 Serge Koksharov gentoosiast dog yandex dot ru
* FvwmIconMan/FvwmIconMan.1.in:
diff -Naur fvwmCVS-orig/modules/FvwmIconMan/debug.c
fvwmCVS-fixed/modules/FvwmIconMan/debug.c
--- fvwmCVS-orig/modules/FvwmIconMan/debug.c2006-08-07 11:54:29.0
+0400
+++ fvwmCVS-fixed/modules/FvwmIconMan/debug.c 2006-08-07 15:25:18.0
+0400
@@ -60,7 +60,7 @@
{
assert(console != NULL);
-#ifdef PRINT_DEBUG
+#ifdef FVWM_DEBUG_MSGS
if (flag)
{
va_list args;
diff -Naur fvwmCVS-orig/modules/FvwmIconMan/debug.h
fvwmCVS-fixed/modules/FvwmIconMan/debug.h
--- fvwmCVS-orig/modules/FvwmIconMan/debug.h2006-08-07 11:54:29.0
+0400
+++ fvwmCVS-fixed/modules/FvwmIconMan/debug.h 2006-08-07 15:26:52.0
+0400
@@ -3,10 +3,6 @@
#define IN_DEBUG_H
#if 0
-# define PRINT_DEBUG
-#endif
-
-#if 0
# define OUTPUT_FILE /dev/console
/* # define OUTPUT_FILE /tmp/FvwmIconMan */
#else
diff -Naur fvwmCVS-orig/modules/FvwmIconMan/debuglevels.h
fvwmCVS-fixed/modules/FvwmIconMan/debuglevels.h
--- fvwmCVS-orig/modules/FvwmIconMan/debuglevels.h 2006-08-07
11:54:29.0 +0400
+++ fvwmCVS-fixed/modules/FvwmIconMan/debuglevels.h 2006-08-07
20:59:42.0 +0400
@@ -9,7 +9,7 @@
/* I'm finding lots of the debugging is dereferencing pointers
to zero. I fixed some of them, until I grew tired of the game.
- If you want to turn these back on, be perpared for lots of core
+ If you want to turn these back on, be prepared for lots of core
dumps. dje 11/15/98. */
int CORE = 0;
int FUNCTIONS = 0;
diff -Naur fvwmCVS-orig/modules/FvwmIconMan/functions.c
fvwmCVS-fixed/modules/FvwmIconMan/functions.c
--- fvwmCVS-orig/modules/FvwmIconMan/functions.c2006-08-07
11:54:29.0 +0400
+++ fvwmCVS-fixed/modules/FvwmIconMan/functions.c 2006-08-07
13:51:25.0 +0400
@@ -221,7 +221,7 @@
case SelectButton:
case FocusButton:
ConsoleMessage(
- gotomanger: \select\ or \focus\ does not specify
+ gotomanager: \select\ or \focus\ does not specify
a manager\n);
break;
diff -Naur fvwmCVS-orig/modules/FvwmIconMan/FvwmIconMan.1.in
fvwmCVS-fixed/modules/FvwmIconMan/FvwmIconMan.1.in
--- fvwmCVS-orig/modules/FvwmIconMan/FvwmIconMan.1.in 2006-08-07
11:54:29.0 +0400
+++ fvwmCVS-fixed/modules/FvwmIconMan/FvwmIconMan.1.in 2006-08-07
20:40:43.0 +0400
@@ -101,7 +101,7 @@
Font
