Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

[Jaimos Skriletz]

On Sun, Jan 15, 2017 at 10:10 PM, Jaimos Skriletz
 wrote:
> On Sun, Jan 15, 2017 at 8:44 PM, Jaimos Skriletz
>  wrote:
>> On Wed, Dec 28, 2016 at 3:16 AM, Dominik Vogt  wrote:
>>> On Tue, Dec 27, 2016 at 05:34:08PM -0700, Jaimos Skriletz wrote:
 On Tue, Dec 27, 2016 at 5:28 PM, Jaimos Skriletz
  wrote:
 > On Tue, Dec 27, 2016 at 5:15 PM, Dominik Vogt  
 > wrote:
 >> On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
 >>> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
 >>>  wrote:
 >>> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  
 >>> > wrote:
 >>> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
 >>> >>> Hello,
 >>> >>>
 >>> >>> This was reported by a Debian user. Please retain the CC to
 >>> >>> 849355-forwar...@bugs.debian.org in your response, so that
 >>> >>> the Debian BTS has a record.
 >>> >>>
 >>> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr 
 >>> >>> when
 >>> >>> opening and closing windows. I too have had this issue in 2.6.7 
 >>> >>> (and
 >>> >>> previous versions) so I can also say it affects my Debian system.
 >>> >>
>>> Fixed on the (new) fvwm2-stable branch; patch for the development
>>> branches will follow one I've figured out how to deal with the
>>> two repositories.
>>>
>>
>
> I'm also getting these errors from other applications. I will remove
> the patches and see if the behvior goes back to the way it was, or if
> there is something else in my system causing fvwm to output these
> warnings. Here is one from a vim window.
>

After further investigation these new warnings do not seem related to
the original bug as they occur with or without the patches in
question. If I remove the patches I get the old behavior back. And
without the patches I still get gvim and other windows giving
warnings. I wonder if there is something new going on on my system in
the other applications causing these warnings or if they were there
before, I just didn't notice in the spam of the ones from FvwmIconMan.

Anyways thanks again for your help on this.

jaimos

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

[Dominik Vogt]

On Tue, Dec 27, 2016 at 05:34:08PM -0700, Jaimos Skriletz wrote:
> On Tue, Dec 27, 2016 at 5:28 PM, Jaimos Skriletz
>  wrote:
> > On Tue, Dec 27, 2016 at 5:15 PM, Dominik Vogt  wrote:
> >> On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
> >>> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
> >>>  wrote:
> >>> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  
> >>> > wrote:
> >>> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
> >>> >>> Hello,
> >>> >>>
> >>> >>> This was reported by a Debian user. Please retain the CC to
> >>> >>> 849355-forwar...@bugs.debian.org in your response, so that
> >>> >>> the Debian BTS has a record.
> >>> >>>
> >>> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
> >>> >>> opening and closing windows. I too have had this issue in 2.6.7 (and
> >>> >>> previous versions) so I can also say it affects my Debian system.
> >>> >>
> >>> >>
> >>> >> I don't get any such messages with or without FvwmIconMan.  Can
> >>> >> you give detailed instructions pelase?
> >>> >>
> >>> >
> >>> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
> >>> > patches, but I will compile a version without patches and test.
> >>> >
> >>>
> >>> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
> >>> same issue.
> >>>
> >>> >
> >>> > I tested this with other windows and modules. FvwmScript modules
> >>> > seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
> >>> > do with transient windows or not (just something I noticed).
> >>> >
> >>>
> >>> Nevermind this, FvwmIdentify is not a traisnent window, the reason it
> >>> was not producing the warning was it was configured so FvwmIconMan did
> >>> not create a button for that window.
> >>>
> >>> After further testing the warning seems to be due to be caused by
> >>> adding/removing the button for a window from FvwmIconMan. Windows that
> >>> appear there trigger the warning but ones that don't appear don't.
> >>
> >> Still no luck to reproduce it.  After said message there should
> >> always be this one which prints all the details of the window and
> >> the faulty hints:
> >>
> >> fvwm_msg(
> >> WARN, "GetWindowSizeHints",
> >> "The application window (id %#lx)\n"
> >> "  \"%s\" has broken size hints (%s).\n"
> >> "fvwm is ignoring those hints.  "
> >> "  hint override = %d, flags = %lx\n"
> >> "  min_width = %d, min_height = %d, "
> >> "max_width = %d, max_height = %d\n"
> >> "  width_inc = %d, height_inc = %d\n"
> >> "  min_aspect = %d/%d, max_aspect = %d/%d\n"
> >> "  base_width = %d, base_height = %d\n"
> >> "  win_gravity = %d\n",
> >>
> >
> > I get no other output after the warning, so that message is never
> > printed to stderr on my system.
> >
> > Unsure if this helps, but I did enable BugOpts DebugCRMotionMethod,
> > and get the output
> >
> > _cdim: not moved 0x55927d4a8990 'FvwmIconMan'
> >
> > after each time the warning is produced.
> 
> Further testing, if I set the ManagerGeometry to something like 5x3 so
> FvwmIconMan doesn't resize itself, I no longer get the warning. It is
> only with the default like 0x1, causing the window to grow/shrink I
> get the warning.

Could be reproduced with a standalone FvwmIconMan (instead of the
one inside FvwmButtons).

> Wild guess, could it be some timing issue during the resizing of the
> window when adding/removing a button cause the window's current size
> to become invalid as per the warning?

Roughly, yes.  FvwmIconMan sets the minimum and maximum width and
height size hints to the new geometry it wants, then requests the
new size.  When fvwm reads the new hints, the current geometry of
the manager window becomes obviously invalid until the window is
also resized.  That's what triggers the warning.

So, to fix this:

1. Remove the size restrictions, then resize, then set the new
   size restrictions.  Theoretically the winodw might be resized
   by the user in between, but that's highly unlikely.

2. Also print the size hints that trigger this warning in a second
   message.

Fixed on the (new) fvwm2-stable branch; patch for the development
branches will follow one I've figured out how to deal with the
two repositories.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

[Jaimos Skriletz]

On Tue, Dec 27, 2016 at 5:28 PM, Jaimos Skriletz
 wrote:
> On Tue, Dec 27, 2016 at 5:15 PM, Dominik Vogt  wrote:
>> On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
>>> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
>>>  wrote:
>>> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
>>> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>>> >>> Hello,
>>> >>>
>>> >>> This was reported by a Debian user. Please retain the CC to
>>> >>> 849355-forwar...@bugs.debian.org in your response, so that
>>> >>> the Debian BTS has a record.
>>> >>>
>>> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>>> >>> opening and closing windows. I too have had this issue in 2.6.7 (and
>>> >>> previous versions) so I can also say it affects my Debian system.
>>> >>
>>> >>
>>> >> I don't get any such messages with or without FvwmIconMan.  Can
>>> >> you give detailed instructions pelase?
>>> >>
>>> >
>>> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
>>> > patches, but I will compile a version without patches and test.
>>> >
>>>
>>> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
>>> same issue.
>>>
>>> >
>>> > I tested this with other windows and modules. FvwmScript modules
>>> > seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
>>> > do with transient windows or not (just something I noticed).
>>> >
>>>
>>> Nevermind this, FvwmIdentify is not a traisnent window, the reason it
>>> was not producing the warning was it was configured so FvwmIconMan did
>>> not create a button for that window.
>>>
>>> After further testing the warning seems to be due to be caused by
>>> adding/removing the button for a window from FvwmIconMan. Windows that
>>> appear there trigger the warning but ones that don't appear don't.
>>
>> Still no luck to reproduce it.  After said message there should
>> always be this one which prints all the details of the window and
>> the faulty hints:
>>
>> fvwm_msg(
>> WARN, "GetWindowSizeHints",
>> "The application window (id %#lx)\n"
>> "  \"%s\" has broken size hints (%s).\n"
>> "fvwm is ignoring those hints.  "
>> "  hint override = %d, flags = %lx\n"
>> "  min_width = %d, min_height = %d, "
>> "max_width = %d, max_height = %d\n"
>> "  width_inc = %d, height_inc = %d\n"
>> "  min_aspect = %d/%d, max_aspect = %d/%d\n"
>> "  base_width = %d, base_height = %d\n"
>> "  win_gravity = %d\n",
>>
>
> I get no other output after the warning, so that message is never
> printed to stderr on my system.
>
> Unsure if this helps, but I did enable BugOpts DebugCRMotionMethod,
> and get the output
>
> _cdim: not moved 0x55927d4a8990 'FvwmIconMan'
>
> after each time the warning is produced.

Further testing, if I set the ManagerGeometry to something like 5x3 so
FvwmIconMan doesn't resize itself, I no longer get the warning. It is
only with the default like 0x1, causing the window to grow/shrink I
get the warning.

Wild guess, could it be some timing issue during the resizing of the
window when adding/removing a button cause the window's current size
to become invalid as per the warning?

jaimos

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

[Jaimos Skriletz]

On Tue, Dec 27, 2016 at 5:15 PM, Dominik Vogt  wrote:
> On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
>> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
>>  wrote:
>> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
>> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>> >>> Hello,
>> >>>
>> >>> This was reported by a Debian user. Please retain the CC to
>> >>> 849355-forwar...@bugs.debian.org in your response, so that
>> >>> the Debian BTS has a record.
>> >>>
>> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>> >>> opening and closing windows. I too have had this issue in 2.6.7 (and
>> >>> previous versions) so I can also say it affects my Debian system.
>> >>
>> >>
>> >> I don't get any such messages with or without FvwmIconMan.  Can
>> >> you give detailed instructions pelase?
>> >>
>> >
>> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
>> > patches, but I will compile a version without patches and test.
>> >
>>
>> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
>> same issue.
>>
>> >
>> > I tested this with other windows and modules. FvwmScript modules
>> > seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
>> > do with transient windows or not (just something I noticed).
>> >
>>
>> Nevermind this, FvwmIdentify is not a traisnent window, the reason it
>> was not producing the warning was it was configured so FvwmIconMan did
>> not create a button for that window.
>>
>> After further testing the warning seems to be due to be caused by
>> adding/removing the button for a window from FvwmIconMan. Windows that
>> appear there trigger the warning but ones that don't appear don't.
>
> Still no luck to reproduce it.  After said message there should
> always be this one which prints all the details of the window and
> the faulty hints:
>
> fvwm_msg(
> WARN, "GetWindowSizeHints",
> "The application window (id %#lx)\n"
> "  \"%s\" has broken size hints (%s).\n"
> "fvwm is ignoring those hints.  "
> "  hint override = %d, flags = %lx\n"
> "  min_width = %d, min_height = %d, "
> "max_width = %d, max_height = %d\n"
> "  width_inc = %d, height_inc = %d\n"
> "  min_aspect = %d/%d, max_aspect = %d/%d\n"
> "  base_width = %d, base_height = %d\n"
> "  win_gravity = %d\n",
>

I get no other output after the warning, so that message is never
printed to stderr on my system.

Unsure if this helps, but I did enable BugOpts DebugCRMotionMethod,
and get the output

_cdim: not moved 0x55927d4a8990 'FvwmIconMan'

after each time the warning is produced.

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

[Dominik Vogt]

On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote:
> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
>  wrote:
> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
> >>> Hello,
> >>>
> >>> This was reported by a Debian user. Please retain the CC to
> >>> 849355-forwar...@bugs.debian.org in your response, so that
> >>> the Debian BTS has a record.
> >>>
> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
> >>> opening and closing windows. I too have had this issue in 2.6.7 (and
> >>> previous versions) so I can also say it affects my Debian system.
> >>
> >>
> >> I don't get any such messages with or without FvwmIconMan.  Can
> >> you give detailed instructions pelase?
> >>
> >
> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
> > patches, but I will compile a version without patches and test.
> >
> 
> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
> same issue.
> 
> >
> > I tested this with other windows and modules. FvwmScript modules
> > seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
> > do with transient windows or not (just something I noticed).
> >
> 
> Nevermind this, FvwmIdentify is not a traisnent window, the reason it
> was not producing the warning was it was configured so FvwmIconMan did
> not create a button for that window.
> 
> After further testing the warning seems to be due to be caused by
> adding/removing the button for a window from FvwmIconMan. Windows that
> appear there trigger the warning but ones that don't appear don't.

Still no luck to reproduce it.  After said message there should
always be this one which prints all the details of the window and
the faulty hints:

fvwm_msg(
WARN, "GetWindowSizeHints",
"The application window (id %#lx)\n"
"  \"%s\" has broken size hints (%s).\n"
"fvwm is ignoring those hints.  "
"  hint override = %d, flags = %lx\n"
"  min_width = %d, min_height = %d, "
"max_width = %d, max_height = %d\n"
"  width_inc = %d, height_inc = %d\n"
"  min_aspect = %d/%d, max_aspect = %d/%d\n"
"  base_width = %d, base_height = %d\n"
"  win_gravity = %d\n",

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

[Jaimos Skriletz]

On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz
 wrote:
> On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
>> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>>> Hello,
>>>
>>> This was reported by a Debian user. Please retain the CC to
>>> 849355-forwar...@bugs.debian.org in your response, so that
>>> the Debian BTS has a record.
>>>
>>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>>> opening and closing windows. I too have had this issue in 2.6.7 (and
>>> previous versions) so I can also say it affects my Debian system.
>>
>>
>> I don't get any such messages with or without FvwmIconMan.  Can
>> you give detailed instructions pelase?
>>
>
> Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
> patches, but I will compile a version without patches and test.
>

Tested with a fresh compile of Fvwm 2.6.7 without any debian patches,
same issue.

>
> I tested this with other windows and modules. FvwmScript modules
> seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
> do with transient windows or not (just something I noticed).
>

Nevermind this, FvwmIdentify is not a traisnent window, the reason it
was not producing the warning was it was configured so FvwmIconMan did
not create a button for that window.

After further testing the warning seems to be due to be caused by
adding/removing the button for a window from FvwmIconMan. Windows that
appear there trigger the warning but ones that don't appear don't.

jaimos

Re: Fwd: Bug#849355: fvwm: GetWindowSizeHints warnings when windows and opened and closed

[Jaimos Skriletz]

On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt  wrote:
> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote:
>> Hello,
>>
>> This was reported by a Debian user. Please retain the CC to
>> 849355-forwar...@bugs.debian.org in your response, so that
>> the Debian BTS has a record.
>>
>> In short when running FvwmIconMan, fvwm prints warnings to stderr when
>> opening and closing windows. I too have had this issue in 2.6.7 (and
>> previous versions) so I can also say it affects my Debian system.
>
>
> I don't get any such messages with or without FvwmIconMan.  Can
> you give detailed instructions pelase?
>

Using Fvwm 2.6.7 Debian package, doubt it is any of the debian
patches, but I will compile a version without patches and test.

Run FvwnIconMan by itself with no configuration, so FvwmIconMan is in
its own window (if FvwmIconMan was swallowed in FvwmButtons I did not
notice this warning).

Once FvwmIconMan is running, run xterm, warning appears, close xterm,
warning appears again.

I tested this with other windows and modules. FvwmScript modules
seemed to trigger it, FvwmIdentify did not, so I wonder if it has to
do with transient windows or not (just something I noticed).

If you are not able to reproduce this wonder if it is something
specific with Debian's xserver, let me know what other output you
would want.

jaimos