Re: [PATCH master 07/52] More reshuffling of code

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: Following the split Types/BasicTypes, we can remove the last JSON-related stuff from Utils.hs, and do some more cleanup. ---  htools/Ganeti/BasicTypes.hs   |    6 ++  htools/Ganeti/HTools/JSON.hs  |   12  

Re: [PATCH master 08/52] Stop exporting JSON functionality from Utils.hs

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This completes the Utils/JSON split started in commit f047f90f. The import graph should be cleaner now. ---  htools/Ganeti/HTools/IAlloc.hs |    2 +-  htools/Ganeti/HTools/Luxi.hs   |    3 +--  htools/Ganeti/HTools/QC.hs     |

Re: [PATCH master 09/52] Add object definitions for the ispec and ipolicy

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: ---  htools/Ganeti/HTools/Types.hs |   22 +-  htools/Ganeti/THH.hs          |   10 +-  2 files changed, 26 insertions(+), 6 deletions(-) I'm never used template Haskell or anything related to it, but

Re: [PATCH master 10/52] Improve convert-constants to handle dictionaries

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: The two main drawbacks for convert-constants are the fact that it can't handle sets/frozensets (mainly due to the fact that I don't know how useful this would be to the Haskell code) and that it cannot export dictionaries. To

Re: [PATCH master 11/52] More improvements to convert-constants

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This prepares for tuple and other conversions. ---  autotools/convert-constants |   41 ++---  1 files changed, 26 insertions(+), 15 deletions(-) LGTM. René

Re: [PATCH master 12/52] Add support for tuples in convert-constants

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: ---  autotools/convert-constants |   11 +++  1 files changed, 11 insertions(+), 0 deletions(-) LGTM. René

Re: [PATCH master 13/52] Add support for lists/frozensets in convert-constants

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: Unfortunately, we only support lists of simple types, and not even lists of tuples. If we actually needed those, it would be possible to implement them, with a bit more complexity in the converter. ---  

Re: [PATCH master 14/52] Add support for RE patterns to convert constants

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This is a trivial conversion. ---  autotools/convert-constants |   10 ++  1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/autotools/convert-constants b/autotools/convert-constants index 89f9f00..ae36774

Re: [PATCH master 15/52] Add default ipolicy declarations

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: ---  htools/Ganeti/HTools/Types.hs |   35 +++  1 files changed, 35 insertions(+), 0 deletions(-) LGTM. René

Re: [PATCH master 16/52] Extend ClusterData with the cluster instance policy

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This attribute is always initialised to the default, and is not (yet) read/saved in the various backends. ---  htools/Ganeti/HTools/IAlloc.hs         |    4 ++--  htools/Ganeti/HTools/Loader.hs         |    4 +++-  

Re: [PATCH master 17/52] Load cluster ipolicy via Luxi

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: Also show it in hbal's verbose output (helpful for debugging). ---  htools/Ganeti/HTools/Luxi.hs         |   16 ++--  htools/Ganeti/HTools/Program/Hbal.hs |    5 +++--  2 files changed, 13 insertions(+), 8

Re: [PATCH master 3/4] set-mem rapi and tests

2012-01-11 Thread Iustin Pop
On Tue, Jan 10, 2012 at 06:28:51PM +, Guido Trotter wrote: We still need --running-mem: this is meant for ballooning without changing min and max, which are the only values we currently save. Guid, can you confirm this is correct? - we have min/max mem, which are config values - we have

Re: [PATCH master 09/52] Add object definitions for the ispec and ipolicy

2012-01-11 Thread Iustin Pop
On Wed, Jan 11, 2012 at 10:17:38AM +0100, René Nussbaumer wrote: On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: ---  htools/Ganeti/HTools/Types.hs |   22 +-  htools/Ganeti/THH.hs          |   10 +-  2 files changed, 26 insertions(+), 6

Re: [PATCH master 14/52] Add support for RE patterns to convert constants

2012-01-11 Thread Iustin Pop
On Wed, Jan 11, 2012 at 10:51:56AM +0100, René Nussbaumer wrote: On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This is a trivial conversion. ---  autotools/convert-constants |   10 ++  1 files changed, 10 insertions(+), 0 deletions(-) diff --git

Re: [PATCH master 14/52] Add support for RE patterns to convert constants

2012-01-11 Thread René Nussbaumer
On Wed, Jan 11, 2012 at 11:15, Iustin Pop ius...@google.com wrote: On Wed, Jan 11, 2012 at 10:51:56AM +0100, René Nussbaumer wrote: On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This is a trivial conversion. ---  autotools/convert-constants |   10 ++  1 files

Re: [PATCH master 3/4] set-mem rapi and tests

2012-01-11 Thread Guido Trotter
Not exactly. - There is no such thing as min at run time - As for max it cannot be modified without a reboot. So it's all true except the last sentence: we just want a way to modify oper_ram, live. (there is no sense in doing it non-live) Guido On Jan 11, 2012 11:02 AM, Iustin Pop

Re: [PATCH master 3/4] set-mem rapi and tests

2012-01-11 Thread Iustin Pop
On Wed, Jan 11, 2012 at 10:58:54AM +, Guido Trotter wrote: Not exactly. - There is no such thing as min at run time Hmm. Right now (in 2.6) not, but this would have been the value that Xen (or KVM) is allowed to auto-balloon-down the instance. But I might be wrong indeed and there's no

Re: [PATCH master 3/4] set-mem rapi and tests

2012-01-11 Thread Guido Trotter
I think auto_ballooning will go as much as it can. I've seen no minimum there. oper_ram is just the current one, not the minimum, the hypervisor might go lower. I think that min is the minimum ganeti will guarantee to be available (never start instances if all of them are nit guaranteed to have at

Re: [PATCH master 18/52] Update memory/maxmem reading in Rapi backend

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: Recent changes to the instance beparams have replaced memory with maxmem in Rapi bulk queries. Until this is either reverted (for backwards compat) or we decide to go ahead with only maxmem, we change the backend to read both;

Re: [PATCH master 19/52] Load cluster ipolicy via Rapi

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This requires changing from querying the /tags resource to the /info resource. ---  htools/Ganeti/HTools/Rapi.hs |   21 -  1 files changed, 16 insertions(+), 5 deletions(-) LGTM René

Re: [PATCH master 20/52] Abstract creation of instance from a spec

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: ---  htools/Ganeti/HTools/Program/Hspace.hs |   20  1 files changed, 12 insertions(+), 8 deletions(-) LGTM. René

Re: [PATCH master 22/52] Switch hspace defaults to the cluster policy

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This changes from the current hardcoded defaults to the cluster policy. The command line options now override the defaults from the cluster, and the tiered spec mode is always enabled. Also fixes a tiny typo in the man page

Re: [PATCH master 23/52] Fix handling of errors from InstancePolicy.Check...

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This code raises a configuration error, but we need to transform it into a prereq error (or possibly exec error), depending on when we call this function. ---  lib/cmdlib.py |   18 +++---  1 files changed, 15

Re: [okeanos-dev] Re: [RFC master] Implement rbd disk template

2012-01-11 Thread Andrea Spadaccini
Hello Stratos, After fighting with a couple of ceph/rbd bugs, today I managed to set up a fully operational ceph cluster. Instance creation works, but burnin does not: can you please tell me which commit ID did you base your tests on? I want to make sure I debug an RBD issue and not

[PATCH master] Fix acquisition of node lock in LUInstanceGrowDisk

2012-01-11 Thread Constantinos Venetsanopoulos
Ensure node level locks are recalculated properly in LUInstanceGrowDisk. Signed-off-by: Constantinos Venetsanopoulos c...@grnet.gr --- Hello, LUInstanceGrowDisk seems to not recalculate locks properly, leading to this (testing with -t plain): # gnt-instance grow-disk testgrow 0 1g Failure:

Re: [PATCH master 25/52] Add a new disk-template ipolicy option

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: ---  lib/cli.py |    7 +++  1 files changed, 7 insertions(+), 0 deletions(-) This is to spec for allowed disk templates? I wonder how max/min will look like here. The code itself LGTM. René

Re: [PATCH master 26/52] Move the instance specs options to cli.py

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: Currently these are defined twice, instead of a single time in cli.py. Also adds the new disk_templates option to the common block, even though it's not yet used. ---  lib/cli.py                |   11 +++  

Re: [PATCH master 27/52] Remove extraneous check in policy creation

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: The values are already checked in CreateIPolicy, no need to manually check them again. ---  lib/client/gnt_cluster.py |    2 --  lib/client/gnt_group.py   |    3 ---  2 files changed, 0 insertions(+), 5 deletions(-) LGTM.

Re: [PATCH master 28/52] Add new disk_templates parameter to instance policy

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This is a bit more complex patch, as it requires changing the assumption that all keys in the policy dict points to values that are themselves dicts. Right now we introduce an assumption that any non-dicts are lists, we'll see

Re: [RFC master] Implement rbd disk template

2012-01-11 Thread Constantinos Venetsanopoulos
On 01/10/2012 06:17 PM, Andrea Spadaccini wrote: Hello, Introduce the rbd disk template, which handles provisioning and management of instance disks as block devices mapped to rbd volumes on a RADOS cluster. Thanks for sending the patch. After fighting with a couple of ceph/rbd bugs, today I

Re: [PATCH master 25/52] Add a new disk-template ipolicy option

2012-01-11 Thread René Nussbaumer
On Wed, Jan 11, 2012 at 16:13, René Nussbaumer r...@google.com wrote: On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: ---  lib/cli.py |    7 +++  1 files changed, 7 insertions(+), 0 deletions(-) This is to spec for allowed disk templates? I wonder how max/min will look

Re: [PATCH master 29/52] Move DiskTemplate definition around

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This is needed since we'll need the DiskTemplate definition in the IPolicy one. ---  htools/Ganeti/HTools/Types.hs |   22 +++---  1 files changed, 11 insertions(+), 11 deletions(-) This is just a move further

Re: [PATCH master 30/52] Read the disk templates part of the ipolicy

2012-01-11 Thread René Nussbaumer
On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: The default value is badly defined (hardcoded defaults)… ---  htools/Ganeti/HTools/Types.hs |    6 ++  1 files changed, 6 insertions(+), 0 deletions(-) LGTM. René

Re: [PATCH master 26/52] Move the instance specs options to cli.py

2012-01-11 Thread Iustin Pop
On Wed, Jan 11, 2012 at 04:15:01PM +0100, René Nussbaumer wrote: On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: Currently these are defined twice, instead of a single time in cli.py. Also adds the new disk_templates option to the common block, even though it's not yet

Re: [PATCH master 28/52] Add new disk_templates parameter to instance policy

2012-01-11 Thread Iustin Pop
On Wed, Jan 11, 2012 at 04:32:35PM +0100, René Nussbaumer wrote: On Mon, Jan 9, 2012 at 11:58, Iustin Pop ius...@google.com wrote: This is a bit more complex patch, as it requires changing the assumption that all keys in the policy dict points to values that are themselves dicts. Right now