Re: [Geeqie-devel] Geeqie++ fever dreams
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Am Sa den 24. Dez 2016 um 18:18 schrieb Alexander Antimonov: > > - Introduce new bugs (because big rewrites always do) > Sure, but with C++ port we can also simplify code, and less code - less bugs. > Now considerable part of Geeqie's code is plain C which builds UI. > It's a rare method of building UI nowadays. It should be replaced with > something like Glade description. Well, geeqie does not stop you to do some implementations in c++ (see the exiv2 interface). However, there should be someone caring about that parts afterwards. We had several big changes in the past where the main author wrote it and kept the bug hunting to others. I can say that I had to fight with motivation issues due to that. :-( > > - Maybe exclude some core developers who just don't have as much fun in C++ > > as in C > It might be a good chance for them to improve their skills a bit. > > My 5 cents, I prefer do not use love/hate words when it comes to > technical things. I for myself have technical reasons why I dislike C++. And I also have concerns about maintainability. Many times the encapsulating breaks necessary overview. About the UI design. I tried myself once to redo it with glade. However, I dropped it as it just binds so many resources that I can spend for better stuff. But I agree, that a more OO design would help for UI stuff. Other stuff would not gain any improvement and, worse, loose it. So, conclusion, if you have something that can be done in C++ and you want to do it, go ahead. Especially if you stay with the project and maintain that stuff afterwards. :-) But just converting existing logic into C++ for no need would not help I think. Regards Klaus - -- Klaus Ethgen http://www.ethgen.ch/ pub 4096R/4E20AF1C 2011-05-16Klaus EthgenFingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C -BEGIN PGP SIGNATURE- Comment: Charset: ISO-8859-1 iQGyBAEBCgAdFiEEMWF28vh4/UMJJLQEpnwKsYAZ9qwFAlhf86EACgkQpnwKsYAZ 9qzgkQv4qCk1lgxt03Qd3UUGCeNDHr7CiBR74UMbdTXDFDSoRuELEDgHzOJF1vQt oemygjW4nhe/GnzA0EeUbadHIpGGew15Pd4DMLVigRApVuimFLt4OvpMuwS58Qo0 o24jdwc7R5KS0Bvrk4TD+EZXSrmOX3iPwisAt1higs8fRKKwImIebijuW8paqObb AEp+jFG+QrZgCcDTQj2HfroWKBu8PSNeyj9vbfMN9/xXe9QojC8iAh+HF2TgG4IK qlVSWvSShkmibXDSvtIdcxbcUt6TgyQSwHKXVGrUh9cN6EuqK9fLUaUATVjNjWuk cfKt8mox3OjXVHqLp87nfdnCWDkcWqcYLl1fCHVyusGqGhB9xpUqFZE5thIL7EjD BHmyb/Gebko3J1ghI9smAapnlIVDM4zLSXEnEtrXPayV1zxL35bIu+vWE5R6frVj 3TS2YMzZ98P+W1a5AqkCUuw7C6kwtgy69k0F72kKAzsIbFYmXsCaIk3KRWonn6/O 6zDzaWw= =bS1x -END PGP SIGNATURE- -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Geeqie coding standards? Third edition :o)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Folks, Am Sa den 24. Dez 2016 um 15:43 schrieb Ian Zimmerman: > I use Emacs. I do not know any of emacs and how to customize it depending on the file/projects. I would even not voluntary start emacs. ;-) > - I strongly prefer spaces only indentation That could be agreed with, I think. > - I too prefer K ish style (opening brace after keyword on the same > line) See my follow up mail. I muddled the two. > - I think it's helpful to code function declarations and calls like this: > > int > foo_func (long arg) > { > call_to_bar(arg); > } That's what I meat. Most often it is really important to have the opening and closing braced on the same column. > I mean in particular the hoisting of the return type on its own line, That I don't need but have no oportunity against. > - I am actually pretty religious about keeping to 80 chars per line. When it comes to religious matter with styles I learned from many projects that this is mostly wrong and could even kill projects. As I said, I do not like this 80 column limit. It makes no sense anymore and I had troubles several times with intermixing with editor line breaks. So better let the editor do the (virtual) breaks/wraps. Am Sa den 24. Dez 2016 um 19:53 schrieb Omari Stephens: > I agree with everything you just said. But my terminal is 190 columns > wide, and when I see lines wrapping just because the author didn't > bother to put a single newline in there, it's a problem. That could be.. > I think we could easily say "no lines longer than 160 chars" without > incurring most of the downsides that you're bringing up. That might be a good compromise. However, I would rather see that as "soft" limit. Regards Klaus - -- Klaus Ethgen http://www.ethgen.ch/ pub 4096R/4E20AF1C 2011-05-16Klaus EthgenFingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C -BEGIN PGP SIGNATURE- Comment: Charset: ISO-8859-1 iQGzBAEBCgAdFiEEMWF28vh4/UMJJLQEpnwKsYAZ9qwFAlhf8GUACgkQpnwKsYAZ 9qwIcwv+JB9gMyyqcid06j1NiLrsPzDeKoe0lbaE0awh1iL7PYv8hTM9kl0i98gR 8t7J0da4c9G4t6NUqyI5ryeZ9HkJHOVmCqBP1vLzrm6ZJHafQn+VqETcVU80MCxO vDQi2I7lG22G3MRaLwyGDHUT1uE8df7v/7E1zNrJvRMaZKV56ImNq8dBzukIHPCL EPTvjToAPKuuRlLvbsS7ayhnG6jeRJZDknJue/GR6qRmqNDY4q1gXLOmGzXf42Q1 5MQdLGTe0sWWGBU3XAqXesNBRAggvFtcFtJ3XPb5Nj7b46z/3rshb5wqrckT6peL pwv5xa0YB6ExsUM6KyTyVFo+2nj4gRjHUoP+JeaqciTaxM9cKl1PSCJPcSn86iyP PdzkK/AnrsSRRCLuPnSxR601sSXmXT5GsUzEsUduxvi5UntgbYugm9Dp6WOrpCTC Q4z4QQ+psrbx887hmWI3f8gvrsqFGFudjNXN/00Au0cX/Mi9ZQrxULsk5i33ADTG t00LkxIk =ctza -END PGP SIGNATURE- -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel