Re: [Geotools-devel] Thinking about static analysis

2018-12-24 Thread fernando.m...@geo-solutions.it
I think it can be pretty useful, I had a good experience fixing code with old findbugs (now spotbugs) years ago but you're right it can be hard to manage. I'll be glad to give a hand. Regards, Fernando Mino == GeoServer Professional Services from the experts! Visit

Re: [Geotools-devel] Thinking about static analysis

2018-12-24 Thread Ian Turton
Sounds good to me, I'm a little tied up just now, but I might be able to help later. Ian On Mon, 24 Dec 2018, 15:38 Andrea Aime Hi all, > I was wondering if it might be time, and or it might be useful, to add > some static code analysis in our build > chain, as a profile that build servers can

Re: [Geotools-devel] Thinking about static analysis

2018-12-24 Thread Kurt Schwehr
I can help a little bit with fixing ErrorProne issues as I am already seeing them some with bazel builds On Mon, Dec 24, 2018 at 9:53 AM Ian Turton wrote: > Sounds good to me, I'm a little tied up just now, but I might be able to > help later. > > Ian > > On Mon, 24 Dec 2018, 15:38 Andrea Aime

Re: [Geotools-devel] Thinking about static analysis

2018-12-24 Thread bradh
+1: I’m always happy to have tools help me get things right. The other tool I’ve seen, but not tried yet, is Infer (https://fbinfer.com/) I had a look at the PMD branch, but it says “This branch is even with geotools:master.” – did you push? Brad