[PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-08 Thread Stefan Beller
A user reported a submodule issue regarding a section mix-up, but it could be boiled down to the following test case: $ git init test && cd test $ git config foo."Bar".key test $ git config foo."bar".key test $ tail -n 3 .git/config [foo "Bar"] key = test key = test

Re: [PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-03 Thread Junio C Hamano
Stefan Beller writes: > And *technically* the two level is old style, so I figured it's ok. If we call the bit not after the recentness of the style but after what it is about, e.g. "is the section name as a whole (including its possible subsection part) case insensitive?", then yes, a

[PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-02 Thread Stefan Beller
A user reported a submodule issue regarding a section mix-up, but it could be boiled down to the following test case: $ git init test && cd test $ git config foo."Bar".key test $ git config foo."bar".key test $ tail -n 3 .git/config [foo "Bar"] key = test key = test

Re: [PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-02 Thread Stefan Beller
On Wed, Aug 1, 2018 at 3:51 PM Junio C Hamano wrote: > > Stefan Beller writes: > > > A use reported a submodule issue regarding strange case indentation > > issues, but it could be boiled down to the following test case: > > Perhaps > > s/use/user/ > s/case indentation issues/section mix-up/

Re: [PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-01 Thread Junio C Hamano
Stefan Beller writes: > A use reported a submodule issue regarding strange case indentation > issues, but it could be boiled down to the following test case: Perhaps s/use/user/ s/case indentation issues/section mix-up/ > ... However we do not have a test for writing out config correctly with

Re: [PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-01 Thread Junio C Hamano
Ramsay Jones writes: > On 01/08/18 20:34, Stefan Beller wrote: >> A use reported a submodule issue regarding strange case indentation > > s/use/user/ ? True. Also s/indentation/something else/ ? Insufficient proofreading, perhaps?

Re: [PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-01 Thread Ramsay Jones
On 01/08/18 20:34, Stefan Beller wrote: > A use reported a submodule issue regarding strange case indentation s/use/user/ ? ATB, Ramsay Jones

[PATCH 2/3] config: fix case sensitive subsection names on writing

2018-08-01 Thread Stefan Beller
A use reported a submodule issue regarding strange case indentation issues, but it could be boiled down to the following test case: $ git init test && cd test $ git config foo."Bar".key test $ git config foo."bar".key test $ tail -n 3 .git/config [foo "Bar"] key = test

Re: [PATCH 2/3] config: fix case sensitive subsection names on writing

2018-07-31 Thread Junio C Hamano
Stefan Beller writes: > A use reported a submodule issue regarding strange case indentation > issues, but it could be boiled down to the following test case: > > $ git init test && cd test > $ git config foo."Bar".key test > $ git config foo."bar".key test > $ tail -n 3 .git/config >

[PATCH 2/3] config: fix case sensitive subsection names on writing

2018-07-30 Thread Stefan Beller
A use reported a submodule issue regarding strange case indentation issues, but it could be boiled down to the following test case: $ git init test && cd test $ git config foo."Bar".key test $ git config foo."bar".key test $ tail -n 3 .git/config [foo "Bar"] key = test