Re: [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-06 Thread Stepan Kasal
Hi, On Thu, Jun 05, 2014 at 11:44:22PM +0200, Karsten Blees wrote: I think the most time-preserving option is to send it upstream as unchanged as possible (probably with the bugfix-patches squashed). I plan to submit one by one or in a small series. Agreed about the squashes, I have several of

[PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Stepan Kasal
From: Johannes Schindelin johannes.schinde...@gmx.de Date: Wed, 2 Jun 2010 00:41:33 +0200 If HOME is not set, use $HOMEDRIVE$HOMEPATH Signed-off-by: Johannes Schindelin johannes.schinde...@gmx.de Signed-off-by: Stepan Kasal ka...@ucw.cz --- Hello Karsten, thanks for your explanation. There are

Re: [msysGit] [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Torsten Bögershausen
On 2014-06-05 10.03, Stepan Kasal wrote: From: Johannes Schindelin johannes.schinde...@gmx.de Date: Wed, 2 Jun 2010 00:41:33 +0200 If HOME is not set, use $HOMEDRIVE$HOMEPATH Signed-off-by: Johannes Schindelin johannes.schinde...@gmx.de Signed-off-by: Stepan Kasal ka...@ucw.cz ---

Re: [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Karsten Blees
Am 05.06.2014 10:03, schrieb Stepan Kasal: From: Johannes Schindelin johannes.schinde...@gmx.de Date: Wed, 2 Jun 2010 00:41:33 +0200 If HOME is not set, use $HOMEDRIVE$HOMEPATH Signed-off-by: Johannes Schindelin johannes.schinde...@gmx.de Signed-off-by: Stepan Kasal ka...@ucw.cz ---

Re: [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Erik Faye-Lund
On Thu, Jun 5, 2014 at 11:40 AM, Karsten Blees karsten.bl...@gmail.com wrote: Am 05.06.2014 10:03, schrieb Stepan Kasal: From: Johannes Schindelin johannes.schinde...@gmx.de Date: Wed, 2 Jun 2010 00:41:33 +0200 If HOME is not set, use $HOMEDRIVE$HOMEPATH Signed-off-by: Johannes Schindelin

Re: [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Stepan Kasal
Hello, On Thu, Jun 05, 2014 at 11:40:50AM +0200, Karsten Blees wrote: Am 05.06.2014 10:03, schrieb Stepan Kasal: I hope you can ack this patch as a step forward. No, not really. It's sure better than introducing a special get_home_directory(), but it still increases the diff between

Re: [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Johannes Schindelin
Hi Karsten, On Thu, 5 Jun 2014, Karsten Blees wrote: Am 05.06.2014 10:03, schrieb Stepan Kasal: * even if $HOME was empty, git should setenv(HOME) so that child processes can benefit from it (similar to TMPDIR and TERM in current msysgit's mingw_startup()). Not setting $HOME because it

Re: [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Karsten Blees
Am 05.06.2014 15:39, schrieb Johannes Schindelin: And in particular with your changes to Unicodify the complete environment, I am *highly* doubtful that child processes will be able to handle themselves properly, unless we spend a whole lot of time converting back and forth the environment

Re: [PATCH v2] Add a Windows-specific fallback to getenv(HOME);

2014-06-05 Thread Karsten Blees
Am 05.06.2014 11:58, schrieb Erik Faye-Lund: On Thu, Jun 5, 2014 at 11:40 AM, Karsten Blees karsten.bl...@gmail.com wrote: Am 05.06.2014 10:03, schrieb Stepan Kasal: From: Johannes Schindelin johannes.schinde...@gmx.de Date: Wed, 2 Jun 2010 00:41:33 +0200 If HOME is not set, use