Re: reftable [v3]: new ref storage format

2017-07-28 Thread Shawn Pearce
On Fri, Jul 28, 2017 at 7:18 PM, Michael Haggerty wrote: > On Fri, Jul 28, 2017 at 3:12 PM, Shawn Pearce wrote: >> I'm with you this far, and like the {min,max}_update_index in the >> header. I'm concerned about update_index in 32 bits. At some point

Re: reftable [v3]: new ref storage format

2017-07-28 Thread Michael Haggerty
On Fri, Jul 28, 2017 at 3:12 PM, Shawn Pearce wrote: > I'm with you this far, and like the {min,max}_update_index in the > header. I'm concerned about update_index in 32 bits. At some point you > need to reset the counter, or the repository is broken. 4b updates is > enough

Re: reftable [v3]: new ref storage format

2017-07-28 Thread Shawn Pearce
On Thu, Jul 27, 2017 at 7:28 AM, Michael Haggerty wrote: > On Sat, Jul 22, 2017 at 11:29 AM, Shawn Pearce wrote: >> 3rd iteration of the reftable storage format. >> >> [...] >> ### Objectives >> >> - Near constant time lookup for any single reference,

Re: reftable [v3]: new ref storage format

2017-07-27 Thread Michael Haggerty
Thanks for your continued work on this. I have some comments about v3 (inline below). On Sat, Jul 22, 2017 at 11:29 AM, Shawn Pearce wrote: > 3rd iteration of the reftable storage format. > > [...] > ### Objectives > > - Near constant time lookup for any single reference,

Re: reftable [v3]: new ref storage format

2017-07-27 Thread Stefan Beller
On Mon, Jul 24, 2017 at 4:00 PM, Shawn Pearce wrote: > On Mon, Jul 24, 2017 at 3:22 PM, Stefan Beller wrote: >>> index record >>> >>> An index record describes the last entry in another block. >>> Index records are written as: >>> >>> varint(

Re: reftable [v3]: new ref storage format

2017-07-24 Thread Shawn Pearce
On Mon, Jul 24, 2017 at 3:22 PM, Stefan Beller wrote: > On Sat, Jul 22, 2017 at 11:29 AM, Shawn Pearce wrote: >> 3rd iteration of the reftable storage format. >> >> You can read a rendered version of this here: >>

Re: reftable [v3]: new ref storage format

2017-07-24 Thread Stefan Beller
On Sat, Jul 22, 2017 at 11:29 AM, Shawn Pearce wrote: > 3rd iteration of the reftable storage format. > > You can read a rendered version of this here: > https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md > > Significant changes from v2:

Re: reftable [v3]: new ref storage format

2017-07-23 Thread Ævar Arnfjörð Bjarmason
On Sat, Jul 22, 2017 at 8:29 PM, Shawn Pearce wrote: > 3rd iteration of the reftable storage format. > > You can read a rendered version of this here: > https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md > > Significant changes from v2:

Re: reftable [v3]: new ref storage format

2017-07-22 Thread Shawn Pearce
3rd iteration of the reftable storage format. You can read a rendered version of this here: https://googlers.googlesource.com/sop/jgit/+/reftable/Documentation/technical/reftable.md Significant changes from v2: - efficient lookup by SHA-1 for allow-tip-sha1-in-want. - type 0x4 for FETCH_HEAD,