[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-10-14 Thread Pascal Muetschard
I've uploaded another patch set, which merges in the latest changes from the trunk. On Mon, Oct 12, 2009 at 2:34 AM, John Tamplin j...@google.com wrote: On Mon, Oct 12, 2009 at 12:03 AM, John LaBanca jlaba...@google.comwrote: @jat - When do you think we'll merge the htmlunit branch into

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-10-14 Thread Bruce Johnson
@John L: You taking this one? On Wed, Oct 14, 2009 at 12:08 PM, Pascal Muetschard pmuetsch...@google.comwrote: I've uploaded another patch set, which merges in the latest changes from the trunk. On Mon, Oct 12, 2009 at 2:34 AM, John Tamplin j...@google.com wrote: On Mon, Oct 12, 2009 at

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-10-14 Thread John LaBanca
Yes, as soon as we get the build stabilized, I'll commit this. Thanks, John LaBanca jlaba...@google.com On Wed, Oct 14, 2009 at 3:20 PM, Bruce Johnson br...@google.com wrote: @John L: You taking this one? On Wed, Oct 14, 2009 at 12:08 PM, Pascal Muetschard pmuetsch...@google.com wrote:

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-10-12 Thread John Tamplin
On Mon, Oct 12, 2009 at 12:03 AM, John LaBanca jlaba...@google.com wrote: @jat - When do you think we'll merge the htmlunit branch into trunk so we can check in this patch? We are supposed to ship MS2 on Wednesday, so it has to be real soon. -- John A. Tamplin Software Engineer (GWT),

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-10-11 Thread John LaBanca
@jat - When do you think we'll merge the htmlunit branch into trunk so we can check in this patch? Thanks, John LaBanca jlaba...@google.com On Fri, Oct 9, 2009 at 2:58 PM, Pascal Muetschard pmuetsch...@google.comwrote: I have updated the patch set to also have the benchmark test cases use the

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-10-09 Thread Pascal Muetschard
I have updated the patch set to also have the benchmark test cases use the new strategy. Please review it. When do you think this will make it into the trunk? Thanks. On Fri, Sep 25, 2009 at 4:36 PM, Pascal Muetschard pmuetsch...@google.comwrote: FYI, I've uploaded another patch to

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-09-25 Thread Bruce Johnson
Looks convenient, but I have a few questions/comments. 1) What happens if the module returned by getModuleName() already specifies a fix value for a given property? More generally, how should one think about how these annotations dovetail with the settings in the module config? 2) The

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-09-25 Thread Bruce Johnson
On Fri, Sep 25, 2009 at 1:19 PM, Pascal Muetschard pmuetsch...@google.comwrote: 1) What happens if the module returned by getModuleName() already specifies a fix value for a given property? More generally, how should one think about how these annotations dovetail with the settings in the

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-09-25 Thread John LaBanca
I'll help Pascal with the changes, but it might be good to get a few more comments before changing too much. It *might *not be trivial for Benchmark to subclass the new Strategy because it does its own thing as well, but it shouldn't be too difficult. I agree that the annotation should override

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-09-25 Thread Bruce Johnson
On Fri, Sep 25, 2009 at 1:51 PM, John LaBanca jlaba...@google.com wrote: I vote for @WithBindingProperties for the annotation name. Is that a vote that we should start using the term binding properties in general? I think that's not quite the right term (perhaps this should be a separate

[gwt-contrib] Re: Proposed API Addition - @WithModuleParameters on test cases

2009-09-25 Thread John LaBanca
@WithClientProperties is fine with me. I thought we used the term binding somewhere, but creating a DeferredBinding doesn't actual require the use of the term binding. The gwt.xml files just refer to these as properties. Thanks, John LaBanca jlaba...@google.com On Fri, Sep 25, 2009 at 1:57