Re: [HarfBuzz] Disable uniscribe backend
On 08/20/11 14:47, Grigori Goronzy wrote: Hi, the Uniscribe backend doesn't work on Windows XP and unnecessarily Is that because we use the OpenType version of ScriptShape, etc? In that case I think I should switch to a GetProcAddress() method which is common practice on Windows then. bloats HarfBuzz on Windows. According to commit logs it only is for testing purposes anyway, so can we have an option to disable it at build time? Yes, we will have for everything. I just haven't got to building the configure system properly yet... Grigori PS: what happened to the 0.8 release and the promises of API stability? I've been on vacation last week and this week, but I'm getting some hacking done. I'm integrating Graphite today. It was necessary to integrate at least a couple other backends to kick the last quirks out of the API. So that's for the API stability. As for the 0.8 release, well, I just have been lazy :). ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz
[HarfBuzz] Disable uniscribe backend
Hi, the Uniscribe backend doesn't work on Windows XP and unnecessarily bloats HarfBuzz on Windows. According to commit logs it only is for testing purposes anyway, so can we have an option to disable it at build time? Grigori PS: what happened to the 0.8 release and the promises of API stability? ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz
Re: [HarfBuzz] Disable uniscribe backend
Hi again, here's a patch that adds a simple configure switch to select Uniscribe. I disabled Uniscribe support by default. Similar switches for ICU and glib might be handy as well. Grigori From 7f0b6832cc17e76012d249c7ccb536da59aa35a3 Mon Sep 17 00:00:00 2001 From: Grigori Goronzy greg@blackbox Date: Sat, 20 Aug 2011 18:34:23 +0200 Subject: [PATCH 1/2] Add Uniscribe configure toggle, disabled by default --- configure.ac |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index f42fb3c..82b5df1 100644 --- a/configure.ac +++ b/configure.ac @@ -71,6 +71,9 @@ if test x$GCC = xyes; then esac fi +AC_ARG_ENABLE([uniscribe], AS_HELP_STRING([--enable-uniscribe], +[enable uniscribe backend @:@default=no@:@])) + dnl == PKG_CHECK_MODULES(GLIB, glib-2.0 = 2.16, have_glib=true, have_glib=false) @@ -157,7 +160,9 @@ AM_CONDITIONAL(HAVE_OT, $have_ot) dnl === -AC_CHECK_HEADERS(usp10.h windows.h, have_uniscribe=true, have_uniscribe=false) +if test x$enable_uniscribe = xyes; then +AC_CHECK_HEADERS(usp10.h windowsx.h, have_uniscribe=true, have_uniscribe=false) +fi if $have_uniscribe; then UNISCRIBE_CFLAGS= UNISCRIBE_LIBS=-lusp10 -lgdi32 -- 1.7.2.3 ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/harfbuzz
