On Tue, 12 Mar 2024, "Sripada, Radhakrishna"
wrote:
> LGTM,
> Reviewed-by: Radhakrishna Sripada
Thanks for the review, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel
On Tue, 12 Mar 2024 16:26:00 +0200
Pekka Paalanen wrote:
> On Tue, 12 Mar 2024 08:30:34 +
> "Garg, Nemesa" wrote:
>
> > This KMS property is not implementing any formula
>
> Sure it is. Maybe Intel just does not want to tell what the algorithm
> is, or maybe it's even patented.
>
> >
On Wed, 13 Mar 2024, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The newly added function is not available without CONFIG_ACPI, causing
> a build failure:
>
> drivers/gpu/drm/i915/display/intel_bios.c:3424:24: error: implicit
> declaration of function 'intel_opregion_vbt_present'; did you
Hi,
https://patchwork.freedesktop.org/series/130966/ - Re-reported.
Thanks,
Tejasree
-Original Message-
From: Janusz Krzysztofik
Sent: Tuesday, March 12, 2024 8:45 PM
To: LGCI Bug Filing
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915/hwmon: Fix
Hi,
https://patchwork.freedesktop.org/series/130643/ - Re-reported.
Thanks,
Tejasree
From: Chauhan, Shekhar
Sent: Wednesday, March 13, 2024 9:25 AM
To: LGCI Bug Filing
Cc: intel-gfx@lists.freedesktop.org; Roper, Matthew D
Subject: RE: ✗ Fi.CI.BAT: failure for drm/i915/dp: Increase idle
On Tue, Mar 12, 2024 at 09:36:22PM -0700, Manasi Navare wrote:
> Thanks Stan for the cleanup around post disable non MST case, one comment
> below
>
> On Fri, Mar 8, 2024 at 5:11 AM Stanislav Lisovskiy
> wrote:
> >
> > Extract the "not-MST" stuff from intel_ddi_post_disable() so that
> > the
Extract the "not-MST" stuff from intel_ddi_post_disable() so that
the whole thing isn't so cluttered.
The bigjoiner slave handling was outside of the !MST check,
but it really should have been inside it as its the counterpart
to the master handling inside the check. So we pull that
in as well.
Handle only bigjoiner masters in skl_commit_modeset_enables/disables,
slave crtcs should be handled by master hooks. Same for encoders.
That way we can also remove a bunch of checks like
intel_crtc_is_bigjoiner_slave.
v2: - Moved skl_pfit_enable, intel_dsc_enable, intel_crtc_vblank_on to
From: Vidya Srinivas
We need bigjoiner support with MST functionality
for MST monitor resolutions > 5K to work.
Adding support for the same.
v2: Addressed review comments from Jani.
Revert rejection of MST bigjoiner modes and add
functionality
v3: Fixed pipe_mismatch WARN for
Unify the master vs. slave handling in
intel_ddi_post_disable_hdmi_or_sst() by looping over all the
pipes in one go.
This also lets us move the intel_crtc_vblank_off() calls to
happen in a consistent place vs. the transcoder disable.
Previously we did the master vs. slaves on different sides
of
Reorganize the crtc disable path to only deal with the
master pipes/transcoders in intel_old_crtc_state_disables()
and offload the handling of joined pipes to hsw_crtc_disable().
This makes the whole thing much more sensible since we can
actually control the order in which we do the per-pipe vs.
There are few things we need to do for bigjoiner, in order
to improve code maintenance and also make testing for Bigjoiner
easier.
Those series contain addition of bigjoiner force debugfs option,
in order to be able to force bigjoiner even if there is no display
support, also we refactor pipe vs
And we have at least one trivial place in
intel_ddi_update_active_dpll() where we can use it
immediately, so let's do that.
v2: - Fixed conflicts, part of patch didn't apply, because of master_crtc
rename(Stan)
Signed-off-by: Ville Syrjälä
Signed-off-by: Stanislav Lisovskiy
---
From: Arnd Bergmann
The newly added function is not available without CONFIG_ACPI, causing
a build failure:
drivers/gpu/drm/i915/display/intel_bios.c:3424:24: error: implicit declaration
of function 'intel_opregion_vbt_present'; did you mean
'intel_opregion_asle_present'?
On Tue, 2024-03-12 at 18:44 +0200, Ville Syrjälä wrote:
> On Fri, Mar 08, 2024 at 01:00:39PM +0200, Jouni Högander wrote:
> > Increasing number of fast wake sync pulses seem to fix problems
> > with
> > certain PSR panels. This should be ok for other panels as well as
> > the eDP
> > specification
== Series Details ==
Series: drm/i915/dp: Increase idle pattern wait timeout to 2ms (rev4)
URL : https://patchwork.freedesktop.org/series/130643/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14420 -> Patchwork_130643v4
On Tue, Mar 12, 2024 at 09:48:33PM -0700, Manasi Navare wrote:
> Now when we enable bigjoiner for MST, in MST case
> intel_ddi_post_disable_hdmi_or_sst() function wont get called,
> Do we need similar changes for MST case to loop over the joined pipes
> in MST bigjoiner case?
>
> Manasi
Hi
Quoting Patchwork (2024-03-12 22:30:46-03:00)
>== Series Details ==
>
>Series: Enable LNL display (rev2)
>URL : https://patchwork.freedesktop.org/series/130689/
>State : failure
>
>== Summary ==
>
>CI Bug Log - changes from CI_DRM_14421_full -> Patchwork_130689v2_full
Hi!
On Mon, 2024-03-11 at 14:07 +0100, Thomas Hellström wrote:
> On Fri, 2024-03-08 at 13:13 +0530, Somalapuram, Amaranath wrote:
> > Patches are tested on AMD platform.
> > Repeated stress test on Unigine Heaven, memory full (VRAM + GTT +
> > system
> > SWAP), then free.
> > No errors/warning
On Tue, Mar 12, 2024 at 09:49:05AM -0700, Matt Roper wrote:
On Tue, Mar 12, 2024 at 01:36:33PM -0300, Gustavo Sousa wrote:
Currently, only Xe2LPD uses CDCLK PLL as the source of MDCLK and
previous display IPs use the CD2XCLK. There will be changes in code
paths common to those platforms that
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, March 6, 2024 4:15 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Ville Syrjälä ; Manna, Animesh
> ; Murthy, Arun R ;
> Hogander, Jouni
> Subject: [PATCH v3 6/6] drm/i915/psr: Do not write ALPM configuration for
> PSR1 or
This patch set is improving IO and fast wake lines calculation in PSR
code:
Use actual fast wake sync pulse count in calculation Implement getter
for IO buffer wake times and use that. Better presentation on how
these are calculated. Use calculation for display version < 12 as
well.
Also
ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO
wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static
to make it available for PSR code.
v2: use int instead of u8
Signed-off-by: Jouni Högander
Reviewed-by: Ville Syrjälä
---
Bspec mentions 50 us for IO wake time and 32 us for fast wake time. 32 us
is most probably wrong as it doesn't meet the specification as fast wake
time is calculated in Bspec like this:
10..16 us (precharge) + 8 us (preamble) + 4 us (phy_wake) + 20 us
(tfw_exit_latency)
Instead of using these
Current fast and IO wake lines calculation is assuming fast wake sync
length is 18 pulses. Let's improve this by checking actual length.
Add getter for IO buffer wake time and return 10 us there which was assumed
with static 42 us IO wake time. Upcoming patches will extent this for
different
Increasing number of fast wake sync pulses seem to fix problems with
certain PSR panels. This should be ok for other panels as well as the eDP
specification allows 10...16 precharge pulses and we are still within that
range.
v2: add comment explaining pulse count is increased
Closes:
On Wed, 2024-03-13 at 11:15 +, Manna, Animesh wrote:
>
>
> > -Original Message-
> > From: Hogander, Jouni
> > Sent: Wednesday, March 6, 2024 4:15 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Ville Syrjälä ; Manna, Animesh
> > ; Murthy, Arun R
> > ;
> > Hogander, Jouni
> >
On Tue, 12 Mar 2024 13:36:31 -0300, Gustavo Sousa wrote:
> This series aims at providing the remaining patches for enabling display
> on Lunar Lake, which used Xe2LPD display IP.
>
> The first set of patches contains fixes and extra stuff required for
> supporting CDCLK on Xe2LPD:
>
>
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, March 6, 2024 4:15 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Ville Syrjälä ; Manna, Animesh
> ; Murthy, Arun R ;
> Hogander, Jouni
> Subject: [PATCH v3 1/6] drm/display: Add missing aux less alpm wake related
> bits
>
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, March 6, 2024 4:15 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Ville Syrjälä ; Manna, Animesh
> ; Murthy, Arun R ;
> Hogander, Jouni
> Subject: [PATCH v3 3/6] drm/i915/psr: Calculate aux less wake time
>
> Calculate
> -Original Message-
> From: Hogander, Jouni
> Sent: Wednesday, March 6, 2024 4:15 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Ville Syrjälä ; Manna, Animesh
> ; Murthy, Arun R ;
> Hogander, Jouni
> Subject: [PATCH v3 5/6] drm/i915/psr: Enable ALPM for eDP Panel replay
>
> Enable
On Wed, 2024-03-13 at 11:14 +, Manna, Animesh wrote:
>
>
> > -Original Message-
> > From: Hogander, Jouni
> > Sent: Wednesday, March 6, 2024 4:15 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Ville Syrjälä ; Manna, Animesh
> > ; Murthy, Arun R
> > ;
> > Hogander, Jouni
> >
Hi Nirmoy,
On Tue, Mar 12, 2024 at 12:18:15PM +0100, Nirmoy Das wrote:
> Caching mode is HW dependent so pick a correct one using
> intel_gt_coherent_map_type().
>
> Cc: Andi Shyti
> Cc: Janusz Krzysztofik
> Cc: Jonathan Cavitt
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10249
On Wed, Mar 13, 2024 at 03:32:21PM +0200, Jouni Högander wrote:
> Increasing number of fast wake sync pulses seem to fix problems with
> certain PSR panels. This should be ok for other panels as well as the eDP
> specification allows 10...16 precharge pulses and we are still within that
> range.
>
For Earlier platforms, the Pipe source size is 12-bits so
max pipe source width and height is 4096. For newer platforms it is
13-bits so theoretically max width/height is 8192. For few of the
earlier platforms the scaler did not use all bits of the PIPESRC,
so max scaler source size was used to
Hi Janusz,
On Mon, Mar 11, 2024 at 09:34:58PM +0100, Janusz Krzysztofik wrote:
> In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an
> rpm wakeref. That results in lock inversion:
>
> <4> [197.079335] ==
> <4>
== Series Details ==
Series: Bigjoiner refactoring (rev10)
URL : https://patchwork.freedesktop.org/series/128311/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14426 -> Patchwork_128311v10
Summary
---
**FAILURE**
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: dad309222e4c3fc7f88b20ce725ce1e0eea07cc7 Add linux-next specific
files for 20240313
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202403131859.szdcjzfy-...@intel.com
Error
== Series Details ==
Series: drm/i915: add intel_opregion_vbt_present() stub function
URL : https://patchwork.freedesktop.org/series/131060/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
== Series Details ==
Series: drm/i915: add intel_opregion_vbt_present() stub function
URL : https://patchwork.freedesktop.org/series/131060/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14426 -> Patchwork_131060v1
Summary
On Wed, 13 Mar 2024, Jonathon Hall wrote:
> Since commit 0c65dc062611 ("drm/i915/jsl: s/JSL/JASPERLAKE for
> platform/subplatform defines"), boot freezes on a Jasper Lake tablet
> (Librem 11), usually with graphical corruption on the eDP display,
> but sometimes just a black screen. This commit
On Wed, Mar 13, 2024 at 07:27:36PM +0300, Nikita Kiryushin wrote:
>
> Remove IS_KABYLAKE and IS_SKYLAKE in special handlers for
> skylake and kabylake: the checks are done at hook initialization and are
> always true in corresponding handlers.
>
> Signed-off-by: Nikita Kiryushin
Reviewed-by:
== Series Details ==
Series: Bigjoiner refactoring (rev10)
URL : https://patchwork.freedesktop.org/series/128311/
State : warning
== Summary ==
Error: dim checkpatch failed
96075b92e19f drm/i915: Add a small helper to compute the set of pipes for crtc
8307ecb8447f drm/i915: Extract
== Series Details ==
Series: Bigjoiner refactoring (rev10)
URL : https://patchwork.freedesktop.org/series/128311/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1:
On Fri, 08 Mar 2024, Thomas Zimmermann wrote:
> Acked-by: Thomas Zimmermann
>
> for the series.
Thanks, pushed the lot to drm-misc-next-fixes.
> Do you plan to make the return type an unsigned int eventually?
Not really. The hooks could still return -ENOMEM or something, with no
compiler
On Wed, 2024-03-13 at 11:14 +, Manna, Animesh wrote:
>
>
> > -Original Message-
> > From: Hogander, Jouni
> > Sent: Wednesday, March 6, 2024 4:15 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Ville Syrjälä ; Manna, Animesh
> > ; Murthy, Arun R
> > ;
> > Hogander, Jouni
> >
On Wed, 2024-03-13 at 11:18 +, Manna, Animesh wrote:
>
>
> > -Original Message-
> > From: Hogander, Jouni
> > Sent: Wednesday, March 6, 2024 4:15 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Ville Syrjälä ; Manna, Animesh
> > ; Murthy, Arun R
> > ;
> > Hogander, Jouni
> >
We want a fixed load CCS balancing consisting in all slices
sharing one single user engine. For this reason do not create the
intel_engine_cs structure with its dedicated command streamer for
CCS slices beyond the first.
Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")
Enable only one CCS engine by default with all the compute sices
allocated to it.
While generating the list of UABI engines to be exposed to the
user, exclude any additional CCS engines beyond the first
instance.
This change can be tested with igt i915_query.
Fixes: d2eae8e98d59 ("drm/i915/dg2:
The hardware should not dynamically balance the load between CCS
engines. Wa_14019159160 recommends disabling it across all
platforms.
Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")
Signed-off-by: Andi Shyti
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Matt Roper
Cc: # v6.2+
Hi,
this series does basically two things:
1. Disables automatic load balancing as adviced by the hardware
workaround.
2. Assigns all the CCS slices to one single user engine. The user
will then be able to query only one CCS engine
>From v5 I have created a new file,
== Series Details ==
Series: IO and fast wake lines calculation and increase fw sync length (rev6)
URL : https://patchwork.freedesktop.org/series/130173/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14428 -> Patchwork_130173v6
== Series Details ==
Series: drm/i915/scaler: Update Pipe src size check in skl_update_scaler
URL : https://patchwork.freedesktop.org/series/131078/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14428 -> Patchwork_131078v1
== Series Details ==
Series: drm/i915/gt: Report full vm address range
URL : https://patchwork.freedesktop.org/series/131095/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14428 -> Patchwork_131095v1
Summary
---
== Series Details ==
Series: Disable automatic load CCS load balancing (rev9)
URL : https://patchwork.freedesktop.org/series/129951/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Disable automatic load CCS load balancing (rev9)
URL : https://patchwork.freedesktop.org/series/129951/
State : warning
== Summary ==
Error: dim checkpatch failed
06497016416d drm/i915/gt: Disable HW load balancing for CCS
c3197ab37c84 drm/i915/gt: Do not generate
== Series Details ==
Series: Disable automatic load CCS load balancing (rev9)
URL : https://patchwork.freedesktop.org/series/129951/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14428 -> Patchwork_129951v9
Summary
---
== Series Details ==
Series: Fix divide-by-zero regression on DP MST unplug with nouveau (rev2)
URL : https://patchwork.freedesktop.org/series/131002/
State : warning
== Summary ==
Error: dim checkpatch failed
64a2dd5de4fd Fix divide-by-zero regression on DP MST unplug with nouveau
-:14:
== Series Details ==
Series: Fix divide-by-zero regression on DP MST unplug with nouveau (rev2)
URL : https://patchwork.freedesktop.org/series/131002/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14428 -> Patchwork_131002v2
Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per
vm") has reserved an object for kernel space usage.
Userspace, though, needs to know the full address range.
Fixes: 9bb66c179f50 ("drm/i915: Reserve some kernel space per vm")
Signed-off-by: Andi Shyti
Cc: Andrzej Hajda
Cc: Chris
== Series Details ==
Series: drm/i915: Use drm_printer more (rev8)
URL : https://patchwork.freedesktop.org/series/129956/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14427 -> Patchwork_129956v8
Summary
---
== Series Details ==
Series: drm/i915: Rename ICL_PORT_TX_DW6 bits (rev2)
URL : https://patchwork.freedesktop.org/series/130899/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14427 -> Patchwork_130899v2
Summary
---
== Series Details ==
Series: drm/i915: Use drm_printer more (rev8)
URL : https://patchwork.freedesktop.org/series/129956/
State : warning
== Summary ==
Error: dim checkpatch failed
bfbc14be30be drm/i915: Indicate which pipe failed the fastset check overall
b4f30f44c52b drm/i915: Include CRTC
== Series Details ==
Series: drm/i915: Use drm_printer more (rev8)
URL : https://patchwork.freedesktop.org/series/129956/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Use container_of_const() (rev2)
URL : https://patchwork.freedesktop.org/series/130868/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Use container_of_const() (rev2)
URL : https://patchwork.freedesktop.org/series/130868/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14428 -> Patchwork_130868v2
Summary
---
== Series Details ==
Series: IO and fast wake lines calculation and increase fw sync length (rev6)
URL : https://patchwork.freedesktop.org/series/130173/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Fix a regression when using nouveau and unplugging a StarTech MSTDP122DP
DisplayPort 1.2 MST hub (the same regression does not appear when using
a Cable Matters DisplayPort 1.4 MST hub). Trace:
divide error: [#1] PREEMPT SMP PTI
CPU: 7 PID: 2962 Comm: Xorg Not tainted 6.8.0-rc3+ #744
== Series Details ==
Series: drm/i915/display: Fixed a screen flickering when turning on display
from off (rev3)
URL : https://patchwork.freedesktop.org/series/130780/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14428 -> Patchwork_130780v3
Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per
vm") has reserved an object for kernel space usage.
Userspace, though, needs to know the full address range.
Fixes: 9bb66c179f50 ("drm/i915: Reserve some kernel space per vm")
Signed-off-by: Andi Shyti
Cc: Andrzej Hajda
Cc: Chris
70 matches
Mail list logo
