On 15/01/2015 22:16, Ralf Lang wrote:
On 15.01.2015 21:35, Mike wrote:
Wouldn't this one change render all code in PEAR as broken?
No.
Why not? PEAR uses PHP4-constructors almost everywhere.
But PEAR can be fixed, I guess. Along with application using/extending
it. The process can be
Multiple places 'spprintf' is called with a NULL 'pbuf', which
passes itself to vspprintf, which dereferences it.
Although most places check whether 'pbuf'(normally called 'error')
is null, it is smarter to check it inside the function that
requires a non-null value.
This will avoid future
Hi!
+ //Test 'pbuf'(also known as 'error') against NULL, since it is called
multiple places without checking against, causing null pointer dereferences.
No C++ comments please.
if (buf.c) {
- *pbuf = buf.c;
+ if(pbuf) {
+ *pbuf =
On 16/01/15 19:23, Stanislav Malyshev wrote:
No C++ comments please.
Fixed.(Will push afterwards)
if (buf.c) {
- *pbuf = buf.c;
+ if(pbuf) {
+ *pbuf = buf.c;
+ }
result = buf.len;
I think if pbuf is null, it should return 0
Hi all,
Take a look at
http://3v4l.org/HbVnd
foreach should not affect internal(zval) array position, but it does.
I'm not sure why foreach works this way, but HHVM behavior is
reasonable. IMHO.
PHP 7 would be perfect opportunity fix this behavior.
Any comments?
Regards,
--
Yasuo Ohgaki
On 16 January 2015 01:41:55 GMT, Stanislav Malyshev smalys...@gmail.com wrote:
debate. I'm just claiming that `(int) $num` is more explicit, has no
BC breaks and should, IMMO, be the preferred choice.
No, it should not be, and I just wrote two mails explaining why exactly
it should not. Here's
--
Multiple places 'spprintf' is called with a NULL 'pbuf', which
passes itself to vspprintf, which dereferences it.
Although most places check whether 'pbuf'(normally called 'error')
is null, it is smarter to check it inside the function that
requires a non-null value.
This will avoid future
---
main/spprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main/spprintf.c b/main/spprintf.c
index ba12868..5f50d8a 100644
--- a/main/spprintf.c
+++ b/main/spprintf.c
@@ -845,7 +845,7 @@ PHPAPI size_t vspprintf(char **pbuf, size_t max_len, const
char *format, va_list
Hi Stas,
-Ursprüngliche Nachricht-
Von: Stanislav Malyshev [mailto:smalys...@gmail.com]
Gesendet: Mittwoch, 14. Januar 2015 21:26
An: Marc Bennewitz; internals@lists.php.net
Betreff: Re: [PHP-DEV] [RFC] Skipping parameters take 2
Hi!
Is it possible to use the default parameter
On 15/01/15 15:28, Niktia Nefedov wrote:
Consider what a mess was register_globals and problems it had, but at
least
it was a global setting. Declare will work on per file basis, and it will
end up even more of a mess.
I think PHP development community learned that lesson and that's why you
Am 14.01.2015 20:50 schrieb Simon J Welsh si...@welsh.co.nz:
create_query(deleted=0, name, _, _, true);
Still not sure if it's better than `default`, though.
That would be a BC break as you can currently have a constant _.
A visually pleasing (IMO), even easier to type, and non-BC
On Fri, Jan 16, 2015 at 11:08 AM, Lester Caine les...@lsces.co.uk wrote:
On 15/01/15 15:28, Niktia Nefedov wrote:
Consider what a mess was register_globals and problems it had, but at
least
it was a global setting. Declare will work on per file basis, and it
will
end up even more of a
On 16/01/15 11:05, Benjamin Eberlei wrote:
You keep bringing this up, but there is a workaround to manually enable
On PHP5.4 or later? We are stuck with 5.3 unless code is modified. Same
with other removed functions in 5.4.
register globals again if you need to have it for migration. It should
On Thu, 15 Jan 2015, Levi Morrison wrote:
On Thu, Jan 15, 2015 at 9:55 AM, Andrea Faulds a...@ajf.me wrote:
Upon further thought, I’m not super-enthusiastic about this. As has
been pointed out, it’s a pretty serious BC break, whether code can
be automatically updated or not. PHP 4
On Thu, 15 Jan 2015, Jordi Boggiano wrote:
On 14/01/2015 00:16, Andrea Faulds wrote:
Here: https://wiki.php.net/rfc/scalar_type_hints
This is a new thread because I’ve made a significant revision to the RFC, so
it’d be sensible to separate discussion of the updated RFC from the v0.1
On Thu, Jan 15, 2015 at 3:11 PM, Jan Ehrhardt php...@ehrhardt.nl wrote:
Benjamin Eberlei in php.internals (Thu, 15 Jan 2015 15:53:43 +0100):
Not sure how that helps, since you would tag versions anyways using semver,
so if there is a master vs next/phpng branch, then they might still result
in
---
ext/dba/libflatfile/flatfile.c | 28
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/ext/dba/libflatfile/flatfile.c b/ext/dba/libflatfile/flatfile.c
index b5028f5..f640e19 100644
--- a/ext/dba/libflatfile/flatfile.c
+++
Mike Willbanks wrote on 15/01/2015 16:55:
It also means that then a library developer would
need to handle conditions on both sides (when in weak vs. strict). So I
don't really understand where the gains of this would come from and it
actually causes me concern in that what if a developer
Hello everyone,
Might I suggest community feedback on this one in a reddit thread? My guess
is that even though a lot of applications out there are still PHP 4 ctor
reliant, a very low percentage of these applications might be under active
development.
Best,
Stelian
On Fri, Jan 16, 2015 at
Hi,
On Fri, Jan 16, 2015 at 2:29 PM, Rowan Collins rowan.coll...@gmail.com wrote:
Mike Willbanks wrote on 15/01/2015 16:55:
It also means that then a library developer would
need to handle conditions on both sides (when in weak vs. strict). So I
don't really understand where the gains of
Hi Stelian,
Stelian Mocanita writes:
Hello everyone,
Might I suggest community feedback on this one in a reddit thread? My guess
is that even though a lot of applications out there are still PHP 4 ctor
reliant, a very low percentage of these applications might be under active
development.
Florian Margaine wrote on 16/01/2015 13:01:
Hi Stelian,
Stelian Mocanita writes:
Hello everyone,
Might I suggest community feedback on this one in a reddit thread? My guess
is that even though a lot of applications out there are still PHP 4 ctor
reliant, a very low percentage of these
Andrey Andreev wrote on 16/01/2015 13:00:
Hi,
On Fri, Jan 16, 2015 at 2:29 PM, Rowan Collins rowan.coll...@gmail.com wrote:
Mike Willbanks wrote on 15/01/2015 16:55:
It also means that then a library developer would
need to handle conditions on both sides (when in weak vs. strict). So I
Hi again,
On Fri, Jan 16, 2015 at 4:52 PM, Rowan Collins rowan.coll...@gmail.com wrote:
Specifically, I don't think a library author should be able to tell me that,
just because they're feeling picky, '42' and 42 are not equivalent when
calling their function. It does very little to protect
Andrey Andreev wrote on 16/01/2015 15:37:
With no attempt to argue, I just thought of another example, inspired
by the ones given in the RFC - it is fairly common for functions
dealing with times to only accept a UNIX timestamp or otherwise just a
single kind of a time unit, such as only a count
Hi Benjamin,
Thanks for idea.
With PHP7 AST compiler, it's quite easy to implement this (it took us 15
minutes to try :)
However, it doesn't make big improvement on our benchmarks.
We will take a look into possibilities to apply your idea to other patterns
(e.g. for and foreach loops).
Anyway,
Yasuo Ohgaki wrote on 16/01/2015 08:40:
Hi all,
Take a look at
http://3v4l.org/HbVnd
foreach should not affect internal(zval) array position, but it does.
I'm not sure why foreach works this way, but HHVM behavior is
reasonable. IMHO.
PHP 7 would be perfect opportunity fix this behavior.
Any
On 16 January 2015 at 01:58, Rasmus Lerdorf ras...@lerdorf.com wrote:
The closest we have at this point is:
https://wiki.php.net/phpng-upgrading
If people
here could skim it and fix anything that isn't current it would help.
Thanks. I think the TSRM changes need to be added, which could
I was just surprised by the current behavior :)
$ cat ops.php
?php
function foo(string $str) {
}
foo(ops);
?
$ sapi/cli/php -n ops.php
Catchable fatal error: Argument 1 passed to foo() must be an instance of
string, string given in ops.php on line 2
It too me time to realize what is going on
De : Pierre Joye [mailto:pierre@gmail.com]
I tend to prefer separate files and add the right source at configure
time.
It is then easier to keep fixes, features, etc. in sync.
However both solutions may work, if we decide to go for one or another
solution. We can add
Hey:
On Sat, Jan 17, 2015 at 12:12 AM, Dmitry Stogov dmi...@zend.com wrote:
Hi Benjamin,
Thanks for idea.
With PHP7 AST compiler, it's quite easy to implement this (it took us 15
minutes to try :)
yeah... by handy :)
However, it doesn't make big improvement on our benchmarks.
in reallife
See the patch for while and for loops
https://gist.github.com/dstogov/9cc5767a14f3b88e1275
All tests passed.
The patch leads to 2% improvement in number of CPU instructions retired on
bench.php.
Unfortunately, It doesn't make any visible speed difference.
Anyway, I'm going to commit it on
On Fri, Jan 2, 2015 at 5:04 PM, Nikita Popov nikita@gmail.com wrote:
Hi internals!
Voting on the removal of deprecated functionality in PHP 7 is now open:
https://wiki.php.net/rfc/remove_deprecated_functionality_in_php7#votes
As requested, I've split this up in many individual
On Thu, Dec 25, 2014 at 6:20 PM, Sara Golemon poll...@php.net wrote:
On Mon, Nov 24, 2014 at 8:47 PM, Sara Golemon poll...@php.net wrote:
While playing around with Andrea's unicode literals syntax proposal, I
was reminded of just how little of ICU is exposed. I've put up a
short proposal for
On Fri, Jan 16, 2015 at 6:09 PM, Dmitry Stogov dmi...@zend.com wrote:
See the patch for while and for loops
https://gist.github.com/dstogov/9cc5767a14f3b88e1275
All tests passed.
The patch leads to 2% improvement in number of CPU instructions retired on
bench.php.
Unfortunately, It
How long do you usually take to respond emails?
Thank you !
Best regards,
Natalia Marín Pérez
[http://www.mikejr1.es/linux/images/stories/images/tux_buscar.png]
Platform Hosting
Systems Engineer
* Contact
Informationhttps://ease.intel.com/es/Phonebook/ViewEmployeeRec.aspx?wwid=11338730
Engage
Hi Dimitry,
Thank you for the acknowledgment. I am a big fan of your work.
I think adding the suggested changes to foreach will be a good improvement.
With foreach one cold actually merge the jump-into-opcode (line 0 in the
while-loop example) with FE_RESET.
On another note, I think there are
I think this broke usort() of more than 16 elements.
eg.
?php
$pr = [ [ 'id' = 'aaa', 'date' = 'Oct 8, 2006' ],
[ 'id' = 'bbb', 'date' = 'Nov 14, 2008'],
[ 'id' = 'ccc', 'date' = 'Dec 19, 2014'],
[ 'id' = 'ddd', 'date' = 'Feb 4, 2010'],
[ 'id' = 'eee', 'date' =
Hi Robert
Am 16.01.2015 um 11:04 schrieb Robert Stoll:
Hi Stas,
-Ursprüngliche Nachricht-
Von: Stanislav Malyshev [mailto:smalys...@gmail.com]
Gesendet: Mittwoch, 14. Januar 2015 21:26
An: Marc Bennewitz; internals@lists.php.net
Betreff: Re: [PHP-DEV] [RFC] Skipping parameters take 2
Hi!
This would be quite a nice feature, even if this RFC does not pass.
Just as hint, there are ambiguous case which need to be considered:
interface A{ function foo($a=1); } interface B{ function
foo($a=hi); } class C implements A, B{ function foo($a=default){}
//what would be the default
Hi Rowan,
On Sat, Jan 17, 2015 at 1:22 AM, Rowan Collins rowan.coll...@gmail.com
wrote:
Yasuo Ohgaki wrote on 16/01/2015 08:40:
Hi all,
Take a look at
http://3v4l.org/HbVnd
foreach should not affect internal(zval) array position, but it does.
I'm not sure why foreach works this way,
Hi Simon and Levi,
On Fri, Jan 16, 2015 at 4:53 PM, Simon J Welsh si...@welsh.co.nz wrote:
The tests have it after the use():
https://github.com/php/php-src/pull/997/files#diff-e306c6e99612ba59b00a4fe435b287e5R9
This was discussed in depth a couple of times in the related threads.
Thank
Florian Margaine wrote on 16/01/2015 13:01:
Hi Stelian,
Stelian Mocanita writes:
Hello everyone,
Might I suggest community feedback on this one in a reddit thread? My
guess
is that even though a lot of applications out there are still PHP 4 ctor
reliant, a very low percentage of these
On 16 January 2015 at 00:03, Pierre Joye pierre@gmail.com wrote:
It is also important to note that I would like to push the usage of install
from git/other VCS in the near term, using pickle, and use the website only
for the meta info but not (or much less) for hosting the releases.
As
That’s an invalid comparison function. It causes the current usort to reverse
sort the array and I see no problem with that changing (you’re saying that a
value for $a less than $b is in fact greater than it, and a value of $b less
than or equal to $a is equal to it).
On 17/01/2015, at 06:17,
On 01/16/2015 03:54 PM, Simon J Welsh wrote:
That’s an invalid comparison function. It causes the current usort to reverse
sort the array and I see no problem with that changing (you’re saying that a
value for $a less than $b is in fact greater than it, and a value of $b less
than or equal
Hi!
On 1/16/15 11:17 AM, Rasmus Lerdorf wrote:
I think this broke usort() of more than 16 elements.
Also, collator_asort.phpt unit test is broken. Xinchen Hui, please take
a look.
--
Stas Malyshev
smalys...@gmail.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe,
Marin Perez, Natalia wrote:
How long do you usually take to respond emails?
intern...@php.net is a list for those who want to help out with the
development of PHP; you might be better off asking on
php-inst...@lists.php.net. See http://php.net/mailing-lists.php.
--
Christoph M. Becker
--
Hey:
On Sat, Jan 17, 2015 at 8:20 AM, Rasmus Lerdorf ras...@lerdorf.com wrote:
On 01/16/2015 03:54 PM, Simon J Welsh wrote:
That’s an invalid comparison function. It causes the current usort to
reverse sort the array and I see no problem with that changing (you’re
saying that a value for
Hey:
On Sat, Jan 17, 2015 at 8:39 AM, Stanislav Malyshev smalys...@gmail.com wrote:
Hi!
On 1/16/15 11:17 AM, Rasmus Lerdorf wrote:
I think this broke usort() of more than 16 elements.
Also, collator_asort.phpt unit test is broken. Xinchen Hui, please take
a look.
that test skip
Hi Marc,
This is an unusual follow-up from me.
Particularly on 32-bit systems, it would be useful to have a ‘u’
zend_parse_parameters specifier for an unsigned integer. Unfortunately, again,
I don’t think native unsigned integers (IS_ULONG) will get into PHP. But it
looks like the bigint RFC
Hey:
On Sat, Jan 17, 2015 at 2:14 AM, Benjamin Coutu ben.co...@zeyos.com wrote:
Hi Dimitry,
Thank you for the acknowledgment. I am a big fan of your work.
I think adding the suggested changes to foreach will be a good improvement.
With foreach one cold actually merge the jump-into-opcode
Hi!
you could fix it by change the output(it must because equal elements
compare)...
I could but I'd be busy for this weekend so it'd be better if you fixed
it since your patch broke it :)
Also it would be nice if such big changes were run through the CI before
committing. We have it run
Hey:
On Sat, Jan 17, 2015 at 11:54 AM, Stanislav Malyshev
smalys...@gmail.com wrote:
Hi!
you could fix it by change the output(it must because equal elements
compare)...
I could but I'd be busy for this weekend so it'd be better if you fixed
it since your patch broke it :)
okey, I just
On Jan 16, 2015, at 19:18, Xinchen Hui larue...@php.net wrote:
Hey:
On Sat, Jan 17, 2015 at 8:20 AM, Rasmus Lerdorf ras...@lerdorf.com wrote:
On 01/16/2015 03:54 PM, Simon J Welsh wrote:
That’s an invalid comparison function. It causes the current usort to
reverse sort the array and I
Hey:
On Sat, Jan 17, 2015 at 12:37 PM, Rasmus Lerdorf ras...@lerdorf.com wrote:
On Jan 16, 2015, at 19:18, Xinchen Hui larue...@php.net wrote:
Hey:
On Sat, Jan 17, 2015 at 8:20 AM, Rasmus Lerdorf ras...@lerdorf.com wrote:
On 01/16/2015 03:54 PM, Simon J Welsh wrote:
That’s an invalid
Hey:
On Sat, Jan 17, 2015 at 1:16 PM, Xinchen Hui larue...@php.net wrote:
Hey:
On Sat, Jan 17, 2015 at 12:37 PM, Rasmus Lerdorf ras...@lerdorf.com wrote:
On Jan 16, 2015, at 19:18, Xinchen Hui larue...@php.net wrote:
Hey:
On Sat, Jan 17, 2015 at 8:20 AM, Rasmus Lerdorf ras...@lerdorf.com
On Sat, Jan 17, 2015 at 6:24 AM, Xinchen Hui larue...@php.net wrote:
Hey:
On Sat, Jan 17, 2015 at 1:16 PM, Xinchen Hui larue...@php.net wrote:
but okey, I agree we need write some note(actually I noted in UPGRADE
of we are using hybrid sorting algo now)..
but what kindof note I mean how
hi,
On Wed, Nov 19, 2014 at 12:11 AM, Levi Morrison le...@php.net wrote:
Dear Internals,
I am proposing an RFC[1] to remove PHP 4 constructors in PHP 7. If
accepted, methods with the same name as their defining class will no
longer be recognized as constructors. As noted in the RFC, there
On Sat, Jan 17, 2015 at 4:32 AM, Andrea Faulds a...@ajf.me wrote:
Hi Marc,
This is an unusual follow-up from me.
Particularly on 32-bit systems, it would be useful to have a ‘u’
zend_parse_parameters specifier for an unsigned integer. Unfortunately,
again, I don’t think native unsigned
On Sat, Jan 17, 2015 at 12:09 AM, Dan Ackroyd dan...@basereality.com wrote:
On 16 January 2015 at 00:03, Pierre Joye pierre@gmail.com wrote:
It is also important to note that I would like to push the usage of install
from git/other VCS in the near term, using pickle, and use the website
On Fri, Jan 16, 2015 at 10:36 PM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi Simon and Levi,
On Fri, Jan 16, 2015 at 4:53 PM, Simon J Welsh si...@welsh.co.nz wrote:
The tests have it after the use():
https://github.com/php/php-src/pull/997/files#diff-e306c6e99612ba59b00a4fe435b287e5R9
This
62 matches
Mail list logo
