Re: [PHP-DEV] Exception message cleanup

2015-04-09 Thread Niklas Keller
Hi Nikita, I like the new display format, but there's one thing I miss. If you replace the exception name for warnings and fatals, how does a user know which exception he has to catch? Regards, Niklas Nikita Popov nikita@gmail.com schrieb am Do., 09.04.2015, 10:04: Hi internals! A lot

Re: [PHP-DEV] Concern around growing complexity in engine - hash table specifically

2015-04-09 Thread Julien Pauli
On Thu, Apr 9, 2015 at 1:01 PM, Dmitry Stogov dmi...@zend.com wrote: On Thu, Apr 9, 2015 at 1:35 PM, Julien Pauli jpa...@php.net wrote: On Wed, Apr 8, 2015 at 10:55 PM, Dmitry Stogov dmi...@zend.com wrote: On Fri, Apr 3, 2015 at 9:57 PM, Anthony Ferrara ircmax...@gmail.com wrote: All,

Re: [PHP-DEV] Concern around growing complexity in engine - hash table specifically

2015-04-09 Thread Dmitry Stogov
On Thu, Apr 9, 2015 at 1:35 PM, Julien Pauli jpa...@php.net wrote: On Wed, Apr 8, 2015 at 10:55 PM, Dmitry Stogov dmi...@zend.com wrote: On Fri, Apr 3, 2015 at 9:57 PM, Anthony Ferrara ircmax...@gmail.com wrote: All, I spent a little bit of time today trying to debug an issue with 7

Re: [PHP-DEV] Exception message cleanup

2015-04-09 Thread Lester Caine
On 09/04/15 13:55, Nikita Popov wrote: I like the new display format, but there's one thing I miss. If you replace the exception name for warnings and fatals, how does a user know which exception he has to catch? Sorry, I don't understand what you mean here. The first part of the message

Re: [PHP-DEV] Concern around growing complexity in engine - hash table specifically

2015-04-09 Thread Anthony Ferrara
Julien, On Apr 9, 2015 7:52 AM, Julien Pauli jpa...@php.net wrote: On Thu, Apr 9, 2015 at 1:01 PM, Dmitry Stogov dmi...@zend.com wrote: On Thu, Apr 9, 2015 at 1:35 PM, Julien Pauli jpa...@php.net wrote: On Wed, Apr 8, 2015 at 10:55 PM, Dmitry Stogov dmi...@zend.com wrote: On Fri, Apr 3,

[PHP-DEV] Exception message cleanup

2015-04-09 Thread Nikita Popov
Hi internals! A lot of people have been confused about engine exceptions currently displaying as normal fatal errors (if they aren't caught). We'll have to change this to use exception messages. Before doing this I'd like to clean up the messages a bit to make them more friendly for CLI usage.

Re: [PHP-DEV] password_hash() deprecate salt option - thoughts?

2015-04-09 Thread Anthony Ferrara
I gave it some additional time in case others raised concern. I have since merged the deprecation of the salt option to password_hash() Thanks! Anthony On Wed, Apr 1, 2015 at 2:26 PM, Anthony Ferrara ircmax...@gmail.com wrote: All, I've added a PR for this:

Re: [PHP-DEV] Exception message cleanup

2015-04-09 Thread Nikita Popov
On Thu, Apr 9, 2015 at 12:33 PM, Niklas Keller m...@kelunik.com wrote: Hi Nikita, I like the new display format, but there's one thing I miss. If you replace the exception name for warnings and fatals, how does a user know which exception he has to catch? Regards, Niklas Sorry, I don't

Re: [PHP-DEV] Concern around growing complexity in engine - hash table specifically

2015-04-09 Thread Julien Pauli
On Wed, Apr 8, 2015 at 10:55 PM, Dmitry Stogov dmi...@zend.com wrote: On Fri, Apr 3, 2015 at 9:57 PM, Anthony Ferrara ircmax...@gmail.com wrote: All, I spent a little bit of time today trying to debug an issue with 7 that Drupal 8 was facing, specifically regarding an array index not

RE: [PHP-DEV] Concern around growing complexity in engine - hash table specifically

2015-04-09 Thread Anthony Ferrara
Fancois, On Apr 9, 2015 10:16 AM, François Laupretre franc...@php.net wrote: De : Anthony Ferrara [mailto:ircmax...@gmail.com] If we were using a pure abstraction (only accessing the hash table information through the public API), then fine because it's isolated. However, many

RE: [PHP-DEV] Concern around growing complexity in engine - hash table specifically

2015-04-09 Thread François Laupretre
De : Anthony Ferrara [mailto:ircmax...@gmail.com] If we were using a pure abstraction (only accessing the hash table information through the public API), then fine because it's isolated. However, many extensions and even places in core access hash table structure directly (as can be seen by

Re: [PHP-DEV] Exception message cleanup

2015-04-09 Thread Anthony Ferrara
Nikita, On Apr 9, 2015 8:56 AM, Nikita Popov nikita@gmail.com wrote: On Thu, Apr 9, 2015 at 12:33 PM, Niklas Keller m...@kelunik.com wrote: Hi Nikita, I like the new display format, but there's one thing I miss. If you replace the exception name for warnings and fatals, how does a

Re: [PHP-DEV] Exception message cleanup

2015-04-09 Thread Patrick Schaaf
Am 09.04.2015 10:04 schrieb Nikita Popov nikita@gmail.com: New message: UnexpectedValueException: Failed to open directory in %s on line %d ... Essentially exceptions would display like ordinary error, but with Fatal error / Warning / ... replaced by the exception name, and showing a