Re: [PHP-DEV] [Concept] Don't cast keys in array to int

2020-08-16 Thread Michael Voříšek - ČVUT FEL
This seems almost as a bug, strict types should apply also for array key which is currently not the case. https://3v4l.org/epv5s With kind regards / Mit freundlichen Grüßen / S přátelským pozdravem, Michael Voříšek On 17 Aug 2020 02:56, Josh Bruce wrote: I'm sure this conversation has

Re: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2

2020-08-16 Thread Theodore Brown
On Sun, Aug 16, 2020 at 4:36 AM Benjamin Eberlei wrote: > We have updated the RFC with all (hopefully) of the feedback from > this discussion: > > https://wiki.php.net/rfc/shorter_attribute_syntax_change > > Most notable changes are: > - A new section with several subsections on the benefits of

[PHP-DEV] [Concept] Don't cast keys in array to int

2020-08-16 Thread Josh Bruce
I’m sure this conversation has happened before. But it’s on my mind as I work on some things on wanted to ask internals real quick before getting back to it. [“2” => “hello”, “4” => “internals”] -> [2 => “hello”, 4 => “internals”] Meanwhile: [“hello”, “internals”] -> cast to object -> (“0” =>

Re: [PHP-DEV] Voting access

2020-08-16 Thread Christoph M. Becker
On 16.08.2020 at 23:31, Michael Voříšek - ČVUT FEL wrote: > I registered on https://wiki.php.net/start?do=register > >> To get authorization you must send a quick introduction to the >> internals mailing list. Mention your wiki username and say what you're >> planning to do. This email lets us

Re: [PHP-DEV] [RFC] Better string interpolation

2020-08-16 Thread Rowan Tommins
Hi Ilija, On 14/08/2020 17:14, Ilija Tovilo wrote: I've been thinking about ways to improve string interpolation. String interpolation in PHP is currently pretty limited to say the least. Thanks for putting together some thoughts on this. My instinct is that rather than having a whole new

Re: [PHP-DEV] Voting access

2020-08-16 Thread Michael Voříšek - ČVUT FEL
Hello, I registered on https://wiki.php.net/start?do=register To get authorization you must send a quick introduction to the internals mailing list. Mention your wiki username and say what you're planning to do. This email lets us know you're a human (and not a robot) and what you'll be

Re: [PHP-DEV] Re: [RFC] Better string interpolation

2020-08-16 Thread Alexandru Pătrănescu
On Sun, Aug 16, 2020, 20:45 Ilija Tovilo wrote: > Hi internals > > > I've been thinking about ways to improve string interpolation. > > Absolutely overwhelmed by the feedback (:P) I've decided to create a small > POC: > >

[PHP-DEV] Re: [RFC] Better string interpolation

2020-08-16 Thread Ilija Tovilo
Hi internals > I've been thinking about ways to improve string interpolation. Absolutely overwhelmed by the feedback (:P) I've decided to create a small POC: https://github.com/php/php-src/compare/master...iluuu1994:string-interpolation The POC uses the following syntax: echo "Static method

Re: [PHP-DEV] Voting access

2020-08-16 Thread Kalle Sommer Nielsen
Den søn. 16. aug. 2020 kl. 12.08 skrev Michael Voříšek - ČVUT FEL : > > Hello, > > based on https://wiki.php.net/rfc/voting voting access is offered to > people who: > > - contributed to PHP source - I have made several smaller contributions > to php-src incl. + some core xdebug optimization > > -

Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change

2020-08-16 Thread Michał Marcin Brzuchalski
Hi Benjamin, niedz., 16 sie 2020, 11:29 użytkownik Benjamin Eberlei napisał: > Following the valid criticisms of us starting the vote too early, we have > closed the vote for this RFC for now. > > We look to restart the vote middle next week, so that we can close this > before the Beta 3

Re: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2

2020-08-16 Thread tyson andre
Hi Benjamin, > We are looking for further feedback from the community. Thanks, the updated RFC looks much better. Some more feedback on why the edge cases are a concern to me, and why the lack of an ending delimiter is similar to parsing problems already faced. I'd agree that restarting a

Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change

2020-08-16 Thread Deleu
As stated by the RFC: We argue why we should strongly favor a syntax with closing delimiter to > keep consistency with other parts of the language and propose to use #[], > @[], or the original << … >> instead. Given the desire for a closing delimiter, has `@:Attr;` been considered (or even

Re: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2

2020-08-16 Thread Michael Voříšek - ČVUT FEL
I have one major issues with the examples. Syntax Side by Side: The properties are annotated (with attributes) inline which is the opposited of common usage now (with annotation). Discussion on Grouping Pro/Cons: But since this depends on the coding style the user... No, this should be

Re: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2

2020-08-16 Thread Benjamin Eberlei
We have updated the RFC with all (hopefully) of the feedback from this discussion: https://wiki.php.net/rfc/shorter_attribute_syntax_change Most notable changes are: - A new section with several subsections on the benefits of a closing delimiter / enclosing syntax. - A section on grouping

Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change

2020-08-16 Thread Benjamin Eberlei
On Sun, Aug 16, 2020 at 10:39 AM Jakob Givoni wrote: > On Sun, Aug 16, 2020 at 1:00 AM Benjamin Eberlei > wrote: > >> > >> The RFC says that > >> > The main concern is that @@ has no ending symbol and it's > inconsistent with the language > >> > that it would be the only declaration or

Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change

2020-08-16 Thread Benjamin Eberlei
Following the valid criticisms of us starting the vote too early, we have closed the vote for this RFC for now. We look to restart the vote middle next week, so that we can close this before the Beta 3 release on September 3rd. We have updated the RFC at

[PHP-DEV] Voting access

2020-08-16 Thread Michael Voříšek - ČVUT FEL
Hello, based on https://wiki.php.net/rfc/voting voting access is offered to people who: - contributed to PHP source - I have made several smaller contributions to php-src incl. + some core xdebug optimization - lead developers of PHP based projects - I contributed to Symfony, Mink and

Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change

2020-08-16 Thread Jakob Givoni
On Sun, Aug 16, 2020 at 1:00 AM Benjamin Eberlei wrote: >> >> The RFC says that >> > The main concern is that @@ has no ending symbol and it's inconsistent >> > with the language >> > that it would be the only declaration or statement in the whole language >> > that has no ending termination

Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change

2020-08-16 Thread Jakob Givoni
> > Can I make a suggestion? > > Make the new or updated RFC a primary vote on: "Should attributes be > enclosed in delimiters?" Actually, let's add the word "block" in there: "Should attributes be enclosed in block delimiters?" Where block delimiters are "matching" (not interpreted in any

Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change

2020-08-16 Thread Jakob Givoni
> > We are working to integrate our arguments in favour of enclosing from that > Derick and I made in this and the previous thread into the RFC at the moment, > as the lack of them is a valid point of criticism. > > Additionally, Derick and I are waiting for word from Sara and Gabriel at the >