Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Claude Pache
> Le 2 mai 2024 à 14:48, Ollie Read a écrit : > > The question that is holding this PR back is should these methods be 1 > indexed, so that the provided position is consistent with the error messages, > or how a person would typically count, or should they be 0 indexed to remain > consistent

Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Robert Landers
On Fri, May 3, 2024 at 4:01 AM Gina P. Banyard wrote: > > On Thursday, 2 May 2024 at 21:33, Derick Rethans wrote: > > > On 2 May 2024 13:48:36 BST, Ollie Read php@ollie.codes wrote: > > > > > These methods accept an integer to retrieve a parameter by its position, > > > or a string to retrieve b

Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Gina P. Banyard
On Thursday, 2 May 2024 at 21:33, Derick Rethans wrote: > On 2 May 2024 13:48:36 BST, Ollie Read php@ollie.codes wrote: > > > These methods accept an integer to retrieve a parameter by its position, or > > a string to retrieve by its name. So far, I have built this so that if you > > required

Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Robert Landers
On Thu, May 2, 2024 at 10:22 PM Benjamin Außenhofer wrote: > > > On Thu, May 2, 2024 at 2:51 PM Ollie Read wrote: > >> Hi All, >> >> I've been working on a PR that introduces >> ReflectionFunctionAbstract::getParameter() and >> ReflectionFunctionAbstract::hasParameter(), to fall more inline with

Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Derick Rethans
On 2 May 2024 13:48:36 BST, Ollie Read wrote: >These methods accept an integer to retrieve a parameter by its position, or a >string to retrieve by its name. So far, I have built this so that if you >required the first parameter, it's parameter 0. I treat it this way because >the only other pl

Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Benjamin Außenhofer
On Thu, May 2, 2024 at 2:51 PM Ollie Read wrote: > Hi All, > > I've been working on a PR that introduces > ReflectionFunctionAbstract::getParameter() and > ReflectionFunctionAbstract::hasParameter(), to fall more inline with the > other method sets we have, as well as just generally making people

[PHP-DEV] PHP and MySQL 8.4

2024-05-02 Thread Matteo Beccati
Hello internals! Looks like MySQL 8.4 is not loading the 'mysql_native_password' plugin by default anymore, causing some CI failures in connect-related tests. This happens both in the php-src repo and in userland libraries. The issue already shows on CircleCI ARM builds which use a mysql:8 c

Re: [PHP-DEV] RFC [Discussion]: array_find

2024-05-02 Thread Larry Garfield
On Wed, May 1, 2024, at 9:26 PM, Joshua Rüsweg wrote: > Hi > > On 01.05.24 12:26, Larry Garfield wrote: >> This looks good to me, with one remaining exception, which isn't specific to >> this function but should still be discussed: Always passing the value and >> key to the callback is unsafe, fo

[PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Ollie Read
Hi All, I've been working on a PR that introduces ReflectionFunctionAbstract::getParameter() and ReflectionFunctionAbstract::hasParameter(), to fall more inline with the other method sets we have, as well as just generally making peoples lives easier. The PR is here: https://github.com/php/php

[PHP-DEV] Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-05-02 Thread Benjamin Außenhofer
On Tue, Apr 23, 2024 at 3:27 PM Benjamin Außenhofer wrote: > Hi internals, > > My PR for #[\Deprecated] attribute was in hibernation for a long while now > and after some off-list discussion a few weeks ago I have decided to > revisit it and asked Tim to help me out with the work. > > Tim has cle