Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Lars Strojny
Hi Sean, thanks for your answers. Am 08.08.2013 um 02:54 schrieb Sean Cannella se...@fb.com: It does in the sense the same way as the current mode enforces types on properties. That is, there's no guarantee that types will remain as initially set, only that the values passed to the

Re: [PHP-DEV] php_serialize session serialize handler

2013-08-08 Thread Lester Caine
Yasuo Ohgaki wrote: Or make it optional for 5.5 and 5.6, write full documentation about serializer and make new serializer default for future releases. It would work better. There would be enough time for users may have BC issue. If they do, it would be simple task to adopt because it is plain

Re: [PHP-DEV] VCS Account Request: requinix

2013-08-08 Thread Peter Cowburn
On 8 August 2013 05:35, Hannes Magnusson hannes.magnus...@gmail.com wrote: \o/ I've approved your request, which means you have full karma on bugs.php.net and wiki.php.net. Good to have you on board, Damian. :)

Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Leigh
On 7 August 2013 20:47, Sean Cannella se...@fb.com wrote: https://wiki.php.net/rfc/constructor-promotion What do you all think? I'm not sure what problem this is really trying to solve, the boilerplate code you mention is very explicit and it is very clear to the reader what is being done.

Re: [PHP-DEV] php_serialize session serialize handler

2013-08-08 Thread Yasuo Ohgaki
Hi Lester, On Thu, Aug 8, 2013 at 5:26 PM, Lester Caine les...@lsces.co.uk wrote: We need to help get the rest of the infrastructure working with PHP5.4 before starting work on 5.6 ... let alone 5.5 ... Since 5.5 is just released, some fixes may be good to add. However, I agree that released

Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Jordi Boggiano
On 08.08.2013 10:34, Leigh wrote: I'm not sure what problem this is really trying to solve, the boilerplate code you mention is very explicit and it is very clear to the reader what is being done. Each property documented with its type, purpose and visibility in a common place for easy

Re: [PHP-DEV] php_serialize session serialize handler

2013-08-08 Thread Leigh
Sorry I failed at reply to all. On 8 August 2013 11:38, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi Leigh, On Thu, Aug 8, 2013 at 7:23 PM, Leigh lei...@gmail.com wrote: Are you keeping it as optional for 5.6 and not the default? If you're making it default don't we need to vote on BC breaks?

Re: [PHP-DEV] php_serialize session serialize handler

2013-08-08 Thread Yasuo Ohgaki
Hi Leigh, On Thu, Aug 8, 2013 at 7:53 PM, Leigh lei...@gmail.com wrote: but I'm not sure if it should be default behaviour. What's the point of having old serialzers that is bonded to register_globals? This kind of change should have done when 5.4.0 was released, IMO. Regards, -- Yasuo

Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Martin Keckeis
Am 08.08.2013 12:34 schrieb Jordi Boggiano j.boggi...@seld.be: On 08.08.2013 10:34, Leigh wrote: I'm not sure what problem this is really trying to solve, the boilerplate code you mention is very explicit and it is very clear to the reader what is being done. Each property documented with

Re: [PHP-DEV] php_serialize session serialize handler

2013-08-08 Thread Leigh
On 8 August 2013 12:05, Yasuo Ohgaki yohg...@ohgaki.net wrote: What's the point of having old serialzers that is bonded to register_globals? This kind of change should have done when 5.4.0 was released, IMO. Because somebodies code will depend on functionality not changing, and we shouldn't

Re: [PHP-DEV] php_serialize session serialize handler

2013-08-08 Thread Lester Caine
Leigh wrote: On 8 August 2013 12:05, Yasuo Ohgakiyohg...@ohgaki.net wrote: What's the point of having old serialzers that is bonded to register_globals? This kind of change should have done when 5.4.0 was released, IMO. Because somebodies code will depend on functionality not changing, and

[PHP-DEV] Re: [RFC] Importing namespaced functions

2013-08-08 Thread Igor Wiedler
Hi everyone, I just wanted to bump this topic, since there's not been much feedback during the last few weeks. Comments on the patch are also welcome. RFC: https://wiki.php.net/rfc/use_function Patch: https://github.com/php/php-src/pull/388 Thanks, Igor -- PHP Internals - PHP Runtime

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Michael Wallner
On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads https://github.com/m6w6/php-src/compare/stdint So, is everyone fine with it so far? -- Regards, Mike -- PHP Internals - PHP

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Ralf Lang
On 08.08.2013 14:42, Michael Wallner wrote: On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads https://github.com/m6w6/php-src/compare/stdint So, is everyone fine with it so

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Kalle Sommer Nielsen
Hi Michael 2013/8/8 Michael Wallner m...@php.net: On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads https://github.com/m6w6/php-src/compare/stdint So, is everyone fine with it

Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Matthieu Napoli
Le 08/08/2013 13:11, Martin Keckeis a écrit : Am 08.08.2013 12:34 schrieb Jordi Boggiano j.boggi...@seld.be: On 08.08.2013 10:34, Leigh wrote: I'm not sure what problem this is really trying to solve, the boilerplate code you mention is very explicit and it is very clear to the reader what

[PHP-DEV] handling non-fatal compile-time errors

2013-08-08 Thread Ferenc Kovacs
Hi, I've just bumped into https://bugs.php.net/bug.php?id=65322 recently, and I would like you get some opinions on the issue. Personally I think that it is a really bad design to introduce pedantic(E_STRICT) errors which can break basic functionality of the engine (calling the registered

Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Leigh
On 8 August 2013 14:12, Matthieu Napoli matth...@mnapoli.fr wrote: class MyClass { public $foo; protected $bar; public function __construct($this-foo, $this-bar, $baz) { // $this-foo and $this-bar are now set This actually feels _way_ more intuitive to me, it feels like you are

AW: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Robert Stoll
I agree, that looks nice. It is still readable IMO and removes the boilerplate code in the constructor (and setters and where needed) This proposal seems much better to me because the class members $foo and $bar are still in the same place as usual and the compiler does not generate magic code as

AW: [PHP-DEV] Re: [RFC] Importing namespaced functions

2013-08-08 Thread Robert Stoll
Hi Igor, Personally I like your RFC. I also like the fact that it is possible to replace built-in functions where desired by declaring a corresponding use statement. I do not see aliases in your RFC but I guess it would also be possible to write things like: use function foo\bar as foo; cheers,

Re: [PHP-DEV] Re: [RFC] Importing namespaced functions

2013-08-08 Thread Igor Wiedler
Yes, aliases are supported just as you would expect. I will add an example to the RFC. Thanks, Igor On Aug 8, 2013, at 8:17 PM, Robert Stoll rst...@tutteli.ch wrote: Hi Igor, Personally I like your RFC. I also like the fact that it is possible to replace built-in functions where desired

Re: [PHP-DEV] Re: [RFC] Importing namespaced functions

2013-08-08 Thread Michael Wallner
On 8 August 2013 14:29, Igor Wiedler i...@wiedler.ch wrote: Hi everyone, I just wanted to bump this topic, since there's not been much feedback during the last few weeks. Comments on the patch are also welcome. RFC: https://wiki.php.net/rfc/use_function Patch:

Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Michael Wallner
On 8 August 2013 17:16, Leigh lei...@gmail.com wrote: On 8 August 2013 14:12, Matthieu Napoli matth...@mnapoli.fr wrote: class MyClass { public $foo; protected $bar; public function __construct($this-foo, $this-bar, $baz) { // $this-foo and $this-bar are now set This actually

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Michael Wallner
On 8 August 2013 14:44, Kalle Sommer Nielsen ka...@php.net wrote: Hi Michael 2013/8/8 Michael Wallner m...@php.net: On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads

[PHP-DEV] zend bison check

2013-08-08 Thread Michael Wallner
As I have no Zend karma, is anybody kind enough to merge the bison blacklist patch? https://github.com/php/php-src/pull/402 -- Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: PHP 5.5.2 RC1 is tagged

2013-08-08 Thread Michael Wallner
On 5 August 2013 17:46, Christopher Jones christopher.jo...@oracle.com wrote: On 8/5/13 8:12 AM, Jan Ehrhardt wrote: Julien Pauli in php.internals (Fri, 2 Aug 2013 10:05:00 +0200): Please test the release carefully and report any bugs. What is the best way to report things that are so

Re: [PHP-DEV] Re: PHP 5.5.2 RC1 is tagged

2013-08-08 Thread Michael Wallner
On 8 August 2013 21:04, Michael Wallner m...@php.net wrote: On 5 August 2013 17:46, Christopher Jones christopher.jo...@oracle.com wrote: On 8/5/13 8:12 AM, Jan Ehrhardt wrote: What is the best way to report things that are so small that opening an issue would be overkill? Submit pull

Re: [PHP-DEV] RFC: constructor argument promotion

2013-08-08 Thread Martin Keckeis
Am 08.08.2013 15:12 schrieb Matthieu Napoli matth...@mnapoli.fr: Le 08/08/2013 13:11, Martin Keckeis a écrit : Am 08.08.2013 12:34 schrieb Jordi Boggiano j.boggi...@seld.be: On 08.08.2013 10:34, Leigh wrote: I'm not sure what problem this is really trying to solve, the boilerplate

Re: [PHP-DEV] Re: [RFC] Importing namespaced functions

2013-08-08 Thread Daniel Bingham
Hey Igor, I love the RFC, but how about: use bar\baz() as baz; As an alternative to use function. Still new syntax, but a little less wordy. I have nothing for use const, but use const feels more natural to me than use function does. Just an idea for pondering! Dan On Thu, Aug 8, 2013 at

Re: [PHP-DEV] php_serialize session serialize handler

2013-08-08 Thread Yasuo Ohgaki
Hi, On Thu, Aug 8, 2013 at 9:10 PM, Lester Caine les...@lsces.co.uk wrote: Leigh wrote: I can't judge the scope of the break, or how many users will be affected. I just want to say that breaks without a good reason shouldn't happen. Seconded. In hindsight I personally would have

Re: [PHP-DEV] zend bison check

2013-08-08 Thread Ángel González
On 08/08/13 20:56, Michael Wallner wrote: As I have no Zend karma, is anybody kind enough to merge the bison blacklist patch? https://github.com/php/php-src/pull/402 Maybe it should be bison_version_exclude=none so that the error message is nicer? -- PHP Internals - PHP Runtime Development

Re: [PHP-DEV] zend bison check

2013-08-08 Thread Yasuo Ohgaki
Hi, I proposed that specify any bison as developer wants. It seems it is not merged, yet. Usage: YACC=/usr/local/bin/mybison ./configure diff --git a/Zend/acinclude.m4 b/Zend/acinclude.m4 index 454513f..1440a2a 100644 --- a/Zend/acinclude.m4 +++ b/Zend/acinclude.m4 @@ -12,7 +12,7 @@