[PHP-DEV] Re: [RFC] [VOTE] Shorter Attribute Syntax

2020-07-01 Thread Theodore Brown
On Wed, June 17, 2020 at 5:59 PM Theodore Brown wrote: > I've opened voting on the Shorter Attribute Syntax RFC: > https://wiki.php.net/rfc/shorter_attribute_syntax > > Since all RFCs require a primary vote with a 2/3 majority, there is > a main vote to approve the secondary ranked-choice vote.

Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-07-01 Thread tyson andre
Hi Nikita, > Why is the lower limit of the ini setting 15 and not 0? > > I just saw that you mention this possibility as "future scope". > I don't think your reasoning there holds up if you take into account > that we already introduced zend.exception_ignore_args in PHP 7.4 -- > and which is

Re: [PHP-DEV] Draft RFC callable types + callable type/function autoloading

2020-07-01 Thread Larry Garfield
On Wed, Jul 1, 2020, at 4:55 AM, Dan Ackroyd wrote: > On Tue, 26 May 2020 at 18:08, Iván Arias wrote: > > Just a Little question. I see this other document in the same repo: > > > > https://github.com/Danack/FunctionTypes/blob/master/3_referencing_functions_and_callables.md > > > > Are you

Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-07-01 Thread Nikita Popov
On Wed, Jul 1, 2020 at 9:05 PM Nikita Popov wrote: > On Wed, Jul 1, 2020 at 8:55 PM tyson andre > wrote: > >> Hi internals, >> >> I plan to start the voting for >> https://wiki.php.net/rfc/throwable_string_param_max_len on July 11, 2020. >> > > Why is the lower limit of the ini setting 15 and

Re: [PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-07-01 Thread Nikita Popov
On Wed, Jul 1, 2020 at 8:55 PM tyson andre wrote: > Hi internals, > > I plan to start the voting for > https://wiki.php.net/rfc/throwable_string_param_max_len on July 11, 2020. > Why is the lower limit of the ini setting 15 and not 0? Nikita

[PHP-DEV] Re: [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-07-01 Thread tyson andre
Hi internals, I plan to start the voting for  https://wiki.php.net/rfc/throwable_string_param_max_len on July 11, 2020. > Since 2003, `Throwable->getTraceAsString()` and `Throwable->__toString()` > have limited the length of string function arguments in stringified stack > traces to 15 bytes >

[PHP-DEV] [RFC] Allow trailing comma in closure use list

2020-07-01 Thread tyson andre
Hi internals, I've created a new RFC https://wiki.php.net/rfc/trailing_comma_in_closure_use_list to allow a trailing comma in closure use lists. This is already supported for argument and parameter lists. ``` $longArgs_longVars = function ( $longArgument, $longerArgument,

Re: [PHP-DEV][RFC] Saner numeric strings

2020-07-01 Thread Rowan Tommins
Hi George, On Wed, 1 Jul 2020 at 15:26, G. P. B. wrote: > >2. Emit the E_WARNING "Illegal string offset" and evaluate to 0 for >offsets like '2str', and emit the E_WARNING "String offset cast >occurred" for float numeric strings like '2.5' I'm not clear how this option fits with

Re: [PHP-DEV][RFC] Saner numeric strings

2020-07-01 Thread G. P. B.
Hello again, While reviewing the implementation Nikita spotted a peculiar behaviour that PHP currently has in regards to string offsets. The offset is validated using the is_numeric_string but integer representation of it is computed using an explicit int cast, this is what leads to the E_NOTICE

Re: [PHP-DEV][RFC] Saner numeric strings

2020-07-01 Thread G. P. B.
I've added a test case just to ensure that casting of leading numeric strings yields the previous behaviour and have added this to the BC Break section of the RFC: https://wiki.php.net/rfc/saner-numeric-strings Any other feedback or questions are welcomed. George P. Banyard

Re: [PHP-DEV] [RFC] Property write visibility

2020-07-01 Thread Nikita Popov
On Wed, Jul 1, 2020 at 12:58 PM André Rømcke wrote: > > "Attempting to pass a property value outside of allowed writable scope >> as a reference, results in an error." > > > ... we definitely shouldn't do this, because it goes against existing > language semantics. You can take a reference to a

Re: [PHP-DEV] [RFC] Property write visibility

2020-07-01 Thread André Rømcke
>> "Attempting to pass a property value outside of allowed writable scope >> as a reference, results in an error." > > ... we definitely shouldn't do this, because it goes against existing > language semantics. You can take a reference to a normal private property > (i.e. private get, private

Re: [PHP-DEV] [RFC] Property write visibility

2020-07-01 Thread Nikita Popov
On Tue, Jun 30, 2020 at 1:26 PM Dan Ackroyd wrote: > On Mon, 29 Jun 2020 at 10:42, André Rømcke wrote: > > > > I'd like to start discussion on a new RFC proposing a way to be able to > > (optionally) specify property > > write visibility, separate from read: > > > >

Re: [PHP-DEV] Draft RFC callable types + callable type/function autoloading

2020-07-01 Thread Dan Ackroyd
On Tue, 26 May 2020 at 18:08, Iván Arias wrote: > Just a Little question. I see this other document in the same repo: > > https://github.com/Danack/FunctionTypes/blob/master/3_referencing_functions_and_callables.md > > Are you planning to also raise it? Yes, but for PHP 8.1. Although I think

Re: [PHP-DEV] Permitting trailing commas in closure use() declarations

2020-07-01 Thread Nikita Popov
On Wed, Jun 24, 2020 at 5:23 PM tyson andre wrote: > Hi internals, > > https://wiki.php.net/rfc/trailing_comma_in_parameter_list mentioned > > > https://wiki.php.net/rfc/list-syntax-trailing-commas Trailing Commas In > List Syntax was a previous proposal to support optional trailing commas in >