[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-04-02 Thread Gary D. Gregory (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244206#comment-13244206 ] Gary D. Gregory commented on CODEC-96: -- OK, I see the Clirr errors now after applying

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-04-02 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244472#comment-13244472 ] Sebb commented on CODEC-96: --- The mark/reset patch should really be on a separate JIRA, as it is

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-04-01 Thread Gary D. Gregory (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243740#comment-13243740 ] Gary D. Gregory commented on CODEC-96: -- The patch CODEX-96-2.patch applies cleanly on

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-04-01 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243742#comment-13243742 ] Sebb commented on CODEC-96: --- codec-96-3rd-attempt.patch is very old (2010). I think it can be

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-28 Thread Thomas Neidhart (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240530#comment-13240530 ] Thomas Neidhart commented on CODEC-96: -- I have reviewed the patch, which looks good in

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-28 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240542#comment-13240542 ] Sebb commented on CODEC-96: --- bq. BaseNCodec has a member xcontext which is never used Sorry, looks

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-28 Thread Thomas Neidhart (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240566#comment-13240566 ] Thomas Neidhart commented on CODEC-96: -- {quote} That's a separate issue; this patch

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-20 Thread Jochen Wiedmann (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233310#comment-13233310 ] Jochen Wiedmann commented on CODEC-96: -- I agree with Henri: Document the facts and

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-20 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233362#comment-13233362 ] Sebb commented on CODEC-96: --- I think it might be possible to move the mutable fields out of the

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-20 Thread Sebb (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234003#comment-13234003 ] Sebb commented on CODEC-96: --- I've got a prototype which passes all the tests. Basically I put all

[jira] [Commented] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2012-03-19 Thread Matt Ryall (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233234#comment-13233234 ] Matt Ryall commented on CODEC-96: - I'm happy to have it resolved if there's Javadoc saying

[jira] Commented: (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2010-03-29 Thread Jochen Wiedmann (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851037#action_12851037 ] Jochen Wiedmann commented on CODEC-96: -- Excuse me, but have an instance create another

[jira] Commented: (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2010-03-28 Thread Matt Ryall (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12850769#action_12850769 ] Matt Ryall commented on CODEC-96: - Patch looks to me like it would work. Unfortunately, I

[jira] Commented: (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2010-02-26 Thread Jochen Wiedmann (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12838758#action_12838758 ] Jochen Wiedmann commented on CODEC-96: -- The problem is not in the Base64 code, but in

[jira] Commented: (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder

2010-02-26 Thread Julius Davies (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12838924#action_12838924 ] Julius Davies commented on CODEC-96: I agree I should have documented (or even thought