[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061793#comment-16061793
]
Dmitri Blinov commented on JEXL-227:
Shouldn't we simply go away from precompiled values and take values of engine
version and language version from jexl jar's manifest properties, like
Implementation_Version and Specification_version?
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060178#comment-16060178
]
Bruno P. Kinoshita commented on JEXL-227:
-
Looking at Java 8 Nashorn;
{code:java}
import javax.script.ScriptEngine;
import javax.script.ScriptEngineManager;
public class Scripts {
public static void main(String[] args) {
ScriptEngineManager manager = new ScriptEngineManager();
ScriptEngine engine = manager.getEngineByName("nashorn");
System.out.println("ENGINE: " + engine.getFactory().getEngineVersion());
System.out.println("LANGUAGE: " +
engine.getFactory().getLanguageVersion());
}
}
{code}
Gives:
{noformat}
ENGINE: 1.8.0_131
LANGUAGE: ECMA - 262 Edition 5.1
{noformat}
So I believe in our case, the ENGINE_VERSION must match the version of JEXL.
And Language should either match that version, or be 3.0 until there are
changes that impact the language (in that case, we need to remember to update
it should we add/remove features from the language).
>As a reminder, we may want to create a bug that we re-create after each
>release stating 'verify getLanguageVersion/getEngineVersion before release'.
>Otherwise, we'll probably keep forgetting about it...
Big +1 for that. Are you going to do that? Otherwise I can create the ticket,
and assign to the next version, linking to this discussion, and asking the
assignee to create a new one for the next release.
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059203#comment-16059203
]
Henri Biestro commented on JEXL-227:
Checked the JSR 223; semantics on getLanguageVersion/getEngineVersion is not
very detailed.
LANGUAGE_VERSION: Reserved key for the named value that identifies the version
of the scripting language supported by the implementation.
ENGINE_VERSION: Reserved key for a named value that identifies the version of
the ScriptEngine implementation.
As a reminder, we may want to create a bug that we re-create after each release
stating 'verify getLanguageVersion/getEngineVersion before release'. Otherwise,
we'll probably keep forgetting about it...
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058477#comment-16058477
]
Bruno P. Kinoshita commented on JEXL-227:
-
Yup. Besides fixing the version in either or both methods, I'd like to add some
lines in the Javadocs, and then maybe a note somewhere in the project
documentation (wiki?) for when someone releases a new version s/he can remember
to check if this version needs to be updated too.
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058471#comment-16058471
]
Sebb commented on JEXL-227:
---
Surely if the language syntax changes (as mentioned above), then the language
version needs updating?
It's not as clear to me what the engine version is supposed to represent.
Maybe worth checking the JSR
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058343#comment-16058343
]
Bruno P. Kinoshita commented on JEXL-227:
-
(y) thanks for the explanation Henri!
>From the Javadocs of the parent
{code:java}
/**
* Returns the version of the scripting language supported by this
* ScriptEngine.
* @return The version of the supported language.
*/
public String getLanguageVersion();
/**
* Returns the version of the ScriptEngine.
* @return The ScriptEngine implementation version.
*/
public String getEngineVersion();
{code}
So I think #getEngineVersionmust match the version in pom.xml, and
#getLanguageVersion should be 3.0, until we introduce version to the language
that deserve a version bump. Does that sound right?
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057653#comment-16057653
]
Henri Biestro commented on JEXL-227:
Since we've introduced new syntactic elements in 3.1 (side effect operators),
I'd bump the language version to 3.1. However, releasing a new version will
change the version number so #getEngineVersion should return 3.1.1 (probably).
Need to fix a few other bugs/enh before attempting release though.
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (JEXL-227) JexlScriptEngineFactory.getEngineVersion() should return actual version, ie 3.1 as of reporting
[
https://issues.apache.org/jira/browse/JEXL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057388#comment-16057388
]
Bruno P. Kinoshita commented on JEXL-227:
-
Felt tempted to quickly fix and commit. But then realized there are two methods
with 3.0: #getEngineVersion and #getLanguageVersion.
Not sure if we should update both, or one and not the other, or update only
with major releases... Will wait to see if someone else knows (maybe [~henrib]
?) more about these methods, and then maybe we could override the javadoc (or
complement, and use that inheritDoc tag too if necessary) saying what to do /
why.
Cheers
Bruno
> JexlScriptEngineFactory.getEngineVersion() should return actual version, ie
> 3.1 as of reporting
> ---
>
> Key: JEXL-227
> URL: https://issues.apache.org/jira/browse/JEXL-227
> Project: Commons JEXL
> Issue Type: Bug
>Affects Versions: 3.1
>Reporter: Dmitri Blinov
>Priority: Minor
>
> JexlScriptEngineFactory.getEngineVersion() reports "3.0" as a script engine
> version in 3.1
> {code}
> public String getEngineVersion() {
> return "3.0"; // ensure this is updated if function changes are made
> to this class
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
