-Original Message-
From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED]
Sent: 03 December 2003 19:42
To: JMeter Developers List
Subject: Re: Unit tests totally broken
Well, none should ever fail (I mean when committing), so
reporting one
only just makes de clean-up process
ant test shows one failure more than it used to.
In addition, it now hangs.
:-(
We must all (including myself) learn to run the tests before checking.
--
Salut,
Jordi.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional
.
Not sure about a hang, but it can be a bit slow.
S.
-Original Message-
From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED]
Sent: 03 December 2003 11:27
To: JMeter Developers List
Subject: Unit tests totally broken
ant test shows one failure more than it used to.
In addition, it now hangs
a hang, but it can be a bit slow.
S.
-Original Message-
From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED]
Sent: 03 December 2003 11:27
To: JMeter Developers List
Subject: Unit tests totally broken
ant test shows one failure more than it used to.
In addition, it now hangs.
:-(
We must all
Just to clarify and factor out possible platform differences: are you
seeing this unit test failure?
[java] 1)
testGUIComponents(org.apache.jmeter.junit.JMeterTest)junit.framework.ComparisonFailure: GUI-CLASS:
Failed on org.apache.jmeter.protocol.http.control.gui.AccessLogSamplerGui
Developers List
Subject: Re: Unit tests totally broken
Just to clarify and factor out possible platform differences: are you
seeing this unit test failure?
[java] 1)
testGUIComponents(org.apache.jmeter.junit.JMeterTest)junit.framework.Compari
sonFailure: GUI-CLASS: Failed
I've found the cause for this one: the failing test is checking that the
TestElements returned by two consecutive calls to
guiComponent.createTestElement() will be separate -- which is not true
for the AccessLogSamplerGui.
The only reason why it does not fail for the ProxyControlGUI (which
-Original Message-
From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED]
Sent: 03 December 2003 12:50
To: JMeter Developers List
Subject: Re: Unit tests totally broken
Hmmm... it really looks like a hang. The test runs to completion (I see
the output FAILURES!!, and then:
[java
Salvat i Alabart [mailto:[EMAIL PROTECTED]
Sent: 03 December 2003 12:50
To: JMeter Developers List
Subject: Re: Unit tests totally broken
Hmmm... it really looks like a hang. The test runs to completion (I see
the output FAILURES!!, and then:
[java] FAILURES!!!
[java] Xlib: unexpected
The AccessLogSamplerGui holds a reference to an internal HTTPSampler,
and it stores values in it as well as in the individual GUI elements. Because
of the interaction of modifyTestElement, createTestElement, and
configure(TestElement), this double storing of values causes problems. The
I know it's not serious, but it doesn't help asking people to check for
clean unit tests before committing.
As a whole, I have a feeling that our TreeNode--TestElement--GUI
relationship (and the corresponding API semantics) is not as clean as it
should be. We'll need to work on that [again] in
fail; a single test can have
several failures.
S.
-Original Message-
From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED]
Sent: 03 December 2003 13:30
To: JMeter Developers List
Subject: Re: Unit tests totally broken
[...] the test won't continue after that first failure.
Which is wrong
Mike is right. He and I had discussions about how to best handle validation at
runtime. I probably won't have time until next week to fix it, so feel free to clean
out AccessLogSampler.
the larger problem of how to handle runtime errors and pass the events back to the GUI
is a much larger
[mailto:[EMAIL PROTECTED]
Sent: 03 December 2003 13:30
To: JMeter Developers List
Subject: Re: Unit tests totally broken
[...] the test won't continue after that first failure.
Which is wrong: the test or the components
14 matches
Mail list logo
