[kbuild-devel] Re: [PATCH] Pointer cast warnings in scripts/

2005-06-22 Thread Russell King
On Wed, Jun 22, 2005 at 01:12:06PM +0200, Pierre Ossman wrote:
 That doesn't really make it a standard though (de facto perhaps). :)
 The odds of all those man pages deviating from the standard is probably
 very low. But unless someone has actually read the damn thing we won't
 know for sure.

You could check the C99 spec of course, which says gives (eg) strcmp as:

   int strcmp(const char *s1, const char *s2);

rmk's rules of char:

1. use char for character strings and individual characters
2. use signed char if your data type relies upon negative char values
3. use unsigned char if your data type does not require negative char
   values, especially if it makes use of the positive values not
   present in the signed char range.

IOW, use signed/unsigned when you need to explicitly state your
requirements, but omit it for true strings and characters.

-- 
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core


---
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477alloc_id=16492op=click
___
kbuild-devel mailing list
kbuild-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kbuild-devel


[kbuild-devel] Fwd: RE: [BUG] 2.6.0: ARM won't build without CONFIG_CPU_FREQ_GOV_USERSPACE=y

2003-12-26 Thread Russell King
There appears to be an issue with select vs choice statements; see the
message below.

Essentially, it appears a default selection in a choice statement takes
precidence over an explicit select statement for one of the choice
options.

- Forwarded message from [EMAIL PROTECTED] -
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED], [EMAIL PROTECTED]
Bcc: [EMAIL PROTECTED]
Subject: RE: [BUG] 2.6.0: ARM won't build without CONFIG_CPU_FREQ_GOV_USERSPACE=y
Date: Fri, 26 Dec 2003 10:57:54 +0100

Because of cpufreq_get() being necessary for SA1100 it is already
special-handled for this architecture. 

A snippet from arch/arm/Kconfig:

# CPUfreq on SA11x0 is special -- it _needs_ the userspace governor

config CPU_FREQ_SA1100
bool
depends on CPU_FREQ  SA1100_LART
default y
select CPU_FREQ_DEFAULT_GOV_USERSPACE
select CPU_FREQ_24_API if SYSCTL

config CPU_FREQ_SA1110
bool
depends on CPU_FREQ  (SA1100_ASSABET || SA1100_CERF |
SA1100_PT_SYSTEM3)
default y
select CPU_FREQ_DEFAULT_GOV_USERSPACE
select CPU_FREQ_24_API if SYSCTL


IMO this should cause the default governor to be forced to userspace,
and the deprecated 2.4. API [including cpufreq_get()] to be activated as
well. However, Kconfig thinks different: the default setting for
CPU_FREQ_DEFAULT_GOV (see drivers/cpufreq/Kconfig) is PERFORMANCE, and
this seems to take precedence over the select. IMHO this is a Kconfig
bug -- can you notify the maintainer of this issue, please?

Else we'd have to change drivers/cpufreq/Kconfig from
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
to
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE if !CPU_FREQ_SA1100
default CPU_FREQ_DEFAULT_GOV_USERSPACE if !CPU_FREQ_SA1100
or disable the selection for CPU_FREQ_SA1100 completely.

Dominik


- End forwarded message -

-- 
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA  - http://pcmcia.arm.linux.org.uk/
 2.6 Serial core


---
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278alloc_id=3371op=click
___
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel


[kbuild-devel] [BUG] 2.6.0: make gconfig broken

2003-12-25 Thread Russell King
Hi,

I'm just trying to get a new kernel build box up and running, and
I tripped over this with 2.6.0:

  HOSTCC  scripts/kconfig/gconf.o
In file included from /usr/include/gtk-2.0/gtk/gtk.h:90,
 from /home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c:17:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:51: warning: function declaration isn't a 
prototype
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c: In function 
`on_treeview1_button_press_event':
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c:1175: warning: passing arg 1 of 
`gtk_widget_grab_focus' from incompatible pointer type
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c: In function `update_tree':
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c:1404: warning: unused variable `path'
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c: In function `display_tree':
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c:1530: warning: suggest parentheses 
around  within ||
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c: At top level:
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:6: warning: `xpm_load' defined but 
not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:36: warning: `xpm_save' defined but 
not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:66: warning: `xpm_back' defined but 
not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:175: warning: `xpm_symbol_no' defined 
but not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:192: warning: `xpm_symbol_mod' 
defined but not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:209: warning: `xpm_symbol_yes' 
defined but not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:226: warning: `xpm_choice_no' defined 
but not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:243: warning: `xpm_choice_yes' 
defined but not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:277: warning: `xpm_menu_inv' defined 
but not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/images.c:294: warning: `xpm_menuback' defined 
but not used
/home/rmk/linux-2.6-rmk/scripts/kconfig/gconf.c:981: warning: `renderer_toggled' 
defined but not used

-- 
Russell King
 Linux kernel2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA  - http://pcmcia.arm.linux.org.uk/
 2.6 Serial core


---
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278alloc_id=3371op=click
___
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel


[kbuild-devel] Re: [patch] kernel config 3/N - move sound into drivers/media

2002-08-14 Thread Russell King

On Tue, Aug 13, 2002 at 11:35:58PM -0500, Peter Samuelson wrote:
 The big loser here is ARM - it no longer suppresses the sound card
 question for the appropriate boards.  But it's just one question, so I
 didn't sweat it too much.

I'd be tempted to drop that set of tests, and just rely on the per-driver
stuff, where its sane to do so.  There's no way we can special case all
the drivers out there for each machine type in the generic config files.
That is the route to madness.

-- 
Russell King ([EMAIL PROTECTED])The developer of ARM Linux
 http://www.arm.linux.org.uk/personal/aboutme.html



---
This sf.net email is sponsored by: Dice - The leading online job board
for high-tech professionals. Search and apply for tech jobs today!
http://seeker.dice.com/seeker.epl?rel_code=31
___
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel



[kbuild-devel] Re: Announce: Kernel Build for 2.5, Release 2.0 is available

2002-04-06 Thread Russell King

On Sat, Apr 06, 2002 at 12:03:15PM +1000, Keith Owens wrote:
 The timings above were for exactly the same .config on the same build
 machine,

Can you provide details of this machine?

-- 
Russell King ([EMAIL PROTECTED])The developer of ARM Linux
 http://www.arm.linux.org.uk/personal/aboutme.html


___
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel



[kbuild-devel] Re: CML2-2.1.3 is available

2002-01-15 Thread Russell King

On Tue, Jan 15, 2002 at 02:53:24PM -0500, Eric S. Raymond wrote:
   * The `vitality' flag is gone from the language.  Instead, the 
 autoprober detects the type of your root filesystem and forces
 its symbol to Y.

This seems like a backwards step.  What's the reasoning for breaking the
ability to configure the kernel for a completely different machine to the
one that you're running the configuration/build on?

Answers including Aunt Tillies or Penelopes won't be accepted. 8)

-- 
Russell King ([EMAIL PROTECTED])The developer of ARM Linux
 http://www.arm.linux.org.uk/personal/aboutme.html


___
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel



Re: [kbuild-devel] Re: State of the new config build system

2001-12-30 Thread Russell King

On Sun, Dec 30, 2001 at 05:14:22PM +, David Woodhouse wrote:
 [EMAIL PROTECTED] said:
   unless (ISA or PCI) suppress dependent IDE
 
  Just a minor point, but what about non-PCI/ISA ide?
 
 Eric is merely representing the _existing_ rules. Changing the behaviour 
 can come later - that shouldn't be done at the same time as introducing CML2.

Existing rules allow non-PCI/ISA IDE.  Its a bug, not a change of
behaviour.

-- 
Russell King ([EMAIL PROTECTED])The developer of ARM Linux
 http://www.arm.linux.org.uk/personal/aboutme.html


___
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel



Re: [kbuild-devel] Re: State of the new config build system

2001-12-29 Thread Russell King

On Sat, Dec 29, 2001 at 05:43:54PM -0500, Eric S. Raymond wrote:
 Tom Rini [EMAIL PROTECTED]:
   unless (ISA or PCI) suppress dependent IDE
  
  Just a minor point, but what about non-PCI/ISA ide?
 
 The CML1 rules seem to imply that this set is empty.

RiscPC:
  CONFIG_PCI=n
  CONFIG_ISA=n
  CONFIG_ARCH_ACORN=y

Yet, we have in drivers/ide:
  if [ $CONFIG_ARCH_ACORN = y ]; then
 dep_bool 'ICS IDE interface support' CONFIG_BLK_DEV_IDE_ICSIDE 
$CONFIG_ARCH_ACORN
 dep_bool '  ICS DMA support' CONFIG_BLK_DEV_IDEDMA_ICS 
$CONFIG_BLK_DEV_IDE_ICSIDE
 dep_bool 'Use ICS DMA by default' CONFIG_IDEDMA_ICS_AUTO 
$CONFIG_BLK_DEV_IDEDMA_ICS
 define_bool CONFIG_BLK_DEV_IDEDMA $CONFIG_BLK_DEV_IDEDMA_ICS
 dep_bool 'RapIDE interface support' CONFIG_BLK_DEV_IDE_RAPIDE 
$CONFIG_ARCH_ACORN
  fi

So I guess I've found a bug.

-- 
Russell King ([EMAIL PROTECTED])The developer of ARM Linux
 http://www.arm.linux.org.uk/personal/aboutme.html


___
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel



[kbuild-devel] Re: Request for comment -- a better attribution system

2001-04-22 Thread Russell King

On Sun, Apr 22, 2001 at 11:22:11AM +0100, Matthew Kirkwood wrote:
 C: CONFIG_SCSI_BLARG
 
 tag to MAINTAINERS.  If you _really_ insist, add an:
 
 F: drivers/scsi/blarg.c
 F: drivers/scsi/blarg.h
 
 too.  It removes the ambiguity inherent in the current system,
 without adding an overengineered solution with no obvious
 advantages.

And what would:

C: CONFIG_ARM

tell you?  Nothing that is not described in the rest of the ARM PORT
entry.

--
Russell King ([EMAIL PROTECTED])The developer of ARM Linux
 http://www.arm.linux.org.uk/personal/aboutme.html


___
kbuild-devel mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/kbuild-devel