Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Rolf Eike Beer
ReadPipe() doesn't return 0 as expected in the case that the command is not found. but the length of sh's output which is command not found in this case. This is because popen() does not fail if the command is not found, because it _can_ run sh. (according to the man page, popen calls /bin/sh

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43323 --- Ship it! OK. I only meant don't remove existing code that

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43331 --- Ship it! Ship It! - John Layt On Oct. 22, 2013, 4:49 p.m.,

RE: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Wolfgang Bauer
-Original Message- From: Rolf Eike Beer [mailto:k...@opensource.sf-tec.de] Sent: Sunday, November 10, 2013 9:11 AM To: kde-core-devel@kde.org; Wolfgang Bauer Cc: David Stephen Hubner Subject: Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the

Re: Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

2013-11-10 Thread Michael Pyne
On Sun, November 10, 2013 11:18:19 Wolfgang Bauer wrote: -Original Message- From: Rolf Eike Beer [mailto:k...@opensource.sf-tec.de] Sent: Sunday, November 10, 2013 9:11 AM To: kde-core-devel@kde.org; Wolfgang Bauer Cc: David Stephen Hubner Subject: Re: Review Request 113779:

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Kevin Ottens
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Any chance for an update? - Kevin --- This is an automatically generated

Re: Review Request 113785: Fix Mozilla bookmark importing

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/#review43352 --- Ship it! kio/bookmarks/kbookmarkimporter_ns.cc

Re: Review Request 113785: Fix Mozilla bookmark importing

2013-11-10 Thread Dawit Alemayehu
On Nov. 10, 2013, 3:51 p.m., David Faure wrote: kio/bookmarks/kbookmarkimporter_ns.cc, line 65 http://git.reviewboard.kde.org/r/113785/diff/1/?file=212403#file212403line65 (could be more optimized with startsWith(HR, Qt::CaseInsensitive) -- but ok, the rest of the code uses

Re: Review Request 113785: Fix Mozilla bookmark importing

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/#review43368 --- This review has been submitted with commit

Re: Review Request 113785: Fix Mozilla bookmark importing

2013-11-10 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/ --- (Updated Nov. 10, 2013, 5 p.m.) Status -- This change has been

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Denis Kuplyakov
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Yes I will finish it, when have time. There are many pre-exams in university. -