D29428: Update categories docbook (KMM)

yurchor accepted this revision. This revision is now accepted and ready to land. REPOSITORY R261 KMyMoney BRANCH docs REVISION DETAIL https://phabricator.kde.org/D29428 To: ostroffjh, kde-doc-english, #kmymoney, yurchor Cc: yurchor, #kmymoney, kde-doc-english, gennad, fbampaloukas,

D22594: [Dolphin] Open Preferred Search Tool action

elvisangelaccio added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:2289 > > It is still impossible to detect (un)installation of such tool. > > There's signals when the KSycoca service database changes which we use in the > application menu to update when apps are

D29428: Update categories docbook (KMM)

ostroffjh updated this revision to Diff 82032. ostroffjh added a comment. - Fix typos found by yurchor REPOSITORY R261 KMyMoney CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29428?vs=81940=82032 BRANCH docs REVISION DETAIL https://phabricator.kde.org/D29428 AFFECTED FILES

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > It is still impossible to detect (un)installation of such tool. > "More Search Tools" menu currently recreates the menu from > KMoreToolsMenuFactory when it is shown. > It is still impossible to

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:2289 > > (can be modified with More Search Tools -> More -> Configure) > > Then there should be a signal in `KMoreTools` a user of this class can > connect to to get notified when user preference

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > > So, the URL does not have any impact on the search tool chosen? I thought > > that was the main reason for using the URL and updating it all the time. > > This depends on KMoreToolsMenuFactory.

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:2289 > > It is a rare occasion that user changes preferred search tools, > > So, the URL does not have any impact on the search tool chosen? I thought > that was the main reason for using the URL and

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > It was added to handle this action as a button in toolbar (can be added by > user, and this was requested in #384798). > > I didn't notice this causes such a problem with remote connections,

D22594: [Dolphin] Open Preferred Search Tool action

pdabrowski added inline comments. INLINE COMMENTS > broulik wrote in dolphinmainwindow.cpp:943 > `exec()` on a job is generally bad, but looks like it was like this already? Yes, it was like that in DolphinMainWindow::openTerminal() before. It was needed as explained in this comment: // If

D29428: Update categories docbook (KMM)

yurchor requested changes to this revision. yurchor added a comment. This revision now requires changes to proceed. Thanks in advance for fixing these minor typos. INLINE COMMENTS > details-categories.docbook:37 > + category menu item; select a parent in the tree > + in the Categories