This revision was automatically updated to reflect the committed changes.
Closed by commit R293:1a3c23f076d2: [FileWatchTest] Extend coverage to config
updates (authored by bruns).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D29190?vs=81207=81229#toc
REPOSITORY
R293 Baloo
CHANGES
bruns marked an inline comment as done.
REPOSITORY
R293 Baloo
BRANCH
fwtest
REVISION DETAIL
https://phabricator.kde.org/D29190
To: bruns, #baloo, ngraham, meven
Cc: meven, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, domson, ashaposhnikov, michaelh,
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> meven wrote in filewatchtest.cpp:223
> Maybe less, to keep the test reasonably fast.
Does not really matter as soon as the code is fixed (review pending). Default
would be 5000.
REPOSITORY
R293 Baloo
meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> filewatchtest.cpp:223
> +QEXPECT_FAIL("", "Removal of excluded folders not deteced", Continue);
> +QVERIFY(spyIndexNew.wait(500));
> +for (const QList& event
meven added inline comments.
INLINE COMMENTS
> filewatchtest.cpp:165
> +
> +Test::writeIndexerConfig({d1, d2}, {d11, d21});
> +FileIndexerConfig config;
Could you add a comment "d11, d21 are marked as excluded"
REPOSITORY
R293 Baloo
REVISION DETAIL
bruns updated this revision to Diff 81207.
bruns added a comment.
whitespace
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29190?vs=81205=81207
BRANCH
fwtest
REVISION DETAIL
https://phabricator.kde.org/D29190
AFFECTED FILES
bruns added a dependent revision: D29191: [FileWatch] Fix watch updates on
config changes.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D29190
To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, domson,
bruns added a dependent revision: D29189: [KInotify] Fix path matching when
removing watches.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D29190
To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, domson,
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Currently, config changes are not covered in the
tests, add a test case
