Re: [Kgdb-bugreport] [PATCH 4/4] kgdb: x86: Detach gdb if machine shuts down or reboots

2012-03-19 Thread Jan Kiszka
On 2012-03-16 16:36, Jason Wessel wrote: On 03/16/2012 07:17 AM, Jan Kiszka wrote: Hook into machine restart/power-off/halt handlers and call gdbstub_exit so that a attached gdb frontend is properly informed. If kgdb is disabled or no frontend attached, gdbstub_exit will do nothing. We

Re: [Kgdb-bugreport] [PATCH 1/4] kgdb: x86: Return all segment registers also in 64-bit mode

2012-03-19 Thread Jan Kiszka
On 2012-03-16 16:57, Jason Wessel wrote: On 03/16/2012 07:17 AM, Jan Kiszka wrote: Even if the content is always 0, gdb expects us to return also ds, es, fs, and gs while in x86-64 mode. Do this to avoid ugly errors on info registers. Signed-off-by: Jan Kiszka jan.kis...@siemens.com ---

Re: [Kgdb-bugreport] [PATCH 1/4] kgdb: x86: Return all segment registers also in 64-bit mode

2012-03-19 Thread Jason Wessel
On 03/19/2012 08:52 AM, Jan Kiszka wrote: On 2012-03-16 16:57, Jason Wessel wrote: The rest should be fine. I can test this and add it to the merge queue with the NUMREGBYTES change, unless you disagree. I don't disagree. :) Sounds fine. I added this to the merge queue for the 3.4 kernel.

Re: [Kgdb-bugreport] [PATCH 4/4] kgdb: x86: Detach gdb if machine shuts down or reboots

2012-03-19 Thread Jason Wessel
On 03/19/2012 08:49 AM, Jan Kiszka wrote: An arch-independent hook has its advantages, no question. Maybe we should just start this way and then evolved on top as needed. Sounds good to me. I added the reboot notifier patch into the merge queue for kgdb/kdb. I was wondering why those

[Kgdb-bugreport] KGDB / KDB Merge queue for 3.4

2012-03-19 Thread Jason Wessel
This is the merge queue for the 3.4 kernel, in case anyone wanted to further comment, before I send the pull request. git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git for_linus Thanks, Jason. --- Andrei Warkentin (1): KDB: Fix usability issues relating to the 'enter' key.

[Kgdb-bugreport] [PATCH 2/5] kgdb: Respect that flush op is optional

2012-03-19 Thread Jason Wessel
From: Jan Kiszka jan.kis...@siemens.com Not all kgdb I/O drivers implement a flush operation. Adjust gdbstub_exit accordingly. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jason Wessel jason.wes...@windriver.com --- kernel/debug/gdbstub.c |3 ++- 1 files changed, 2

[Kgdb-bugreport] [PATCH 3/5] kgdb, debug-core, gdbstub: Hook the reboot notifier for debugger detach

2012-03-19 Thread Jason Wessel
The gdbstub and kdb should get detached if the system is rebooting. Calling gdbstub_exit() will set the proper debug core state and send a message to any debugger that is connected to correctly detach. An attached debugger will receive the exit code from include/linux/reboot.h based on SYS_HALT,

[Kgdb-bugreport] [PATCH 5/5] kgdb, debug_core: add the ability to control the reboot notifier

2012-03-19 Thread Jason Wessel
Sometimes it is desirable to stop the kernel debugger before allowing a system to reboot either with kdb or kgdb. This patch adds the ability to turn the reboot notifier on and off or enter the debugger and stop kernel execution before rebooting. It is possible to change the setting after

[Kgdb-bugreport] [PATCH 4/5] KDB: Fix usability issues relating to the 'enter' key.

2012-03-19 Thread Jason Wessel
From: Andrei Warkentin andrey.warken...@gmail.com This fixes the following problems: 1) Typematic-repeat of 'enter' gives warning message and leaks make/break if KDB exits. Repeats look something like 0x1c 0x1c 0x9c 2) Use of 'keypad enter' gives warning message and leaks the ENTER