Re: [Kgdb-bugreport] [PATCH] i386/x86_64 h/w breakpoints: coding style cleanups

2007-08-08 Thread Pete/Piet Delaney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sergei Shtylyov wrote: Piet Delaney wrote: Perform the following coding style cleanups in i386/x86_64 KGDB ports: - make the 'breakinfo' array 'static' (x86_64 only); - replace the references to 'breakno' variable with constants in the

Re: [Kgdb-bugreport] [PATCH] i386/x86_64 h/w breakpoints: coding style cleanups

2007-08-05 Thread Wessel, Jason
-Original Message- From: Sergei Shtylyov [mailto:[EMAIL PROTECTED] Well, probably it's as good as it is -- will teach me to separate cleanups to the different patches. :-) If I need to separate the patches differently, please let me know, and I'll shift some hunks around.

Re: [Kgdb-bugreport] [PATCH] i386/x86_64 h/w breakpoints: coding style cleanups

2007-08-03 Thread Jason Wessel
Sergei Shtylyov wrote: Hello. Erm... the patches were not separated at this place actually but before kgdb_arch_handle_exception()... Anyway, x86_64-hw_breakpoints.patch fails to apply for me now, here's the reject: Are you sure the source forge cvs was up todate? I don't see

Re: [Kgdb-bugreport] [PATCH] i386/x86_64 h/w breakpoints: coding style cleanups

2007-08-03 Thread Sergei Shtylyov
Hello. Jason Wessel wrote: Erm... the patches were not separated at this place actually but before kgdb_arch_handle_exception()... Anyway, x86_64-hw_breakpoints.patch fails to apply for me now, here's the reject: Are you sure the source forge cvs was up todate? Yeah, those

Re: [Kgdb-bugreport] [PATCH] i386/x86_64 h/w breakpoints: coding style cleanups

2007-08-03 Thread Sergei Shtylyov
Hello. Jason Wessel wrote: Index: linux-2.6/arch/x86_64/kernel/kgdb.c === --- linux-2.6.orig/arch/x86_64/kernel/kgdb.c +++ linux-2.6/arch/x86_64/kernel/kgdb.c Everything in between belongs to x86_64-hw_breakpoints.patch and

Re: [Kgdb-bugreport] [PATCH] i386/x86_64 h/w breakpoints: coding style cleanups

2007-07-31 Thread Sergei Shtylyov
Piet Delaney wrote: Perform the following coding style cleanups in i386/x86_64 KGDB ports: - make the 'breakinfo' array 'static' (x86_64 only); - replace the references to 'breakno' variable with constants in the 'switch' statement of kgdb_correct_hw_break(); - fixed the parameter list

Re: [Kgdb-bugreport] [PATCH] i386/x86_64 h/w breakpoints: coding style cleanups

2007-07-30 Thread Sergei Shtylyov
Hello, I wrote: Perform the following coding style cleanups in i386/x86_64 KGDB ports: Actually, it needs to be split between 4 patches. - make the 'breakinfo' array 'static' (x86_64 only); - replace the references to 'breakno' variable with constants in the 'switch' statement of