Review Request 130046: Removed kde3 and qt3 dependencies from oscar protocol

2017-03-24 Thread Vijay Krishnavanshi
protocols/oscar/oscarstatusmanager.cpp 9154e57 protocols/oscar/oscarversionupdater.h 2e6b9e7 Diff: https://git.reviewboard.kde.org/r/130046/diff/ Testing --- Thanks, Vijay Krishnavanshi

Re: Review Request 130046: Removed kde3 and qt3 dependencies from oscar protocol

2017-03-24 Thread Vijay Krishnavanshi
o reply, visit: https://git.reviewboard.kde.org/r/130046/#review102939 --- On March 24, 2017, 4:42 p.m., Vijay Krishnavanshi wrote: > > --- > This is an automatically generated e-

Re: Review Request 130046: Adapted slots and signal to qt4 of oscar protocol with minor changes to header files

2017-03-24 Thread Vijay Krishnavanshi
protocols/oscar/oscarprivacyengine.h 6bbacf4 protocols/oscar/oscarstatusmanager.cpp 9154e57 protocols/oscar/oscarversionupdater.h 2e6b9e7 Diff: https://git.reviewboard.kde.org/r/130046/diff/ Testing --- Thanks, Vijay Krishnavanshi

Re: Review Request 130046: Removed kde3 and qt3 dependencies from oscar protocol

2017-03-24 Thread Vijay Krishnavanshi
> On March 24, 2017, 4:56 p.m., Pali Rohár wrote: > > KDE3 and Qt3 support libraries are not used by oscar protocol anymore... > > IIRC they were removed in commit 42bdc1dcfcd442e44775020d3354522e10f77c98. > > So what is reason for this very huge patch? > > Vijay K

Re: Review Request 130041: Adapted slots and signal to qt4 of wlm and testbed protocol with minor changes to header files

2017-03-24 Thread Vijay Krishnavanshi
protocols/wlm/wlmlibmsn.h 6b76630 protocols/wlm/wlmlibmsn.cpp 3691ba1 protocols/wlm/wlmprotocol.cpp e559e4f protocols/wlm/wlmsocket.h 3d50416 protocols/wlm/wlmtransfermanager.h 5a2ec61 Diff: https://git.reviewboard.kde.org/r/130041/diff/ Testing --- Thanks, Vijay

Regarding GSoC project Kopete KF5 port

2017-03-22 Thread vijay krishnavanshi
the possible changes in the timeline and approach. Looking forward to your replies. Regards, Vijay Krishnavanshi

Regarding GSoC 2017 project Kopete: KF5 port

2017-03-25 Thread vijay krishnavanshi
mentor me. Regards, Vijay Krishnavanshi

Re: Review Request 130014: Adapted signal slot of gadu protocol to qt5

2017-03-15 Thread Vijay Krishnavanshi
/ Testing --- Thanks, Vijay Krishnavanshi

Review Request 130041: removed qt3 headers, adapted slots and signal to qt4 of wlm and testbed protocols

2017-03-21 Thread Vijay Krishnavanshi
/wlm/wlmprotocol.cpp e559e4f protocols/wlm/wlmsocket.h 3d50416 protocols/wlm/wlmtransfermanager.h 5a2ec61 Diff: https://git.reviewboard.kde.org/r/130041/diff/ Testing --- Thanks, Vijay Krishnavanshi

Review Request 130014: Adapted signal slot of gadu protocol to qt5

2017-03-15 Thread Vijay Krishnavanshi
6d4cdec protocols/gadu/gaduregisteraccount.cpp 640c853 protocols/gadu/gadusession.cpp 53e4747 Diff: https://git.reviewboard.kde.org/r/130014/diff/ Testing --- Thanks, Vijay Krishnavanshi

Re: Review Request 130041: Adapted slots and signal to qt4 of wlm and testbed protocol with minor changes to header files

2017-04-21 Thread Vijay Krishnavanshi
3d50416 protocols/wlm/wlmtransfermanager.h 5a2ec61 Diff: https://git.reviewboard.kde.org/r/130041/diff/ Testing --- Thanks, Vijay Krishnavanshi

Re: Review Request 129325: Fix build with mediastreamer >= 2.14

2017-03-09 Thread Vijay Krishnavanshi
> On Nov. 3, 2016, 7:32 p.m., Pali Rohár wrote: > > Can you point to documentation or description of that changed function API? > > Or e.g. to sources? > > Fabian Vogt wrote: > Unfortunately the official online source is broken (as is the online git > browser), but I found a mirror on

Regarding old review requests for kopete on git reviewsboard

2017-03-05 Thread vijay krishnavanshi
Hi, I looked around the old review requests of kopete on git reviewboard. What needs to be done with review requests that are open. Do I need to apply the patches according to the reviews or something else? Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 13 Report 1]

2017-08-11 Thread vijay krishnavanshi
work on improving the front-end of the application also. I think that issues will be mainly due to port of functions and of UI changes. I will also work try to spot bugs and fix them. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 9 Report 1]

2017-07-15 Thread vijay krishnavanshi
will update the written tests after that is resolved, till then I will write autotests that test the feature of plugins without config file. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 10 Report 1]

2017-07-22 Thread vijay krishnavanshi
to atleast complete the port of Oscar protocol and remove all the usage of deprecated function by the end of this week. I will get up to time line by the end of this week. Regard, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 11 Report 1]

2017-07-27 Thread vijay krishnavanshi
will look for bug fixes in the main codebase. Sorry, Laurent I wanted to complete 100 patches before 29 July but it looks like I will only be able to submit 60 Patches tops by then :( Not that I want to sound like giving an excuse but I fell sick. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 10 Report 2]

2017-07-27 Thread vijay krishnavanshi
of these libkopete and plugins are done and Oscar protocol out of protocols is complete. Kopete mainly contains the GUI Components and needs autotests. I will start working on kopete module after I am done with protocols. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 9 Report 2]

2017-07-20 Thread vijay krishnavanshi
with these tests. I am first porting the plugins to KF5/Qt5 and then writing tests for them to spot regression if any. I am also working on spotting the bugs in the main codebase. I will complete the remaining plugin tests and will start on autotests for protocols in the coming week. Regards, Vijay

Project - Autotests and improving Protocol Support for Kopete [Week 8 Report 2]

2017-07-12 Thread vijay krishnavanshi
://git.reviewboard.kde.org/r/130155/ - https://git.reviewboard.kde.org/r/130173/ So please review them whenever you get time :) I have just mentioned them to make them easily available. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 6 Report 2]

2017-06-28 Thread vijay krishnavanshi
to the time line as I think this is part of improving protocol support of kopete. Some of the stuff that need to be ported will need to be reimplemented. I am trying to spec it out to work on it. Regards, Vijay Krishnavanshi

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

2017-07-04 Thread Vijay Krishnavanshi
tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION tests/libkopete/kopetestatustest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/130155/diff/ Testing --- Thanks, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 8 Report 1]

2017-07-04 Thread vijay krishnavanshi
commented out. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 7 Report 2]

2017-07-03 Thread vijay krishnavanshi
open another review request this week Link: https://git.reviewboard.kde.org/r/130170/ I will post another review request with some fixes on which I also worked last week. I will speed up the work in coming week to make up. Regards, Vijay Krishnavanshi

Re: Kopete & KF5 switch

2017-08-05 Thread vijay krishnavanshi
I will try to verify the same for the application. I have linked it below to make sure if this is the same commit we are talking about. Link : https://cgit.kde.org/kopete.git/commit/?h=kf5=cb97ce4e61baa44d9f401b8853982355ef6e684f Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 12 Report 1]

2017-08-04 Thread vijay krishnavanshi
. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 11 Report 2]

2017-08-01 Thread vijay krishnavanshi
connections slots don't exist and signals in some. I will try to find out what is needed for fixing them by looking at the previous working version of Kopete. Regards, Vijay Krishnavanshi

Re: Kopete & KF5 switch

2017-08-09 Thread vijay krishnavanshi
Hi Pali, I am still unable to access the repo. Can you please see if the link that you gave is correct? I don't think syncing should take this long, I may be wrong also. Regards, Vijay Krishnavanshi New branch master-kf5 is in my cloned repository, available at: > https://cgit.kde.org/clo

Project - Autotests and improving Protocol Support for Kopete [Week 12 Report 2]

2017-08-09 Thread vijay krishnavanshi
Jabber Protocol I am still stuck at handling the third party function calls. I am reading about it how it can be done but as not much documentation and example implementation is available I will need to work more on it. Regards, Vijay Krishnavanshi

Query Regarding GSoC Project Kopete

2017-08-04 Thread vijay krishnavanshi
, Vijay Krishnavanshi

Re: Kopete & KF5 switch

2017-08-06 Thread vijay krishnavanshi
ning in systray after closing > last window. > Yes, now I see, I will make a patch undoing that particular line. Regards, Vijay Krishnavanshi

Re: Kopete & KF5 switch

2017-08-06 Thread vijay krishnavanshi
Hi, I am fixing the raised issues in old review requests so how do I submit the changes for review. Should I create a new review request addressing all the issues or create a separate review request for each old review request? or comment on the old review request for the changes? Regards, Vijay

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

2017-08-06 Thread Vijay Krishnavanshi
-CREATION tests/libkopete/kopetestatusmessagetest.cpp ea25894 tests/libkopete/kopetestatustest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/130155/diff/ Testing --- Thanks, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 13 Report 2]

2017-08-22 Thread vijay krishnavanshi
like kmail, kcontact and others also to find the issues that can be improved. I was busy with my Visa application since last two days. I will be able to deliver at least 70% of the project at the end of GSoC period and will complete it before the Randa Meetings :) Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 14 Report 1]

2017-08-22 Thread vijay krishnavanshi
://community.kde.org/GSoC/2017/StatusReports/vijay Regards, Vijay Krishnavanshi

Re: GSoC 2017 - Announcement of Kopete projects

2017-05-09 Thread vijay krishnavanshi
will be able to get. I will try my best to maximise it :) I will also make room for revisiting it later also in my timeline. Link to google docs (with comment rights): https://goo.gl/o1HCZq Regards, Vijay Krishnavanshi On 7 May 2017 at 23:43, Paulo Lieuthier <paulolieuth...@gmail.com>

Project - Autotests and Improving Protocol Support for Kopete - [Week 1, Report 1]

2017-05-16 Thread vijay krishnavanshi
will be working on. Regards, Vijay Krishnavanshi

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

2017-06-20 Thread Vijay Krishnavanshi
tests/libkopete/kopetestatusgrouptest.cpp PRE-CREATION tests/libkopete/kopetestatustest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/130155/diff/ Testing --- Thanks, Vijay Krishnavanshi

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

2017-06-20 Thread Vijay Krishnavanshi
urrent one okay? I will create even more complex autotests. - Vijay --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130155/#review103334 --------

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

2017-06-20 Thread Vijay Krishnavanshi
/kopetestatustest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/130155/diff/ Testing --- Thanks, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 5 Report 2]

2017-06-21 Thread vijay krishnavanshi
it out. I was able to work out the issue of review requests. I have updated the previous review request with new commits. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 6 Report 1]

2017-06-21 Thread vijay krishnavanshi
of plugins tests or share the details of the error to get help. Regards, Vijay Krishnavanshi

Re: GSoC 2017 - StatusReports on wiki

2017-06-24 Thread vijay krishnavanshi
Hi, I have updated the status report on community.kde.org Link : https://community.kde.org/GSoC/2017/StatusReports/vijay I went through the report of other students and this was all they had on theirs. Please tell if anything else should be added. Regards, Vijay Krishnavanshi On 22 June 2017

Query regarding handling command line arguments for kopete

2017-06-25 Thread vijay krishnavanshi
to timeline(if yes then for later or now)? I am working on the test cases at present and have gotten quite a hang of the internal connections inside kopete and how classes are handled. Regards, Vijay Krishnavanshi

Re: Query regarding handling command line arguments for kopete

2017-06-25 Thread vijay krishnavanshi
> I have few questions - > Should I remove the section that is not being used or comment them out? > Should I add them to timeline(if yes then for later or now)? > > I am working on the test cases at present and have gotten quite a hang of > the internal connections inside kopete and how classes are handled. > > Regards, > Vijay Krishnavanshi >

Re: GSoC 2017 - Announcement of Kopete projects

2017-05-22 Thread vijay krishnavanshi
that are to be discussed. Please comment where you think is ambiguous or not possible. Link: https://goo.gl/Fr2yNk I am working on writing test cases for plugins. My second report of this week is due. I will finish that up today itself. Regards, Vijay Krishnavanshi On 22 May 2017 at 18:18, Pali Rohár <pali

Project - Autotests and improving Protocol Support for Kopete [Week 1 Report 2]

2017-05-23 Thread vijay krishnavanshi
. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 2 Report 1]

2017-05-23 Thread vijay krishnavanshi
-tests for latex. Few plugins are marked to be re-written. I will try to see if it is possible to activate them if port is the problem. I will post back the status of auto-tests in my second report of this week. Please let me know if reports need to be more elaborate. Regards, Vijay Krishnavanshi

Regarding GSoC Project Autotests for Kopete

2017-05-27 Thread vijay krishnavanshi
:) Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 2 Report 2]

2017-05-30 Thread vijay krishnavanshi
and have autotests for their plugins that will be best. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 3 Report 1]

2017-05-30 Thread vijay krishnavanshi
for plugin once this issue gets resolved, till then I will write tests for libkopete and other parts of the kopete application. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 4 Report 1]

2017-06-07 Thread vijay krishnavanshi
in which I should compile and link the libraries of the plugin but I guess that will be clear in the review. I will continue working on writing test cases for libkopete and will attempt to complete the plugin tests as well. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 4 Report 2]

2017-06-13 Thread vijay krishnavanshi
planning to cover the classes in libkopete first as its is the most important part. Regards, Vijay Krishnavanshi

Project - Autotests and improving Protocol Support for Kopete [Week 5 Report 1]

2017-06-13 Thread vijay krishnavanshi
of application for testing. I tried to post another review request on git review-board but was not able to post its gives an error line undefined : undefined :( I already have one open review request on the same repo. If you know where I might be going wrong please suggest. Regards, Vijay Krishnavanshi

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

2017-06-17 Thread Vijay Krishnavanshi
--- Thanks, Vijay Krishnavanshi

Re: Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate, kopeteproperty, kopetepropertycontainer and kopetestatusgroup

2017-06-17 Thread Vijay Krishnavanshi
/kopetestatustest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/130155/diff/ Testing --- Thanks, Vijay Krishnavanshi

Review Request 130155: Added autotests for libkopete for classes - kopetestatus, kopetepropertytemplate and kopetestatusgroup

2017-06-11 Thread Vijay Krishnavanshi
/kopetestatusgrouptest.cpp PRE-CREATION tests/libkopete/kopetestatustest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/130155/diff/ Testing --- Thanks, Vijay Krishnavanshi

Re: GSoC 2017 - Announcement of Kopete projects

2017-05-05 Thread vijay krishnavanshi
also or just updates on kopete-devel are fine? Regards, Vijay Krishnavanshi On 6 May 2017 at 00:11, Pali Rohár <pali.ro...@gmail.com> wrote: > Hello! > > This year in Google Summer of Code program were selected two students > with their projects: > > Vijay Krishnava

Re: Query regarding handling command line arguments for kopete

2017-06-27 Thread vijay krishnavanshi
On 28-Jun-2017 03:30, "Pali Rohár" <pali.ro...@gmail.com> wrote: On Tuesday 27 June 2017 20:30:21 vijay krishnavanshi wrote: > On 27 June 2017 at 23:53, Pali Rohár <pali.ro...@gmail.com> wrote: > > On Sunday 25 June 2017 20:49:47 vijay krishnavanshi wrote: > &g

Re: Review Request 130183: Added autotests for autoreplace plugin

2017-10-15 Thread Vijay Krishnavanshi
/CMakeLists.txt e69de29 tests/plugins/autoreplace/CMakeLists.txt PRE-CREATION tests/plugins/autoreplace/kopeteautoreplaceplugintest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/130183/diff/3/ Testing --- Thanks, Vijay Krishnavanshi

Using Phabricator for new review requests

2017-08-26 Thread vijay krishnavanshi
://phabricator.kde.org/source/kopete/ I will first fix the issues in git.reviewboard's review requests and will either submit them or discard. They will be available on git.reviewboard for reference later. Regards, Vijay Krishnavanshi

Re: Using Phabricator for new review requests

2017-08-26 Thread vijay krishnavanshi
/130195/ 2- https://git.reviewboard.kde.org/r/130225/ 3- https://git.reviewboard.kde.org/r/130183/ 4- https://git.reviewboard.kde.org/r/130173/ 5- https://git.reviewboard.kde.org/r/130155/ I have put the links for convenience as there were only five remaining. Regards, Vijay Krishnavanshi On 26 August

Project - Autotests and improving Protocol Support for Kopete [Week 14 Report 2]

2017-08-27 Thread vijay krishnavanshi
, Vijay Krishnavanshi

Regarding reviving history plugin

2017-08-28 Thread vijay krishnavanshi
and looking at each cases. I will update issues on phabricator. Regards, Vijay Krishnavanshi

Re: Kopete & KF5 switch

2017-09-01 Thread vijay krishnavanshi
or a directory. I will look it up and will submit a patch. I have tested it by building it on my system and checking it out on my account of Gmail. It works correctly. Regards, Vijay Krishnavanshi On 19 August 2017 at 21:33, vijay krishnavanshi < vijaykrishnavan...@gmail.com> wrote: >

Re: Kopete & KF5 switch

2017-11-13 Thread vijay krishnavanshi
t because of university curriculum I get very little time :( I will try to submit the patch by the coming week. Regards, Vijay Krishnavanshi

D7635: Update History Plugin and create logs in xml format

2017-11-02 Thread Vijay Krishnavanshi
vijaykrishnavanshi updated this revision to Diff 21671. vijaykrishnavanshi added a comment. Restricted Application added a project: Kopete. Restricted Application added a subscriber: Kopete. Tweaked UI and port kDebug REPOSITORY R434 Kopete CHANGES SINCE LAST UPDATE

Participation of Kopete in Season of KDE 2018

2017-12-02 Thread vijay krishnavanshi
this thread with contact info. I will put their contacts too on the mentor list on idea page. Any suggestions to changes or addition in the project description is also appreciated :) Regards, Vijay Krishnavanshi

D10160: Test for Crypt in QQ Protocol

2018-01-28 Thread Vijay Krishnavanshi
vijaykrishnavanshi added inline comments. INLINE COMMENTS > qqcrypttest.cpp:11 > +private slots: > +void CryptTest(); > +}; Make this test data-driven. Link: http://doc.qt.io/qt-5/qttestlib-tutorial2-example.html REVISION DETAIL https://phabricator.kde.org/D10160 To:

Re: Joining Project for GSOC 2018

2018-03-27 Thread vijay krishnavanshi
achine. Let us know if any help is required in that :) Regards, Vijay Krishnavanshi