Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-13 Thread Hollis Blanchard
On Thu, 2008-11-13 at 08:44 +1030, Rusty Russell wrote: Note that I still don't have a balloon patch: want to send me one? linux: virtio-balloon: avoid implicit use of Linux page size in balloon interface Make the balloon interface always use 4K pages, and convert Linux pfns if necessary.

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-13 Thread Hollis Blanchard
On Thu, 2008-11-13 at 08:44 +1030, Rusty Russell wrote: Note that I still don't have a balloon patch: want to send me one? qemu: virtio-balloon: don't use TARGET_PAGE_BITS in balloon interface Make the balloon interface always use 4K pages. Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-13 Thread Rusty Russell
On Friday 14 November 2008 08:18:33 Hollis Blanchard wrote: On Thu, 2008-11-13 at 08:44 +1030, Rusty Russell wrote: Note that I still don't have a balloon patch: want to send me one? linux: virtio-balloon: avoid implicit use of Linux page size in balloon interface Thanks, applied with

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-13 Thread Hollis Blanchard
On Thu, 2008-11-13 at 08:44 +1030, Rusty Russell wrote: Note that I still don't have a balloon patch: want to send me one? linux: virtio-balloon: avoid implicit use of Linux page size in balloon interface Make the balloon interface always use 4K pages, and convert Linux pfns if necessary.

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-13 Thread Hollis Blanchard
On Thu, 2008-11-13 at 08:44 +1030, Rusty Russell wrote: Note that I still don't have a balloon patch: want to send me one? qemu: virtio-balloon: don't use TARGET_PAGE_BITS in balloon interface Make the balloon interface always use 4K pages. Signed-off-by: Hollis Blanchard [EMAIL PROTECTED]

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-13 Thread Rusty Russell
On Friday 14 November 2008 08:18:33 Hollis Blanchard wrote: On Thu, 2008-11-13 at 08:44 +1030, Rusty Russell wrote: Note that I still don't have a balloon patch: want to send me one? linux: virtio-balloon: avoid implicit use of Linux page size in balloon interface Thanks, applied with

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-12 Thread Rusty Russell
On Tuesday 11 November 2008 10:07:09 Hollis Blanchard wrote: Both sides of the virtio interface must agree about how big a pfn really is. This is particularly an issue on architectures where the page size is configurable (e.g. PowerPC, IA64) -- the interface must be independent of PAGE_SHIFT.

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-12 Thread Hollis Blanchard
On Wed, 2008-11-12 at 22:51 +1030, Rusty Russell wrote: On Tuesday 11 November 2008 10:07:09 Hollis Blanchard wrote: Both sides of the virtio interface must agree about how big a pfn really is. This is particularly an issue on architectures where the page size is configurable (e.g. PowerPC,

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-12 Thread Rusty Russell
On Thursday 13 November 2008 02:46:31 Hollis Blanchard wrote: On Wed, 2008-11-12 at 22:51 +1030, Rusty Russell wrote: On Tuesday 11 November 2008 10:07:09 Hollis Blanchard wrote: Both sides of the virtio interface must agree about how big a pfn really is. This is particularly an issue on

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-12 Thread Rusty Russell
On Thursday 13 November 2008 02:46:31 Hollis Blanchard wrote: On Wed, 2008-11-12 at 22:51 +1030, Rusty Russell wrote: On Tuesday 11 November 2008 10:07:09 Hollis Blanchard wrote: Both sides of the virtio interface must agree about how big a pfn really is. This is particularly an issue on

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-11 Thread Avi Kivity
Hollis Blanchard wrote: Avi, will you commit the matching qemu patch? (I'm not clear on the patch flow for kvm-userspace qemu virtio patches.) At this time, I'm accepting qemu/virtio patches (and will apply this one); once virtio is merged in qemu upstream, patches will have to go there

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-11 Thread Hollis Blanchard
On Tue, 2008-11-11 at 23:47 +1030, Rusty Russell wrote: On Tuesday 11 November 2008 10:07:09 Hollis Blanchard wrote: Both sides of the virtio interface must agree about how big a pfn really is. This is particularly an issue on architectures where the page size is configurable (e.g.

Re: [PATCH] [v2] linux: virtio: Standardize virtio's concept of page size

2008-11-11 Thread Avi Kivity
Hollis Blanchard wrote: Avi, will you commit the matching qemu patch? (I'm not clear on the patch flow for kvm-userspace qemu virtio patches.) At this time, I'm accepting qemu/virtio patches (and will apply this one); once virtio is merged in qemu upstream, patches will have to go there