Re: [GIT PULL] vhost-net fix for 2.6.34-rc3

2010-04-07 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 7 Apr 2010 20:35:02 +0300 David, The following tree includes a patch fixing an issue with vhost-net in 2.6.34-rc3. Please pull for 2.6.34. Pulled, thanks Michael. -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

2010-04-25 Thread David Miller
From: Changli Gao xiao...@gmail.com Date: Sun, 25 Apr 2010 17:33:02 +0800 On Sun, Apr 25, 2010 at 5:19 PM, xiaohui@intel.com wrote: +static int dev_is_mpassthru(struct net_device *dev) +{ +       if (dev dev-mp_port) +               return 1; +       return 0; +} + Please make it

Re: [RFC][PATCH v4 05/18] Add a function to indicate if device use external buffer.

2010-04-25 Thread David Miller
From: Changli Gao xiao...@gmail.com Date: Sun, 25 Apr 2010 17:35:01 +0800 On Sun, Apr 25, 2010 at 5:19 PM, xiaohui@intel.com wrote: +static int dev_is_mpassthru(struct net_device *dev) bool return value should be better here. Right. -- To unsubscribe from this list: send the line

Re: [RFC][PATCH v4 00/18] Provide a zero-copy method on KVM virtio-net.

2010-04-25 Thread David Miller
From: xiaohui@intel.com Date: Sun, 25 Apr 2010 17:20:06 +0800 The idea is simple, just to pin the guest VM user space and then let host NIC driver has the chance to directly DMA to it. Isn't it much easier to map the RX ring of the network device into the guest's address space, have DMA

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 4 May 2010 00:32:45 +0300 The following tree includes a couple of enhancements that help vhost-net. Please pull them for net-next. Another set of patches is under debugging/testing and I hope to get them ready in time for 2.6.35, so there

Re: [GIT PULL] first round of vhost-net enhancements for net-next

2010-05-03 Thread David Miller
From: David Miller da...@davemloft.net Date: Mon, 03 May 2010 15:07:29 -0700 (PDT) From: Michael S. Tsirkin m...@redhat.com Date: Tue, 4 May 2010 00:32:45 +0300 The following tree includes a couple of enhancements that help vhost-net. Please pull them for net-next. Another set of patches

Re: [GIT PULL] amended: first round of vhost-net enhancements for net-next

2010-05-06 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 4 May 2010 14:21:01 +0300 This is an amended pull request: I have rebased the tree to the correct patches. This has been through basic tests and seems to work fine here. The following tree includes a couple of enhancements that help

Re: [GIT PULL] last minute vhost-net fix

2010-05-14 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 13 May 2010 11:44:34 +0300 David, if it's not too late, please pull the following last minute fix into 2.6.34. Pulled, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH] vhost-net: utilize PUBLISH_USED_IDX feature

2010-05-17 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 18 May 2010 04:19:31 +0300 With PUBLISH_USED_IDX, guest tells us which used entries it has consumed. This can be used to reduce the number of interrupts: after we write a used entry, if the guest has not yet consumed the previous entry, or

Re: [PATCH] [resend] fix non-mergeable buffers packet too large error handling

2010-05-17 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 18 May 2010 06:12:52 +0300 DaveM, just to clarify, this patch is on top of the series we are working on with David L Stevens. It's not for your net tree. Understood. -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [GIT PULL net-2.6] vhost-net: error handling fixes

2010-05-27 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 27 May 2010 14:57:14 +0300 David, The following tree includes fixes dealing with error handling in vhost-net. It is on top of net-2.6. Please merge it for 2.6.35. Thanks! The following changes since commit

Re: [PATCH] virtio-net: fix data corruption with OOM

2009-10-26 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 26 Oct 2009 11:07:13 +0200 Another, and hopefully the last, note, is that git-am can only handle Subject/From lines at the beginning of the message. So git style of the mail would be ... I think it's weird. We could invent some kind of

Re: [PATCHv7 1/3] tun: export underlying socket

2009-11-04 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 3 Nov 2009 19:24:00 +0200 Assuming it's okay with davem, I think it makes sense to merge this patch through Rusty's tree because vhost is the first user of the new interface. Posted here for completeness. I'm fine with that, please add my:

Re: KVM for Sparc?

2008-09-22 Thread David Miller
From: Javier Guerra [EMAIL PROTECTED] Date: Mon, 22 Sep 2008 15:31:07 -0500 On Mon, Sep 22, 2008 at 3:18 PM, Hollis Blanchard [EMAIL PROTECTED] wrote: It would be even more interesting to implement host support on the Sparc processors with hardware virtualization support. Does Sparc

Re: KVM for Sparc?

2008-09-22 Thread David Miller
From: Hollis Blanchard [EMAIL PROTECTED] Date: Mon, 22 Sep 2008 16:25:51 -0500 On Mon, 2008-09-22 at 13:26 -0700, David Miller wrote: From: Hollis Blanchard [EMAIL PROTECTED] Date: Mon, 22 Sep 2008 15:18:39 -0500 It would be even more interesting to implement host support on the Sparc

Re: KVM for Sparc?

2008-09-23 Thread David Miller
From: Blue Swirl [EMAIL PROTECTED] Date: Tue, 23 Sep 2008 18:28:06 +0300 On 9/22/08, David Miller [EMAIL PROTECTED] wrote: As he mentioned, the V8 rett instruction causes problems on V9 chips. An opcode which was a V8 privileged instruction, rett, got reused as a non-privileged

Re: KVM for Sparc?

2008-09-23 Thread David Miller
From: Blue Swirl [EMAIL PROTECTED] Date: Tue, 23 Sep 2008 18:34:12 +0300 On 9/23/08, David Miller [EMAIL PROTECTED] wrote: Sun4v systems come with Sun's hypervisor. Linux simply runs on top of that, whether as a host or a guest. The hypervisor source is opensource and we could

Re: KVM for Sparc?

2008-09-23 Thread David Miller
From: Hollis Blanchard [EMAIL PROTECTED] Date: Tue, 23 Sep 2008 11:07:31 -0500 As far as I can see, you have a hypervisor privilege mode which allows your guests to execute privileged instructions like WRPR without trapping. Sure. Without that hardware support (with only 2 privilege

Re: KVM for Sparc?

2008-09-24 Thread David Miller
From: Blue Swirl [EMAIL PROTECTED] Date: Wed, 24 Sep 2008 20:20:33 +0300 I see, also Qemu needs to use one more bit then. Does this mean that even V8 code written specially may use these traps to call hypervisor? No, V8 code should not set the extra bit. Only V9 code on a processor which is

Re: KVM for Sparc?

2008-09-24 Thread David Miller
From: Blue Swirl [EMAIL PROTECTED] Date: Wed, 24 Sep 2008 20:22:45 +0300 I'm not sure, but I think that hypervisor is not a real hypervisor like the PROM version but one specially designed for Legion emulator. No, it's the real deal. All the real hardware device support is there. And Legion

Re: KVM for Sparc?

2008-09-24 Thread David Miller
From: Blue Swirl [EMAIL PROTECTED] Date: Wed, 24 Sep 2008 21:06:21 +0300 Now I found the relevant part in the manuals. The extra sun4v bit is not taken into account from user mode, so we can't catch privileged to hyperprivileged mode traps easily. That's right, the top bit is ignored in user

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

2008-12-14 Thread David Miller
From: Gleb Natapov g...@redhat.com Date: Sun, 14 Dec 2008 13:50:55 +0200 It is undesirable to use TCP/IP for this purpose since network connectivity may not exist between host and guest and if it exists the traffic can be not routable between host and guest for security reasons or TCP/IP

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

2008-12-15 Thread David Miller
From: Gleb Natapov g...@redhat.com Date: Mon, 15 Dec 2008 09:48:19 +0200 On Sun, Dec 14, 2008 at 10:44:36PM -0800, David Miller wrote: You guys really need to rethink this. Either a stream protocol is a workable solution to your problem, or it isn't. Stream protocol is workable solution

Re: [PATCH] AF_VMCHANNEL address family for guest-host communication.

2008-12-15 Thread David Miller
From: Anthony Liguori anth...@codemonkey.ws Date: Mon, 15 Dec 2008 09:02:23 -0600 There is already an AF_IUCV for s390. This is a scarecrow and irrelevant to this discussion. And this is exactly why I asked that any arguments in this thread avoid talking about virtualization technology and why

Re: Network performance with small packets

2011-01-27 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 27 Jan 2011 22:05:48 +0200 Interesting. Could this is be a variant of the now famuous bufferbloat then? Sigh, bufferbloat is the new global warming... :-/ -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [PULL] vhost-net: 2.6.38 - warning fix

2011-02-01 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 1 Feb 2011 17:44:40 +0200 git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks Michael. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] vhost: copy_from_user - __copy_from_user

2011-03-06 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 6 Mar 2011 13:33:49 +0200 copy_from_user is pretty high on perf top profile, replacing it with __copy_from_user helps. It's also safe because we do access_ok checks during setup. Signed-off-by: Michael S. Tsirkin m...@redhat.com Is Rusty

Re: [PULL net-2.6] vhost: cleanups and fixes

2011-03-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 17 Mar 2011 16:04:04 +0200 The following changes since commit 1fc050a13473348f5c439de2bb41c8e92dba5588: ipv4: Cache source address in nexthop entries. (2011-03-07 20:54:48 -0800) are available in the git repository at:

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-29 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 28 Jun 2010 13:08:07 +0300 Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The

Re: [PATCHv2] vhost-net: add dhclient work-around from userspace

2010-06-30 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 29 Jun 2010 16:04:39 +0300 Since using the module involves updating the management tools as well, if we go down this route it will be much less painful for everyone to do push it upstream. Ok, you can make your case to Patrick McHardy and if

Re: [GIT PULL net-2.6] vhost-net: more error handling fixes

2010-07-02 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 1 Jul 2010 19:41:27 +0300 David, The following tree includes more fixes dealing with error handling in vhost-net. It is on top of net-2.6. Please merge it for 2.6.35. Thanks! The following changes since commit

Re: [GIT PULL] vhost-net fixes

2010-07-16 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 16 Jul 2010 15:25:30 +0300 David, please pull the following fixes for 2.6.35. Thanks! The following changes since commit 91a72a70594e5212c97705ca6a694bd307f7a26b: net/core: neighbour update Oops (2010-07-14 18:02:16 -0700) are

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.36

2010-08-02 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 28 Jul 2010 16:32:31 +0300 The following changes since commit 4cfa580e7eebb8694b875d2caff3b989ada2efac: r6040: Fix args to phy_mii_ioctl(). (2010-07-21 21:10:49 -0700) are available in the git repository at:

Re: [PATCH 1/1 net-next] virtio_net: remove send queue

2010-02-12 Thread David Miller
From: Shirley Ma mashi...@us.ibm.com Date: Mon, 08 Feb 2010 16:14:42 -0800 Now we have a virtio detach API (in commit f9bfbebf34eab707b065116cdc9699d25ba4252a), we don't need to track xmit skbs in the virio_net driver, which improves transmission performance. Signed-off-by: Shirley Ma

Re: [PATCH] vhost-net: switch to smp barriers

2010-02-14 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sat, 13 Feb 2010 19:39:11 +0200 Dave, I see it's marked not applicable: http://patchwork.ozlabs.org/patch/44207/ the patch applies to net-next as of b3b3f04fb587ecb61b5baa6c1c5f0e666fd12d73. Can this be queued up please? Should I resubmit with

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
Just for the record I'm generally not interested in vhost patches. If it's a specific network one that will be merged via the networking tree, yes please CC: me. But if it's a bunch of changes to vhost.c and other pieces of infrastructure, feel free to leave me out of it. It just clutters my

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Feb 2010 07:37:37 +0200 Dave, so while Rusty's on vacation, what's the best way to get vhost infrastructure fixes in? Are you ok with getting pull requests and merging them into net-next? That should keep the clutter in your inbox to the

Re: [PATCH 3/3] vhost: fix get_user_pages_fast error handling

2010-02-23 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Feb 2010 09:34:25 +0200 Implicitly, I guess. He said if there's an issue Michael Tsirkin is the best person to resolve it, this was wrt merging his virtiolguest tree. He didn't mention vhost, I wrote all of vhost though, there shouldn't be

Re: [GIT PULL] vhost-net fixes for 2.6.34

2010-02-28 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 28 Feb 2010 20:44:40 +0200 The following changes since commit 655ffee284dfcf9a24ac0343f3e5ee6db85b85c5: Jiri Pirko (1): wireless: convert to use netdev_for_each_mc_addr are available in the git repository at:

Re: host panic based on kernel 2.6.34-RC1

2010-03-16 Thread David Miller
From: Hao, Xudong xudong@intel.com Date: Wed, 17 Mar 2010 10:14:50 +0800 I installed a latest kvm based on kernel 2.6.34-rc1, after I load kvm kvm_i= ntel module, and start /etc/init.d/kvm, a few minutes later, the system wil= l panic. The panic is easy to reproduce when I use tcpdump in

Re: [GIT PULL] vhost-net fixes for issues in 2.6.34-rc1

2010-03-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 18 Mar 2010 11:53:55 +0200 The following tree includes patches fixing issues with vhost-net in 2.6.34-rc1. Please pull them for 2.6.34. Pulled, thanks a lot. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net.

2010-11-09 Thread David Miller
From: xiaohui@intel.com Date: Tue, 9 Nov 2010 17:03:05 +0800 We provide an zero-copy method which driver side may get external buffers to DMA. Here external means driver don't use kernel space to allocate skb buffers. Currently the external buffer can be from guest virtio-net driver. 1)

Re: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net.

2010-11-10 Thread David Miller
From: xiaohui@intel.com Date: Wed, 10 Nov 2010 17:23:28 +0800 From: Xin Xiaohui xiaohui@intel.com 2) The idea to key off of skb-dev in skb_release_data() is fundamentally flawed since many actions can change skb-dev on you, which will end up causing a leak of your external data

Re: [V2 PATCH] virtio-net: init link state correctly

2010-11-12 Thread David Miller
From: Jason Wang jasow...@redhat.com Date: Fri, 05 Nov 2010 10:50:08 +0800 For device that supports VIRTIO_NET_F_STATUS, there's no need to assume the link is up and we need to call nerif_carrier_off() before querying device status, otherwise we may get wrong operstate after diver was loaded

Re: [PATCH] macvlan: Introduce 'passthru' mode to takeover the underlying device

2010-11-22 Thread David Miller
From: Sridhar Samudrala s...@us.ibm.com Date: Thu, 28 Oct 2010 16:10:50 -0700 With the current default 'vepa' mode, a KVM guest using virtio with macvtap backend has the following limitations. - cannot change/add a mac address on the guest virtio-net - cannot create a vlan device on the

Re: [PATCH v16 02/17]Add a new struct for device to manipulate external buffer.

2010-12-10 Thread David Miller
From: xiaohui@intel.com Date: Wed, 1 Dec 2010 16:08:13 +0800 From: Xin Xiaohui xiaohui@intel.com Add a structure in structure net_device, the new field is named as mp_port. It's for mediate passthru (zero-copy). It contains the capability for the net device driver,

Re: [PATCH v16 03/17] Add a ndo_mp_port_prep pointer to net_device_ops.

2010-12-10 Thread David Miller
From: xiaohui@intel.com Date: Wed, 1 Dec 2010 16:08:14 +0800 +#if defined(CONFIG_MEDIATE_PASSTHRU) || defined(CONFIG_MEDIATE_PASSTHRU_MODULE) + int (*ndo_mp_port_prep)(struct net_device *dev, + struct mp_port *port);

Re: [GIT PULL net-2.6] vhost-net: logging fixup

2010-12-12 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 12 Dec 2010 12:09:43 +0200 Please merge the following fix for 2.6.37. It is also applicable to -stable. Thanks! The following changes since commit a19faf0250e09b16cac169354126404bc8aa342b: net: fix skb_defer_rx_timestamp() (2010-12-10

Re: [GIT PULL net-next-2.6] vhost-net: tools, cleanups, optimizations

2010-12-14 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 14 Dec 2010 14:23:26 +0200 On Mon, Dec 13, 2010 at 12:44:13PM +0200, Michael S. Tsirkin wrote: Please merge the following tree for 2.6.38. Thanks! Rusty Acked it as is, so please pull the below. Thanks very much! The following changes

Re: [PULL] vhost-net: 2.6.38 fix

2011-01-14 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 14 Jan 2011 11:33:02 +0200 Please pull the following for 2.6.38. Thanks! The following changes since commit 0c21e3aaf6ae85bee804a325aa29c325209180fd: Merge branch 'for-next' of

Re: [PATCH 0/5] virtio_net: Add MAC and VLAN filtering

2009-01-18 Thread David Miller
From: Alex Williamson alex.william...@hp.com Date: Fri, 16 Jan 2009 14:13:12 -0700 This series enables setting the virtio-net device MAC address, adds infrastructure for the new control virtqueue, and makes use of it to support set_rx_mode, unicast and multicast address lists, and supporting

Re: [PATCH 0/5] virtio_net: Add MAC and VLAN filtering

2009-01-19 Thread David Miller
From: Mark McLoughlin mar...@redhat.com Date: Mon, 19 Jan 2009 08:30:31 + virtio_net: add link status handling Allow the host to inform us that the link is down by adding a VIRTIO_NET_F_STATUS which indicates that device status is available in virtio_net config. This is currently

Re: [PATCH 5/5] virtio_net: Add support for VLAN filtering in the hypervisor

2009-01-25 Thread David Miller
From: Mark McLoughlin mar...@redhat.com Date: Tue, 20 Jan 2009 16:44:00 + On Tue, 2009-01-20 at 09:36 -0700, Alex Williamson wrote: VLAN filtering allows the hypervisor to drop packets from VLANs that we're not a part of, further reducing the number of extraneous packets recieved.

Re: [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering

2009-01-29 Thread David Miller
From: Alex Williamson alex.william...@hp.com Date: Thu, 29 Jan 2009 16:05:02 -0700 I'm not completely sure it's everything you're looking for Rusty, but it does seem cleaner. Let me know if this is closer to what you're thinking. Rusty, are these good? If so, would you like you or I to take

Re: [PATCH v4 0/4] virtio_net: Add MAC and VLAN filtering

2009-02-03 Thread David Miller
From: Alex Williamson alex.william...@hp.com Date: Tue, 03 Feb 2009 12:25:50 -0700 This series adds infrastructure for a new control virtqueue and makes use of it to support set_rx_mode, unicast and multicast address lists, and supporting a hypervisor based VLAN filter. The goal is to make

Re: [PATCH] virtio_net: Allow setting the MAC address of the NIC

2009-02-04 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Thu, 5 Feb 2009 10:07:12 +1030 On Thursday 05 February 2009 05:56:06 Alex Williamson wrote: Many physical NICs let the OS re-program the hardware MAC address. Virtual NICs should allow this too. Signed-off-by: Alex Williamson

Re: copyless virtio net thoughts?

2009-02-07 Thread David Miller
From: Arnd Bergmann a...@arndb.de Date: Sat, 7 Feb 2009 12:56:06 +0100 Having the load spread evenly over all guests sounds like a much rarer use case. Totally agreed. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: virtio_net: MAC address releated breakage if there is no MAC area in config

2009-04-04 Thread David Miller
From: Christian Borntraeger borntrae...@de.ibm.com Date: Thu, 2 Apr 2009 19:23:48 +0200 Am Thursday 02 April 2009 18:06:25 schrieb Alex Williamson: virtio_net: Set the mac config only when VIRITO_NET_F_MAC VIRTIO_NET_F_MAC indicates the presence of the mac field in config space, not the

Re: [GIT PULL net-2.6] vhost-net: 2.6.36 regression fixes

2010-09-09 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 6 Sep 2010 14:36:06 +0300 The following tree includes more regression fixes for vhost-net in 2.6.36. It is on top of net-2.6. Please merge it for 2.6.36. Pulled, thanks Michael. -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC PATCH 2/2] macvtap: TX zero copy between guest and host kernel

2010-09-13 Thread David Miller
From: Shirley Ma mashi...@us.ibm.com Date: Mon, 13 Sep 2010 13:48:03 -0700 + base = (unsigned long)from-iov_base + offset1; + size = ((base ~PAGE_MASK) + len + ~PAGE_MASK) PAGE_SHIFT; + num_pages = get_user_pages_fast(base, size, 0, page[i]); +

Re: [GIT PULL net-2.6] vhost-net: fix range checking

2010-09-20 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 20 Sep 2010 19:42:22 +0200 git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Pulled, thanks! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [GIT PULL net-2.6] vhost-net: last minute fix

2010-09-27 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 27 Sep 2010 15:34:13 +0200 The following tree includes a last minute bugfix for vhost-net. It is on top of net-2.6. Please merge it for 2.6.36. Pulled, thanks Michael. -- To unsubscribe from this list: send the line unsubscribe kvm in the

Re: [PATCH v12 06/17] Use callback to deal with skb_release_data() specially.

2010-10-01 Thread David Miller
From: xiaohui@intel.com Date: Thu, 30 Sep 2010 22:04:23 +0800 @@ -197,10 +197,11 @@ struct skb_shared_info { union skb_shared_tx tx_flags; struct sk_buff *frag_list; struct skb_shared_hwtstamps hwtstamps; - skb_frag_t frags[MAX_SKB_FRAGS]; /*

Re: [GIT PULL net-next-2.6] vhost-net patchset for 2.6.37

2010-10-06 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 5 Oct 2010 20:27:32 +0200 It looks like it was a quiet cycle for vhost-net: probably because most of energy was spent on bugfixes that went in for 2.6.36. People are working on multiqueue, tracing but I'm not sure it'll get done in time for

Re: [PATCH v12 06/17] Use callback to deal with skb_release_data() specially.

2010-10-11 Thread David Miller
From: Xin, Xiaohui xiaohui@intel.com Date: Mon, 11 Oct 2010 15:06:05 +0800 That's to avoid the new cache miss caused by using destructor_arg in data path like skb_release_data(). That's based on the comment from Eric Dumazet on v7 patches. Thanks for the explanation. -- To unsubscribe

Re: [PATCH v13 10/16] Add a hook to intercept external buffers from NIC driver.

2010-10-19 Thread David Miller
From: xiaohui@intel.com Date: Fri, 15 Oct 2010 17:12:11 +0800 @@ -2891,6 +2922,11 @@ static int __netif_receive_skb(struct sk_buff *skb) ncls: #endif + /* To intercept mediate passthru(zero-copy) packets here */ + skb = handle_mpassthru(skb, pt_prev, ret, orig_dev); +

Re: [GIT PULL net-2.6] vhost-net: access_ok fix

2010-10-21 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Tue, 19 Oct 2010 16:59:01 +0200 David, Not sure if it's too late for 2.6.36 - in case it's not, the following tree includes a last minute bugfix for vhost-net, found by code inspection. It is on top of net-2.6. Thanks! The following changes

Re: [PATCH v13 10/16] Add a hook to intercept external buffers from NIC driver.

2010-10-29 Thread David Miller
From: Xin, Xiaohui xiaohui@intel.com Date: Wed, 27 Oct 2010 09:33:12 +0800 Somehow, it seems not a trivial work to support it now. Can we support it later and as a todo with our current work? I would prefer the feature work properly, rather than only in specific cases, before being

Re: [PATCH 3/3] net - removing superfluous rcu_read_lock_held check

2010-11-01 Thread David Miller
From: Jiri Olsa jo...@redhat.com Date: Mon, 1 Nov 2010 20:15:09 +0100 the rcu_dereference_check is defined as #define rcu_dereference_check(p, c) \ __rcu_dereference_check((p), rcu_read_lock_held() || (c), __rcu) so the caller does not need to specify rcu_read_lock_held()

Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts

2012-10-21 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 21 Oct 2012 14:49:01 +0200 On Mon, Oct 15, 2012 at 07:55:34PM +0200, Michael S. Tsirkin wrote: We copy head count to a 16 bit field, this works by chance on LE but on BE guest gets 0. Fix it up. Signed-off-by: Michael S. Tsirkin

Re: [PATCH for-3.7] vhost: fix mergeable bufs on BE hosts

2012-10-24 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Oct 2012 18:24:38 +0200 Would you like me to repost the patch? This question is almost retorical. I said I don't reliably read things I'm not explicitly CC:'d on, therefore it's possible (and in fact, likely) I don't have the patch in my

Re: [PATCH repost for-3.7] vhost: fix mergeable bufs on BE hosts

2012-10-24 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 24 Oct 2012 20:37:51 +0200 We copy head count to a 16 bit field, this works by chance on LE but on BE guest gets 0. Fix it up. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Alexander Graf ag...@suse.de Cc:

Re: [PATCHv2 net-next 1/8] skb: report completion status for zero copy skbs

2012-11-01 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Wed, 31 Oct 2012 12:31:06 +0200 -void vhost_zerocopy_callback(struct ubuf_info *ubuf) +void vhost_zerocopy_callback(struct ubuf_info *ubuf, int zerocopy_status) If you're only reporting true/false values, even just for now, please use 'bool' for

Re: [PATCHv2 net-next 1/8] skb: report completion status for zero copy skbs

2012-11-01 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 1 Nov 2012 18:16:11 +0200 Do you think it's over-engineering, or a good idea? Engineer what you need, not what you might need. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCHv3 net-next 0/8] enable/disable zero copy tx dynamically

2012-11-02 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 1 Nov 2012 21:16:17 +0200 tun supports zero copy transmit since 0690899b4d4501b3505be069b9a687e68ccbe15b, however you can only enable this mode if you know your workload does not trigger heavy guest to host/host to guest traffic -

Re: [PATCH 1/1] vhost: Remove duplicate inclusion of linux/vhost.h

2012-11-19 Thread David Miller
From: Sachin Kamat sachin.ka...@linaro.org Date: Mon, 19 Nov 2012 16:58:28 +0530 linux/vhost.h was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Michael, are you gonna take this? Thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH 1/1] vhost: Remove duplicate inclusion of linux/vhost.h

2012-11-19 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 19 Nov 2012 21:49:55 +0200 On Mon, Nov 19, 2012 at 02:18:13PM -0500, David Miller wrote: From: Sachin Kamat sachin.ka...@linaro.org Date: Mon, 19 Nov 2012 16:58:28 +0530 linux/vhost.h was included twice. Signed-off-by: Sachin Kamat

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-28 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 26 Nov 2012 17:14:16 +0200 On Mon, Nov 19, 2012 at 10:26:41PM +0200, Michael S. Tsirkin wrote: Userspace bits: - 1) LKVM The latest vhost-blk userspace bits for kvm tool can be found here:

Re: [PATCH] vhost-net: initialize zcopy packet counters

2012-12-03 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Mon, 3 Dec 2012 19:31:51 +0200 These packet counters are used to drive the zercopy selection heuristic so nothing too bad happens if they are off a bit - and they are also reset once in a while. But it's cleaner to clear them when backend is set

Re: [PULL net-next] vhost: changes for 3.8

2012-12-07 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 6 Dec 2012 17:18:00 +0200 The following changes since commit b93196dc5af7729ff7cc50d3d322ab1a364aa14f: net: fix some compiler warning in net/core/neighbour.c (2012-12-05 21:50:37 -0500) are available in the git repository at:

Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

2012-12-07 Thread David Miller
From: Jason Wang jasow...@redhat.com Date: Sat, 8 Dec 2012 01:04:54 +0800 This series is an update version (hope the final version) of multiqueue (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were addressed, the work were based on Krishna Kumar's work to let virtio-net

Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net

2012-12-08 Thread David Miller
From: Jason Wang jasow...@redhat.com Date: Sat, 8 Dec 2012 01:04:54 +0800 This series is an update version (hope the final version) of multiqueue (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were addressed, the work were based on Krishna Kumar's work to let virtio-net

Re: [heads-up] bridge in kernel 3.0~ and dhcp from kvm guest on tap device

2011-07-07 Thread David Miller
From: Michael Tokarev m...@tls.msk.ru Date: Thu, 07 Jul 2011 13:44:57 +0400 The combination in $subject apparently stopped working -- I'm running 3.0-rc6 kernel on host where it doesn't work. Already fixed in net-2.6: From 44661462ee1ee3c922754fc1f246867f0d01e7ea Mon Sep 17 00:00:00 2001

Re: [PATCH V8 2/4 net-next] skbuff: skb supports zero-copy buffers

2011-07-07 Thread David Miller
From: Shirley Ma mashi...@us.ibm.com Date: Wed, 06 Jul 2011 15:22:12 -0700 + while (head) { + put_page(head); + head = (struct page *)head-private; + } Looks like you might be referencing the page

Re: [PATCH V8 0/4 net-next] macvtap/vhost TX zero-copy support

2011-07-07 Thread David Miller
From: Shirley Ma mashi...@us.ibm.com Date: Wed, 06 Jul 2011 15:15:25 -0700 This patchset add supports for TX zero-copy between guest and host kernel through vhost. It significantly reduces CPU utilization on the local host on which the guest is located (It reduced about 50% CPU usage for

Re: [PATCH V8 0/4 net-next] macvtap/vhost TX zero-copy support

2011-07-07 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 7 Jul 2011 14:37:15 +0300 Apply patches 1-3 for now? Done, and I fixed the use-after-free in patch #2. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH V8 2/4 net-next] skbuff: skb supports zero-copy buffers

2011-07-07 Thread David Miller
From: Shirley Ma mashi...@us.ibm.com Date: Thu, 07 Jul 2011 11:32:25 -0700 You are right, will fix it. You don't need to, I fixed it when I committed the patch to net-next-2.6 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org

Re: [PATCH net-next] skbuff: clear tx zero-copy flag

2011-07-09 Thread David Miller
From: Shirley Ma mashi...@us.ibm.com Date: Sat, 09 Jul 2011 00:12:46 -0700 This patch clears tx zero-copy flag as needed. Signed-off-by: Shirley Ma x...@us.ibm.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCHv9] vhost: experimental tx zero-copy support

2011-07-17 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 17 Jul 2011 22:36:14 +0300 The below is what I came up with. We add the feature enabled by default ... s/enabled/disabled/ Well, at least you got it right in the commit message where it counts :-) -- To unsubscribe from this list: send the

Re: [PULL net] vhost-net: zercopy mode fixes

2011-07-22 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 22 Jul 2011 09:00:46 +0300 The following includes vhost-net fixes - both in the experimental zero copy mode. Please pull for 3.1. Thanks! Where is this the following? I don't see any GIT url to pull from or anything :-) -- To unsubscribe

Re: [PULL net (try 2)] vhost-net: zercopy mode fixes

2011-07-22 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Fri, 22 Jul 2011 09:32:38 +0300 Fixing a corrupted pull request sent earlier. Sorry about the noise! The following includes vhost-net fixes - both in the experimental zero copy mode. Please pull for 3.1. Pulled, thanks! -- To unsubscribe from

Re: [PATCH net-next] skbuff: clear tx zero-copy flag

2011-07-25 Thread David Miller
From: Herbert Xu herb...@gondor.hengli.com.au Date: Mon, 25 Jul 2011 17:57:11 +0800 However, I think we should add a WARN_ON to the splice skb path so that should a packet find its way through a path that we haven't thought of then at least we'll know about it. Good idea. -- To unsubscribe

Re: Page allocation failures in guest

2009-08-26 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Wed, 26 Aug 2009 21:48:58 +0930 Dave, can you push this to Linus ASAP? Ok. Subject: virtio: net refill on out-of-memory If we run out of memory, use keventd to fill the buffer. There's a report of this happening: Page allocation failures in

Re: virtio net regression

2009-05-13 Thread David Miller
From: Antoine Martin anto...@devloop.org.uk Date: Wed, 13 May 2009 19:58:45 +0700 Re-sending as this does not seem to have made it to the list. It made it, it's just that nobody has had a chance to look into this. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH 1/3] net: use this_cpu_xxx replace percpu_xxx funcs

2012-01-11 Thread David Miller
From: Alex,Shi alex@intel.com Date: Wed, 11 Jan 2012 16:45:33 +0800 percpu_xxx funcs are duplicated with this_cpu_xxx funcs, so replace them for further code clean up. And in preempt safe scenario, __this_cpu_xxx funcs has a bit better performance since __this_cpu_xxx has no

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-12 Thread David Miller
From: Stephen Hemminger shemmin...@vyatta.com Date: Wed, 11 Jan 2012 21:30:38 -0800 Subject: vhost-net: add module alias (v2.1) By adding some module aliases, programs (or users) won't have to explicitly call modprobe. Vhost-net will always be available if built into the kernel. It does

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-13 Thread David Miller
From: Kay Sievers kay.siev...@vrfy.org Date: Fri, 13 Jan 2012 05:19:05 +0100 On Fri, Jan 13, 2012 at 05:07, David Miller da...@davemloft.net wrote: From: Stephen Hemminger shemmin...@vyatta.com Date: Wed, 11 Jan 2012 21:30:38 -0800 Subject: vhost-net: add module alias (v2.1) By adding some

Re: [PATCH] vhost-net: add module alias (v2.1)

2012-01-16 Thread David Miller
From: Stephen Hemminger shemmin...@vyatta.com Date: Mon, 16 Jan 2012 07:52:36 -0800 On Mon, 16 Jan 2012 12:26:45 + Alan Cox a...@linux.intel.com wrote: ACKs, NACKs? What is happening here? I would like an Ack from Alan Cox who switched vhost-net to a dynamic minor in the first

Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb

2011-10-03 Thread David Miller
From: Sasha Levin levinsasha...@gmail.com Date: Wed, 28 Sep 2011 17:40:54 +0300 This patch verifies that the length of a buffer stored in a linked list of pages is small enough to fit into a skb. If the size is larger than a max size of a skb, it means that we shouldn't go ahead building

Re: [PATCH v2 1/2] virtio-net: Verify page list size before fitting into skb

2011-10-06 Thread David Miller
From: Sasha Levin levinsasha...@gmail.com Date: Wed, 28 Sep 2011 17:40:54 +0300 This patch verifies that the length of a buffer stored in a linked list of pages is small enough to fit into a skb. If the size is larger than a max size of a skb, it means that we shouldn't go ahead building

  1   2   >