[Libreoffice] Crash after Preference selection on Mac

2010-11-25 Thread Chris Makepeace
Libre Office (current) and OOo (3.2.1) is repeatedly crashing as I go into Preferences (Mac language for 'Options'). The system console reports that the crash is related to JavaNativeFoundation and the crash log makes no mention of Java but does spend 771 lines reporting a lot else. iMac running

Re: [Libreoffice] ucb/source/ucb compilation error

2010-11-25 Thread Sebastian Spaeth
On Thu, 21 Oct 2010 09:40:53 +0200, Thomas Klausner w...@netbsd.org wrote: -#define OSL_LOG_PREFIX OSL_THIS_FILE : OSL_THIS_FUNC : OSL_MACRO_VALUE_TO_STRING( __LINE__ ) ; +#define OSL_LOG_PREFIX (OSL_THIS_FILE, :, OSL_THIS_FUNC, :, OSL_MACRO_VALUE_TO_STRING( __LINE__ ), ; ) On OOo there is

Re: [Libreoffice] ucb/source/ucb compilation error

2010-11-25 Thread Sebastian Spaeth
On Thu, 25 Nov 2010 10:47:22 +0100, Sebastian Spaeth wrote: +#define OSL_LOG_PREFIX (OSL_THIS_FILE, :, OSL_THIS_FUNC, :, OSL_MACRO_VALUE_TO_STRING( __LINE__ ), ; ) On OOo there is a bug open to remove OSL_THIS_FUNC (or was it an Easy Hack) as it is not doing anyway what it is suposed to

Re: [Libreoffice] ucb/source/ucb compilation error

2010-11-25 Thread Miklos Vajna
On Thu, Nov 25, 2010 at 10:51:05AM +0100, Sebastian Spaeth sebast...@sspaeth.de wrote: On Thu, 25 Nov 2010 10:47:22 +0100, Sebastian Spaeth wrote: +#define OSL_LOG_PREFIX (OSL_THIS_FILE, :, OSL_THIS_FUNC, :, OSL_MACRO_VALUE_TO_STRING( __LINE__ ), ; ) On OOo there is a bug open to

Re: [Libreoffice] ucb/source/ucb compilation error

2010-11-25 Thread Michael Meeks
Hi Miklos, On Wed, 2010-11-24 at 16:08 +0100, Miklos Vajna wrote: Both are just removing the __PRETTY_FUNCTION__ / etc expressions, which is not that good, I think. :-) The attached patch tries to solve both problems, and of course build-tested. Does it look sane - may i push it?

Re: [Libreoffice] Styles and Formatting

2010-11-25 Thread Michael Meeks
Hi Gert, On Wed, 2010-11-03 at 18:28 +0100, Gert Faller wrote: I have erased the line : m_aActionTbL.SetHelpId( HID_TEMPLDLG_TOOLBOX_LEFT ); in the patch file 2. A pastecopy error... So - I notice this is still not merged; which is bad. Sorry for the delay - clearly this got killed

Re: [Libreoffice] ucb/source/ucb compilation error

2010-11-25 Thread Tor Lillqvist
Tor was exercised about this at one stage IIRC, does the above work for you ? Sure, although I think I would prefer to keep OSL_THIS_FUNC as instead of (unknown) in the fallback case. Also, we need to find out if there really is no __func__ or similar even in MSVC2010. So, you think the

Re: [Libreoffice] More links inherited from OOo

2010-11-25 Thread Florian Effenberger
Hi, Christian Lohmaier wrote on 2010-11-16 16.22: Do we want to have a support.libreoffice.org subsite, or do we want to havewww.libreoffice.org/support? for now, I'd go with the latter one, but that's just my feeling... Florian -- Florian Effenberger flo...@documentfoundation.org Steering

Re: [Libreoffice] Auto-detection of toolbar icon size (well, kinda)

2010-11-25 Thread Thorsten Behrens
Michael Meeks wrote: prompted by some complaints on too large icons on Mac, switched the icon size from 'large' to 'auto' for 3.3. Did we ever get some screenshots of the perceived problem ? I asked in some bug, but never got that back AFAIR. Hi Michael, take my word for it, it

Re: [Libreoffice] Auto-detection of toolbar icon size (well, kinda)

2010-11-25 Thread Tor Lillqvist
On 2010-11-25 at 12:47, peterla...@gmail.com wrote: On Thu. 25.11.2010 10:19, Michael Meeks wrote: prompted by some complaints on too large icons on Mac, switched the icon size from 'large' to 'auto' for 3.3. Did we ever get some screenshots of the perceived problem ? I asked in some

Re: [Libreoffice] compilation of LO on mac

2010-11-25 Thread Thorsten Behrens
Jonathan Aquilina wrote: hey guys is it possible to compile LO on mac osx? if so what dependencies does one need to satisfy before compiling it. Hi Jonathan, sure - please read up here for details: http://wiki.documentfoundation.org/Development/How_to_build#Mac_OS_X Don't hesitate to ask,

Re: [Libreoffice] installation on mac doesnt require read me or licenses

2010-11-25 Thread Thorsten Behrens
Jonathan Aquilina wrote: hey guys i'm noticing something interesting. wouldn't it be better to use an installer to make sure the read me's as well as the licenses get installed in the LO directory. currently the way it is i don't have to drag either of them into the application directory. Hi

Re: [Libreoffice] installation on mac doesnt require read me or licenses

2010-11-25 Thread Jonathan Aquilina
im happy with the way things are done on mac, but the folder that has the licenses i didnt even bother looking at that folder hence the suggestion for a mac package that would install LO in the app folder. On Thu, Nov 25, 2010 at 1:11 PM, Thorsten Behrens t...@documentfoundation.org wrote:

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-25 Thread Michael Meeks
On Mon, 2010-11-22 at 09:47 +0100, Gioele Barabucci wrote: in bug #31633 I proposed a patch to one of the export filters. I've just committed it; sorry for delay. It's great to have you prodding at this piece of the code. One of the sad things about the XSLT filters is that

Re: [Libreoffice] quick starter applet/systray defaults and various confusion

2010-11-25 Thread Caolán McNamara
On Wed, 2010-11-24 at 20:50 +, Caolán McNamara wrote: On Wed, 2010-11-24 at 12:04 +0100, David Tardon wrote: Does anyone have any clever idea how to prevent that? How about we over-engineer and.. a) use osl_getModuleURLFromFunctionAddress or something of that nature to get the

[Libreoffice] [PATCH] Another Base cleanup

2010-11-25 Thread Wols Lists
Cheers, Wol From 6642a11fbcfa7f2f4f35f5535ffe8c33fa856309 Mon Sep 17 00:00:00 2001 From: Wol anth...@youngman.org.uk Date: Thu, 25 Nov 2010 13:04:08 + Subject: [PATCH 4/4] Dead code deletion --- dbaccess/source/ui/querydesign/JoinDesignView.cxx |1 -

[Libreoffice] [Pushed] Another Base cleanup

2010-11-25 Thread Michael Meeks
Nice, thanks ! Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Are ISC/BSD-licensed contributions acceptable?

2010-11-25 Thread Gioele Barabucci
Wols Lists 25/11/2010 14:21: It's tricky, but imho the rule should be if you make a major contribution to a file then you add your copyright notice. In general, patches, fixes, etc shouldn't. And possibly we add a line that says copyright assorted contributors - see git history for details.

Re: [Libreoffice] quick starter applet/systray defaults and various confusion

2010-11-25 Thread Michael Meeks
On Thu, 2010-11-25 at 13:14 +, Caolán McNamara wrote: This seems to work, e.g. the attached. Looks great to me :-) [ still puzzling over the migration swamp though ]. Regards, Michael. -- michael.me...@novell.com , Pseudo Engineer, itinerant idiot

Re: [Libreoffice] quick starter applet/systray defaults and various confusion

2010-11-25 Thread Michael Meeks
Hi Caolan, On Thu, 2010-11-25 at 09:42 +, Caolán McNamara wrote: On Fri, 2010-11-19 at 15:37 +, Caolán McNamara wrote: 3) We should probably instead modify InitializeQuickStartMode to effectively || Sfx::ShutdownIcon::GetAutostart() with the IsQuickStart command line argument.

[Libreoffice] [PATCH] Remove dead codes and undesired comments with fixed typo

2010-11-25 Thread Takeshi Abe
Hi, yet another cleanup on base. Cheers, -- Takeshi Abe From dff2f8d6d37863a5517a412ea4f92ebdbee536ff Mon Sep 17 00:00:00 2001 From: Takeshi Abe t...@fixedpoint.jp Date: Fri, 26 Nov 2010 01:45:21 +0900 Subject: [PATCH] Remove dead codes and undesired comments with fixed typo ---

Re: [Libreoffice] LibreOffice config migration

2010-11-25 Thread Michael Meeks
On Fri, 2010-10-15 at 19:23 +0200, André Schnabel wrote: Am 15.10.2010 17:21, schrieb Michael Meeks: So - here is my suggestion ;-) hopefully it annoys everybody, and it is two-fold. .. (no question on 1. - harden the code for migration) ... 2. we continue to do automatic config

[Libreoffice] warnig and coding, need a little help on C++

2010-11-25 Thread Pierre-André Jacquod
Hello, as I said, still in warm up phase and getting back familiar with C++.. So cleaning is a good exercise. I got a compiler warning: filters/binfilter/bf_sw/source/core/para/sw_paratr.cxx:214:26: warning: 'nTemp' may be used uninitialized in this function for this: case MID_DROPCAP_LINES :

[Libreoffice] Extensions code cleanup

2010-11-25 Thread Roth Robert
Some more dead code and bogus comments removed from extensions. The license, as always is LGPLv3+ / MPL. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fwd: Extensions code cleanup with patch

2010-11-25 Thread Roth Robert
-- Forwarded message -- From: Roth Robert robert.roth@gmail.com Date: Thu, Nov 25, 2010 at 9:27 PM Subject: Extensions code cleanup To: libreoffice@lists.freedesktop.org Some more dead code and bogus comments removed from extensions. The license, as always is LGPLv3+ / MPL.

Re: [Libreoffice] C++0x and LibreOffice

2010-11-25 Thread Caolán McNamara
On Thu, 2010-11-25 at 19:53 +0100, Pierre-André Jacquod wrote: Hello, thanks, will avoid some errors.. I guess this is not (yet ?) enabled per default / per configure choices? Not yet. Since I am very weak with make and such tools: any possibility to enable it per option when running

Re: [Libreoffice] [PUSHED] Re: [PATCH 02/12] RTL_CONSTASCII_USTRINGPARAM in components cui options

2010-11-25 Thread Jan Holesovsky
Hi Wol, On 2010-11-23 at 20:49 +, Wols Lists wrote: String aFoo = String::createFromAscii( Something ) should be replaced, with String aFoo( RTL_CONSTASCII_USTRINGPARAM( Something ) ) Fine. Fixes in base will appear as I spot them :-) Just one important little point - the

[Libreoffice] main.xdg 2 largest sections not needed on startup?

2010-11-25 Thread Sebastian Spaeth
Hi all, after looking at kcachegrind for a while, I found that a significant amount of our startuptime comes from allocating string memory and comparing strings 400k times, much of it reading the configuration files. I just looked at the .xcd files now and of that I focused on main.xcd because

Re: [Libreoffice] warnig and coding, need a little help on C++

2010-11-25 Thread Caolán McNamara
On Thu, 2010-11-25 at 19:41 +0100, Pierre-André Jacquod wrote: { sal_Int8 nTemp; rVal = nTemp; if(nTemp =1 nTemp 0x7f nLines = (BYTE)nTemp; } Well, that's fine for me, nTemp is effectively not initialized. And the second line is then the same as: rVal = rVal nTemp

Re: [Libreoffice] [PUSHED] Clean code at writer [source/ui]

2010-11-25 Thread Kayo Hamid
I can't see the commit at cgit, where is? I want to see the changes to improve my skills, see the changes. What wrong I'm doing? Better, what are wrong remove? revol_ Pushed with some changes. D. ___ LibreOffice mailing list

[Libreoffice] [Patch] cppcheck, Memory leak: fallback in shell/source/unix/misc/gnome-open-url.c

2010-11-25 Thread Julien Nabet
Hello, Here's a small patch for shell/source/unix/misc/gnome-open-url.c Julien. (LGPLv3+ / MPL) commit 6b768a031280d0c3ad23624dd3a6470c57395a56 Author: serval ser...@ilapharm.com Date: Thu Nov 25 23:26:39 2010 +0100 correct cppcheck, Memory leak: fallback diff --git

[Libreoffice] [PATCH] run-libreoffice-ciabot: avoid flood on merges

2010-11-25 Thread Miklos Vajna
Hi Kendy, I'm attaching a patch that updates the cia bot so that you don't need to manually disable it on each merge. ;) OK to push? (More importantly, if I push it, it would be nice if you could restart the bot, as I guess that's not automatic. :) ) Thanks. From

Re: [Libreoffice] C++0x and LibreOffice

2010-11-25 Thread René Kjellerup
Well, the version 4.4.3 of gcc on my system seems to support it. One way to see when it's available would be to look up gcc's documentation in the changelog for the 4.4.x series I took a quick look at gnu's web site and found this: http://gcc.gnu.org/projects/cxx0x.html (looks like a little

Re: [Libreoffice] Fwd: Extensions code cleanup with patch

2010-11-25 Thread David Tardon
On Thu, Nov 25, 2010 at 10:15:52PM +0200, Roth Robert wrote: -- Forwarded message -- From: Roth Robert robert.roth@gmail.com Date: Thu, Nov 25, 2010 at 9:27 PM Subject: Extensions code cleanup To: libreoffice@lists.freedesktop.org Some more dead code and bogus

[Libreoffice] [PATCH 1/9] suppress warning in binfilters sc_token

2010-11-25 Thread Pierre-André Jacquod
Hello, here some patches in binfilter to remove warnings by compiling... Since some changes could (will) look strange, I submit it in little chunks, often with compiler warning in comment. This may help the reviewer. Hope I did no mistake regards Pierre-André From

[Libreoffice] [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal

2010-11-25 Thread Pierre-André Jacquod
regards From f6202b304ca7f0ffdd16cbd2886872465273852a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Tue, 23 Nov 2010 21:58:53 +0100 Subject: [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal ---

[Libreoffice] [PATCH 5/9] waring removal in binfilter core/para

2010-11-25 Thread Pierre-André Jacquod
regards From 01e9e819f9dd8f1726ddff7672f27cfcbd44760c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 20:09:15 +0100 Subject: [PATCH 5/9] waring removal in binfilter core/para --- binfilter/bf_sw/source/core/para/sw_paratr.cxx

[Libreoffice] [PATCH 6/9] waring cleaning in sw_sw3redln.cxx

2010-11-25 Thread Pierre-André Jacquod
regards From 84e58630f70dc34f71ee34419d9843980b14b723 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 20:18:10 +0100 Subject: [PATCH 6/9] waring cleaning in sw_sw3redln.cxx shadowing warning and unused parameters ---

[Libreoffice] [PATCH 7/9] warnings removal in binfilter sw_sw3redln.cxx

2010-11-25 Thread Pierre-André Jacquod
regards From 13a33d71df128454159d0e911f55179cddac2d72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 20:52:47 +0100 Subject: [PATCH 7/9] warnings removal in binfilter sw_sw3redln.cxx all code deletion due to compiler warning

Re: [Libreoffice] [PATCH 3/9] warnings in binfilters sc_interpr4.cxx

2010-11-25 Thread Jonathan Aquilina
Quick question wouldn't it be better to have the comments in English instead of German? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PATCH 9/9] binfilter sw3io warning fixes

2010-11-25 Thread Pierre-André Jacquod
regards From d8ca0db19fdc508ebc0bf0ee42107fdea2f498b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?= pjacq...@alumni.ethz.ch Date: Thu, 25 Nov 2010 21:10:27 +0100 Subject: [PATCH 9/9] binfilter sw3io warning fixes use of not initialized variables ---

Re: [Libreoffice] [PATCH 3/9] warnings in binfilters sc_interpr4.cxx

2010-11-25 Thread Pierre-André Jacquod
Quick question wouldn't it be better to have the comments in English instead of German? Sorry, !! I translate then when I can, but I did not the job to the end for this one. Not_appropriate_handling_for_me++ regards ___ LibreOffice mailing list

Re: [Libreoffice] warnig and coding, need a little help on C++

2010-11-25 Thread Pierre-André Jacquod
Thanks for helping. Heh, this also confuses cppcheck as well. cough... cough... ! I am not smarter than a machine... ! A professor I had told: this not a good point being too smart... I understand what he meant. For stepping in, not the easiest way. Once there is no waring any more when