[Libreoffice-commits] .: toolkit/inc

2013-01-09 Thread Libreoffice Gerrit user
toolkit/inc/toolkit/controls/unocontrolmodel.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a280ba47ee434a46d7d29008534f5c662088abc5 Author: Noel Grandin n...@peralex.com Date: Wed Jan 9 09:34:34 2013 +0200 fix windows build broken by my UNO

[Libreoffice-commits] .: sc/qa sw/qa

2013-01-09 Thread Libreoffice Gerrit user
sc/qa/unit/subsequent_filters-test.cxx | 10 -- sw/qa/core/swdoc-test.cxx |1 - 2 files changed, 11 deletions(-) New commits: commit 4d1a877dbf74b8e6e5908bb2c0eec570a5fb3184 Author: Miklos Vajna vmik...@suse.cz Date: Wed Jan 9 07:28:52 2013 +0100 Revert fix a

[PATCH] Kill the ancient StarOffice patch concept

2013-01-09 Thread Tor Lillqvist (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1605 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1605/1 Kill the ancient StarOffice patch concept For Windows, superseded by Windows Installer patching (i.e., creating

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Petr Mladek
Pedro píše v Út 08. 01. 2013 v 17:16 -0800: Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. That means it should be available in the 4.0 daily builds tomorrow? Yup, it should be there. BTW if anyone is curious I

Re: LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Petr Mladek
leif píše v Út 08. 01. 2013 v 20:14 +0100: Hi, I tried with the daily from http://dev-builds.libreoffice.org/daily/libreoffice-4-0/Linux-x86_10-Release-Configuration/2013-01-07_14.50.57/ This is too old. Many fixes were added yesterday evening. You would need to test a daily build from today

[Libreoffice-commits] .: forms/source sc/source slideshow/source

2013-01-09 Thread Libreoffice Gerrit user
forms/source/component/errorbroadcaster.cxx |4 +-- sc/source/filter/oox/stylesbuffer.cxx | 32 slideshow/source/engine/transitions/fanwipe.cxx |2 - 3 files changed, 19 insertions(+), 19 deletions(-) New commits: commit

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Petr Mladek
Jean-Baptiste Faure píše v St 09. 01. 2013 v 06:22 +0100: Le 09/01/2013 02:16, Pedro a écrit : Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. That means it should be available in the 4.0 daily builds tomorrow?

[PUSHED] turn some OSL_ENSURE into SAL_WARN_IF to avoid warnings abou...

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1600 -- To view, visit https://gerrit.libreoffice.org/1600 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

Re: Knowledge acquired trying to fiz fdo#59106

2013-01-09 Thread Miklos Vajna
Hi Marcos, On Tue, Jan 08, 2013 at 09:25:26AM -0200, Marcos Souza marcos.souza@gmail.com wrote: Yesterday I was trying to undertand the dump generated by the mso-dumper. But, I believe the first issue is about the word Definição in a new page, instead of the same page as Trabalho 1 as

Re: UI issue

2013-01-09 Thread Michael Meeks
Hi Steve, You mentioned you wanted code pointers for this lot (hopefully C++ is not -so- different from C ;-) so: On Mon, 2013-01-07 at 10:55 -0800, Steven Howe wrote: 1) Insert-Section. When there is more then one section, they are listed in the order created, not linear order with

[Libreoffice-commits] .: sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/source/core/unocore/unotext.cxx |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 2f320afd978f15a8197f11614251b1e7014487c9 Author: Michael Meeks michael.me...@suse.com Date: Wed Jan 9 09:41:57 2013 + cleanup speedup patch pushed in error.

Re: UI issue

2013-01-09 Thread Michael Meeks
On Mon, 2013-01-07 at 22:55 -0800, Steven Howe wrote: Navigator. Sections. The section highlighted is may not be the section my cursor is in. ... Logic requires the Navigator follow where I am. ... Perhaps the highlighted section in the Navigator should also be the section I am editing?

[Libreoffice-commits] .: filter/source rsc/source sc/source sd/source svl/source svx/source sw/inc sw/source

2013-01-09 Thread Libreoffice Gerrit user
filter/source/graphicfilter/ieps/ieps.cxx |3 rsc/source/tools/rsctools.cxx |2 sc/source/ui/vba/vbahelper.cxx | 78 sc/source/ui/vba/vbaname.cxx| 90 +--- sc/source/ui/vba/vbanames.cxx

Re: [PUSHED] Bug 38838 - Removal/Replacement of the String/UniString with OUString once and for all.

2013-01-09 Thread Miklos Vajna
Hi Jean-Noël, On Tue, Jan 08, 2013 at 10:57:22AM +0100, Jean-Noël Rouvignac jn.rouvig...@gmail.com wrote: Please find and review the attached patch. Looks good, I just pushed it, thanks! :-) Please commit it If it suits. Actually, it would be nice if *you* could commit it, then send it to

[Libreoffice-commits] Changes to 'refs/tags/libreoffice-4.0.0.1'

2013-01-09 Thread Libreoffice Gerrit user
Tag 'libreoffice-4.0.0.1' created by Petr Mladek pmla...@suse.cz at 2013-01-09 09:56 -0800 Tag libreoffice-4.0.0.1 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJQ7T7vAAoJEPQ0oe+v7q6jPywQAMjXh9WK++fL+SsCryUAkO5G

[Libreoffice-commits] Changes to 'refs/tags/libreoffice-4.0.0.1'

2013-01-09 Thread Libreoffice Gerrit user
Tag 'libreoffice-4.0.0.1' created by Petr Mladek pmla...@suse.cz at 2013-01-09 09:57 -0800 Tag libreoffice-4.0.0.1 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJQ7T7vAAoJEPQ0oe+v7q6jk+8QAIWL7iwa7gtwH6ltYmVR+acS

[Libreoffice-commits] Changes to 'refs/tags/libreoffice-4.0.0.1'

2013-01-09 Thread Libreoffice Gerrit user
Tag 'libreoffice-4.0.0.1' created by Petr Mladek pmla...@suse.cz at 2013-01-09 09:57 -0800 Tag libreoffice-4.0.0.1 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJQ7T7vAAoJEPQ0oe+v7q6jdqMP/REDDC5o6owSHvxqS2VkS81m

[Libreoffice-commits] Changes to 'refs/tags/libreoffice-4.0.0.1'

2013-01-09 Thread Libreoffice Gerrit user
Tag 'libreoffice-4.0.0.1' created by Petr Mladek pmla...@suse.cz at 2013-01-09 09:57 -0800 Tag libreoffice-4.0.0.1 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJQ7T7vAAoJEPQ0oe+v7q6jzPUQAISJv2sMa+yVbJEzob0IBhNL

[Libreoffice-commits] .: cui/source

2013-01-09 Thread Libreoffice Gerrit user
cui/source/tabpages/autocdlg.src |1 + 1 file changed, 1 insertion(+) New commits: commit f900c56a32c1b29ea6330a85dcfa38bb7fbe6ae3 Author: Christopher Copits chrisc...@live.com Date: Mon Jan 7 20:19:38 2013 -0500 fdo#45964 - Wrong behavior of words list in AutoCorrect Word Completion

[PUSHED] fdo#45964 - Wrong behavior of words list in AutoCorrect Wo...

2013-01-09 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1571 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1571 To unsubscribe,

Re: [PATCH] Bug 38838 - Removal/Replacement of the String/UniString with OUString once and for all.

2013-01-09 Thread julien2412
Hi Jean-Noël, First thank you for this big patch! Perhaps I missed it but I didn't find a license statement from you. Could you send a post with it? (you can take example from http://nabble.documentfoundation.org/License-Statement-td4027832.html) Thank you in advance. Julien -- View this

[Libreoffice-commits] .: sfx2/doc

2013-01-09 Thread Libreoffice Gerrit user
sfx2/doc/sfx2doc.odg |binary 1 file changed New commits: commit 0d91792ae34ca6531fbd6244d7717a2738f6a607 Author: Lennard Wasserthal wassert...@nefkom.net Date: Tue Jan 8 19:58:39 2013 +0100 Documentation for sfx2 Change-Id: Id0df71664891ad2ced5336a7eea65c03353bbd92

[PUSHED] Documentation for sfx2

2013-01-09 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1599 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1599 To unsubscribe,

[Libreoffice-commits] .: vcl/inc vcl/source

2013-01-09 Thread Libreoffice Gerrit user
vcl/inc/vcl/settings.hxx | 10 +- vcl/source/app/settings.cxx | 38 +++--- vcl/source/window/dockingarea.cxx |8 vcl/source/window/menu.cxx| 12 ++-- 4 files changed, 30 insertions(+), 38 deletions(-) New

fix Writer table functions printed wrongly

2013-01-09 Thread Tim Hardeck (via Code Review)
Tim Hardeck has abandoned this change. Change subject: fix Writer table functions printed wrongly .. Patch Set 1: Abandoned Like I have mentioned in the bug report I wasn't sure if it is the right fix and I didn't had much

Re: [libreoffice-dev] - building difficulties with C++ extension, addIn

2013-01-09 Thread Stephan Bergmann
Hi Neeraj, Thank you for taking the trouble of making your Calc addin example work. The SDK is indeed an area that could benefit from more maintenance help, lots of the documentation goes stale over time etc. That said, I'm not sure we'll improve the overall situation by adding more

minor String to OUString in svx

2013-01-09 Thread Miklos Vajna (via Code Review)
Miklos Vajna has abandoned this change. Change subject: minor String to OUString in svx .. Patch Set 2: Abandoned Sorry, this is ugly. Please convert TakeSdrDragComment() first. -- To view, visit

Crash on Right-click on misspelled word

2013-01-09 Thread Samuel Mehrbrodt
In my build (Jan 7th, I755ea5b2ec7b6357a7fd2c86ec8479737696042b) I have a crash in Writer when I right-click on a misspelled word. Do I need to update or is this a bug that is still there? Samuel ___ LibreOffice mailing list

[Libreoffice-commits] .: Branch 'feature/rb1' - 0 commits -

2013-01-09 Thread Libreoffice Gerrit user
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: src/docrecord.py src/docstream.py test/doc

2013-01-09 Thread Miklos Vajna
src/docrecord.py | 61 + src/docstream.py |5 +++- test/doc/field.doc |binary test/doc/field.rtf |8 ++ test/doc/test.py |9 +++ 5 files changed, 82 insertions(+), 1 deletion(-) New commits: commit

fix problem with missing .po files

2013-01-09 Thread via Code Review
Matúš Kukan has abandoned this change. Change subject: fix problem with missing .po files .. Patch Set 1: Abandoned This was done in

[ANNOUNCE] libreoffice-4.0.0.1 tag created

2013-01-09 Thread Petr Mladek
Hi, there have been created the libreoffice-4.0.0.1 tag (aka rc1). The corresponding official builds will be available within next few days. IMPORTANT: We are in rc phase, so all commits into the 3-6 branch need a single reviewer approval from now on! See the attached list of changes against

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#58589 recovery dialog title area text is missi...

2013-01-09 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1606 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/1606/1 Resolves: fdo#58589 recovery dialog title area text is missing regression since

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Stefan Knorr (Astron)
Hi all, so, some of you know, I have soem reservations about this feature... be that as it may, I have a small number of comments still: * there are some spelling/grammar errors: ** the button for selecting the background image has the word Backround on it ** the window for Select a persona has

[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#58589 recovery dialog title area text is missi...

2013-01-09 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1607 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/1607/1 Resolves: fdo#58589 recovery dialog title area text is missing regression since

[Libreoffice-commits] .: connectivity/Library_mozabdrv.mk

2013-01-09 Thread Libreoffice Gerrit user
connectivity/Library_mozabdrv.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 06bdea2aa9d6b7e2f47f2012a1d8aaa701ad5932 Author: Matúš Kukan matus.ku...@gmail.com Date: Wed Jan 9 12:59:03 2013 +0100 Library_mozabdrv: use nss3 for prtypes.h header Change-Id:

[PATCH] xmlsecurity: remove obsolete tools directory

2013-01-09 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1608 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/1608/1 xmlsecurity: remove obsolete tools directory Change-Id: I5a1df11c18eb5932651ee381fae29f2ac0697b6a --- D

[Libreoffice-commits] .: cui/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
cui/uiconfig/ui/personalization_tab.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ad4c7b5130767008c55b5711ddbdbe7b08bd6f4f Author: Jan Holesovsky ke...@suse.cz Date: Wed Jan 9 13:23:20 2013 +0100 Personas: Fix typo (Backround - Background).

[Libreoffice-commits] .: svx/source

2013-01-09 Thread Libreoffice Gerrit user
svx/source/dialog/compressgraphicdialog.cxx |6 +++--- svx/source/svdraw/svdattr.cxx |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit e070b852074dd6f90128832ac0da3ef96e868d77 Author: Luboš Luňák l.lu...@suse.cz Date: Wed Jan 9 13:36:39

Re: [PUSHED] Documentation for sfx2

2013-01-09 Thread Stephan Bergmann
On 01/09/2013 11:14 AM, Miklos Vajna (via Code Review) wrote: Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1599 Approvals: Miklos Vajna: Verified; Looks good to me, approved Do people

[Libreoffice-commits] .: vcl/generic vcl/inc vcl/unx

2013-01-09 Thread Libreoffice Gerrit user
vcl/generic/print/genprnpsp.cxx |1 + vcl/inc/vcl/jobdata.hxx |3 ++- vcl/unx/generic/printer/jobdata.cxx |8 +++- 3 files changed, 10 insertions(+), 2 deletions(-) New commits: commit 9c4d77f22d58f5b500c95f65a431628a8d8d6e6e Author: Caolán McNamara

[Libreoffice-commits] .: cui/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
cui/uiconfig/ui/select_persona_dialog.ui |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 1c04ef068cf56568e5077cf9ed565481e7708901 Author: Jan Holesovsky ke...@suse.cz Date: Wed Jan 9 13:50:34 2013 +0100 Personas: Improved wording (URL - address, and

Re: GTK theming: oxygen-gtk support broken

2013-01-09 Thread Michael Meeks
Hi Ruslan, On Sat, 2013-01-05 at 22:59 +0300, Ruslan Kabatsayev wrote: What about such a simple change, which will let us set LibO version once and for all GTK theme calls: I guess we could do; we'd want to produce a real version string for a patch though :-) The reason why I

[PATCH] Change in core[libreoffice-4-0]: Resolves: fdo#59131 resolve default backend on printer-setu...

2013-01-09 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1609 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/1609/1 Resolves: fdo#59131 resolve default backend on printer-setup For setting permanent defaults via spadmin we

[Libreoffice-commits] .: 2 commits - sc/qa sd/source

2013-01-09 Thread Libreoffice Gerrit user
sc/qa/unit/subsequent_filters-test.cxx | 10 ++ sd/source/ui/dlg/prltempl.cxx |3 ++- sd/source/ui/func/fuprobjs.cxx |2 +- 3 files changed, 13 insertions(+), 2 deletions(-) New commits: commit 004c72330a132bbff09267459b35decdea3d8cf6 Author: Michael Meeks

Re: GTK theming: oxygen-gtk support broken

2013-01-09 Thread Tor Lillqvist
Using SUPD is reasonably easy - it is a 4.0.0 - 400 thing: not terribly robust over big versions, but easy enough to parse I guess. Hmm, I have wanted us to eventually get rid of this mysterious SUPD symbol, and SOURCEVERSION == WORK_STAMP, who have their historical roots in the MWS

[Libreoffice-commits] .: sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/source/ui/uno/unoatxt.cxx|4 ++-- sw/source/ui/utlui/attrdesc.cxx | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 8948b137acc954778b6198b3e333945eb8c63d31 Author: Michael Meeks michael.me...@suse.com Date: Wed Jan 9 13:08:53 2013 +

[PATCH] Change in core[libreoffice-4-0]: Template Manager: don't deselect item after setting default ...

2013-01-09 Thread Bosdonnat Cedric (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1611 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1611/1 Template Manager: don't deselect item after setting default template Change-Id:

[PATCH] Change in core[libreoffice-4-0]: Template Manager: double click on the whole item instead of ...

2013-01-09 Thread Bosdonnat Cedric (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1610 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/1610/1 Template Manager: double click on the whole item instead of only thumbnail Change-Id:

Re: [PUSHED] Documentation for sfx2

2013-01-09 Thread Miklos Vajna
On Wed, Jan 09, 2013 at 01:45:37PM +0100, Stephan Bergmann sberg...@redhat.com wrote: https://gerrit.libreoffice.org/1599 Do people generally consider it a good idea to include binary documentation files (rather than some helpful ASCII art in the existing */README files, say) in the

[Libreoffice-commits] .: cui/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
cui/uiconfig/ui/personalization_tab.ui | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit a4a3fcb906c552a869ec15e9d1afad5cf658e6a4 Author: Jan Holesovsky ke...@suse.cz Date: Wed Jan 9 14:11:41 2013 +0100 Personas: Improve wording of the choices.

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 3 commits - cui/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
cui/uiconfig/ui/personalization_tab.ui | 12 ++-- cui/uiconfig/ui/select_persona_dialog.ui |6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) New commits: commit 9b9d4a9472228a647d61edc428d542fd20bcb034 Author: Jan Holesovsky ke...@suse.cz Date: Wed Jan 9 14:11:41 2013

[Libreoffice-commits] .: 2 commits - sfx2/source

2013-01-09 Thread Libreoffice Gerrit user
sfx2/source/control/thumbnailview.cxx |1 - sfx2/source/doc/templatedlg.cxx | 18 -- 2 files changed, 8 insertions(+), 11 deletions(-) New commits: commit 0c6d58df4c3994d485c174909d4317cb8616c067 Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jan 9

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Jan Holesovsky
Hi Astron, Stefan Knorr (Astron) píše v St 09. 01. 2013 v 12:52 +0100: so, some of you know, I have soem reservations about this feature... :-) be that as it may, I have a small number of comments still: Thanks for that, very good points! * there are some spelling/grammar errors: ** the

[Libreoffice-commits] .: sfx2/source

2013-01-09 Thread Libreoffice Gerrit user
sfx2/source/doc/templatedlg.cxx |3 --- sfx2/source/doc/templatedlg.hrc |1 - sfx2/source/doc/templatedlg.src |5 - 3 files changed, 9 deletions(-) New commits: commit 52006aa4050a07fcc238f3cc9e1faa1ac95d08ec Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jan 9

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Stefan Knorr (Astron)
Hi again, minor correction to my own post only LibO window with my (admittedly somewhat slow (1000 Mb/s)) connection Make that 1 MBit/s... Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [PATCH] Bug 38838 - Removal/Replacement of the String/UniString with OUString once and for all.

2013-01-09 Thread Jean-Noël Rouvignac
2013/1/9 julien2412 serval2...@yahoo.fr Perhaps I missed it but I didn't find a license statement from you. Could you send a post with it? (you can take example from http://nabble.documentfoundation.org/License-Statement-td4027832.html) Hi Julien, I hereby declare that: All my

Re: GTK theming: oxygen-gtk support broken

2013-01-09 Thread Michael Meeks
Hi Tor, On Wed, 2013-01-09 at 15:06 +0200, Tor Lillqvist wrote: Hmm, I have wanted us to eventually get rid of this mysterious SUPD symbol, and SOURCEVERSION == WORK_STAMP, who have their historical roots in the MWS names of the old Sun OOo, and thus are meaningless to us. :-) Why

[PATCH] Change in core[libreoffice-3-6]: Resolves: fdo#45911 rhbz#846775 Clipboard must be disposed b...

2013-01-09 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1612 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/1612/1 Resolves: fdo#45911 rhbz#846775 Clipboard must be disposed before Selection (cherry picked from commit

replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-09 Thread Noel Grandin
maybe we need OUString::valueOfInt32(sal_Int32) that does the cast for us? At least it'll be less noisy, and we can document in one place why it's necessary. Original Message Subject:[Libreoffice-commits] .: 2 commits - sc/qa sd/source Date: Wed, 9 Jan 2013

[Libreoffice-commits] .: setup_native/source

2013-01-09 Thread Libreoffice Gerrit user
setup_native/source/packinfo/spellchecker_selection.pl |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit d8385c2cfc63b25414f37699faf0143ee9f5ded9 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jan 9 15:09:58 2013 +0100 Always default-select English

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 vitriol vitriol_vitr...@katamail.com changed: What|Removed |Added Depends on||58171 --- Comment

[PATCH] Change in core[libreoffice-4-0]: Always default-select English dictionary

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1614 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/1614/1 Always default-select English dictionary It was discovered that on a Russian Windows, by default only Russian

[PATCH] Change in core[libreoffice-3-6]: Always default-select English dictionary

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1613 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/1613/1 Always default-select English dictionary It was discovered that on a Russian Windows, by default only Russian

gmake: CXXFLAGS override gb_Library_add_cxxflags

2013-01-09 Thread Petr Mladek
Hi, CXXFLAGS are used after gb_Library_add_cxxflags in gbuild. This causes problems because gb_Library_add_cxxflags usually enforce some setting that is strictly needed. For example, my LO-4.0 build for openSUSE crashes in bridge test. It is related to omit-frame-pointer gcc feature. + openSUSE

[Libreoffice-commits] .: sfx2/source

2013-01-09 Thread Libreoffice Gerrit user
sfx2/source/control/templateabstractview.cxx |7 ++- sfx2/source/doc/templatedlg.cxx |2 ++ 2 files changed, 4 insertions(+), 5 deletions(-) New commits: commit 1ce372eec4dd0e4e807baa7bbf568245b955f99f Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jan 9

[Libreoffice-commits] .: sw/qa writerfilter/source

2013-01-09 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo58933.rtf | 28 + sw/qa/extras/rtfimport/rtfimport.cxx | 12 ++ writerfilter/source/rtftok/rtfdocumentimpl.cxx |7 +++--- 3 files changed, 44 insertions(+), 3 deletions(-) New commits: commit

Re: Funding Wishlist

2013-01-09 Thread Lubos Lunak
On Wednesday 21 of November 2012, Thorsten Behrens wrote: Marc Paré wrote: We are seriously looking at different teams' wishlists. Please do take a little time out of your busy schedule and speak to your teams about any funding for items that you think may be of importance to your team or

[Libreoffice-commits] .: 2 commits - sw/qa sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/qa/complex/writer/CheckTable.java | 32 + sw/source/core/unocore/unocrsrhelper.cxx | 39 +-- sw/source/core/unocore/unoobj.cxx|4 +++ sw/source/core/unocore/unoobj2.cxx |7 +++-- 4 files changed, 67

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sw/qa sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/qa/complex/writer/CheckTable.java | 32 + sw/source/core/unocore/unocrsrhelper.cxx | 39 +-- sw/source/core/unocore/unoobj.cxx|4 +++ sw/source/core/unocore/unoobj2.cxx |7 +++-- 4 files changed, 67

Re: Funding Wishlist

2013-01-09 Thread Michael Meeks
On Wed, 2013-01-09 at 15:59 +0100, Lubos Lunak wrote: Hello, I'd like to ask, is there any plan to have such a mac machine? Or preferably a shared mac build host where developers could test their changes or find out more about tinderboxes breakages (which are sometimes rather hard to

[Libreoffice-commits] .: sw/inc sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/inc/viewopt.hxx |8 sw/source/ui/config/caption.cxx |2 +- sw/source/ui/config/fontcfg.cxx |8 sw/source/ui/config/modcfg.cxx | 12 ++-- sw/source/ui/config/optpage.cxx | 22 +++--- sw/source/ui/config/viewopt.cxx |2

[Libreoffice-commits] .: sw/AllLangResTarget_sw.mk sw/inc sw/source sw/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
sw/AllLangResTarget_sw.mk|1 sw/inc/helpid.h |1 sw/source/ui/inc/glosbib.hxx | 46 +++-- sw/source/ui/inc/misc.hrc|3 sw/source/ui/misc/glosbib.cxx| 180 ++--

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/source/core/unocore/unocrsrhelper.cxx | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) New commits: commit e5add879def40a7695fb506b42c024ef9f776062 Author: Noel Power noel.po...@suse.com Date: Wed Jan 9 14:40:10 2013 +0100 fdo#58242:

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-09 Thread Michael Meeks
On Wed, 2013-01-09 at 16:10 +0200, Noel Grandin wrote: maybe we need OUString::valueOfInt32(sal_Int32) that does the cast for us? At least it'll be less noisy, and we can document in one place why it's necessary. Looks less error prone to me; doesn't suffer from odd

[PATCH] Change in core[libreoffice-3-6]: fdo#58242: sw: fix more crashes when not on SwTxtNode

2013-01-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1615 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1615/1 fdo#58242: sw: fix more crashes when not on SwTxtNode In getCrsrPropertyValue etc.; also add a unit test for

Re: GTK theming: oxygen-gtk support broken

2013-01-09 Thread Michael Meeks
On Wed, 2013-01-09 at 15:47 +0100, Stephan Bergmann wrote: Regarding version information, there is solver/*/inc/*minor.mk (make-level variables VERSIONMAJOR, VERSIONMINOR, etc.) and there is solenv/inc/version.hrc including versionlist.hrc (#defines for VERSION, SUBVERSION, etc.).

Re: Funding Wishlist

2013-01-09 Thread Jonathan Aquilina
Hey guys I have a zippy imac atm which is just sitting on my desk not being used with ample space and ram. I would be more then willing to help set that up as a necessary tinderbox but its running osx 10.7 on it. Let me know if you guys would benefit from having that as a tinderbox at all.

[Libreoffice-commits] .: sfx2/source

2013-01-09 Thread Libreoffice Gerrit user
sfx2/source/doc/templatedlg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3c08052394409a9c8aac07557a343070235672e7 Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Wed Jan 9 16:41:58 2013 +0100 Template Manager: delete popup menus in the proper

[REVIEW 4.0] Template manager fixes

2013-01-09 Thread Cedric Bosdonnat
Hi all, I have some patches fixes various tiny bugs in the new template manager pending review for integration in 4.0. Could someone review them? I first tried to push them to gerrit: https://gerrit.libreoffice.org/1610 https://gerrit.libreoffice.org/1611 And then some more arrived, and I

[Libreoffice-commits] .: sw/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
sw/uiconfig/swriter/ui/exchangedatabases.ui | 286 1 file changed, 286 insertions(+) New commits: commit a0bf71323741c5c58b77651fe656c73419dbf09f Author: Abdulelah Alarifi asalar...@kacst.edu.sa Date: Tue Jan 8 14:02:49 2013 +0300 Converted Exchange Databases

[PUSHED] Converted Exchange Databases widgets .ui

2013-01-09 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1595 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1595 To unsubscribe,

[Libreoffice-commits] .: lingucomponent/source linguistic/inc linguistic/source linguistic/workben

2013-01-09 Thread Libreoffice Gerrit user
lingucomponent/source/hyphenator/altlinuxhyph/hyphen/hyphenimp.cxx |8 +- lingucomponent/source/lingutil/lingutil.cxx|2 lingucomponent/source/spellcheck/macosxspell/macspellimp.mm|4 - lingucomponent/source/spellcheck/spell/sspellimp.cxx

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Michael Meeks wrote: On Wed, 2013-01-09 at 16:10 +0200, Noel Grandin wrote: maybe we need OUString::valueOfInt32(sal_Int32) that does the cast for us? At least it'll be less noisy, Is there really such a big difference between OUString::valueOf(

[PATCH] Change in core[libreoffice-4-0]: resolved fdo#58503 restore awkward handling of empty locale ...

2013-01-09 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1616 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1616/1 resolved fdo#58503 restore awkward handling of empty locale for legacy Partly reverts

Availability of the SDK?

2013-01-09 Thread Stephan Bergmann
Availability of the SDK product appears not to be on par with the main LibreOffice product: * https://www.libreoffice.org/download/ allows to download the Software development kit (SDK) for the browser's platform only (linking directly to

[Libreoffice-commits] .: dbaccess/source

2013-01-09 Thread Libreoffice Gerrit user
dbaccess/source/ui/querydesign/querycontroller.cxx | 170 + dbaccess/source/ui/uno/copytablewizard.cxx | 139 +++-- dbaccess/source/ui/uno/unosqlmessage.cxx |8 3 files changed, 143 insertions(+), 174 deletions(-) New commits: commit

[PUSHED] Remove some RTL_* macros, rtl:: prefixes and simplification ...

2013-01-09 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1572 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1572 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - .gitreview

2013-01-09 Thread Libreoffice Gerrit user
.gitreview |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 58035222f58b1049d16dea1860fee696818de70e Author: Miklos Vajna vmik...@suse.cz Date: Wed Jan 9 17:24:56 2013 +0100 .gitreview: set defaultbranch for this branch correctly Change-Id:

[Libreoffice-commits] .: formula/inc formula/source sc/inc sc/source

2013-01-09 Thread Libreoffice Gerrit user
formula/inc/formula/FormulaCompiler.hxx |3 +- formula/source/core/api/FormulaCompiler.cxx |2 - sc/inc/cell.hxx |5 sc/inc/compiler.hxx |4 +-- sc/inc/formularesult.hxx|2 + sc/inc/token.hxx

[PATCH] Change in core[libreoffice-4-0]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1617 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1617/1 fdo#58933 RTF import: avoid fake pars / cells when having graphic inside cells Regression from

RE: [libreoffice-dev] - building difficulties with C++ extension,addIn

2013-01-09 Thread Rai, Neeraj
Hi Stephan, Thanks for taking this up. I wasn't aware that examples didn't get built with make or make check. Time is not a big issue as long as it gets to the right place, and it seems like you are pushing it in right direction. I noticed that you are listed UNO,sal,config contact. Hope it is

[PATCH] Change in core[libreoffice-3-6]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1618 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/1618/1 fdo#58933 RTF import: avoid fake pars / cells when having graphic inside cells Regression from

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread khagaroth
It's useless without support for font color settings. Black text on black persona isn't exactly great UX experience. Though to be fair, even with support for this, some of the personas have rather weird color combinations when checked in Firefox. On Wed, Jan 9, 2013 at 2:38 PM, Stefan Knorr

Re: replacing OUString::valueOf(static_castsal_Int32) ??

2013-01-09 Thread Michael Stahl
On 09/01/13 17:02, Lubos Lunak wrote: On Wednesday 09 of January 2013, Michael Meeks wrote: On Wed, 2013-01-09 at 16:10 +0200, Noel Grandin wrote: maybe we need OUString::valueOfInt32(sal_Int32) that does the cast for us? At least it'll be less noisy, Is there really such a big

[Libreoffice-commits] bin/push_nightlies.sh

2013-01-09 Thread Libreoffice Gerrit user
bin/push_nightlies.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 76e258540aed3cc1b1ae7e92599e07ab3dd1bea1 Author: Luboš Luňák l.lu...@suse.cz Date: Wed Jan 9 17:47:42 2013 +0100 push also dev .msi Presumably the -path is there to filter out

Re: Availability of the SDK?

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Stephan Bergmann wrote: * http://dev-builds.libreoffice.org/daily/ appears to offer SDK in some cases (like http://dev-builds.libreoffice.org/daily/master/MacOSX-Intel@1-built_no-moz _on_10.6.8/2013-01-09_08.08.08/master~2013-01-09_08.08.08_LibO-Dev_4.1.0.0.a

[Libreoffice-commits] .: sw/AllLangResTarget_sw.mk sw/inc sw/source sw/uiconfig sw/UI_swriter.mk

2013-01-09 Thread Libreoffice Gerrit user
sw/AllLangResTarget_sw.mk |1 sw/UI_swriter.mk|1 sw/inc/fldui.hrc|1 sw/inc/swabstdlg.hxx|2 sw/source/ui/dbui/dbtree.cxx| 26 +++

[Libreoffice-commits] .: odk/cfgWin.js

2013-01-09 Thread Libreoffice Gerrit user
odk/cfgWin.js | 50 +- 1 file changed, 1 insertion(+), 49 deletions(-) New commits: commit 0c22641b4c44938924187ddfb945f494a183ba47 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jan 9 17:45:09 2013 +0100 Fix oo_sdk_ure_home

[Libreoffice-commits] .: sw/uiconfig sw/UI_swriter.mk

2013-01-09 Thread Libreoffice Gerrit user
sw/UI_swriter.mk |1 sw/uiconfig/swriter/ui/asianphoneticguide.ui | 286 +++ 2 files changed, 287 insertions(+) New commits: commit 21be5156d45139d27a1ec18367ed271fdc9373a3 Author: Gokul gswaminat...@kacst.edu.sa Date: Mon Dec 17

  1   2   3   4   >